Download
(171Kb)
Download
Updated: 12-14-06 05:15 PM
Addon for:
FuBar 3.6.5.
Pictures
File Info
Updated:12-14-06 05:15 PM
Created:unknown
Downloads:38,710
Favorites:301
MD5:

FuBar - GarbageFu  Popular! (More than 5000 hits)

Version: 2.0.20634
by: wmrojer [More]

New beta version available at http://files.wowace.com/FuBar_GarbageFu/

Short Description:

FuBar - GarbageFu is a plugin to FuBar 2.0 that helps you clean your bags of Garbage by letting you drop the least valuable item/s. Or if you are at a merchant you can simply select to sell all your Garbage to him by pressing a button.

Feedback and feature requests are needed.

Features:

Drop least valuable item.
Shows all items that can be dropped along with there total value in a tooltip.
Sell all that are shown in the tooltip or all grey items to a vendor with the press of a button.
Select what to drop and what to keep by Sets, Type, Items and Quality threshold.
Supports several addons for retrieval of price information, including it's own.
Select sets of items to use auction price for instead of vendor price.
Select item quality threshold for when to use auction price instead of vendor price.
Supports Autioneer, KC_Items and WoWEcon for Auction prices.
Display total/free/used bag slots on the toolbar.
Toggle bags display.

Long Description:

Selection of what items to drop are made in the following way. (By decreasing priority)

  • Keep Items List.
    Select to keep an item that would otherwise be dropped.
  • Drop Items List.
    Select to drop an item that would otherwise not be dropped.
  • Keep Type list.
    Select types of items to keep.
  • Keep Sets List.
    Select sets of items to keep.
  • Drop Type List.
    Select types of items to drop.
  • Drop Sets List.
    Select sets of items to drop.
  • Quality Drop Threshold.
    Set the default quality threshold for what items to drop. Default is poor quality item.s

Types are based on WoW internal item types. (From GetItemInfo)
Examples:
Armor
Weapons
Bag
Key
Recipie
Quest

Some type also have subtypes.
Armor has
Cloth, Leather, Mail, Plate, Shield....
Weapons as
Dagger, 1H Sword, 2H Sword, 1H Axe........

Included in type are also Bind types.
Soulbound, Quest, Bind on Pickup, Bind on Equip/Use.

Sets are made up of different types of items.
Examples:
Food, Water, Tradeskill, Gathered, Bandages, Scrolls .......

Several sets also have subsets that you can select if you need greater detail
Examples:
Food has
Normal Food, Bonus Food, Stat Food, Conjured Bread, Raw Food, Bread, Fish....
Water has
Normal Water, Percent Water, Conjured Water.

Tooltip that shows all the items in your inventory that can be dropped with the current selections.

By Left Clicking the mouse while holding down shift on the toolbar will drop the item on the top of the list, or sell it if you have a merchant window open. You can also left click the mouse while holding down shift on the Tooltip to drop or sell a specific item in the list.

By left clicking the mouse while holding down control on the toolbar or the tooltip will add that item to the keep items list, those preventing that item from being dropped or sold.

When you have a merchant window open you also have the ability to sell all the items that are shown in the tooltip by either selecting 'Sell All Garbage Items' in the drop down menu, or by clicking the 'Sell All Garbage Item' button on the merchant window. Button on the merchant window can be turned off. You can also select to only sell grey items.

Item values are collected from Auctioneer/Informat, KC_Items, PriceMaster, Ludwig_SellValue (courtesy of Kergoth), WoWEcon, ItemSync (courtesy of kirson), ColaLight and it's own GarbageFu - Prices. Currently GarbageFu will NOT drop any items above grey(poor) quality without price information.

Auction values are collected from Auctioneer, KC_Items or WoWEcon. For Auctioneer you have two way, either directly or cached. Directly requires that Auctioneer is loaded at all time, while cached only requires Auctioneer to be loaded when you want to update what items you want auction values for or when have scanned the auction house to update with updated values. GarbageFu will automaticaly update item values after you scanned the auction house. (WoWEcon don't have a auction house scan. Personal opinion on WoWEcon is that it sucks big time)

You can select what items to use auction prices for by Sets, per item and by quality threshold. If there is no auction value available the vendor price will be used.

You can change in which order GarbageFu will ask both the vendor price addons and auction house addons. Example: You have both Auctineer/Informat and KC_Items loaded and you want vendor prices from KC_Items but auction prices from Auctioneer, just set it up so KC_Items is higher in the list for 'Vendor Addons' option and Auctioneer is higher then in the 'Auction Addons' options. It will then get vendor prices first from KC_Items, and only if it dosn't exist there it will look in Informat/Auctioneer. You can also select to not use a vendor/auction addon by setting it below 'Don't use addons below' in the 'Vendor Addons'/'Auction Addons' in the options. Only addons loaded will be shown in the options. Addons are added when they are loaded (even on demand).

You also have the ability to enter your own price for an item. That price will then override any price gotten from other sources. Price overrides are stored per account, so you only need to enter them once.

Settings are store per profile, so you can choose to have different settings for different chars/classes.

Optional information in the tooltip about where the price came from.
VI = Informat vendor price.
VK = KC_Items vendor price.
VW = WoWEcon vendor price.
VL = Ludwig_SellValue vendor price.
VS = ItemSync vendor price.
VT = GarbageFU_Prices vendor price.
VP = PriceMaster vendor price.
VC = ColaLight vendor price.
AA = Auctioneer auction price.
AC = Cached Auctioneer auction price.
AK = KC_Items auction price.
AW = WoWEcon auction price.

Optional display of Total/Free/Used bag slots. Does not include any ignored special bags. (Ammo, herb soulstone, enchanting).

Double-click to toggle bags. (Does not toggle any ignored special bags)

Sets functionality uses PeriodicTable by Tekkub.
Some code borrowed from ItemizedDeduction by Tekkub.

There are currently no Auto-drop functionality. If it is requested it will be added later.

Installation:

Just unpack in your Interface/AddOns/ folder. No dependancies, all required libraries are embeded.

In the works:
Nothing. Working on some new projects

Know issues:

Auction quailty threshold dosn't work for caching auctioneer.

Patch notes:

2.0.20634
More debug code to try and catch the wrong item error. Warning, special debug build. Will do a complete item check every 60 seconds. May cause lag.
Added check to "Sell All Buttom" that I had missed the last time.

2.0.20111
Hopefully fixed the problem with GarbageFu getting out of sync with what's actually in your inventory. Extra checks still in place.

2.0.19988
Added extra checks that it's the right item that is dropped/sold. Will warn if it detects an inconsistancy in it's data and refuse to drop/sell the item if it dosn't match what it thinks should be in that bagslot.
Fixed the nil,nil,nil prints. (Was an api change in AceConsole-2.0)

2.0.19420
Removed the use of Compost. Not needed since we have lua 5.1.
Fixed a small typo that showed up when Compost was no longer functional.

2.0.19164
Updated toc for WoW 2.0

2.0.16966
Upgraded to AceLocal-2.2 and AceHook-2.1. Fixed TBC compatibility.
Note: You need to remove the embeded Ace2 libs and install the Ace2 TBC standalone version and update the .toc to interface 20000 to get it to work in the TBC beta

2.0.16125
Minor bug fix. (sorry, no Bagnon support)

2.0.14033
Fixed nil error on reloadui. (tekkub)
Now properly updates auction prices OnFullyInitialized (tekkub)
Shorter German translation of 'No items to drop'.

2.0.13718
Fixed problem with vendor and auction price addons loading after GarbageFu. Checking is now done after AceEvent_FullyInitialized.
Added French translation by Culhag.

2.0.13301
Fixed bug where sell grey items sold grey items that is marked to keep.
Added Auction quality threshold.

2.0.11917
Fixed nil error in call to Abacus.

2.0.11684
Changed startup sequence. Addons wasn't always initialized.
Downgraded Ace2 lib's to 10851.

2.0.11635
Added recipes as auction set.
Removed Ammo from drop/keep set since it's available in keep/drop type (that is faster to check).
Updated for lua 5.1
Added bag slots display (Total/Used/Free).
Double-click to open bags.
Fixed issue with settings not being saved in the right profile. (Was an issue with FuBar not setting the profile for a new addon)
Added German translation. German translation by Dermott <Azeroths Plage>

2.0.11023
Added support for Auction prices. Supported addons Auctioneer, KC_Items and WoWEcon.
Added Item types base on information from GetItemInfo itemType and itemSubType. (return param 5 and 6)
Vendor price and Auction price addon priority changable.
Price addons detected even when loaded on demand.

1.0.10349
Added support for ItemSync.
Fixed Sell All Items button to only show when there are items to sell.
Added total value of items to sell to the tooltip of sell all items button.

1.0.9990 First non beta release.
Support for more vendor price addons. Including it's own.
Use of Item icon on the toolbar instead of recycle bin.
Option to only autosell grey items to vendor.
Reverted back to AceLocal-2.0 (Since it appears to be faster now)

0.1.9690 First public beta version.

Post A Reply Comment Options
Unread 12-14-06, 12:17 PM  
astalavista
A Defias Bandit

Forum posts: 3
File comments: 53
Uploads: 0
I currently don't dare dropping stuff, in fear of losing one of the valuable things I carry around in my bags (trinkets, mounts, etc.) I am still testing the vendor trash function, and that's still not working without flaw. Instead of bat ears it sold a stack of Solid Stone yesterday.

I did not receive any error messages or warning messages.
Last edited by astalavista : 12-14-06 at 12:18 PM.
Report comment to moderator  
Reply With Quote
Unread 12-13-06, 01:55 PM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1046
Uploads: 0
Thanks for the reply, wmrojer. Sorry to hear about yet another undocumented Blizzard API change causing problems. That really sucks; its a habit they unfortunately seem to have gotten into.

I don't use MrPlow except to sort things in our guild banks and GarbageFu isn't turned on when I do that.

Tested r20111 (off the SVN) for three hours or so on a level 41 alt last night that had nothing valuable on. No errors at all popped up and it appeared to work properly selecting grey items to delete after looting (& deleting them).

Still not confident enough to use this again on my level 60 main, but no problems so far on my alt.
Last edited by Zidomo : 12-13-06 at 01:57 PM.
Report comment to moderator  
Reply With Quote
Unread 12-12-06, 05:09 PM  
wmrojer
A Deviate Faerie Dragon
 
wmrojer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 73
Uploads: 3
I can't make any garanties that it will not destroy you 900 gold epic mount, but I've done my best to make sure it doesn't.

The problem that has arrisen is pretty rare. It mainly happened if you where moving stuff around in your bags. (MrPlow) I've used it alot and only seen the problem happen once, and that was when I had moved stuff around manually. (For me it was an item that was listed in GarbageFu that I had manually delete)

I'm still not 100% sure I've squashed the bug, but if it's what I think it was then it's a change in how lua handles tables internaly. So it was a change that wasn't in the blizzard release notes (that sucks) or the Lua 5.1 release notes (that dosn't suck as much as blizzards).

If you notice that GarbageFu is out of sync with your inventory you can disable/enable a special bag (ammo/herb/soul/enchant) since that will trigger a complete bag rescan. But hopefully it won't get out of sync anymore.

I do want to know if anyone see the error message 'Error! Expected item %s in bag %d slot %d, but found %s' or in any other way notice that GarbageFu is out of sync in revision 20111 or above. I use the addon myself you know, and I want it to work.

@Razoon: How can you have Auctioneer loaded? It's not yet compatible with WoW 2.0.

@kappe: Darkmoon Fair item is there as an Item Type. Tooltip info isn't GarbageFu's task to do.
Report comment to moderator  
Reply With Quote
Unread 12-12-06, 03:13 PM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1046
Uploads: 0
Originally posted by mindwhip
Give wmrojer a break.

It's seems that its not a bug in the addon, but in WoW. I've had other addons that need to keep track of whats in your bags go out of sync as well... Blizzard changed something unexpected (possibly a bug in the client, possibly related to the performance optimizations) and while garbageFu is dealing with the information it is passed by the client, that information is messed up.
Fine fine (if this is actually the case). But mods which allow you to delete/sell items--either from your bags as this one does (or Itemized Deductions did before this), at a vendor or similar--walk a fine line. A line not many other mods walk. Of course it doesn't matter as much if, say, an inventory mod is no longer storing your inventory list properly. But with a mod that can sell/destroy items, its an issue.

Its absolutely essential that such a mod take steps to assure that nothing valuable is destroyed or sold, no matter how buggy Blizzard's API is. As well as no matter if before a patch, the mod didn't allow this through options set for it.

Thus why I am asking if the latest patch for this has absolutely, for sure solved the previous bug or not.

Don't take this harshly, wmrojer; I really appreciate all the work you do with your mods. Look forward to your future work.
Report comment to moderator  
Reply With Quote
Unread 12-12-06, 04:01 AM  
mindwhip
A Kobold Labourer

Forum posts: 0
File comments: 3
Uploads: 0
Give wmrojer a break.

It's seems that its not a bug in the addon, but in WoW. I've had other addons that need to keep track of whats in your bags go out of sync as well... Blizzard changed something unexpected (possibly a bug in the client, possibly related to the performance optimizations) and while garbageFu is dealing with the information it is passed by the client, that information is messed up.

Oh and can we have some way to get the addon to rescan the bags and get back in sync when things go awry? please? /console reloadui takes ages on my PC.
Report comment to moderator  
Reply With Quote
Unread 12-12-06, 03:07 AM  
razoon
A Fallenroot Satyr

Forum posts: 21
File comments: 63
Uploads: 0
Caching Auctioneer it says that Auctioneer addon isnt loaded. But it is
Report comment to moderator  
Reply With Quote
Unread 12-11-06, 10:36 PM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1046
Uploads: 0
Originally posted by wmrojer
I saw this myself today. So there is something that has changed in WoW 2.0. I've put in some extra checks and extended the debug prints.
For reference, I used this to destroy some gray items taking up pack space when I needed the space for something else yesterday. This was _before_ you got the destructive bug stamped out in the update and it was released on either the SVN or here.

I want to know: this unfortunate bug that passed through your testing (I'm really resisting the urge to say "that really should not have passed through your testing" )...would it potentially destroy anything other than the wrong gray items in the list? This is assuming I didn't change the threshold for destruction or anything in its options related to that. As in white or green/blue/purple items?

I have the queasy feeling that I'll have to search through my packs now--and try to remember what of value I had in them (not easy)--to see if anything valuable is missing. But let me know please.
Last edited by Zidomo : 12-11-06 at 10:41 PM.
Report comment to moderator  
Reply With Quote
Unread 12-11-06, 07:53 PM  
kappe
A Deviate Faerie Dragon

Forum posts: 14
File comments: 123
Uploads: 0
darkmoon faire support (info in tooltip and selling avoidance)?
Report comment to moderator  
Reply With Quote
Unread 12-11-06, 07:14 PM  
wmrojer
A Deviate Faerie Dragon
 
wmrojer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 73
Uploads: 3
Re: So, with a COMPLETELY different problem....

Originally posted by crimanysakes
I am getting no prices for anything. Just ??

I'm not, currently, using Auctioneer or anything, since it's not updated, so I downloaded FuBar_GarbageFu_Prices. It's on, checked, everything. But I still get the prices listed as "??"

Am I missing something (and yes, I'm sure I am).
  • FuBar_GarbageFu_Prices enabled in the addons screens.
  • 'Use GarbageFu Prices' checked in the FuBar_GarbageFu options menu.
  • Check that 'GarbageFu_Prices is not below the '-- Do not use addons below --' line in the 'Vendor price addons order' option.
Report comment to moderator  
Reply With Quote
Unread 12-11-06, 06:54 PM  
crimanysakes
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
So, with a COMPLETELY different problem....

I am getting no prices for anything. Just ??

I'm not, currently, using Auctioneer or anything, since it's not updated, so I downloaded FuBar_GarbageFu_Prices. It's on, checked, everything. But I still get the prices listed as "??"

Am I missing something (and yes, I'm sure I am).
Report comment to moderator  
Reply With Quote
Unread 12-11-06, 01:46 PM  
astalavista
A Defias Bandit

Forum posts: 3
File comments: 53
Uploads: 0
Tried it today, and it was improved, but I still always had to check via buyback tab what had been sold. When selling trash it sold my Noggenfogger. Sadly, it also sold my mining pick, something I hadn't noticed.

Thank you for trying to fix, keep up the great work.

P.S.:

I also use MrPlow, and vBagnon as inventory addon.
Report comment to moderator  
Reply With Quote
Unread 12-11-06, 05:30 AM  
mindwhip
A Kobold Labourer

Forum posts: 0
File comments: 3
Uploads: 0
wrong item error...

I'm getting this a lot, I suspect it's related to when I re-arrange my bags with MrPlow (but not limited to this as it still happened once with MrPlow turned off).

anyway thanks for the extra checks, garbageFu has to be one of the most useful addons when grinding/leveling out there! Keep up the good work!
Report comment to moderator  
Reply With Quote
Unread 12-10-06, 09:33 PM  
wmrojer
A Deviate Faerie Dragon
 
wmrojer's Avatar
AddOn Author - Click to view AddOns

Forum posts: 13
File comments: 73
Uploads: 3
Originally posted by astalavista
I am struggling a lot with GarbageFu since 2.0. My worst problem at the moment is that when you use the shift-click functionality to destroy something from your inventory, it destroys something else. I made this painful experience when it first took a quest item instead, and then two imperfect draenethyst shards. I am going back to manually tossing out stuff for now. The problem seems to be that GarbageFu doesn't refresh correctly. It lists things you no longer have in your inventory, e.g.

Also, when selling vendor trash, you receive the info nil nil nil nil nil etc. where the sum of money you just made should be.

I love this addon and am hoping these bugs can be fixed. Thank you!
I saw this myself today. So there is something that has changed in WoW 2.0. I've put in some extra checks and extended the debug prints.
Report comment to moderator  
Reply With Quote
Unread 12-10-06, 07:29 AM  
astalavista
A Defias Bandit

Forum posts: 3
File comments: 53
Uploads: 0
I am struggling a lot with GarbageFu since 2.0. My worst problem at the moment is that when you use the shift-click functionality to destroy something from your inventory, it destroys something else. I made this painful experience when it first took a quest item instead, and then two imperfect draenethyst shards. I am going back to manually tossing out stuff for now. The problem seems to be that GarbageFu doesn't refresh correctly. It lists things you no longer have in your inventory, e.g.

Also, when selling vendor trash, you receive the info nil nil nil nil nil etc. where the sum of money you just made should be.

I love this addon and am hoping these bugs can be fixed. Thank you!
Report comment to moderator  
Reply With Quote
Unread 12-06-06, 08:08 AM  
doxxx
A Kobold Labourer
 
doxxx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 160
Uploads: 1
Woops! I could have sworn I got an error with GarbageFu in the stacktrace... I just tried it again (without DurabilityFu installed) and no errors. Sorry!
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: