Download
(18Kb)
Download
Updated: 01-20-16 05:33 PM
Pictures
File Info
Compatibility:
Minor patch (6.2.3)
Fury of Hellfire (6.2)
The Adventure Continues (6.1)
Warlords of Draenor (6.0.3)
Warlords of Draenor Pre-Patch (6.0.2)
Updated:01-20-16 05:33 PM
Created:unknown
Downloads:5,743
Favorites:65
MD5:

Bagsy  Popular! (More than 5000 hits)

Version: 6.2.1
by: xtoq, VagrantEsha

Bagsy: A DataBroker Plugin for World of Warcraft

You must have an LDB display addon for Basgy to work.

The screenshot will tell you everything you'll need to know about this plugin, but basically it's all about bag information - free slots, taken slots, that kind of thing.

Set the options in the GUI, and submit tickets via GitHub (preferred) or comments here if you run into problems.

-----

Most recent changes
(see changelog for earlier releases)

6.2.1 - 1/20/2016

- actual release version since no bugs have been uncovered (so far!)

3.3-1.1
11/27/2010
xtoq

- Updated ToC to 4.0. I have no issues with this addon, and haven't heard any complaints, so I assume things are fine...?

3.3-1.0
1/9/2010
xtoq

- Updated LibDataBroker
- Updated ToC to 3.3
- Updated to include inscription bags

2.4.3-1.2

- 1.1 introduced a click bug. I think this was due to some reverted code, basically stuff I had changed that I either undid by accident or didn't save. This is why it took me so long to spot it. This should guarantee that the clicking will work again, if not I'll just revert to the click-code I had in 1.0 from the archive. Here's hoping.
- Again, drycoded. You all know why by now though, sorry about that!

2.4.3-1.1

- I adjusted the alignment of the secondary icons (class/profession), they were actually too far down (see the screenshot) and it was so very irritating! So I've corrected them, they should now be aligned with the first icon.
- There was an issue with the sentences, this was amazingly minor but I had to fix it. There was a point where it would say something like "Not included in the count, and shown separately.", but instead it should be "Not included in the count, shown separately." or "Included in the count, and shown separately." See the screenshot to see what I'm talking about here, it was a minor grammatical error but I had to fix it. Yay for dynamically compiling sentences for tooltips!

2.4.3-1.0 (my coupe de gracie!)

- The click functions for toggling bags/backpack now work properly.
- A toggle has been added for whether or not counts should be coloured.
- Counts for different types of bags can now be separated (with neat little icons!), thaks to Frayol for that awesome idea.
- Did some general cleaning up, and obsessing over every last line of code!
- Not drycoded, this one's actually had all of its features tested (as the screenshot shows), huzzah!

2.4.3-0.9

- Thought I'd upload a quick fix for the default bags not toggling properly.
- More to come tomorrow!
- Drycoded, but should be okay (simple change).

2.4.3-0.8

- The original solution to trying to figure out how to deal with different bag mods didn't work, it was buggy and any fixes I might've had would've only been more complicated and I didn't want to bloat the mod like that. Thankfully, Frayol suggested a really simple and elegant solution that had just passed me by; left and right clicking for different types of bag mods. So that's in there now, thanks to Frayol.

2.4.3-0.7

- I've allowed some time for possible bug reports to come in, since I've had none I'm going to upgrade this from a test version to a standard one.

2.4.3-0.7-Test

- I've hopefully got the toggle bag issue sorted out that rears its head with some bag mods.
- Drycoded. It'll be upgraded from test to a normal version after confirmation of the fix.

2.4.3-0.6

- Changed the backpack toggle to work with all bags instead, which really makes most sense. I did that originally with the thought in mind that everyone probably uses some form of bag mod or another, s'not the case though! So Bagsy now toggles all bags on click, which is much more useful to those without bag mods.

2.4.3-0.5

- Added options to include or disclude class bags (such as soul shard bags, ammo pouches, and things of the sort) and profession bags (such as herbalism bags, ore bags, enchanting bags, and the like) from the overall count.

2.4.3-0.4

- The colour has been removed from the toc name, as this caused issues with alphabetical categorisation.

2.4.3-0.3

- I've got a new direction with the tooltips, it took me a while to decide on this. It was discussed with a few people too and it was generally and mutually decided that the new direction I'm taking them in is better. So this is the New Unification of Tooltip Styles for my plugins. NUTS v1! I'm pretty much going to model all my DataBroker plugins after this layout, to try to keep them as easy to understand at a glance as possible. The basic idea is: Keybinds at the bottom, the most important information at the top, and all the straggler-lines cushioned in the middle. Credit where credit is due, too; this all started because of a suggestion by Nyte, so kudos for Nyte for giving me reason to think about all this! This is far too long for a changelog update, I know... but necessary!
- I've corrected the toc-version, I am scared and confused by toc-versions.

2.4.3-0.2

- First release on WoWI.
Optional Files (0)


Post A Reply Comment Options
Unread 09-01-08, 03:43 AM  
Frayol
A Deviate Faerie Dragon
 
Frayol's Avatar
AddOn Author - Click to view AddOns

Forum posts: 10
File comments: 127
Uploads: 4
@Vytae - You are not being a buzzkill at all. In fact I failed to test without BaudBag running so my post only really related to BaudBag working fine. My mistake in not testing fully.

I have now tested fully and found that the issue does exist exactly as described. In order to rule out settings I wiped my addons and WTF folders then ran with nothing, but Fortress and Bagsy. Right-clicking only opens the backpack. I then zapped the folders clean again and tried with Carousel instead of Fortress, same result. Sorry to say that it looks like the issue lies within Bagsy.
Report comment to moderator  
Reply With Quote
Unread 08-31-08, 10:24 PM  
VagrantEsha
Token Werewolf Fan
 
VagrantEsha's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 27
File comments: 238
Uploads: 38
@Lullah

Alt + Right-click the Bagsy block, that'll colour the numbers. There's actually an option to turn the colouring of numbers on/off that's accessed by doing so.

@Vytae

The first thing I'd like to do here is reassure you, the reason I asked so many questions is because I do believe you're having problems and frankly (like most people who can figure out DataBroker) you seem too smart to have overlooked anything silly, that's why I jumped to the big questions in regards to which bag mods you were using if any, and such!

As it stands though, Bagsy clearly still has a problem if you're not using any bag mods, but it's a problem I didn't see when I uploaded 1.0, and in 1.1 I didn't even touch the bag line (I only changed two tooltip output lines and the placement of the icons). Once we've figured out what's actually going on with it, I'll get it fixed for you, too.

First things first, I'm going to break down how it works (removing any unncessary code from the example):

Code:
function ldb_obj.OnClick(_, which)
	local toggle = is_backpack_open() and "Close" or "Open"
	_G[which == "RightButton" and toggle.."AllBags" or toggle.."Backpack"]()
end
It uses toggle to build the function which is called, toggle just supplies Open or Closed to prepend the function name depending on the state of the backpack. So if the backpack is closed, and left-click is used, the function called is OpenBackpack(). If the bags are open, and right-click is used, the function called is CloseAllBags(). And vice versa.

There's only one thing that can be happening here, and that's that for some bizarre reason which I can't begin to comprehend, Fortress is actually interpreting right mouse clicks as left mouse clicks.

I trust that you tried running just Fortress & Bagsy alone for the purposes of testing, so I have another test for you. If the problem isn't in the code, then it must be in the settings. So here's what we're going to do...

The WTF folder in your World of Warcraft folder contains all your settings, so with Warcraft shut down, rename that folder to WTF_Backup (or similar). Then try running the game, you're going to lose all your settings temporarily but that won't matter, as long as you can get at Bagsy and try clicking on it, then that's all that's important. Try clicking on Bagsy at that time, and see whether the issue persists. If it doesn't then it's a settings problem somewhere.

To get your settings back, go back to your Warcraft folder with Warcraft shut down, there's a new WTF folder there. The new WTF folder are the settings that were created on the last run, we don't need those so delete that folder and then rename WTF_Backup to WTF. That way you'll get all your settings back.

Let me know what your findings are. If the issues prove to be settings-related then I have a few ideas on how we can proceed. If not then I'm completely stumped, but I'll keep looking into it anyway. But this is something we need to find out.
Report comment to moderator  
Reply With Quote
Unread 08-31-08, 09:19 PM  
Lullah
A Murloc Raider

Forum posts: 5
File comments: 12
Uploads: 0
Hey Esha

I just encountered a small problem, not really sure what's the cause of it...hopefully you (or someone else) can provide insight!

Everything works splendidly with Bagsy and I use Fortress for the display addon. I noticed my Bagsy doesn't look exactly like the one in your screenshot. Instead of colored numbers stating how much bag space I have left, mine is just white.
Report comment to moderator  
Reply With Quote
Unread 08-31-08, 05:33 PM  
Vytae
A Murloc Raider

Forum posts: 6
File comments: 62
Uploads: 0
Originally posted by VagrantEsha
That's very strange, I've actually tested this sans-bag mods and it worked fine. It works with Combuctor too, and apparently with BaudBag. The only thing left to me to ask is: Are you using any bag mods, and which one if so? If you're not, then I'm really baffled but I'll look into it nonetheless. If you're not using any bag mods, have you tried just having Bagsy and your DataBroker handler enabled? Does the problem persist? Which DataBroker handler are you using? Sorry to quiz you like this... but it's shots in the dark unless I know where to begin.
no bag mods being used
tried and no success
I am using Fortress and it seemed to work fine yesterday so i am baffled as well. I really didn't want to be the buzzkill after the two posts saying it worked like a dream
Report comment to moderator  
Reply With Quote
Unread 08-31-08, 03:48 PM  
VagrantEsha
Token Werewolf Fan
 
VagrantEsha's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 27
File comments: 238
Uploads: 38
That's very strange, I've actually tested this sans-bag mods and it worked fine. It works with Combuctor too, and apparently with BaudBag. The only thing left to me to ask is: Are you using any bag mods, and which one if so? If you're not, then I'm really baffled but I'll look into it nonetheless. If you're not using any bag mods, have you tried just having Bagsy and your DataBroker handler enabled? Does the problem persist? Which DataBroker handler are you using? Sorry to quiz you like this... but it's shots in the dark unless I know where to begin.
Report comment to moderator  
Reply With Quote
Unread 08-31-08, 12:55 PM  
Vytae
A Murloc Raider

Forum posts: 6
File comments: 62
Uploads: 0
Using version 2.4.3-1.1 the left click and right click only opens my main bag
Report comment to moderator  
Reply With Quote
Unread 08-31-08, 10:20 AM  
Frayol
A Deviate Faerie Dragon
 
Frayol's Avatar
AddOn Author - Click to view AddOns

Forum posts: 10
File comments: 127
Uploads: 4
I'd like to echo Beoko's words, he pretty much said it all. I'd also like to confirm that both left and right clicks now open BaudBag without any problems at all. Thanks for everything it is very much appreciated.
Report comment to moderator  
Reply With Quote
Unread 08-31-08, 08:28 AM  
Beoko
Guest

Join Date: Not Yet
Forum posts: 0
File comments: 0
Uploads: 0
Originally posted by VagrantEsha
And there we go, I've hit 1.0 with Bagsy and what a 1.0 it is. I've fixed all that needed to be fixed, and I included features that I didn't think I'd be able to figure out (embedding textures is fun). I did all this while keeping in mind that people probably use Bagsy because it's a leightweight little mod that's not billions of lines long with no care given to its overall performance. I have to admit that things like that sometimes almost give me bloody aneurysms, but I hope I'm succeeding at my goals.

Now that I've met all the feature requests for Bagsy though, I'm afraid I have some bad news...

http://vagrantesha.wowinterface.com/

You can reply here if you like, and worry not because this means nothing bad for my mods.
Oh my, bagsy has grown quite a bit since the last time I checked up on it . Very good stuff though, Vagrant! However, it's a sad day to see you burdened. I do hope whatever those circumstances are, that they will not be anything which would affect your wonderfully inspirational mind. I'm sure that you can come out of it standing on both feet, whether or not you return to WoW. Good things come from you, and while I do hope you return to WoW one day, I hope even more that your well-being should be intact. <3
Report comment to moderator  
Edit/Delete Message Reply With Quote
Unread 08-31-08, 07:19 AM  
VagrantEsha
Token Werewolf Fan
 
VagrantEsha's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 27
File comments: 238
Uploads: 38
And there we go, I've hit 1.0 with Bagsy and what a 1.0 it is. I've fixed all that needed to be fixed, and I included features that I didn't think I'd be able to figure out (embedding textures is fun). I did all this while keeping in mind that people probably use Bagsy because it's a leightweight little mod that's not billions of lines long with no care given to its overall performance. I have to admit that things like that sometimes almost give me bloody aneurysms, but I hope I'm succeeding at my goals.

Now that I've met all the feature requests for Bagsy though, I'm afraid I have some bad news...

http://vagrantesha.wowinterface.com/

You can reply here if you like, and worry not because this means nothing bad for my mods.
Last edited by VagrantEsha : 08-31-08 at 07:24 AM.
Report comment to moderator  
Reply With Quote
Unread 08-31-08, 03:12 AM  
karmamuscle
A Cobalt Mageweaver
 
karmamuscle's Avatar
AddOn Author - Click to view AddOns

Forum posts: 205
File comments: 173
Uploads: 1
Originally posted by VagrantEsha
Forgive me for being a dunce, but what do you mean by global value colour? At the moment, the overall count is being coloured by how much space you have left in your bags (more towards green if you've got lots of space, more towards red if they're almost full), and the bag items listed in the tooltip get their colours from their very own item links.

Do you mean that you want an option to turn the count-colouring off?
Yes thats exactly what I mean Thank you for saying what I actually want to say
I like having the same color on all my blocks
Report comment to moderator  
Reply With Quote
Unread 08-31-08, 01:43 AM  
Frayol
A Deviate Faerie Dragon
 
Frayol's Avatar
AddOn Author - Click to view AddOns

Forum posts: 10
File comments: 127
Uploads: 4
Sorry to say that 2.4.3-0.9 fix for the default bags actually made the behaviour even stranger. When I tested it, it now opens all apart from the backpack on the first right-click, then toggled the backpack open and closed on all subsequent right-clicks.

With regards to the display, I hadn't really thought about including professions bags to be honest. I would suggest a display of

<Bag Icon>: ?/? - <Ammo/SoulShard Icon>: ?/? - <Profession/CogWheel Icon>: ?/?

The choice of whether to display something would be good too. Perhaps as suggested by using shift+right-click to toggle the ammo count display on/off.

To round off I shall echo ckramme's comment, this is by far the best bag plugin for the DataBroker mods. Many, many thanks for all your efforts.
Report comment to moderator  
Reply With Quote
Unread 08-31-08, 12:18 AM  
VagrantEsha
Token Werewolf Fan
 
VagrantEsha's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 27
File comments: 238
Uploads: 38
Works great on my hunter now. Thanks so much!
Glad to hear it! Luckily I had my own level 30 Hunter alt on standby whom I could use to actually test something like this out with.

Looking forward to seeing what you come up with next.
If all goes according to plan, it should be even more helpful for Hunters (and other classes with bags) soon too, I'm just wondering about the best way to go about it, but once I'm done even Ammo count mods may not be necessary (such is the hope).

This by far the best bag plugin for the DataBroker mods.
I was wondering of it would be possible to get bagsy to use the global value color?
Forgive me for being a dunce, but what do you mean by global value colour? At the moment, the overall count is being coloured by how much space you have left in your bags (more towards green if you've got lots of space, more towards red if they're almost full), and the bag items listed in the tooltip get their colours from their very own item links.

Do you mean that you want an option to turn the count-colouring off?
Report comment to moderator  
Reply With Quote
Unread 08-30-08, 11:08 PM  
karmamuscle
A Cobalt Mageweaver
 
karmamuscle's Avatar
AddOn Author - Click to view AddOns

Forum posts: 205
File comments: 173
Uploads: 1
This by far the best bag plugin for the DataBroker mods.
I was wondering of it would be possible to get bagsy to use the global value color?
Report comment to moderator  
Reply With Quote
Unread 08-30-08, 04:52 PM  
Aethra
A Deviate Faerie Dragon
AddOn Compiler - Click to view compilations

Forum posts: 19
File comments: 42
Uploads: 3
Works great on my hunter now. Thanks so much!

Looking forward to seeing what you come up with next.
Report comment to moderator  
Reply With Quote
Unread 08-30-08, 03:40 PM  
VagrantEsha
Token Werewolf Fan
 
VagrantEsha's Avatar
Premium Member
AddOn Author - Click to view AddOns

Forum posts: 27
File comments: 238
Uploads: 38
The right-click opens all bags as it should. However a second right-click doesn't close them all again, but a left-click does. Not sure if this was the intended behaviour or not, but thought it best to let you know.
That's peculiar as it's just using ToggleBag(). Thanks for letting me know about this, I'll look into it. (But in the morning, if I touched the code as tired as I am now I would unleash horrors untold upon you all.)

Just a thought mind and I do confess an ulterior motive as I wouldn't mind being able to remove another addon that does the ammo counts.
It might seem like a big deal, but considering that the plugin collects all this data anyway it's just a matter of repurposing it to be displayed in other ways. There's only really one problem: Now that I've used so many clicks, I'm wondering how to handle the options. I'm thinking that having 'mirror options' would do it--for example, shift+left-click includes class bags in the overall count, shift+right-click shows an independant display for class bags--but I'll think more on that tomorrow.

The only other trick is how to display it. If I do something like:

Bags: ?/? - Class: ?/? - Profession: ?/?

It's going to get really long on some displays, and that's not something I want to bring about because a bag display should be short. What I'm thinking might be best is if the display were somehing like "?/? ?/? ?/?" and in the tooltip it would display something like "Count Order: Inventory - Class - Professions", and it would remove the appropriate elements depending on what's toggled.

I'd be interested in your thoughts on this anyway, and you'll have time because I'm off t'bed!
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: