(137Kb)

Updated: 09-24-12 05:37 AM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Updated:	09-24-12 05:37 AM
Created:	12-29-09 11:31 AM
Downloads:	18,352
Favorites:	186
MD5:
Categories:	Data Broker, Auction House & Vendors, Bags, Bank, Inventory

Broker Garbage

Version: 5.0v2

by: ckaotik [More]

Have you ever been in a situation where you just can't turn in a quest because your inventory is full? Trying to figure out an item to delete that's cheap and won't make you loose much gold?
This is one of the many situations where Broker_Garbage makes your life easier.

What is it?

Broker_Garbage shows your cheapest item(s) for easily freeing bag space. It uses your auction addon of choice for pricing, including disenchant prices if available. And if you don't want to throw away that [Broken I.W.I.N. Button], put it on your Exclude List and Broker_Garbage will keep it. Forever. Really! And those [Shiny Fish Scales]? Just put them on your Include List.

This addon works as-is but you will only see the text and tooltip if you use an LDB display addon. Some are Bagnon, DockingStation, Bazooka.

Basic Features - all features can be disabled if you don't want to use them

sells junk & chosen items to vendors
repairs your items if possible
sells equipment you can't use nor trade/mail
sells equipment you're not interested in (e.g. cloth on a warrior)
supports auction values from: Auctionator, Auctioneer+Enchantrix (Auc-Advandced), AuctionLite, WoWecon
auto-detect disenchantable items
disenchant items directly from the LDB tooltip!
manage your items - Never drop, always drop, use vendor price, auto sell - using easily configurable lists (shared or character specific)
lists support single items or categories (LibPeriodicTable support)
limit items such as Light Feather
keeps statistics of gains & losses
show cheap items in LDB tooltip & customize the display text
temporarily disable the whole addon with a single button
localized in English, German and Simple Chinese (partially), works in any language

Loot Manager Features

entirely optional plugin
uses your Broker_Garbage lists
intelligent autoloot - ignore cheap items if you have no bag space
clear skinnable mobs, loot when pickpocketing and/or fishing
option to autodestroy items to loot more valuable ones
option to destroy items over their limit
restack your inventory if needed
warn for unopened clams & containers
localized in Englis, German and Simple Chinese (partially), some features might not work in other locales

Support
Do you enjoy Broker_Garbage? So do I! But keeping it up to date and supporting it takes quite a bit of time. If you feel like treating me to a steaming hot chocolate (YUM!), have a loot at the donations page

As with any addon: I provide no warranty but it should do The Right Thing(tm).
If it does not do The Right Thing(tm) or something doesn't feel right, leave me a note containing as much information on your problem as possible, so I can try to fix it.

If you have any suggestions for new features, just write a comment and I'll think about it.
Likewise, if you speak a language currently not supported please feel free to help me localize Broker_Garbage - either send a PM or simply use Curse.com.

For cutting edge updates, find Broker_Garbage on github.com. Files released there are considered 'beta' status but might yield new features or bugfixes.
Broker_Garbage @github Broker_Garbage-LootManager @github

Hints

If you temporarily want to disable Broker_Garbage, just hold down the disable key (SHIFT by default) when adressing the merchant/opening the loot window! If you never want to, just uncheck the options in the options frame.
If you don't ever want to use the Loot Manager, you can disable it in the Addon List.

If you want to quickly add an item to the "Force Vendor Price" list, simply ALT-click on it in the tooltip.
To add a category to your lists, right-click on the corresponding 'plus' icon and choose the one you want.
To set a limit for an item, put it on your Include List and use your mousewheel to set the number.

If you see a question mark icon on any of your lists, it is probably a seasonal item the server hasn't seen yet. There's nothing I can do about that.

Feel free to try /garbage (or /garb). You'll find a few (useful?) goodies in there.

For more detailed information on how things work, have a look at the readme.txt files in the addon folders.

5.0v2
- fixed 'Reset statistics' button not working
- Fixed auto repair using guild funds. The config panel read and changed the wrong variable. You might have to re-check auto repair setting on any character. Guild repair now defaults to "off".
- fixed statistics getting bloated by vendoring high-auction items
- fixed lua error caused by invalid sorting function
- fixed restack lua error on combining e.g. leather scraps
- This commit will include most recent localization data
- removed unnecessary change to LDB
- fixed list options 'add' button to actually respond to OnDrag
- fixed loads and loads of global variables
- removed unset translations from generated localizations
- removed hard embedding of LibPeriodicTable - you might want to grab LibPeriodicTable (http://www.wowace.com/addons/libperiodictable-3-1/)
- lots of toying around with curse.com's packager script
- re-introduced curse.com's localization feature

5.0v1
* Many major and minor changes, rewrites, new options and more!
* A full change log is available on Curse.com

4.0v11
* Fixed lua error in constants.lua. This was caused by Blizzard removing the old totem/sigil/libram/relic item categories. About time, aye?
* This version contains a big remake of the Loot Manager: It will now look at all the loot in the loot window, not just one at a time. So it *should* make smarter decisions.
* added hard coded check to not try to sell to "Rusty Anvil" NPC (as it messes up your statistics)
* added TopFit outdated equipment as an option (works similar to unusable gear). You will need the most recent GitHub version of TopFit for it to work
* the current config UI __still needs to be cleaned up__ so sorry for the overlapping, just bear with it

4.0v8
* Fixed auto repair setting not being saved properly
* Let's see if Curse understands what I mean ...
* added (currently hidden) option to show which item was sold. Enable with /run BG_GlobalDB.showSellLog = true
* added check for BoP items, as they can't be auctioned (no matter what your AH addon may say ;) )
* fixed bug when using "Minimum free slots" slider
* fixed error thrown when deleting (some more testing needed)
* maybe fixed "attempt to compare with nil value" error thrown when looting (some more testing needed)
* fixed Ctrl/Alt-Clicks on LDB tooltip lines not working
* updated tooltip to be a little prettier
* added option to use icons in tooltip lines
* reverted tekKonfig back to normal. Forgot to do that previously ;)

4.0v7
Caution! It is best to remove any previous version of Broker_Garbage & Broker_Garbage-LootManager before updating! (your saved variables will be safe!)
* split off all options into Broker_Garbage-Config, a load on demand addon (this saves you ~400kb of memory if you don't need the options)
* fixed Archaeology problems
* Added [itemicon] to LDB display variables
* Repairing via guild funds as guild master now works as intended
* Added Blizzard's Equipment Manager sets for list management
* Added armor classes (cloth, leather, ...) as sets for list management. Use it e.g. to automatically sell cloth on your warrior. CAUTION! This does not check if the item is soulbound or not, unlike Sell Unusable Gear!)

4.0v6
* fixed 'compare with nil' error when using Enchantrix
* fixed LPT not being properly recognized

4.0v5
* changed the way Auctioneer & Enchantrix values get retrieved. It was a whole mess before and apparently didn't even work correctly!
* changed the way auction values get treated. BG is now aware if there is more than one auction addon loaded and chooses the highest available price it can find.
* updated disenchant levels, now includes cataclysm data (all based on Wowhead.com)
* updated item caching: The new GetItemInfo() made quite a fuss
* unknown list items will now get updated when hovering
* slightly widened the right column in the statistics view
* added AddonLoader support. Default is now: delayed
* BG's tooltip will now work in NinjaPanel! It required a OnLeave() hook to be used

4.0v4
* adjust width/column count in list view automatically fixed (?)
* adjusted unusable gear table. added new "relic" class (librams, totems, sigils all count as relic as of 4.0)
* fixed error when scanning professions
* minor fix for the sell icon not updating properly when auto selling (wherever that came from)
* did some localization tweaks: typos and caution messages ;)
* once again updated LPT version
* did some localization fixes
* added some slash commands:
/garbage tooltiplines <num>
/garbage tooltipheight <num>
/garbage freeslots <number>
* adjusted GetBagSlots() to only consider general bags
* added new tags for use in LDB display text:
[basicfree], [basicslots], [specialfree], [specialslots] to split bag data
[basicbagcolor], [specialbagcolor] to colorize only data for those types of bags
* updated readme.txt on these changes

LootManager changes:
* several minor documentation / localization changes
* added panel:Update() function
* added fix for FishingBuddy not working. This is an issue caused by the LootManager's auto close feature. If you encounter other addons not working properly and you think they might rely on the LOOT_CLOSED event, try disabling this option in the LootManager's options tab. For Fishing Buddy, it is now disabled by default - when fishing only.
* hopefully fixed BoP confirmation not working: yet again, I referenced the wrong variable.
* the same goes for closing the loot window.

4.0v3
* improper column count in list options panel (most likely) fixed
* error on loading options (most likely) fixed
* removed WotLK compatibility layer as 4.0 is live
* updated TOC to proper reflect that this is a 4.0 version
* removed soul shards from default lists, as they changed completely
* removed hunter ammo from default lists (obsolete)
* included most recent LibPeriodicTable data. I hope it gets a real update soon, it's just so horribly off in some categories ...

4.0v2
* fixed promote/demote and delete on lists not working
* fixed error that occured when removing the limit of a junk item
* fixed loot window closing when it's not meant to
* fixed tooltip display for options: money format, drop treshold, sell treshold
* added global tag to "clear all" and "auto confirm bop" tooltips (it was missing before)
* added option to not automatically close the loot window
* provided option to change the Junk List's behavior: toggle between 0c value (default) and actual value (new)
* cleaned up the help panel. Texts are the same but the code is now much neater
* fishing addons not working? try FishingBuddy!

Loot Manager:
* fixed loot master messages: they should now only showing up once
* fixed permanent autoloot
* rearranged autoloot action priorities - this should fix the "loot window closes too quickly" issue in 4.0 v1

4.0v1
* fixed live compatibility (wrong variable name slipped in ...)
* fixed "attempt to compare with nil value" error: referred to the wrong saved variable

4.0v0
* restructured options:
* combined basic options, category test & loot manager into one panel, using tabs
* basic options grouped by their purpose, e.g. all the tooltip settings in one place
* loot manager grouped by their purpose
* shortened & restructured functions to show LibPeriodicTable contents, e.g. when adding a category or using category test (much in favor of my sanity)

* Basic Options changes:
* changed the way "Use in Combat" works. It will now only effect LootSlot() and CloseLoot() functions (which cause addon blocked issues), rather than disable the whole addon if it's unchecked
* clearified label texts for "Drop Treshold" and "Sell treshold". Also, these now use dropdown menus instead of a slider.
* renamed delete "instantly" to "enforce". When checked, Broker_Garbage will try its best to keep your free slots at or above your specified "Minimum free slots".
* renamed "Pickpocket" to "Stealing" in order to use progressive forms on all of these options (call it a knack of mine, if you like).
* added option "Auto-Confirm BoP". When checked, Broker_Garbage will take BoP items without showing the popup.

* Loot Manager options changes:
* removed "Enable" checkbox. Simply use Blizzard's addon manager to disable the Loot Manager
* removed "Selective Looting" checkbox. Looting will take place if any of the "Looting" checkboxes are checked. The only option that went missing without this checkbox is coloring/highlighting loot when *not* autolooting. If you don't like it, you probably don't want the Loot Manager as a whole.
* renamed "Enchanter" to "Have Enchanter" to clearify its meaning. Note please, that if you are an enchanter yourself, this checkbox is meaningless. Use it to 'tell' your Alts to not vendor disenchantable items.
* changed "Money Format" from a slider to a dropdown menu. It just makes more sense that way.

* revised former "Delete instant", see explanation above
* fixed junk items being treated incorrectly
* fixed price inflation for included items (auction prices were used, even though vendor prices should have been)

--> This release is the same as posted in the Cataclysm category. The above are all the changes that occured on that version ;) So, just to make things clear: This version of BG and the one in the Cataclysm category are *identical*

3.3v29 It took quite a while, but I hope it's worth it! Lots of file changes in here, I suggest you remove your Broker_Garbage and Broker_Garbage-LootManager folders and do a clean install (just extract, as usual)
* libraries updated
* hunters cannot use thrown weapons (fixed)
* rogues can use 1h axes (fixed)
* items with forced vendor prices will no longer be sold automatically (fixed)
* items won't inflate your statistics: fixed wrong values getting assigned to forced/listed items
* rebuilt list options
* Updated localizations to mirror these changes, e.g. lists renamed, explanation texts etc.
* Updated (re-wrote) sell icon function. No more missing icons, I hope!
* improved sell icon (texture, size ...)
* Updated default lists
* LootManager: auto-destroy settings are now local (so you can auto-destroy items on your level 15 rogue, but not on your 80 mage)
* LootManager: combat setting now also applies to looting money and closing the loot window (as it always should have)
* LootManager: simple implementation of "private loot": when opening containers in your bag, group loot rules should be ignored
* LootManager: completely re-structured selective looting procedure. The LM should now only delete items and warn of such actions if you're allowed to take that item (no more auto-deleting items for ones that are being rolled for)
* LootManager: updated quest items to always be looted
* LootManager: removed libraries, as those should already be loaded by Broker_Garbage (which is a dependency, anyway!)
* LootManager: now warns if a "Inventory is full" UI error occured
Minor changes:
* removed unnessessary event hook as well as comments
* fixed error created by slash-adding limited items that the server does not know
* fixed list manipulations that were broken because of tooltip/attribute changes (in between versions)

3.3v28
* hopefully the sell icon will now show when it is supposed to
* fixed various minor bugs
* fixed Loot Manager priorities, they got somewhat mixed up. The messages should be more fitting now.
* adjusted some localization strings
* re-inserted "use in combat" checkbox
* fixed default list creation - note that on login, BG cannot scan your tradeskills, but you can use the "default lists" button anytime to have him re-scan
* updated included LPT files
* LDB tooltip and text should now refer to the same item again
* fixed Loot Manager saved variables bug. some settings were requested before they were initialized

3.3v27
* deathknights cannot wear shields. fixed
* fixed items on sell list not selling
* added option to use include list as sell list
* inventory scanning rewritten - will now only scan updated bags, and item info is cached <-- this is worth about 10 minor features and 100kB memory per scan saved
* Broker_Garbage-LootManager: Changed the way 'Warn Clams' and 'Warn Containers' work - they will now show a line in the tooltip
* refined security checks when deleting items
* changed the license from GPLv2 to BSD, mainly because it does all I really need and is much less painful to read ;)
* fixed the bug where BG would go nuts after visiting a merchant once
* many thanks to Zidomo and Cidrei for elaborate testing!

3.3v26
* scanning will now work properly again (I deleted 2 lines that shouldn't have been deleted)
* finally found why Sell Gear would not work - fixed! Gear would only get sold if the global threshold was greater than the Sell Gear treshold, which was not intended.
* BG_LootManager: removed unnessessary saved variables
* Notice: BG_LootManager won't be able to work with the CTRL disable key as CTRL+Click is already connected to the dressup functionality

3.3v25
* made Auto Repair more intelligent: It will tell you if you don't have enough money to repair
* removed /garbage stats slash command - the options panel provides the same information and more (and prettier)
* fixed BG trying to get item values before auction addons are loaded
* fixed the error that was caused by a debug message if you didn't have any junk on you
* changed the format of localization files to support partial translations
* fixed /garbage format reset that would still reset to the old display format

3.3v24
* fixed Sell Gear not selling items (at all)
* fixed tabards not being sold by Sell Gear
* fixed (manual) selling via the tooltip when at a vendor: items without a value will be deleted instead of trying to sell them (which would result in 'The vendor is not interested in this item' error)
* Create Default Lists button fixed. Left-click it to create character specific list entries
* loot window will not be automatically closed if you can't loot something because of missing bagspace (which made it really hard to actually loot the item manually)
* changed plugin handling
* added supported auction addons to .toc file
* updated LibQTip library

3.3v23 Hopefully fixed the 'Addon blocked' issue.
Added an options panel to test category strings. Updated some of the libraries.
Renamed 'Drop Quality' to 'Quality Treshold', 'Positive lists' to 'Whitelist' and 'Negative lists' to 'Blacklist'.
Added button to load default list options.

3.3v22 (Patch 3.3.3) Things fixed:
When 'Never repair guildbank' is checked, Broker_Garbage will now not touch your guild funds any more.
The tooltip may now show more than one stack of any item.
Solved Autosell list priority conflicts: ItemIDs have higher priority than LPT strings.
LootManager turned more talkative. Now uses proper localization strings.
New feature: Sell unusable equipment. This will for example sell plate if you're a clothie, the item is soulbound and you yourself can't disenchant.

3.3v21 several bug fixes, including: Missing enchanting values für > epic items, included tekKonfigDropdown, statistical data gathering cleaned up, Autosell bug when having excluded items in the inventory, display of over-treshold Autosell items ...
New features: Changed the way you may edit the LDB display text, the question mark will help you with (re)configuration. (to lessen lua errors caused by wrong input)
Added possibility to colorize the LDb display text according to your bag situation ([bagspacecolor] ... [endcolor]
You can now use [junkvalue] in the LDB display text, which will show what your junk/Autosell stuff is worth.
SHIFT-Click on the tooltip/the LDB when at a merchant will now sell the item, rather than destroy it.

3.3v20 Split Broker_Garbage basic addon and Broker_Garbage-LootManager into two addons. Fixed some bugs and auction value calculation.
Update: Stupid debug...

3.3v19 Non-limited but included items will be handled properly once again. Same goes for Auto Sell List items.

3.3v18 Autodestroy fixed, fixed promoting limited items

3.3v17 Added the Loot Manager! It uses your Include (never loot) and Exclude List (always loot). to disable it, read the description or the readme.txt.
Added item limits! Want to keep no more than 5 Soulshards? Simply use your mousewheel on the corresponding icon on your include list. Items within that limit will not be shown on the tooltip.
Finally 'fixed' the Sell Icon - it will now properly show if there's something to sell - or not.
Also added some default list settings.
Fixed quite a hand full of bugs, too. Simplified code.

3.3v16 LDB display text option added to interface options panel. Statistics panel added. Fixed a bug where dragging items to the plus icons didn't work. Fixed a bug that caused too many items to appear in the tooltip. Finally found & fixed the bug that made you open positive lists before negative lists ;)

3.3v15 /garbage commands added, LDB text made more customizable, 'pre' errors fixed. Birthday-to-be edition.

3.3v14 Added compatibility to Broker2FuBar. Category list menu reduced to interesting parts. Auto Sell Icon will now do its job.

3.3v13 Addid items to lists possible - once again. No more "LeftButton" added to any list. Fixed icons not updating if GetItemInfo was missing

3.3v12 Auto sell settings will now, once again, be properly saved. This fixed the checksound-error as well. Or is it the other way around? :P

3.3v11 Added LPT support - you can add categories to your lists by right clicking on the 'plus' icons. For more info, have a look at the readme.txt . There might still be bugs in there, but I didn't find any ;) Therefore tagging as beta (to keep the files consistent to curse.com's version).
Update: Told you, there would be bugs! Fixed desaturating icons. Fixed missing items crashing the addon (GetItemInfo on seasonal items sucks).

3.3v10 Bugfixes, once again. And no, an itemLink is NOT the same as an itemID ~.~ New lists should work properly now. Reset money earned/lost will now properly reset the local value, rather than the global one.

3.3v9 list management clarified, more lists added (have a look at the options or the readme file): Force Vendor Price & Auto-Sell. New: ALT-Click on an item in the tooltip and it will be added to your Vendor Price List.

3.3v8 no new features, just a bunch of bugfixes ... stupid stupid Macs ... hate them!

3.3v7 LDB plugin clicks should work for all displays, added "money earned" to tooltip info, shows "no items" instead of empty tooltip, show (or hide) icon to manually sell grays at a vendor

3.3v6 LDB plugin will now properly react to clicks. List Options should display properly

3.3v5 stupid me -.- left debug mode on ... should probably write a pre-release checklist or something. Indeed, I should. Missed something on the include list management.

3.3v4 Tooltip! Corrected auto-hide time, should(tm) work.
Interface! Added options menu to handle include/exclude lists. No more guessing what might be on there!

3.3v3 another try at fixing sticky tooltips (by having the LDB display having the work of hiding the tooltip, not the plugin)

3.3v2 deDE localisation fix, money chat message changed

3.3v1 first upload

Optional Files (0)

Comment Options

Page 11 of 18

« First

Last »

05-08-10, 04:03 PM
Cidrei A Fallenroot Satyr Forum posts: 21 File comments: 114 Uploads: 17	Items on the sell list aren't being sold if they are higher in quality than the quality threshold. The tooltip for the button is correctly displaying the value of the items to be sold, but it's not actually selling them (or listing them in the LDB feed to be sold/dropped). Last edited by Cidrei : 05-08-10 at 04:04 PM.

05-06-10, 06:19 AM

ckaotik

A Fallenroot Satyr

Forum posts: 29

File comments: 168

Uploads: 5

Originally posted by euda
This is a powerful addon and I suspect I'm just trying to use it in a far simpler way than intended lol. Perhaps I what I want is a feature request? Where the vendor sell button sells anything in my LDB tooltip list, regardless of why it's there.

Yup, that's what it is. I'll think about it but currently I don'r really see the need to add this. Maybe later/if more people request it.
Until then, you could use the fact that Shift-Cklicking an item in the tooltip while at a vendor sells the item, rather than destroys it.

__________________
It all starts to make a creepy kind of sense. Avatar

05-05-10, 10:35 PM

euda

A Kobold Labourer

Forum posts: 0

File comments: 10

Uploads: 0

Originally posted by ckaotik
[b]Well, that's what it is supposed to do :/ Otherwise the 'auto sell to vendor' (it's a blacklist) list wouldn't make any sense, would it? Do you gave your items on there?
...

Sorry for delay in reply. I finally got another example of what confused me into picture form here. This character has many Whitelist:'exclude' entries, and a single Blacklist:'sell list' entry of "Consumable.Scroll". I do not use the loot manager either.

This is a powerful addon and I suspect I'm just trying to use it in a far simpler way than intended lol. Perhaps I what I want is a feature request? Where the vendor sell button sells anything in my LDB tooltip list, regardless of why it's there.

Thanks for your feedback so far.

05-01-10, 06:51 AM

ckaotik

A Fallenroot Satyr

Forum posts: 29

File comments: 168

Uploads: 5

Originally posted by euda
I would think it be preferable to have the vendor button sell whatever is in the drop/junk list.

Well, that's what it is supposed to do :/ Otherwise the 'auto sell to vendor' (it's a blacklist) list wouldn't make any sense, would it? Do you gave your items on there?

Edit: Please make sure you use the Auto Sell list as that's exactly what it does

The Include list only marks items as "please show them in my tooltip because usually they don't mean much to me" - the Include list is more of a suggestion list and only works passively (if you don't use Auto Sell from the Loot Manager) whereas Auto Sell actively does something

__________________
It all starts to make a creepy kind of sense. Avatar

Last edited by ckaotik : 05-02-10 at 08:11 AM.

04-28-10, 06:01 PM
euda A Kobold Labourer Forum posts: 0 File comments: 10 Uploads: 0	Excellent addon! I've been looking for a solid addon to replace GarbageFu since I went from Fubar to Broker mods. This one does everything I wanted! I do wonder if the sell button on the vendor window is supposed to only sell grey junk? The one time I've gotten to use it, it seemed to only sell grey items despite MY junk list having more than that. I have auto-selling off, gear selling on, many white list entries and a single black list category. I would think it be preferable to have the vendor button sell whatever is in the drop/junk list. Keep up the great work

04-24-10, 02:40 AM

ckaotik

A Fallenroot Satyr

Forum posts: 29

File comments: 168

Uploads: 5

Originally posted by Zidomo
Yes, you would think that for the MERCHANT_CLOSED event, BrokerGarbage:ScanInventory() would function. But it doesn't at all. Only when placed for the PLAYER_MONEY event sequences (as done in the latest build) does BrokerGarbage:ScanInventory() seem to have any affect.

Okay, thanks for the testing

I suppose the scanning didn't work before because I lock BG's actions while it is selling (otherwise you'd have 2-4 scans per item that you're selling and it might mess up things) - so my guess is that the BAG_UPDATE events fire while it is locked, so basically I force BG so re-scan after it unlocks.
I'll also keep an eye open if Sell Gear works for me (as it did before). Unfortunately, there are not that many items my shaman *can't* wear

__________________
It all starts to make a creepy kind of sense. Avatar

04-23-10, 01:53 PM
Zidomo A Cliff Giant Forum posts: 76 File comments: 1046 Uploads: 0	Yep, often use the tracker (and have an account) on Github. Been posting here for this mod, though; better to let a wider audience know the problems encountered. At least until I get tired of fiddling with this (as happened last week). Build afc1c5bc33db64375bdd6274b607aa14dde5b177 finally works properly in terms of tooltip updating and not continually "selling" non-existent items when pressing the vendor sell button. Yay. In terms of Sell gear working or not, haven't picked up anything yet. Will let you know. Yes, you would think that for the MERCHANT_CLOSED event, BrokerGarbage:ScanInventory() would function. But it doesn't at all. Only when placed for the PLAYER_MONEY event sequences (as done in the latest build) does BrokerGarbage:ScanInventory() seem to have any affect. Last edited by Zidomo : 04-23-10 at 01:54 PM.

04-22-10, 06:15 AM
ckaotik A Fallenroot Satyr Forum posts: 29 File comments: 168 Uploads: 5	Aye, unfortunately I'm still not back on my machine (addon testing on a 1GB RAM, 600 MHz, no graphics card laptop is absolutely not fun) so I can't really test it for now. Still, added (yet) another line on git which sould help once more. The one before just kicked in when you leave the vendor, while the new one reverts the scanning behaviour back to what it was before. The Sell Gear issue is something I don't like, though. Hopefully it vanishes with scanning working again, but I don't expect to get that lucky. Guess I'll just have to see how it works out and have another look when I'm back home :/ Also, if you find bugs, feel free to use git's issue tracker. I read comments here, on curse and on git, but that's a little time consuming __________________ It all starts to make a creepy kind of sense. Avatar

04-22-10, 01:39 AM
Zidomo A Cliff Giant Forum posts: 76 File comments: 1046 Uploads: 0	Github build 47f8911cdbba9f17df29d60a5c6c3dea0fc221d0 (with the added BrokerGarbage:ScanInventory() line), things are pretty much the same as they were with 3.3v25. As well, Sell gear doesn't work at all. Pick up junk from a run, including 2 unusable Rare BOP items (the Max. Quality slider is set to Epic). The Garbage tooltip doesn't show the BOP items. Press the Garbage vendor button to sell, the gray items are sold. But the BOP items are not. Also, as before, the Garbage tooltip fails to update; still shows the junk that has just been sold. And continues to do so after leaving the vendor. Buy the junk items back, try again. Same thing happens; incorrect tooltip info after the junk has been sold and leaving the vendor. But then go back and sell the BOP items by manually putting them in the vendor window. Now the Garbage tooltip finally updates to show No junk. Last edited by Zidomo : 04-22-10 at 01:40 AM.

04-20-10, 01:52 AM

ckaotik

A Fallenroot Satyr

Forum posts: 29

File comments: 168

Uploads: 5

Originally posted by Zidomo
Seems as though bag updates got bugged in v25.

I just accidentally deleted one line that probably shouldn't be deleted

I'm currently not at home so no proper update for now. To quick-fix the issue use GitHub which should do the trick.

__________________
It all starts to make a creepy kind of sense. Avatar

Last edited by ckaotik : 04-20-10 at 01:56 AM.

04-20-10, 01:15 AM

Zidomo

A Cliff Giant

Forum posts: 76

File comments: 1046

Uploads: 0

Originally posted by ckaotik
Does the tooltip update when you press 'Rescan Inventory' (on the options panel)? I hope it does as I changed nothing that has to do with it. Probably just cut out a line too many ...

Yes the tooltip does update to the proper amount of junk you have after selling (none) after pressing Rescan Inventory.

But it doesn't really solve the problem; its not persistent. You have to Rescan Inventory every single time after selling items for the tooltip to update properly.

Seems as though bag updates got bugged in v25.

04-19-10, 04:29 PM

ckaotik

A Fallenroot Satyr

Forum posts: 29

File comments: 168

Uploads: 5

Originally posted by Zidomo
Yes, Github (using git) is an excellent development site for alphas, as well as providing them for others to test, etc.. WowInterface here also has a dev repository (using SVN only). As does WowAce & Curse (Curseforge).

The problem with this is just that I simply don't have enough users that would test it. And even if some do so - they don't give any feedback. So we all have to bite the sour apple and see what comes of single-handed tested addon versions. I don't like having to bug-fix-bug-fix every release three times in order to have it working, and you probably don't like having a buggy addon.

I do enjoy writing (and also maintainig) this addon. I really do. But please keep in mind that I'm just that: me. And me being a student has real life things to tend to as well as lots to learn yet ^^ Also, it means I have limited time to test all the things you might do with Broker_Garbage. I probably could release a pretty much bug-free version, but that would only recreate exactly my settings and you probably wouldn'nt like it much

Back to topic: Does the tooltip update when you press 'Rescan Inventory' (on the options panel)? I hope it does as I changed nothing that has to do with it. Probably just cut out a line too many ...

__________________
It all starts to make a creepy kind of sense. Avatar

04-19-10, 03:35 PM
Zidomo A Cliff Giant Forum posts: 76 File comments: 1046 Uploads: 0	v3.3v25, basic junk selling is bugged. Have some junk from a previous night's run in packs (no "unusable BOP items", though). Go to vendor, click the vendor button to sell, it does so. But then leave the vendor, the Garbage tooltip is still showing the items that I just sold. And continues to do so for five minutes until I go back to a vendor & click the (now grey/"There is nothing to sell!") sell button again. Then the tooltip clears. In the same session, do another dungeon run, pick up junk, problem repeated (again no unusable BOPs). But this time the problem persisted. No matter how often I went to the vendor and clicked the grayed-out sell button, the tooltip remained showing all the junk that had previously been sold. As well received chat feedback--Broker Garbge: Sold trash for 1.38.26--every single time I clicked the button. Despite nothing further being sold. And the Money Earned amount goes up pressing the button, despite nothing actually being sold. Yes, Github (using git) is an excellent development site for alphas, as well as providing them for others to test, etc.. WowInterface here also has a dev repository (using SVN only). As does WowAce & Curse (Curseforge). Last edited by Zidomo : 04-19-10 at 03:44 PM.

04-18-10, 11:34 AM
ckaotik A Fallenroot Satyr Forum posts: 29 File comments: 168 Uploads: 5	I put an updated version online. This should solve the issue (and some others, too) __________________ It all starts to make a creepy kind of sense. Avatar Last edited by ckaotik : 04-19-10 at 07:39 AM.

04-18-10, 10:19 AM

Zidomo

A Cliff Giant

Forum posts: 76

File comments: 1046

Uploads: 0

Changed back to my old garbage mod since our last conversation. But now seeing 3.3v24, decided to give it another go.

Log on, right-click my LDB display to open Garbage's options, nothing happens and:

Code:

["message"] = "Broker_Garbage-3.3v24\\core.lua:251: attempt to index local 'itemTable' (a nil value)\nBroker_Garbage-3.3v24\\core.lua:20: in function `OnClick'\nStatBlockCore-2.65\\StatBlockCore.lua:598: in function <Interface\\AddOns\\StatBlockCore\\StatBlockCore.lua:596>\n\nLocals:|r\n\n  ---",
            ["type"] = "error",
            ["session"] = 1800,
            ["counter"] = 1,
        }, -- [642]
    },

Page 11 of 18

« First

Last »

Like Broker_Garbage? Feel free to buy me a drink (yummy, hot chocolate!)

Every donation is highly appreciated!

Report this File

Category Jump: