Download
(137Kb)
Download
Updated: 09-24-12 05:37 AM
Pictures
File Info
Updated:09-24-12 05:37 AM
Created:12-29-09 11:31 AM
Downloads:18,341
Favorites:186
MD5:
Categories:Data Broker, Auction House & Vendors, Bags, Bank, Inventory

Broker Garbage  Popular! (More than 5000 hits)

Version: 5.0v2
by: ckaotik [More]

Have you ever been in a situation where you just can't turn in a quest because your inventory is full? Trying to figure out an item to delete that's cheap and won't make you loose much gold?
This is one of the many situations where Broker_Garbage makes your life easier.

What is it?

Broker_Garbage shows your cheapest item(s) for easily freeing bag space. It uses your auction addon of choice for pricing, including disenchant prices if available. And if you don't want to throw away that [Broken I.W.I.N. Button], put it on your Exclude List and Broker_Garbage will keep it. Forever. Really! And those [Shiny Fish Scales]? Just put them on your Include List.

This addon works as-is but you will only see the text and tooltip if you use an LDB display addon. Some are Bagnon, DockingStation, Bazooka.

Basic Features - all features can be disabled if you don't want to use them

  • sells junk & chosen items to vendors
  • repairs your items if possible
  • sells equipment you can't use nor trade/mail
  • sells equipment you're not interested in (e.g. cloth on a warrior)
  • supports auction values from: Auctionator, Auctioneer+Enchantrix (Auc-Advandced), AuctionLite, WoWecon
  • auto-detect disenchantable items
  • disenchant items directly from the LDB tooltip!
  • manage your items - Never drop, always drop, use vendor price, auto sell - using easily configurable lists (shared or character specific)
  • lists support single items or categories (LibPeriodicTable support)
  • limit items such as Light Feather
  • keeps statistics of gains & losses
  • show cheap items in LDB tooltip & customize the display text
  • temporarily disable the whole addon with a single button
  • localized in English, German and Simple Chinese (partially), works in any language

Loot Manager Features
  • entirely optional plugin
  • uses your Broker_Garbage lists
  • intelligent autoloot - ignore cheap items if you have no bag space
  • clear skinnable mobs, loot when pickpocketing and/or fishing
  • option to autodestroy items to loot more valuable ones
  • option to destroy items over their limit
  • restack your inventory if needed
  • warn for unopened clams & containers
  • localized in Englis, German and Simple Chinese (partially), some features might not work in other locales

Support
Do you enjoy Broker_Garbage? So do I! But keeping it up to date and supporting it takes quite a bit of time. If you feel like treating me to a steaming hot chocolate (YUM!), have a loot at the donations page

As with any addon: I provide no warranty but it should do The Right Thing(tm).
If it does not do The Right Thing(tm) or something doesn't feel right, leave me a note containing as much information on your problem as possible, so I can try to fix it.

If you have any suggestions for new features, just write a comment and I'll think about it.
Likewise, if you speak a language currently not supported please feel free to help me localize Broker_Garbage - either send a PM or simply use Curse.com.

For cutting edge updates, find Broker_Garbage on github.com. Files released there are considered 'beta' status but might yield new features or bugfixes.
Broker_Garbage @github Broker_Garbage-LootManager @github


Hints

If you temporarily want to disable Broker_Garbage, just hold down the disable key (SHIFT by default) when adressing the merchant/opening the loot window! If you never want to, just uncheck the options in the options frame.
If you don't ever want to use the Loot Manager, you can disable it in the Addon List.

If you want to quickly add an item to the "Force Vendor Price" list, simply ALT-click on it in the tooltip.
To add a category to your lists, right-click on the corresponding 'plus' icon and choose the one you want.
To set a limit for an item, put it on your Include List and use your mousewheel to set the number.

If you see a question mark icon on any of your lists, it is probably a seasonal item the server hasn't seen yet. There's nothing I can do about that.

Feel free to try /garbage (or /garb). You'll find a few (useful?) goodies in there.

For more detailed information on how things work, have a look at the readme.txt files in the addon folders.

5.0v2
- fixed 'Reset statistics' button not working
- Fixed auto repair using guild funds. The config panel read and changed the wrong variable. You might have to re-check auto repair setting on any character. Guild repair now defaults to "off".
- fixed statistics getting bloated by vendoring high-auction items
- fixed lua error caused by invalid sorting function
- fixed restack lua error on combining e.g. leather scraps
- This commit will include most recent localization data
- removed unnecessary change to LDB
- fixed list options 'add' button to actually respond to OnDrag
- fixed loads and loads of global variables
- removed unset translations from generated localizations
- removed hard embedding of LibPeriodicTable - you might want to grab LibPeriodicTable (http://www.wowace.com/addons/libperiodictable-3-1/)
- lots of toying around with curse.com's packager script
- re-introduced curse.com's localization feature

5.0v1
* Many major and minor changes, rewrites, new options and more!
* A full change log is available on Curse.com

4.0v11
* Fixed lua error in constants.lua. This was caused by Blizzard removing the old totem/sigil/libram/relic item categories. About time, aye?
* This version contains a big remake of the Loot Manager: It will now look at all the loot in the loot window, not just one at a time. So it *should* make smarter decisions.
* added hard coded check to not try to sell to "Rusty Anvil" NPC (as it messes up your statistics)
* added TopFit outdated equipment as an option (works similar to unusable gear). You will need the most recent GitHub version of TopFit for it to work
* the current config UI __still needs to be cleaned up__ so sorry for the overlapping, just bear with it

4.0v8
* Fixed auto repair setting not being saved properly
* Let's see if Curse understands what I mean ...
* added (currently hidden) option to show which item was sold. Enable with /run BG_GlobalDB.showSellLog = true
* added check for BoP items, as they can't be auctioned (no matter what your AH addon may say ;) )
* fixed bug when using "Minimum free slots" slider
* fixed error thrown when deleting (some more testing needed)
* maybe fixed "attempt to compare with nil value" error thrown when looting (some more testing needed)
* fixed Ctrl/Alt-Clicks on LDB tooltip lines not working
* updated tooltip to be a little prettier
* added option to use icons in tooltip lines
* reverted tekKonfig back to normal. Forgot to do that previously ;)

4.0v7
Caution! It is best to remove any previous version of Broker_Garbage & Broker_Garbage-LootManager before updating! (your saved variables will be safe!)
* split off all options into Broker_Garbage-Config, a load on demand addon (this saves you ~400kb of memory if you don't need the options)
* fixed Archaeology problems
* Added [itemicon] to LDB display variables
* Repairing via guild funds as guild master now works as intended
* Added Blizzard's Equipment Manager sets for list management
* Added armor classes (cloth, leather, ...) as sets for list management. Use it e.g. to automatically sell cloth on your warrior. CAUTION! This does not check if the item is soulbound or not, unlike Sell Unusable Gear!)

4.0v6
* fixed 'compare with nil' error when using Enchantrix
* fixed LPT not being properly recognized

4.0v5
* changed the way Auctioneer & Enchantrix values get retrieved. It was a whole mess before and apparently didn't even work correctly!
* changed the way auction values get treated. BG is now aware if there is more than one auction addon loaded and chooses the highest available price it can find.
* updated disenchant levels, now includes cataclysm data (all based on Wowhead.com)
* updated item caching: The new GetItemInfo() made quite a fuss
* unknown list items will now get updated when hovering
* slightly widened the right column in the statistics view
* added AddonLoader support. Default is now: delayed
* BG's tooltip will now work in NinjaPanel! It required a OnLeave() hook to be used

4.0v4
* adjust width/column count in list view automatically fixed (?)
* adjusted unusable gear table. added new "relic" class (librams, totems, sigils all count as relic as of 4.0)
* fixed error when scanning professions
* minor fix for the sell icon not updating properly when auto selling (wherever that came from)
* did some localization tweaks: typos and caution messages ;)
* once again updated LPT version
* did some localization fixes
* added some slash commands:
/garbage tooltiplines <num>
/garbage tooltipheight <num>
/garbage freeslots <number>
* adjusted GetBagSlots() to only consider general bags
* added new tags for use in LDB display text:
[basicfree], [basicslots], [specialfree], [specialslots] to split bag data
[basicbagcolor], [specialbagcolor] to colorize only data for those types of bags
* updated readme.txt on these changes

LootManager changes:
* several minor documentation / localization changes
* added panel:Update() function
* added fix for FishingBuddy not working. This is an issue caused by the LootManager's auto close feature. If you encounter other addons not working properly and you think they might rely on the LOOT_CLOSED event, try disabling this option in the LootManager's options tab. For Fishing Buddy, it is now disabled by default - when fishing only.
* hopefully fixed BoP confirmation not working: yet again, I referenced the wrong variable.
* the same goes for closing the loot window.

4.0v3
* improper column count in list options panel (most likely) fixed
* error on loading options (most likely) fixed
* removed WotLK compatibility layer as 4.0 is live
* updated TOC to proper reflect that this is a 4.0 version
* removed soul shards from default lists, as they changed completely
* removed hunter ammo from default lists (obsolete)
* included most recent LibPeriodicTable data. I hope it gets a real update soon, it's just so horribly off in some categories ...

4.0v2
* fixed promote/demote and delete on lists not working
* fixed error that occured when removing the limit of a junk item
* fixed loot window closing when it's not meant to
* fixed tooltip display for options: money format, drop treshold, sell treshold
* added global tag to "clear all" and "auto confirm bop" tooltips (it was missing before)
* added option to not automatically close the loot window
* provided option to change the Junk List's behavior: toggle between 0c value (default) and actual value (new)
* cleaned up the help panel. Texts are the same but the code is now much neater
* fishing addons not working? try FishingBuddy!

Loot Manager:
* fixed loot master messages: they should now only showing up once
* fixed permanent autoloot
* rearranged autoloot action priorities - this should fix the "loot window closes too quickly" issue in 4.0 v1

4.0v1
* fixed live compatibility (wrong variable name slipped in ...)
* fixed "attempt to compare with nil value" error: referred to the wrong saved variable

4.0v0
* restructured options:
* combined basic options, category test & loot manager into one panel, using tabs
* basic options grouped by their purpose, e.g. all the tooltip settings in one place
* loot manager grouped by their purpose
* shortened & restructured functions to show LibPeriodicTable contents, e.g. when adding a category or using category test (much in favor of my sanity)

* Basic Options changes:
* changed the way "Use in Combat" works. It will now only effect LootSlot() and CloseLoot() functions (which cause addon blocked issues), rather than disable the whole addon if it's unchecked
* clearified label texts for "Drop Treshold" and "Sell treshold". Also, these now use dropdown menus instead of a slider.
* renamed delete "instantly" to "enforce". When checked, Broker_Garbage will try its best to keep your free slots at or above your specified "Minimum free slots".
* renamed "Pickpocket" to "Stealing" in order to use progressive forms on all of these options (call it a knack of mine, if you like).
* added option "Auto-Confirm BoP". When checked, Broker_Garbage will take BoP items without showing the popup.

* Loot Manager options changes:
* removed "Enable" checkbox. Simply use Blizzard's addon manager to disable the Loot Manager
* removed "Selective Looting" checkbox. Looting will take place if any of the "Looting" checkboxes are checked. The only option that went missing without this checkbox is coloring/highlighting loot when *not* autolooting. If you don't like it, you probably don't want the Loot Manager as a whole.
* renamed "Enchanter" to "Have Enchanter" to clearify its meaning. Note please, that if you are an enchanter yourself, this checkbox is meaningless. Use it to 'tell' your Alts to not vendor disenchantable items.
* changed "Money Format" from a slider to a dropdown menu. It just makes more sense that way.

* revised former "Delete instant", see explanation above
* fixed junk items being treated incorrectly
* fixed price inflation for included items (auction prices were used, even though vendor prices should have been)

--> This release is the same as posted in the Cataclysm category. The above are all the changes that occured on that version ;) So, just to make things clear: This version of BG and the one in the Cataclysm category are *identical*

3.3v29 It took quite a while, but I hope it's worth it! Lots of file changes in here, I suggest you remove your Broker_Garbage and Broker_Garbage-LootManager folders and do a clean install (just extract, as usual)
* libraries updated
* hunters cannot use thrown weapons (fixed)
* rogues can use 1h axes (fixed)
* items with forced vendor prices will no longer be sold automatically (fixed)
* items won't inflate your statistics: fixed wrong values getting assigned to forced/listed items
* rebuilt list options
* Updated localizations to mirror these changes, e.g. lists renamed, explanation texts etc.
* Updated (re-wrote) sell icon function. No more missing icons, I hope!
* improved sell icon (texture, size ...)
* Updated default lists
* LootManager: auto-destroy settings are now local (so you can auto-destroy items on your level 15 rogue, but not on your 80 mage)
* LootManager: combat setting now also applies to looting money and closing the loot window (as it always should have)
* LootManager: simple implementation of "private loot": when opening containers in your bag, group loot rules should be ignored
* LootManager: completely re-structured selective looting procedure. The LM should now only delete items and warn of such actions if you're allowed to take that item (no more auto-deleting items for ones that are being rolled for)
* LootManager: updated quest items to always be looted
* LootManager: removed libraries, as those should already be loaded by Broker_Garbage (which is a dependency, anyway!)
* LootManager: now warns if a "Inventory is full" UI error occured
Minor changes:
* removed unnessessary event hook as well as comments
* fixed error created by slash-adding limited items that the server does not know
* fixed list manipulations that were broken because of tooltip/attribute changes (in between versions)

3.3v28
* hopefully the sell icon will now show when it is supposed to
* fixed various minor bugs
* fixed Loot Manager priorities, they got somewhat mixed up. The messages should be more fitting now.
* adjusted some localization strings
* re-inserted "use in combat" checkbox
* fixed default list creation - note that on login, BG cannot scan your tradeskills, but you can use the "default lists" button anytime to have him re-scan
* updated included LPT files
* LDB tooltip and text should now refer to the same item again
* fixed Loot Manager saved variables bug. some settings were requested before they were initialized

3.3v27
* deathknights cannot wear shields. fixed
* fixed items on sell list not selling
* added option to use include list as sell list
* inventory scanning rewritten - will now only scan updated bags, and item info is cached <-- this is worth about 10 minor features and 100kB memory per scan saved
* Broker_Garbage-LootManager: Changed the way 'Warn Clams' and 'Warn Containers' work - they will now show a line in the tooltip
* refined security checks when deleting items
* changed the license from GPLv2 to BSD, mainly because it does all I really need and is much less painful to read ;)
* fixed the bug where BG would go nuts after visiting a merchant once
* many thanks to Zidomo and Cidrei for elaborate testing!

3.3v26
* scanning will now work properly again (I deleted 2 lines that shouldn't have been deleted)
* finally found why Sell Gear would not work - fixed! Gear would only get sold if the global threshold was greater than the Sell Gear treshold, which was not intended.
* BG_LootManager: removed unnessessary saved variables
* Notice: BG_LootManager won't be able to work with the CTRL disable key as CTRL+Click is already connected to the dressup functionality

3.3v25
* made Auto Repair more intelligent: It will tell you if you don't have enough money to repair
* removed /garbage stats slash command - the options panel provides the same information and more (and prettier)
* fixed BG trying to get item values before auction addons are loaded
* fixed the error that was caused by a debug message if you didn't have any junk on you
* changed the format of localization files to support partial translations
* fixed /garbage format reset that would still reset to the old display format

3.3v24
* fixed Sell Gear not selling items (at all)
* fixed tabards not being sold by Sell Gear
* fixed (manual) selling via the tooltip when at a vendor: items without a value will be deleted instead of trying to sell them (which would result in 'The vendor is not interested in this item' error)
* Create Default Lists button fixed. Left-click it to create character specific list entries
* loot window will not be automatically closed if you can't loot something because of missing bagspace (which made it really hard to actually loot the item manually)
* changed plugin handling
* added supported auction addons to .toc file
* updated LibQTip library

3.3v23 Hopefully fixed the 'Addon blocked' issue.
Added an options panel to test category strings. Updated some of the libraries.
Renamed 'Drop Quality' to 'Quality Treshold', 'Positive lists' to 'Whitelist' and 'Negative lists' to 'Blacklist'.
Added button to load default list options.

3.3v22 (Patch 3.3.3) Things fixed:
When 'Never repair guildbank' is checked, Broker_Garbage will now not touch your guild funds any more.
The tooltip may now show more than one stack of any item.
Solved Autosell list priority conflicts: ItemIDs have higher priority than LPT strings.
LootManager turned more talkative. Now uses proper localization strings.
New feature: Sell unusable equipment. This will for example sell plate if you're a clothie, the item is soulbound and you yourself can't disenchant.

3.3v21 several bug fixes, including: Missing enchanting values für > epic items, included tekKonfigDropdown, statistical data gathering cleaned up, Autosell bug when having excluded items in the inventory, display of over-treshold Autosell items ...
New features: Changed the way you may edit the LDB display text, the question mark will help you with (re)configuration. (to lessen lua errors caused by wrong input)
Added possibility to colorize the LDb display text according to your bag situation ([bagspacecolor] ... [endcolor]
You can now use [junkvalue] in the LDB display text, which will show what your junk/Autosell stuff is worth.
SHIFT-Click on the tooltip/the LDB when at a merchant will now sell the item, rather than destroy it.

3.3v20 Split Broker_Garbage basic addon and Broker_Garbage-LootManager into two addons. Fixed some bugs and auction value calculation.
Update: Stupid debug...

3.3v19 Non-limited but included items will be handled properly once again. Same goes for Auto Sell List items.

3.3v18 Autodestroy fixed, fixed promoting limited items

3.3v17 Added the Loot Manager! It uses your Include (never loot) and Exclude List (always loot). to disable it, read the description or the readme.txt.
Added item limits! Want to keep no more than 5 Soulshards? Simply use your mousewheel on the corresponding icon on your include list. Items within that limit will not be shown on the tooltip.
Finally 'fixed' the Sell Icon - it will now properly show if there's something to sell - or not.
Also added some default list settings.
Fixed quite a hand full of bugs, too. Simplified code.

3.3v16 LDB display text option added to interface options panel. Statistics panel added. Fixed a bug where dragging items to the plus icons didn't work. Fixed a bug that caused too many items to appear in the tooltip. Finally found & fixed the bug that made you open positive lists before negative lists ;)

3.3v15 /garbage commands added, LDB text made more customizable, 'pre' errors fixed. Birthday-to-be edition.

3.3v14 Added compatibility to Broker2FuBar. Category list menu reduced to interesting parts. Auto Sell Icon will now do its job.

3.3v13 Addid items to lists possible - once again. No more "LeftButton" added to any list. Fixed icons not updating if GetItemInfo was missing

3.3v12 Auto sell settings will now, once again, be properly saved. This fixed the checksound-error as well. Or is it the other way around? :P

3.3v11 Added LPT support - you can add categories to your lists by right clicking on the 'plus' icons. For more info, have a look at the readme.txt . There might still be bugs in there, but I didn't find any ;) Therefore tagging as beta (to keep the files consistent to curse.com's version).
Update: Told you, there would be bugs! Fixed desaturating icons. Fixed missing items crashing the addon (GetItemInfo on seasonal items sucks).

3.3v10 Bugfixes, once again. And no, an itemLink is NOT the same as an itemID ~.~ New lists should work properly now. Reset money earned/lost will now properly reset the local value, rather than the global one.

3.3v9 list management clarified, more lists added (have a look at the options or the readme file): Force Vendor Price & Auto-Sell. New: ALT-Click on an item in the tooltip and it will be added to your Vendor Price List.

3.3v8 no new features, just a bunch of bugfixes ... stupid stupid Macs ... hate them!

3.3v7 LDB plugin clicks should work for all displays, added "money earned" to tooltip info, shows "no items" instead of empty tooltip, show (or hide) icon to manually sell grays at a vendor

3.3v6 LDB plugin will now properly react to clicks. List Options should display properly

3.3v5 stupid me -.- left debug mode on ... should probably write a pre-release checklist or something. Indeed, I should. Missed something on the include list management.

3.3v4 Tooltip! Corrected auto-hide time, should(tm) work.
Interface! Added options menu to handle include/exclude lists. No more guessing what might be on there!

3.3v3 another try at fixing sticky tooltips (by having the LDB display having the work of hiding the tooltip, not the plugin)

3.3v2 deDE localisation fix, money chat message changed

3.3v1 first upload
Optional Files (0)


Post A Reply Comment Options
Unread 02-09-11, 01:11 AM  
Bluspacecow
Giver of walls of text :)
 
Bluspacecow's Avatar
AddOn Author - Click to view AddOns

Forum posts: 770
File comments: 123
Uploads: 1
I was able to fix my 4.0.6 errors with this addon but editing the constants.lua file as detailed here :

http://wow.curse.com/downloads/wow-a...ge.aspx#921686

http://wow.curse.com/downloads/wow-a...ge.aspx#921695
__________________
tuba_man on Apple test labs : "I imagine a brushed-aluminum room with a floor made of keyboards, each one plugged into a different test box somewhere. Someone is tasked with tossing a box full of cats (all wearing turtlenecks) into this room. If none of the systems catch fire within 30 minutes, testing is complete. Someone else must remove the cats. All have iPods." (http://community.livejournal.com/tec...t/2018070.html)
Report comment to moderator  
Reply With Quote
Unread 02-08-11, 06:39 PM  
Zidomo
A Cliff Giant
 
Zidomo's Avatar

Forum posts: 76
File comments: 1046
Uploads: 0
The WoW 4.0.6 live patch has broken this. Consistent logon errors on two different characters (ckaotik-Broker_Garbage-1d59b36):

Code:
["message"] = "Broker_Garbage-4.0v8\\constants.lua:138: table index is nil\n<in C code>: in function `LoadAddOn'\nAddonLoader-2.0\\AddonLoader.lua:109: in function `LoadAddOn'\nAddonLoader-2.0\\Conditions.lua:128: in function <Interface\\AddOns\\AddonLoader\\Conditions.lua:118>\nAddonLoader-2.0\\Conditions.lua:143: in function <Interface\\AddOns\\AddonLoader\\Conditions.lua:133>\n\nLocals:|r\n(*temporary) = \"Broker_Garbage\"\n(*temporary) = <table> {\n OUTDATED = 4\n defaultLocalSettings = <table> {\n }\n defaultGlobalSettings = <table> {\n }\n VENDOR = 6\n EXCLUDE = 0\n toSellValue = <table> {\n }\n locale = <table> {\n }\n clams = <table> {\n }\n DISENCHANT = 8\n enchanting = \"Enchanting\"\n UNUSABLE = 3\n tradeSkills = <table> {\n }\n SELL = 7\n INCLUDE = 1\n AUCTION = 5\n disableKey = <table> {\n }\n playerClass = \"PRIEST\"\n modules = <table> {\n }\n LIMITED = 2\n tag = <table> {\n }\n}\n(*temporary) = <function> defined =[C]:-1\n\n  ---",
            ["type"] = "error",
            ["session"] = 1499,
            ["counter"] = 1,
        }, -- [998]
And a different logon error on one of the two characters above (a level 85 main):

Code:
["message"] = {
                "Broker_Garbage-4.0v8\\util.lua:368: attempt to index field 'usableGear' (a nil value)\nBroker_Garbage-4.0v8\\util.lua:460: in function `GetCached'\nBroker_Garbage-4.0v8\\core.lua:659: in function `GetCheapest'\nBroker_Garbage-4.0v8\\core.lua:407: in function `ScanInventoryContainer'\nBroker_Garbage-4.0v8\\core.lua:376: in function `ScanInventory'\nBroker_Garbage-4.0v8\\core.lua:40: in function <Interface\\AddOns\\Broker_Garbage\\core.lua:24>\n<in C code>: in function `LoadAddOn'\nAddonLoader-2.0\\AddonLoader.lua:109: in function `LoadAddOn'\nAddonLoader-2.0\\Conditions.lua:128: in function <Interface\\AddOns\\AddonLoader\\Conditions.lua:118>\nAddonLoader-2.0\\Conditions.lua:143: in function <Interface\\AddOns\\AddonLoader\\Conditions.lua:133>\n\nLocals:|r\nself = <table> {\n UpdateRepairButton = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:299\n ToggleOption = <function> defined @Interface\\AddOns\\Broker_Garbage\\externals.lua:42\n VENDOR = 6\n AutoRepair = <function> defined @Interfac", -- [1]
                "e\\AddOns\\Broker_Garbage\\core.lua:851\n modules = <table> {\n }\n FormatMoney = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:553\n auctionAddon = \"Auc-Advanced\"\n JoinSimpleTables = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:77\n IsItemInList = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:294\n GetVariable = <function> defined @Interface\\AddOns\\Broker_Garbage\\externals.lua:17\n GetProfessionSkill = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:96\n totalFreeSlots = 0\n defaultLocalSettings = <table> {\n }\n PT = <table> {\n }\n EXCLUDE = 0\n DISENCHANT = 8\n enchanting = \"Enchanting\"\n ScanInventory = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:371\n UpdateLDB = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:130\n Count = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:53\n ScanInventoryContainer = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:384\n OUTDATED = 4\n Cr", -- [2]
                "eateDefaultLists = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:130\n Colorize = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:489\n GetCached = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:457\n GetBagSlots = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:468\n clams = <table> {\n }\n OnClick = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:233\n GetItemValue = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:414\n Delete = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:564\n tradeSkills = <table> {\n }\n IsItemSoulbound = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:188\n LDB = <table> {\n }\n playerClass = \"PRIEST\"\n isAtVendor = false\n locale = <table> {\n }\n ResetStatistics = <function> defined @Interface\\AddOns\\Broker_Garbage\\externals.lua:61\n GetOption = <function> defined @Interface\\AddOns\\Broker_Garbage\\externals.lua:22\n CheckSettings = <function> defined @I", -- [3]
                "nterface\\AddOns\\Broker_Garbage\\util.lua:18\n itemsCache = <table> {\n }\n totalBagSpace = 0\n disableKey = <table> {\n }\n GetCheapest = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:643\n Print = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:6\n toSellValue = <table> {\n }\n GetItemID = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:180\n clamInInventory = false\n ResetOption = <function> defined @Interface\\AddOns\\Broker_Garbage\\externals.lua:51\n UpdateCache = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:319\n SetOption = <function> defined @Interface\\AddOns\\Broker_Garbage\\externals.lua:33\n SELL = 7\n FormatString = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:509\n CanDisenchant = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:215\n UNUSABLE = 3\n GetSingleItemValue = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:435\n Debug = <function> defined @Interface\\AddOns\\Broker_Garbage\\", -- [4]
                "util.lua:11\n defaultGlobalSettings = <table> {\n }\n containerInInventory = false\n INCLUDE = 1\n Find = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:45\n AutoSell = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:771\n FindSlotToDelete = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:516\n AUCTION = 5\n RegisterPlugin = <function> defined @Interface\\AddOns\\Broker_Garbage\\externals.lua:4\n Tooltip = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:140\n LIMITED = 2\n JoinTables = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:60\n GetTradeSkill = <function> defined @Interface\\AddOns\\Broker_Garbage\\util.lua:116\n tag = <table> {\n }\n}\nitemID = 9452\nBG = <table> {\n UpdateRepairButton = <function> defined @Interface\\AddOns\\Broker_Garbage\\core.lua:299\n ToggleOption = <function> defined @Interface\\AddOns\\Broker_Garbage\\externals.lua:42\n VENDOR = 6\n A\n  ---", -- [5]
            },
            ["type"] = "error",
            ["session"] = 1499,
            ["counter"] = 1,
        }, -- [999]
Report comment to moderator  
Reply With Quote
Unread 01-27-11, 02:44 PM  
ckaotik
A Fallenroot Satyr
 
ckaotik's Avatar
AddOn Author - Click to view AddOns

Forum posts: 29
File comments: 168
Uploads: 5
Re: Sorting - stack size

Originally posted by jockey
Maybe it should also consider maximum stack size?
Broker_Garbage is already considering quite a few things when deciding on what should be first in the list. It does not consider stack size when it's comparing two equally valuable items [Note: BG does take the stack value into account, but this is about two stacks being of equal value, but different counts], indeed, but I can't really think of a reason why this would be crucial. There are many stackable (and also non-stackable) junk items, with sometimes one of them being "less important" to the user.
However, I could only guess how a player's preferences in this would be, as it most likely differs from item to item. Imagine the choice between a crafting item that doesn't stack but is required for your next project and a stack of meat (or whatever); the other way around poses the same question: A stack of flasks or rather a blue quest item you won't be using any more? Or maybe even the "stack filling quota", i.e. current stack count divided by maximum stack count. Which would you think is more important? That's exactly what lists are made for

TL;DR: BG always considers the value of whatever is in that item slot, be it one item worth 2c (stack value: 2c) or 2 items being worth 2c each (stack value: 4c). There is no specific order when items are of equal value. There's too many ways users would want to use this.
__________________
It all starts to make a creepy kind of sense. Avatar
Last edited by ckaotik : 01-27-11 at 02:49 PM.
Report comment to moderator  
Reply With Quote
Unread 01-24-11, 01:20 AM  
jockey
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Sorting - stack size

This addon doesn't seem to account for stack size.



I'd expect Scraggy Leather Gloves to be tossed first.

Maybe it should also consider maximum stack size?
Report comment to moderator  
Reply With Quote
Unread 01-07-11, 06:10 PM  
ckaotik
A Fallenroot Satyr
 
ckaotik's Avatar
AddOn Author - Click to view AddOns

Forum posts: 29
File comments: 168
Uploads: 5
@jch4983: I'm very much appreciating the testing you're putting into this! BG tries to always loot quest items, so there could be an issue there. Anyhow, I'M currently extremely busy studying and exams are coming up, too, so I'll have to see if I can get some time (and nerve) to have a closer look.

I did some rewriting a little while ago, if you are interested, feel free to take a look at it: Pre-Alpha(!) Broker_Garbage-LootManager rewrite can be found here.
It may (and probably will) still be quite buggy, though. Will get back to it as soon as I get the time. In the meantime, if you want to try it but don't trust it, use
Code:
/run BG_GlobalDB.noDeletion = true
to disable the final step that would delete an item. Re-enable default behavior by setting it to false or nil again.
__________________
It all starts to make a creepy kind of sense. Avatar
Last edited by ckaotik : 01-07-11 at 06:16 PM.
Report comment to moderator  
Reply With Quote
Unread 01-04-11, 06:04 PM  
jch4983
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
After closer inspection, I think I may have found out another part of the problem. Whether this is a wild goose chase or not remains to be seen.

If a creature drops a quest item and something worth more than my stuff, that message will fire. If a creature doesn't drop a quest item, it will delete stuff normally.

Could this have anything to do with the error message saying you can't loot more than one of a quest item on some critters? I'm gonna try to narrow it down some more for ya.
Report comment to moderator  
Reply With Quote
Unread 01-04-11, 06:40 AM  
ckaotik
A Fallenroot Satyr
 
ckaotik's Avatar
AddOn Author - Click to view AddOns

Forum posts: 29
File comments: 168
Uploads: 5
Re: autodelete

@jch4983
"Sorry, was hoping that error message was only in one place in the code"
It is It's in the one and only "delete this item, now!" function that gets called from ... well, almost everywhere

I'll see into it, though testing on fresh level 1-10 chars is a little tedious. That description should give me something so I can try to recreate your problem (and then, hopefully, solve it)
__________________
It all starts to make a creepy kind of sense. Avatar
Report comment to moderator  
Reply With Quote
Unread 01-02-11, 11:20 PM  
jch4983
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
autodelete

Sorry, was hoping that error message was only in one place in the code and it might be something simple, especially since I've never seen that one before. Here goes. Once I loot something, some things are auto-looted as expected (stackables and leather into my skinning bag).

If the item wouldn't be looted normally I get the expected "new_item_x is cheaper than all your other stuff so we're not gonna loot it" message, so that's working fine. However, if something on the corpse is worth more than my cheapest trash, that message appears. I can still delete things from the plugin on titanpanel, so it's not annoying, just a bit slower from taking time to check and decide for myself.

Also, just noticed the alpha update, gonna give that a shot and let you know.
Last edited by jch4983 : 01-02-11 at 11:21 PM.
Report comment to moderator  
Reply With Quote
Unread 01-02-11, 07:27 AM  
ckaotik
A Fallenroot Satyr
 
ckaotik's Avatar
AddOn Author - Click to view AddOns

Forum posts: 29
File comments: 168
Uploads: 5
Deleting (not) working?

@Kerecha: Can you give any more information? There are several different contexes in which you could delete items.

@jch4983: When do you get this error message? It makes a difference if you try deleting via auto delete, via shift-click on the LDB display, by shift-click on the tooltip's entries etc pp. So some more info would be useful

I uploaded a new alpha version on both GitHub and Curse. This fixes one of the auto delete issues as well as druids selling their precious maces.
__________________
It all starts to make a creepy kind of sense. Avatar
Report comment to moderator  
Reply With Quote
Unread 01-01-11, 09:50 PM  
jch4983
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
Error?

Not sure exactly what's going on, but I believe it may be what Kerecha's experiencing.

BG says:

Code:
Broker_Garbage: Error! Item to be deleted is not the expected item.
I have no idea, but it refuses to delete anything, this is with autodestroy and enforce enabled.
Report comment to moderator  
Reply With Quote
Unread 12-30-10, 08:56 AM  
Kerecha
A Deviate Faerie Dragon
 
Kerecha's Avatar

Forum posts: 10
File comments: 196
Uploads: 0
Hmm...
It might just me messing something up again, but i can't seem to get the autodelete function working again, i even removed all the SV's and tried it fresh, but still can't get it to kick in.
Report comment to moderator  
Reply With Quote
Unread 12-19-10, 01:44 PM  
ckaotik
A Fallenroot Satyr
 
ckaotik's Avatar
AddOn Author - Click to view AddOns

Forum posts: 29
File comments: 168
Uploads: 5
Thanks for all the bug reports ... gee, I'm lucky But still, better to point them out so I can fix them than living with them without me even knowing. I've uploaded yet more bug fix alpha version on GitHub, as well as CurseForge (don't know how well curse handles those files, this is a first for me). I hope to get most of the bug ironed out really soon.

Anyhow, even though you should not get the error messages any more, something might still be behaving strangely - please, tell me! It's hard for me to test things, especially if I have to level a character first (test accounts, yay. No /w, /s, /y, no trades and only up to level 20) or the bug happens with Cataclysm "things" (such as Archaeology) or higher level characters.

Edit: Curse is weird. Apparently it compresses my files, but not the way I want. So grab the latest copy here, extract the files and move all the (sub-)folders (Broker_Garbage, Broker_Garbage-Config, Broker_Garbage-LootManager) into your AddOns folder.
__________________
It all starts to make a creepy kind of sense. Avatar
Last edited by ckaotik : 12-20-10 at 08:27 AM.
Report comment to moderator  
Reply With Quote
Unread 12-18-10, 04:41 PM  
jch4983
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
Odd Errors...

Hopefully you can tell me what's goin on. :P With both the 4.07 release and the alpha3 version, I get this (before and after clearing out my SavedVars just in case):
Code:
Date: 2010-12-18 17:17:33
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Broker_Garbage-LootManager\core.lua line 336:
   attempt to compare nil with number
Debug:
   [C]: ?
   Broker_Garbage-LootManager\core.lua:336:
      Broker_Garbage-LootManager\core.lua:275
   [C]: securecall()
   Broker_Garbage-LootManager\core.lua:54:
      Broker_Garbage-LootManager\core.lua:9
It results in the loot manager not looting anything for the rest of the session, and it occurs on the first loot, so... Yeah. :P I dunno if anybody else is encountering this problem, but I searched the comments and couldn't find a reference to that line (336) bugging out.

Also, when I click on the "Minimum free slots: XX" slider I get this on both versions as well:
Code:
Date: 2010-12-18 17:36:38
ID: 1
Error occured in: Global
Count: 1
Message: ...erface\AddOns\Broker_Garbage-LootManager\options.lua line 240:
   attempt to index global 'BrokerGarbage' (a nil value)
Debug:
   [C]: ?
   ...erface\AddOns\Broker_Garbage-LootManager\options.lua:240:
      ...erface\AddOns\Broker_Garbage-LootManager\options.lua:237
I suppose something's not being init'd properly, but I don't write addons, I just use 'em and try to report bugs when I can. To be honest, I've never tried to change that setting before, so I don't know if it ever worked. :P

EDIT: Oh, and one more right after I posted this comment. :P Looks like it tried to delete something... Yay?!?
Code:
Date: 2010-12-18 17:51:23
ID: 2
Error occured in: Global
Count: 1
Message: ..\AddOns\Broker_Garbage\core.lua line 581:
   Usage: GetContainerItemID(index, slot)
Debug:
   [C]: ?
   [C]: GetContainerItemID()
   Broker_Garbage\core.lua:581: Delete()
   Broker_Garbage-LootManager\core.lua:394:
      Broker_Garbage-LootManager\core.lua:275
   [C]: securecall()
   Broker_Garbage-LootManager\core.lua:54:
      Broker_Garbage-LootManager\core.lua:9
Last edited by jch4983 : 12-18-10 at 04:53 PM.
Report comment to moderator  
Reply With Quote
Unread 12-18-10, 02:27 PM  
ckaotik
A Fallenroot Satyr
 
ckaotik's Avatar
AddOn Author - Click to view AddOns

Forum posts: 29
File comments: 168
Uploads: 5
Soo, once again, thanks for the bug report. I've uploaded the most recent version to GitHub (http://github.com/ckaotik/Broker_Garbage). Feel free to check that one out (regularly!) as I try to fix any bug report asap at least up there
__________________
It all starts to make a creepy kind of sense. Avatar
Report comment to moderator  
Reply With Quote
Unread 12-17-10, 03:01 PM  
Wingforce
A Kobold Labourer

Forum posts: 0
File comments: 4
Uploads: 0
Equipment Manager related error

I downloaded and am using 4.0v7a3.

Thank you very much for adding the Equipment Manager to the latest version. I have added a couple Equipment Manager sets to my "Keep" list and as soon as I added them (and now when logging in) I get...

38x Broker_Garbage-4.0v7\util.lua:300: attempt to compare string with number
Broker_Garbage-4.0v7\util.lua:381: in function `UpdateCache'
Broker_Garbage-4.0v7\util.lua:463: in function `GetCached'
Broker_Garbage-4.0v7\core.lua:382: in function `ScanInventoryContainer'
Broker_Garbage-4.0v7\core.lua:46: in function <Broker_Garbage\core.lua:24>

Locals:
self = <table> {
specialSlots = 0
UpdateRepairButton = <function> @ Broker_Garbage\core.lua:288:
ToggleOption = <function> @ Broker_Garbage\externals.lua:42:
VENDOR = 6
AutoRepair = <function> @ Broker_Garbage\core.lua:840:
freeSpecialSlots = 0
modules = <table> {}
FormatMoney = <function> @ Broker_Garbage\util.lua:556:
JoinSimpleTables = <function> @ Broker_Garbage\util.lua:77:
IsItemInList = <function> @ Broker_Garbage\util.lua:294:
GetVariable = <function> @ Broker_Garbage\externals.lua:17:
GetProfessionSkill = <function> @ Broker_Garbage\util.lua:96:
totalFreeSlots = 0
defaultLocalSettings = <table> {}
PT = <table> {}
EXCLUDE = 0
DISENCHANT = 8
enchanting = "Enchanting"
ScanInventory = <function> @ Broker_Garbage\core.lua:360:
UpdateLDB = <function> @ Broker_Garbage\core.lua:130:
Count = <function> @ Broker_Garbage\util.lua:53:
ScanInventoryContainer = <function> @ Broker_Garbage\core.lua:373:
OUTDATED = 4
CreateDefaultLists = <function> @ Broker_Garbage\util.lua:130:
Colorize = <function> @ Broker_Garbage\util.lua:492:
GetCached = <function> @ Broker_Garbage\util.lua:460:
GetBagSlots = <function> @ Broker_Garbage\util.lua:471:
clams = <table> {}
usableByAll = <table> {}
OnClick = <function> @ Broker_Garbage\core.lua:220:
GetItemValue = <function> @ Broker_Garbage\core.lua:403:
Delete = <function> @ Broker_Garbage\core.lua:553:
tradeSkills = <table> {}
IsItemSoulbound = <function> @ Broker_Garbage\util.lua:188:
ResetOption = <function> @ Broker_Garbage\externals.lua:51:
LDB = <table> {}
Tooltip = <function> @ Broker_Garbage\core.lua:140:
playerClass = "PALADIN"
isAtVendor = false
AutoSell = <function> @ Broker_Garbage\core.lua:763:
itemsCache = <table> {}
GetOption = <function> @ Broker_Garbage\externals.lua:22:
CheckSettings = <function> @ Broker_Garbage\util.lua:18:
totalBagSpace = 0
ResetStatistics = <function> @ Broker_Garbage\externals.lua:61:
disableKey = <table> {}
cheapestItems = <table> {}
Print = <function> @ Broker_Garbage\util.lua:6:
toSellValue = <table> {}
locale = <table> {}
clamInInventory = false
UpdateCache = <function> @ Broker_Garbage\util.lua:322:
SELL = 7
SetOption = <function> @ Broker_Garbage\externals.lua:33:
GetCheapest = <function> @ Broker_Garbage\core.lua:635:
GetItemID = <function> @ Broker_Garbage\util.lua:180:
CanDisenchant = <function> @ Broker_Garbage\util.lua:215:
UNUSABLE = 3
GetSingleItemValue = <function> @ Broker_Garbage\core.lua:424:
Debug = <function> @ Broker_Garbage\util.lua:11:
FindSlotToDelete = <function> @ Broker_Garbage\core.lua:505:
containerInInventory = false
INCLUDE = 1
Find = <function> @ Broker_Garbage\util.lua:45:
usableGear = <table> {}
FormatString = <function> @ Broker_Garbage\util.lua:512:
AUCTION = 5
RegisterPlugin = <function> @ Broker_Garbage\externals.lua:4:
defaultGlobalSettings = <table> {}
LIMITED = 2
JoinTables = <function> @ Broker_Garbage\util.lua:60:
GetTradeSkill = <function> @ Broker_Garbage\util.lua:116:
tag = <table> {}
}
itemID = 33820
class = nil
temp = nil
limit = nil
hasData = "Weather-Beaten Fishing Hat"
itemLink = "|Hitem:33
---
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: