(234Kb)

Updated: 04-27-11 11:51 PM

Add Favorite

Install Help

Pictures

File Info

Updated:	04-27-11 11:51 PM
Created:	04-11-10 11:53 PM
Downloads:	19,034
Favorites:	50
MD5:

Buff Broker

Version: 4.1.13

by: toddimer [More]

"Buff Broker: It lets you mash butan for buffs. No matter what class you are. or what group you're in. You just mash a button and everyone gets the right buff" - Psychonaut

Main Development site
Feature Request List
Discussion Thread
Main user site
Demo on youtube
FAQ

Buff Broker manages your group & personal auras. Be it Blessings, Totems, Shouts, Horns, Marks, or Power Words; your Paladin, Priest, Shaman, Warrior, or Druid; Seals, armors, stances, forms, or fires; installing this addon will help match your best buffs for your group, and help keep those buffs active on you and your party.

Buff Broker is uniquely adaptable to your current party. It is friendly with other players; it will not poach their buffs (although it might poach their assignments); it will not get confused if your buffs are poached; it understands talented vs untalented buffs; it will properly suggest you upgrade from single to class/raid wide buffs. Finally, yes, it does work (with Live, the PTR, and Cataclysm Beta)

Thanks in advance for any feedback and support! If you ever have trouble, i suggest reverting to the last release build (aka won't contain a "B" in the version).

Changelog included in the downloadable package, as "Changelog-BuffBroker-<version>.txt"

http://wow.curseforge.com/addons/buffbroker/files/182-4-1-13/

download total at last release: 12,246
download total at last patch: 12,246

Comment Options

Page 2 of 11

Last »

10-13-10, 01:05 AM
toddimer A Deviate Faerie Dragon Forum posts: 18 File comments: 88 Uploads: 1	I updated all the totem Spellids, but some WEIRD stuff is happening with CanInspect(), and the totem "is better active" logic. I'll investigate tomorrow, once the realms calm down. In the mean time, enjoy the latest french/korean translations, and the probably-works of the other classes.

10-12-10, 12:30 AM
toddimer A Deviate Faerie Dragon Forum posts: 18 File comments: 88 Uploads: 1	Shaman totems should be "fixed"; sort function didn't die in the latest round of tests, and the totem action bar responsiveness is back to snappy. I did reproduce cycling of air totems (windfury/wrath), but only for 4 seconds. Will try to sort that out this week. At least it's not throwing exceptions! French localizations should be bundled in this build. Barring some 4.0.1 spellid mishaps, this should be ready for prime time.

10-10-10, 08:32 PM

toddimer

A Deviate Faerie Dragon

Forum posts: 18

File comments: 88

Uploads: 1

Originally posted by Fritty
okay just updated and got

Code:

1428x BuffBroker-2.0.6B\BuffBroker.lua:1270: invalid order function for sorting BuffBroker-2.0.6B\BuffBroker.lua:1270: in function `BuildSuggestList' BuffBroker-2.0.6B\BuffBroker.lua:1755: in function `RegenerateSuggestionDependencies' BuffBroker-2.0.6B\BuffBroker.lua:3054: in function `OnUpdate' BuffBroker-2.0.6B\BuffBroker.lua:3457: in function <BuffBroker\BuffBroker.lua:3457> 2x BuffBroker-2.0.6B\BuffBroker.lua:1270: invalid order function for sorting BuffBroker-2.0.6B\BuffBroker.lua:1270: in function `BuildSuggestList' BuffBroker-2.0.6B\BuffBroker.lua:1755: in function `RegenerateSuggestionDependencies' BuffBroker-2.0.6B\BuffBroker.lua:1735: in function `RefreshPlayers' BuffBroker-2.0.6B\BuffBroker.lua:3183: in function `OnEvent' BuffBroker-2.0.6B\BuffBroker.lua:3456: in function <BuffBroker\BuffBroker.lua:3456> 17x BuffBroker-2.0.6B\BuffBroker.lua:1270: invalid order function for sorting BuffBroker-2.0.6B\BuffBroker.lua:1270: in function `BuildSuggestList' BuffBroker-2.0.6B\BuffBroker.lua:1755: in function `RegenerateSuggestionDependencies' BuffBroker-2.0.6B\BuffBroker.lua:1930: in function `FullProfile' BuffBroker-2.0.6B\BuffBroker.lua:3235: in function `OnEvent' BuffBroker-2.0.6B\BuffBroker.lua:3456: in function <BuffBroker\BuffBroker.lua:3456>

grouped with warrior, hunter, pally, warlock

Turns out the group composition isn't important. "invalid order function for sorting" is an exceptionally esoteric LUA error. I know how i painted myself into this corner, but it could take a few iterations to wrap this up. I'll try to test/reproduce on my 76 horde shaman before pushing the next build.

10-10-10, 10:51 AM

Fritty

A Cyclonian

Forum posts: 47

File comments: 33

Uploads: 0

okay just updated and got

Code:

1428x BuffBroker-2.0.6B\BuffBroker.lua:1270: invalid order function for sorting
BuffBroker-2.0.6B\BuffBroker.lua:1270: in function `BuildSuggestList'
BuffBroker-2.0.6B\BuffBroker.lua:1755: in function `RegenerateSuggestionDependencies'
BuffBroker-2.0.6B\BuffBroker.lua:3054: in function `OnUpdate'
BuffBroker-2.0.6B\BuffBroker.lua:3457: in function <BuffBroker\BuffBroker.lua:3457>

2x BuffBroker-2.0.6B\BuffBroker.lua:1270: invalid order function for sorting
BuffBroker-2.0.6B\BuffBroker.lua:1270: in function `BuildSuggestList'
BuffBroker-2.0.6B\BuffBroker.lua:1755: in function `RegenerateSuggestionDependencies'
BuffBroker-2.0.6B\BuffBroker.lua:1735: in function `RefreshPlayers'
BuffBroker-2.0.6B\BuffBroker.lua:3183: in function `OnEvent'
BuffBroker-2.0.6B\BuffBroker.lua:3456: in function <BuffBroker\BuffBroker.lua:3456>

17x BuffBroker-2.0.6B\BuffBroker.lua:1270: invalid order function for sorting
BuffBroker-2.0.6B\BuffBroker.lua:1270: in function `BuildSuggestList'
BuffBroker-2.0.6B\BuffBroker.lua:1755: in function `RegenerateSuggestionDependencies'
BuffBroker-2.0.6B\BuffBroker.lua:1930: in function `FullProfile'
BuffBroker-2.0.6B\BuffBroker.lua:3235: in function `OnEvent'
BuffBroker-2.0.6B\BuffBroker.lua:3456: in function <BuffBroker\BuffBroker.lua:3456>

grouped with warrior, hunter, pally, warlock

10-09-10, 11:25 PM

toddimer

A Deviate Faerie Dragon

Forum posts: 18

File comments: 88

Uploads: 1

Originally posted by Fritty
I just got a group and got the error again, it was me, one warlock, warrior tank, mage and rogue.

Those line numbers, error dumps, and party compositions were very helpful. I didn't think that condition could occur; Checks have been added to prevent that particular catch, even though I'm still curious what exactly happened (in the code, that is).

Should be resolved in 2.0.6B

10-09-10, 12:28 PM

Fritty

A Cyclonian

Forum posts: 47

File comments: 33

Uploads: 0

I'm pretty much always grouped (hubby and I level together) - also doing random dungeons. Level/Class/Spec: 65/Shaman/Resto grouped with a warlock most of the time (felhunter out usually)...and I think I actually have buffbroker disabled on that character now that I think about it. It kept telling me to switch between the two air totems in most dungeon groups which was a little irritating and since I didn't really need it for my shaman...so yeah, its odd to me to be getting errors like that with it not enabled.

[edit to add] just now logged in and just grouped with the warlock, no errors
AND...I just did a random dungeon and got no errors - so maybe false alarm! I'll post again if I get anything

OK! the group where I got no errors consisted of me, two warlocks, pally tank and a dk.
I just got a group and got the error again, it was me, one warlock, warrior tank, mage and rogue.

Code:

2x BuffBroker-2.0.4B\BuffBroker.lua:3833: attempt to index local 'right' (a nil value)
<in C code>: in function `sort'
BuffBroker-2.0.4B\BuffBroker.lua:1247: in function `BuildSuggestList'
BuffBroker-2.0.4B\BuffBroker.lua:1732: in function `RegenerateSuggestionDependencies'
BuffBroker-2.0.4B\BuffBroker.lua:3031: in function `OnUpdate'
BuffBroker-2.0.4B\BuffBroker.lua:3434: in function <BuffBroker\BuffBroker.lua:3434>

and

Code:

37x BuffBroker-2.0.4B\BuffBroker.lua:3833: attempt to index local 'right' (a nil value)
<in C code>: in function `sort'
BuffBroker-2.0.4B\BuffBroker.lua:1247: in function `BuildSuggestList'
BuffBroker-2.0.4B\BuffBroker.lua:1732: in function `RegenerateSuggestionDependencies'
BuffBroker-2.0.4B\BuffBroker.lua:3031: in function `OnUpdate'
BuffBroker-2.0.4B\BuffBroker.lua:3434: in function <BuffBroker\BuffBroker.lua:3434>]

and

Code:

1x BuffBroker-2.0.4B\BuffBroker.lua:3833: attempt to index local 'right' (a nil value)
<in C code>: in function `sort'
BuffBroker-2.0.4B\BuffBroker.lua:1247: in function `BuildSuggestList'
BuffBroker-2.0.4B\BuffBroker.lua:1732: in function `RegenerateSuggestionDependencies'
BuffBroker-2.0.4B\BuffBroker.lua:1907: in function `FullProfile'
BuffBroker-2.0.4B\BuffBroker.lua:3212: in function `OnEvent'
BuffBroker-2.0.4B\BuffBroker.lua:3433: in function <BuffBroker\BuffBroker.lua:3433>

and note, I *thought* I had visible unchecked, but it seems to be checked now...I'm not getting any buff suggestions that I have seen

Last edited by Fritty : 10-09-10 at 04:57 PM.

10-09-10, 10:21 AM

toddimer

A Deviate Faerie Dragon

Forum posts: 18

File comments: 88

Uploads: 1

Originally posted by Fritty
just updated to 2.0.4b and am getting a LOT of:

Code:

57x BuffBroker-2.0.4B\BuffBroker.lua:3833: attempt to index local 'right' (a nil value) <in C code>: in function `sort' BuffBroker-2.0.4B\BuffBroker.lua:1247: in function `BuildSuggestList' BuffBroker-2.0.4B\BuffBroker.lua:1732: in function `RegenerateSuggestionDependencies' BuffBroker-2.0.4B\BuffBroker.lua:3031: in function `OnUpdate' BuffBroker-2.0.4B\BuffBroker.lua:3434: in function <BuffBroker\BuffBroker.lua:3434>

Thanks Fritty; what class/level/spec are you playing? Do you get this solo, or in a party? Do you remember anything about your party compositions that triggers this?

10-09-10, 09:36 AM

Fritty

A Cyclonian

Forum posts: 47

File comments: 33

Uploads: 0

just updated to 2.0.4b and am getting a LOT of:

Code:

57x BuffBroker-2.0.4B\BuffBroker.lua:3833: attempt to index local 'right' (a nil value)
<in C code>: in function `sort'
BuffBroker-2.0.4B\BuffBroker.lua:1247: in function `BuildSuggestList'
BuffBroker-2.0.4B\BuffBroker.lua:1732: in function `RegenerateSuggestionDependencies'
BuffBroker-2.0.4B\BuffBroker.lua:3031: in function `OnUpdate'
BuffBroker-2.0.4B\BuffBroker.lua:3434: in function <BuffBroker\BuffBroker.lua:3434>

Last edited by Fritty : 10-09-10 at 09:36 AM.

09-27-10, 01:03 PM

toddimer

A Deviate Faerie Dragon

Forum posts: 18

File comments: 88

Uploads: 1

Originally posted by Zidomo
One thing: any of this being addressed in the current Cata/live updates? I haven't seen anything regarding the issues in the changelogs from v1.7.1 on. [/b]

Not yet, but absolutely. It's something that will change as I get more confident with Lua.

Specifically, a lot of encapsulated tasks are getting more clearly defined/partitioned in the next few versions. I've been busy making the components for handling lookup tables & constants, and for unit profiling. Mostly because those are the things that "broke" in cataclysm. There's eventually going to be a separate component just for the suggestion list (creation, ordering, and updating), which is where a lot of performance potential is.

09-27-10, 10:35 AM

Zidomo

A Cliff Giant

Forum posts: 76

File comments: 1046

Uploads: 0

Originally posted by toddimer
Put your mind at ease; it's absolutely BuffBroker! The way it works gets exponentially worse in larger groups. It would be disturbing to see how things turn out in a 40-man city raid.

That's my suspicion right now. There's some extreme garbage collection / list cycling, every 5 seconds, every time an (applicable) aura changes outside combat, and every time you exit combat. It's a terrible design (now that I know how expensive list management is), which I have a plan to address: the "watch list" will be tailored to just buffs which impact your class, and the expiration of buffs will be better tracked, to eliminate the 5-second check. Most significantly, I plan to detach list generation from list ordering.

Thanks, a better & funnier response than I normally get when reporting resource issues with various mods.

One thing: any of this being addressed in the current Cata/live updates? I haven't seen anything regarding the issues in the changelogs from v1.7.1 on.

09-26-10, 03:29 PM
toddimer A Deviate Faerie Dragon Forum posts: 18 File comments: 88 Uploads: 1	PTR & Beta fixes: -"Role" assignment should be functioning -Updated desired buffs (by role) to match the new types of raid buff -Warrior, Priests, and Mages should be functioning correct Outstanding: -Buffs that provide multiple benefits are only reporting 1 benefit: Might (AP/MP5), Brilliance (Mana/Spell Power), Felhunter(Mana/MP5), and others, may be kind of funky -Deathknights, Shamans, Rogues, Hunters, and Warlocks aren't working 100% (spellids still being updated) -Buff Potency hasn't received a polish pass (i.e. 1/2 talent investements) -Buff Potency scaling with Level isn't working yet -Buff Application hasn't received a polish pass (i.e. perma-buff > 2 min buff)

09-25-10, 06:23 PM
toddimer A Deviate Faerie Dragon Forum posts: 18 File comments: 88 Uploads: 1	2.0.0B is out, now with Cataclysm support! This should be functional for paladins and druids on the PTR and the BETA realms. Support for Priests, Warriors, and others will be coming soon(tm). Just a matter of finding all the new spellids and talents :P There are a few "oddities" due to backwards compatability for live/wotlk: class roles probably aren't being assigned correctly; talented auras (i.e. moonkin aura's 5% crit) aren't detected yet; pets are still considered valid buff targets, which is false/changed; and aura strength isn't matched to player level. All these are on the todo list

09-20-10, 10:21 AM

toddimer

A Deviate Faerie Dragon

Forum posts: 18

File comments: 88

Uploads: 1

Re: Strange issue

Originally posted by Fritty
suggestion of might for the succubus...and then that suggestion stays no matter how many times I cast it, until after combat or until after the warlock mounts and succubus disappears, then I get the suggestion to wisdom the warlock
when I use dumpSuggestions - it seems to think the pets buff is expiring - like when I cast a new buff its not getting updated I guess? [/b]

There's a disconnect between when a pet appears, and when the API reports accurate data. A pet's name is "Unknown" for a few cycles, before the correct name comes back. I put in handlers to re-fresh the name. If a hunter ever names their pet "Unknown", I will kick a kitten.

Anyway, my suspicion is that other pet information is ALSO stale during that period: like buff expiration times. Either cataclysm will fix this, or I will. Reloading your UI is the (fucking terrible) way to fix this, in most cases. OR, get out of range of the pet and come back. That might work too.

Sorry this known-bug hasn't been quashed yet :P

09-19-10, 08:13 AM
Fritty A Cyclonian Forum posts: 47 File comments: 33 Uploads: 0	Strange issue I'm having a strange issue on my lowbie paladin wherein buffbroker wants me to cast multiple buffs per person...usually starts with kings and then follows up with wisdom or might...its only really bad in groups when I end up overwriting another paladin's buffs (even though I do have 'friendly' checked). (oh that was with 1.7.6) okay further clarification...with 1.7.7 grouped with a warlock first it suggests might for me, I cast that then it suggests wisdom and I cast that and thats it for me suggestion of might for the succubus...and then that suggestion stays no matter how many times I cast it, until after combat or until after the warlock mounts and succubus disappears, then I get the suggestion to wisdom the warlock when I use dumpSuggestions - it seems to think the pets buff is expiring - like when I cast a new buff its not getting updated I guess? Last edited by Fritty : 09-19-10 at 01:03 PM.

09-08-10, 09:15 AM
toddimer A Deviate Faerie Dragon Forum posts: 18 File comments: 88 Uploads: 1	For those playing the at-home game, I have not died, nor have I fallen ill...off a cliff. Or anything like that. I'm in the process of updating to the Cataclysm beta, which is a two-prong issue; first, some of the API function calls have changed, which is the easy part. Second, those new awesome calls make a lot of old leg-work highly unnecessary, nigh redundant. I'm trying to re-structure how things are done, before back-porting to live. The result should be a single distribution that works on beta, then works even better on live. Still in the planning/design phase; Pray I get it done before beta goes live =D

Page 2 of 11

Last »

You have a few options to support the continued development of this addon:

Try the latest betas, and actively report any discrepancies, nuisances, or bugs you encounter
Keep an eye on the field! Let me know what related addons are doing that you like (or dislike)
Try your hand at lua! I'm more than willing to coach willing "programmers" through the feature request list
Send a 60-day gamecard (code) via private message on this site. As long as my account is active, I will keep this addon up to date.
Positive feedback and real-world stories keep me engaged. Your experiences with this addon motivate me to make it even better!

Report this File

Category Jump: