Confirm Loot Roll 

Awesome, thanks for the fast upload of this. Much cleaner than some of the other mods that perform this function. As well, you don't assume you know what's best for the user like some of the other authors (for instance: preventing it's function in groups)


Edit: Tested it in a quick random. It doesn't appear to suppress the dialogues, but it appears to accept them? Which is rather odd. I will hit DE or Greed on an item, and it's roll window will disappear, but the Confirmation dialogue will still be up. The loot will even be distributed while the dialogue is still up. I just hit Accept or Cancel and it goes away, but just odd.

I was experiancing the same, but don't have any data on it at the moment.

Will test out of combat versus in combat and get back to you.

Not sure, I think Automaton's BOP module may have been affecting things, will test without it loaded. I am also using Xloot. Not sure if it will cause problems. It didn't matter whether I was in combat or not.

I am also using Passloot, removing their ConfirmBOP and DE modules to see if they are impacting things.

OK, I have removed everything I listed below, and the acceptance of the roll still occurs but leaving the dialogue behind. So to recap, I have removed all mods related to looting: Passloot's ConfirmBOP/DE modules, Automaton's BOP module. I have left Xloot because I find it too valuable to remove, and I don't see why it would impact the confirmation window anyway.

Edit: I have noticed the dialogue only remains on Greed/DE rolls, but not on Need rolls.

What happens:

You click greed/need/de on some items (bop / epic etc)
CONFIRM_LOOT_ROLL or CONFIRM_DISENCHANT_ROLL event fires
StaticPopup_Show("CONFIRM_LOOT_ROLL", SomeItemName) is called
StaticPopup_OnShow(frame) is called
You click 'Accept' and then the ConfirmLootRoll() is done.


What I did with my passloot addons for doing this, was hooked the StaticPopup_OnShow(Frame) function

Frame.which should hold the type of popup it was. Check for "CONFIRM_LOOT_ROLL" (both the de and normal confirm loot roll call the same popup.. the disenchant just changes the text) If it is, then just Frame:Hide() it.

<shrug> hope that helps.

Nice call. I didn't think about hiding all possible popups with that function since I have to make sure it's for the correct item.

edit: actually.. upon looking closer at the hide function, i might not need to hook either... hrmm

Heya!

I started using this addon just recently, and I also find that the confirmation window isn't being closed. The loot-roll I chose is immediately accepted, but the confirmation window stays open.

If I then manually type the following command in the editbox:

/script StaticPopup_Hide("CONFIRM_LOOT_ROLL");

the confirmation window closes just like it should. However, the exact same command should already have been fired by your addon (and probably is), but somehow the window stays open. In or out of combat makes no difference.

I must also mention I am using XLoot Group to replace the default lootframes.

I will try to test this further without any other addons enabled, and also with just XLoot Group disabled to see if there's a difference.

Results coming up in a few hours I guess :P

Update 01.12.10@16:35:
It seems that XLoot is the reason that the behaviour of ConfirmLootRoll is not as expected! :P
I solely disabled XLoot, and everytime I loot BoP items it accepts the loot immediately without popping up the confirmation window.

Oh well. I will not revert to the default Blizzard loot-frames, since I like XLoot way too much Guess I'll have to stick with the windows popping up...

I'll keep using ConfirmLootRoll anyway, since that enables me to completely ignore the confirmation windows and very quickly select all my desired loot-options at bosses

Thanks for that!