Download
(61Kb)
Download
Updated: 01-11-21 12:04 AM
Pictures
File Info
Compatibility:
Classic Patch (1.13.6)
Updated:01-11-21 12:04 AM
Created:10-13-19 09:05 PM
Downloads:7,713
Favorites:16
MD5:
Categories:Bags, Bank, Inventory, Classic - General

BankItems Classic  Popular! (More than 5000 hits)

Version: v 2.56
by: Hawksy [More]

BankItems has been written and maintained by Xinhuan. However, Xinhuan seems to have retired. I have modified the addon to work in Classic. If Xinhuan returns, and releases a version for Classic, then I will take this one down.

Hawksy


NOTES:

-- version 2.56 updated for 1.13.6

-- version 2.55 fixes the double-counting issue when moving items to or from the bank

-- Many modifications to get BankItems working in Classic, the most significant being not showing mail items in a bag
-- Mail items are still findable via Search and Export (and now in tooltips)
-- An alternative might have been to show mail in a bag, but not show equipped items in a bag
-- Added tooltip display code from Retail version, modified to work in Classic
-- Known anomalies:
-- No auction support, no expired mail support, no returned or deleted mail support, no money support
-- Player A can see something they mailed to player B, but player B can't see that it is incoming -- even though players A and B can see each other's non-mail amounts

Post A Reply Comment Options
Unread 01-20-23, 01:33 PM  
phoenixr
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Report comment to moderator  
Reply With Quote
Unread 07-04-22, 12:50 PM  
Hawksy
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 27
Uploads: 7
BankItems for Burning Crusade Classic

I have uploaded a version of BankItems that seems to work on Burning Crusade Classic PTR.

It also adds some mail functions, and a reload button.

I apologize for taking so long to realize that the classic BankItems wasn't working for Burning Crusade.

I will have an updated Classic version available if this one works properly. Please let me know if it works, or if it has bugs.

Hawksy
Report comment to moderator  
Reply With Quote
Unread 09-26-21, 05:57 PM  
endymon
A Kobold Labourer

Forum posts: 0
File comments: 13
Uploads: 0
Someone hosted an updated version for TBCC
https://github.com/Macumbatbc/BankItem-TBCC
Report comment to moderator  
Reply With Quote
Unread 06-28-21, 07:13 AM  
Dizzeth
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Re: Re: Rapaired Addons for TBC

Originally Posted by zedorg
Originally Posted by Dimodian
I don't know if i dare to post this. Curse site is down now and i wanted to share repaired addons for TBC. So i put it on my homepage. Those are Bagmeters and BankItems. lysak_de/files/addons
Everything works fine for me. The last bank slot too. Have fun with it. Of course you have to put dot in the link.
The files cannot be downloaded, 404.
If you click a link on the website and then manually change "Addons" to lowercase "addons" in the link then the files can be downloaded. With this version the items in my last bank slot are also counted in item tooltip.

And a big thanks to everyone who contributed fixes.
Report comment to moderator  
Reply With Quote
Unread 06-02-21, 04:15 PM  
zedorg
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Re: Rapaired Addons for TBC

Originally Posted by Dimodian
I don't know if i dare to post this. Curse site is down now and i wanted to share repaired addons for TBC. So i put it on my homepage. Those are Bagmeters and BankItems. lysak_de/files/addons
Everything works fine for me. The last bank slot too. Have fun with it. Of course you have to put dot in the link.
The files cannot be downloaded, 404.
Report comment to moderator  
Reply With Quote
Unread 05-30-21, 05:16 PM  
Dimodian
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Rapaired Addons for TBC

I don't know if i dare to post this. Curse site is down now and i wanted to share repaired addons for TBC. So i put it on my homepage. Those are Bagmeters and BankItems. lysak_de/files/addons
Everything works fine for me. The last bank slot too. Have fun with it. Of course you have to put dot in the link.
Last edited by Dimodian : 05-30-21 at 05:19 PM.
Report comment to moderator  
Reply With Quote
Unread 05-29-21, 09:17 PM  
Gee
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Found a few more fixes for TBC not covered below. First change should fix the last 4 item slots not being saved, just do a find and replace cos its duplicated on a few lines. Second change fixes the 7th bag slot not showing up in bank items window. This still leaves an empty icon in the bottom left of the window but think thats fine as there are no more player bags/equiped items to show there.

Code:
-- lines 1254, 1786, 1841, 1889, 1963
for num = 1, 28 do

-- line 1510
for i = 0, 11 do
Report comment to moderator  
Reply With Quote
Unread 05-29-21, 04:10 AM  
DavidNiven
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
There still a problem with the addon, it doesnt count the items in banks. bags, etc. most likely due to modifications in itemString , TBC adds 4 more ids - jewelID1-4. Can anyone takes a look and maybe finds a solution? Thank you in advance.
Report comment to moderator  
Reply With Quote
Unread 05-21-21, 11:26 PM  
endymon
A Kobold Labourer

Forum posts: 0
File comments: 13
Uploads: 0
A few more edit are needed ontop of phoenixr list of changes.

Code:
BagButtonAr[5]:SetPoint("TOPLEFT", ItemButtonAr[19], "BOTTOMLEFT", 0, -33)
UPDATE TO
BagButtonAr[5]:SetPoint("TOPLEFT", ItemButtonAr[22], "BOTTOMLEFT", 0, -33)

(3 places)
 = 5, 10 do
UPDATE TO
 = 5, 11 do
These are all the additional changes I know of at this time.
With these:
- Bag alignment is fixed
- 7th bank slot is populated
Last edited by endymon : 05-21-21 at 11:27 PM.
Report comment to moderator  
Reply With Quote
Unread 05-21-21, 03:17 PM  
mailfalanyok
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
ty a lot phoenixr.

Not a good coder. Can you pls send me rar file etc of yours?

Like others, this addon is my must-have, such an awesoem addon.
Report comment to moderator  
Reply With Quote
Unread 05-21-21, 01:36 PM  
Doctor0Who
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Same Issue as below...

Same Issue with the Offset Bags as below...after phoenixr's "fixes".


Hopefully an actual update arrives...sooner rather than later.
Report comment to moderator  
Reply With Quote
Unread 05-21-21, 10:46 AM  
Druadev
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Originally Posted by phoenixr
To make the addon work...
Bless you, bless you, bless you... that pretty much did the trick. I'd figured out a few of those things (adding bag 11, changing the 6's to 7's, etc. Still there were a few things that eluded me, esp the frame OptionsFrame stuff.

I do still have one problem, however. In the main BI window, all of my bank bags and character bags are offset from where they're supposed to be. Relative to each other the bags are positioned correctly and they are all clickable, however they are not in their expected position at the bottom of the window. If you look at the main BI window, those two rows of bags are offset 1 bag row up and 5 rows to the right. Is there some constant I didn't change?

And a picture is worth a thousand words...
https://i.ibb.co/r5wcv3c/bank-items.png

Thanks for your help and keeping BankItems going!
Report comment to moderator  
Reply With Quote
Unread 05-21-21, 08:09 AM  
phoenixr
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
To make the addon work, search for the lines with SetBackdrop, go back to the lines with CreateFrame in the same text block and add
, BackdropTemplateMixin and "BackdropTemplate")

There are 2 instances

BankItems_OptionsFrame = CreateFrame("Frame", "BankItems_OptionsFrame", UIParent)
>>
BankItems_OptionsFrame = CreateFrame("Frame", "BankItems_OptionsFrame", UIParent, BackdropTemplateMixin and "BackdropTemplate")

and

BankItems_ExportFrame = CreateFrame("Frame", "BankItems_ExportFrame", UIParent, "DialogBoxFrame")
>>
BankItems_ExportFrame = CreateFrame("Frame", "BankItems_ExportFrame", UIParent, "DialogBoxFrame", BackdropTemplateMixin and "BackdropTemplate")

Other changes for the new bank slots to work:
local BAGNUMBERS = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 100} -- List of bag numbers used internally by BankItems (11 and 101 removed for Classic)

BankItems_Frame:SetWidth(453) -- classic 403

for i = 1, 24 do
change the 24 to 28 everywhere

elseif (mod(i, 6) == 1) then
ItemButtonAr[i]:SetPoint("TOPLEFT", ItemButtonAr[i-6], "BOTTOMLEFT", 0, -7)
-- change the 2 6s to 7s

Change this
BagButtonAr[100]:SetPoint("TOPLEFT", BagButtonAr[5], "BOTTOMLEFT", 0, -6) -- bottom row, player bags
to:
BagButtonAr[11]:SetPoint("TOPLEFT", BagButtonAr[10], "TOPRIGHT", 12, 0)
BagButtonAr[100]:SetPoint("TOPLEFT", BagButtonAr[6], "BOTTOMLEFT", 0, -6) -- bottom row, player bags

for j = 1, 36 do
36 to 40


I'd upload a fixed version, but it's probably against ToS
Report comment to moderator  
Reply With Quote
Unread 05-20-21, 09:39 AM  
Druadev
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
Hoping for a TBC Classic Version

BankItems is one of my "must have" WoW addons and it isn't working under the "new" classic Burning Crusade patch. (I assume because Blizz has added back a 7th bank bag and 4 more slots.) I tried to poke around in the code, but am just not savvy enough to patch it. Help!

I just wanted you to know, Hawksy, that there's someone out there who cares and deeply appreciate your efforts to keep Xinhuan's old addon alive.
Report comment to moderator  
Reply With Quote
Unread 01-11-21, 12:11 AM  
Hawksy
A Kobold Labourer
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 27
Uploads: 7
Originally Posted by Elzirak
Is there a way to use another bag mods textures?
Not that I am aware of. I'm not the original author of this addon, I just made it work in Classic. Xinhuan may have returned and updated his version, so check for that.

Hawksy
Last edited by Hawksy : 01-11-21 at 12:12 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: