Quantcast
Download
(14 Kb)
Download
Updated: 12-19-20 04:36 AM
Pictures
File Info
Compatibility:
Shadowlands pre-patch (9.0.1)
Updated:12-19-20 04:36 AM
Created:07-30-19 06:41 PM
Downloads:1,105
Favorites:11
MD5:

Compact Vendor Filter

Version: v9.0.2.201017
by: Vlad [More]

Official repository can be found at GitHub.

Compact Vendor converts your vendor frame into a compact scrollable list with a search box.

Inspiration drawn from Yssaril's GoblinVendorFilter.

CompactVendorFilter
v9.0.2.201017 (2020-10-17)
Full Changelog Previous Releases
  • Correct TOC bump for SL pre-patch.
  • Setup hooks but keep the widget specific original method reference.
Optional Files (0)


Archived Files (7)
File Name
Version
Size
Author
Date
v9.0.0.201015
14kB
Vlad
10-15-20 01:08 PM
v9.0.0.200731b
13kB
Vlad
10-15-20 04:47 AM
v9.0.0.200731
14kB
Vlad
10-14-20 12:13 PM
v8.3.0.200306
14kB
Vlad
03-05-20 03:22 AM
v8.3.0.200202
14kB
Vlad
02-02-20 03:38 AM
8.2.0.190812
13kB
Vlad
08-13-19 01:19 AM
8.2.0.190728
13kB
Vlad
07-30-19 06:41 PM


Post A Reply Comment Options
Unread 10-15-20, 02:55 PM  
Vlad
A Molten Giant
 
Vlad's Avatar
AddOn Author - Click to view AddOns

Forum posts: 792
File comments: 337
Uploads: 28
Re: Issues with tooltip hooks

Originally Posted by brykrys
Please could you look again at how you set hooks on GameTooltip-type objects?

I see you have hooked SetMerchantItem and SetMerchantCostItem (to set a flag called EnableHooks), and these hooks are applied to every GameTooltip-type object.

However the hooks are not calling back the correct old function in every case, they all call back the old function from GameTooltip itself.

This is a problem if any other AddOn has hooked these functions before you:

For example if an AddOn has hooked SetMerchantItem only on the GameTooltip, and expects the function to be called only from GameTooltip itself, it may cause unexpected errors when called from other tooltip objects.

Alternatively if an AddOn has applied a special version of SetMerchantItem to a particular tooltip other than GameTooltip itself, your hook will simply remove this special version.
Thanks for the heads up, you are right that this isn't good enough. I will have to create new functions per widget and store their original function whatever they might be in order to avoid hooking issues the way its done right now.

I believe this commit fixes this particular issue: https://github.com/Vladinator89/wow-...1dc9fcbdc04afd
__________________
Profile: Curse | Wowhead
Last edited by Vlad : 10-15-20 at 03:02 PM.
Report comment to moderator  
Reply With Quote
Unread 07-27-20, 07:37 AM  
brykrys
A Deviate Faerie Dragon
 
brykrys's Avatar
AddOn Author - Click to view AddOns

Forum posts: 12
File comments: 74
Uploads: 3
Issues with tooltip hooks

Please could you look again at how you set hooks on GameTooltip-type objects?

I see you have hooked SetMerchantItem and SetMerchantCostItem (to set a flag called EnableHooks), and these hooks are applied to every GameTooltip-type object.

However the hooks are not calling back the correct old function in every case, they all call back the old function from GameTooltip itself.

This is a problem if any other AddOn has hooked these functions before you:

For example if an AddOn has hooked SetMerchantItem only on the GameTooltip, and expects the function to be called only from GameTooltip itself, it may cause unexpected errors when called from other tooltip objects.

Alternatively if an AddOn has applied a special version of SetMerchantItem to a particular tooltip other than GameTooltip itself, your hook will simply remove this special version.
Report comment to moderator  
Reply With Quote
Unread 09-10-19, 11:03 AM  
AnrDaemon
A Chromatic Dragonspawn
AddOn Author - Click to view AddOns

Forum posts: 156
File comments: 2225
Uploads: 5
Would you mind fixing the link on the front page?
https://www.wowinterface.com/downloa...dorFilter.html
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: