Download
(24Kb)
Download
Updated: 07-29-18 04:42 AM
Updated:07-29-18 04:42 AM
Created:04-22-13 06:29 PM
Downloads:9,704
Favorites:72
MD5:

GoFish  Popular! (More than 5000 hits)

Version: 8.0.0.0
by: Phanx, Akkorian

I am no longer developing or maintaining World of Warcraft addons. I haven't played in years, and don't have the time or interest to continue working on addons for a game I don't play anymore. If you are an addon author interested in continuing one of my addons, please see https://phanx.net/addons/. If you are an addon user, sorry, but there won't be any more fixes or updates from me.
GoFish lets you double-right-click to fish, and enhances sound effects while fishing.
Fishing mode is automatically enabled when you mouse over a fishing pool, while you have a fishing pole equipped, or can be toggled using a keybind or slash command. Fishing mode is disabled if you enter combat or unequip a fishing pole, or after 10 seconds of no fishing activity if it was enabled via mouseover.

While in fishing mode, double-right-clicking anywhere on the game world casts Fishing, auto-loot is enabled, auto-interact is disabled, the sound effect volume is raised, and other volumes are lowered. When exiting fishing mode, your normal settings are restored.

To toggle fishing mode manually, type "/gofish" or bind a key. To change options, type "/gofish options" or browse to the GoFish panel in the standard Interface Options window.
Feedback
Post a comment or open a ticket on GitHub. If you are reporting a bug, please include detailed instructions I can follow to reproduce the bug myself, whether or not it still happens when all other addons are disabled, and the exact text of the first related error message (if any) from Bugger/BugSack/Swatter.

Please note that GoFish does not support lures or other skill-enhancing items, and requests for such features will not be considered at this time.
Language Support
Compatible with all locales. The UI is translated into English, Deutsch, Español, 한국어, and 繁體中文.

To add or update translations for the UI in any language, enter them on CurseForge.

To add or update fish pool names for any language, please post a comment or send me a PM.
Credits
GoFish was inspired by Ammo's FishermansFriend. The click-casting code borrows heavily from Torhal's Archy. The translations for fish pool names were mostly copied from Kagaro's GatherMate2 and Wowhead.

Version 8.0.0.0 (2018 Jul 29)
  • Updated for WoW 8.0

Version 7.3.5.0 (2018 May 6)
  • Added compatibility with WoW 8.0 beta
  • Added Portuguese translations
  • Updated Simplified Chinese translations
  • Updated Traditional Chinese translations
Post A Reply Comment Options
Unread 02-08-19, 11:47 PM  
GFGame
A Defias Bandit
 
GFGame's Avatar

Forum posts: 3
File comments: 20
Uploads: 0
License Confusion

So.. it's all rights reserved but then says it's okay to fork and modify on Github so why not just use an MIT, Apache, LGPL, or other permissible license?
I am glad to see the code's available and that people can mod it.


Also, does this still work in 8.1?
__________________
Crypt Master of <Deadly Intent> [H] (Stonemaul)
Last edited by GFGame : 02-08-19 at 11:47 PM.
Report comment to moderator  
Reply With Quote
Unread 08-19-18, 12:36 PM  
Rykaerdoe82
A Kobold Labourer

Forum posts: 0
File comments: 1
Uploads: 0
Sound

Gofish doesn't seem to change my sound settings. Even using gofish as sole addon will cause this. Any known fix?

Thanks!
Report comment to moderator  
Reply With Quote
Unread 08-17-18, 04:43 PM  
DreamsUnderStars
A Defias Bandit

Forum posts: 3
File comments: 105
Uploads: 0
I'd like to request the option to turn off chat spam... or perhaps you could tell me what code and where to comment out?
Report comment to moderator  
Reply With Quote
Unread 07-29-18, 10:00 AM  
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5617
File comments: 2321
Uploads: 54
Version 8.0.0.0 (2018 Jul 29)
  • Updated for WoW 8.0
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
Report comment to moderator  
Reply With Quote
Unread 07-22-18, 07:30 PM  
Ekaterina
A Theradrim Guardian
AddOn Author - Click to view AddOns

Forum posts: 65
File comments: 50
Uploads: 1
In 8.0/8.0.1 If you get errors mousing over fishing pools while mounted,
Replacing line 389
Lua Code:
  1. or (IsMounted() and not (UnitBuff("player", FROSTWOLF_WAR_WOLF) or UnitBuff("player", TELAARI_TALBUK)))
with:
Lua Code:
  1. or (IsMounted() and not (AuraUtil.FindAuraByName(FROSTWOLF_WAR_WOLF, "player") or AuraUtil.FindAuraByName(TELAARI_TALBUK, "player")))
should fix the problem.

Just so that people can keep using this awesome addon until it next gets updated.
Report comment to moderator  
Reply With Quote
Unread 09-18-15, 08:12 AM  
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5617
File comments: 2321
Uploads: 54
If it happens fairly regularly, you can enable some debug messages to try to see if the problem is actually in the addon logic or not. If it's a rare problem, debugging will just spam you a lot, but you could still try.

Open Addon.lua in Notepad and find this line:
Code:
GoFish:SetScript("PostClick", function(self, button, down)
After it, remove the two dashes from in front of each "print" statement, eg:
Code:
--print("Fished")
But stop replacing when you get to this line:
Code:
function GoFish:EnableFishingMode()
Now save the file, reload your UI if you were already in-game, and start fishing.

If it turns out your mouse button is flaky (eg. if the sensor is wearing out, pressing the button with insufficient force may just barely complete the switch and end up sending multiple click events as it makes and loses contact) you may be able to work around it by raising the minimum time between clicks:
Code:
if clickDiff > 0.05 and clickDiff < 0.25 then
Change 0.05 to something higher. However, this may cause your intentional double-clicks to be ignored if they're too fast. You can play around with it.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
Report comment to moderator  
Reply With Quote
Unread 09-17-15, 05:40 AM  
Barleduq
Premium Member
 
Barleduq's Avatar
Premium Member

Forum posts: 135
File comments: 742
Uploads: 0
English

Yes, English, USA servers.

One reason I haven't reported the lack of loot was because of exactly that. I have double-click turned *off* on fishing buddy, tho, because it never worked. I wouldn't care except that I don't get the fish, and it made various fish questing a royal pain in the butt.
Report comment to moderator  
Reply With Quote
Unread 09-16-15, 09:21 PM  
def9
A Cobalt Mageweaver
 
def9's Avatar
AddOn Author - Click to view AddOns

Forum posts: 219
File comments: 108
Uploads: 1
English here.
__________________
Epiria, level 100 Ret/Holy Paladin
Simkin level 100 Combat Rogue
Feldeemus, level 100 Arcane Mage
Report comment to moderator  
Reply With Quote
Unread 09-16-15, 08:10 PM  
JDoubleU00
A Firelord
 
JDoubleU00's Avatar
AddOn Author - Click to view AddOns

Forum posts: 463
File comments: 82
Uploads: 2
Re: Re: On first login after updating

Originally Posted by Phanx
What language are you guys playing in?

Originally Posted by Barleduq
I do have Fishing Buddy installed, which claims to enable double-click fishing ... sometimes when I click on the bobber to loot the fish, it immediately casts the line again and does NOT give me the fish.
Without any other information, I'd be inclined to assume this is happening because you have two addons trying to manage double-clicking to fish, or because your mouse has a sticky button, though you'd probably notice that in other apps as well.
I also get this message even with all addons disabled except yours and stAddon manager.

Code:
Message: Interface\AddOns\GoFish\Addon.lua:15: attempt to index field 'Quick fishing {OFF}' (a nil value)
Time: 09/16/15 22:07:08
Count: 1
Stack: Interface\AddOns\GoFish\Addon.lua:15: in main chunk

Locals: ADDON = "GoFish"
ns = <table> {
 F = <table> {
 }
 L = <table> {
 }
}
FISHING = "Fishing"
FISHING_POLE = "Fishing Poles"
F = <table> {
 蕁麻魚群 = true
 Ein Schwarm Hochlandguppys = true
 大型鼠尾魚群 = true
 Grosso Banco di Dipnoi di Giada Luminosi = true
 Banco di Pesci di Vetro = true
 微光珍宝斑马鱼 = true
 Musselback Sculpin School = true
 Grande Cardume de Polvos do Recife Migrados = true
 Cardume de Pançudos do Mar Profundo = true
 Banco di Gamberi Mantide Aggrovigliati = true
 Débris de la Voile sanglante = true
 Banco di Pescifango = true
 Banco de peces alveolares de jade = true
 Banco di Vildenti Frenetici = true
 Poza brillante = true
 Débris flottants = true
 Large Swarm of Migrated Reef Octopus = true
 Banc de poissons-spores = true
 Sporefish School = true
 포자물고기 떼 = true
 용지느러미 천사돔 떼 = true
 Piscinia extraño = true
 Banco di Pescisalvia = true
 Banc de tassergals = true
 刺皮鱼群 = true
 Banco de pulpos de arrecife emigrados = true
 Banco de sabiolas = true
 Cardume de Bagres-cegos Albinos = true
 Schiffswracktrümmer = true
 미꾸라지 떼 = true
 Grande réserve de boue de gouramis tigres = true
 Pozza di Tuorlo di Gru = true
 Banco di Pesci Scorpione Toccati dallo Sha = true
 Косяк борейского медузника = true
 Ein Schwarm Sporenfische = true
 Cardume de Acarás-bandeira Pinadragos = true
 Floating Wreckage = true
 Destroços Encharcados = true
 유리지느러미 송사리 떼 = true
 闪光翠绿肺鱼 = true
 Banc de lutjans de nagefeu = true
 虎皮丝足鱼群 = true
 Banc de saumons glaciaires = true
 Cardume de Piranha Selvagem = true
 Косяк ледоспинки = true
 Cardume de Boca-grandes Abissais Oleosos = true
 Косяк испуганноого веслоноса = true
 Стайка каменного угря = true
 Cardume de Boca-grandes Abissais = true
 高地孔雀魚群 = true
 Redbelly Mandarin School = true
 Ein Schwarm Blauflossen = true
 Banco de mandarines panzarroja = true
 Fat Sleeper School = true
 Grosso Banco Affollato di Panciarossa Orientali = true
 Большой косяк сверкающего бриллиантового данио = true
 Verhedderter Schwarm riesiger Mantisgarnelen = true
 Banco de esturiones ciegos de lago = true
 Cardume da Lagoa = true
 Cardume de Platis = true
 Oily Abyssal Gulper School = true
 Giant Mantis Shrimp Swarm = true
 Fire Ammonite School = true
 Cardume de Peixes-espátula de Krasarang = true
 Bassin du lagon = true
 Restos de los Velasangre = true
 크라사랑 주걱철갑상어 떼 = true
 Mandarines panzarroja atiborrados = true
 Grosso Banco di Pesci Scorpione Toccati dallo Sha = true
 Banco di Pesci Oceanici = true
 Ein Schwarm Riffkraken = true
 비취 폐어 떼 = true
 Косяк глубоководного шалфокуня = true
 Pozza di Fuoco = true
 황금 화살고기 떼 = true
 Стайка саженного угря = true
 Cardume de Escorpiões do Mar Oleosos = true
 Cardume Misto Salobre = true
 Banco de pargos de fuego = true
 Стая запутавшихся раков-богомолов = true
 Banc de sagerelles abyssales = true
 Glimmering Jewel Danio Pool = true
 Enjambre de poliodóntidos aterrados = true
 Cardume de Gouramis-tigre = true
 帝王鲑鱼群 = true
 Pozza di Piranha Selvaggi = true
 Banco de salmones glaciales = true
 Banco di Pesci Spatola nel Panico = true
 Flaque de sang = true
 Peixe-espinho Tocado pelo Sha = true
 Schiffswrackteile = true
 一大群迁徙的八爪鱼 = true
 Détritus de la pompe à vapeur = true
 Ein Schwarm Rotbauchmandarine = true
 Косяк луфаря = true
 Banco di Storioni di Lago Ciechi = true
 Cardume de Azorragues Aguanegra = true
 Grande Poça de Piramboias de Jade Brilhantes = true
 Banco di Eleotridi Grassi = true
 Banco de pulpos de arrecife = true
 Ein Schwarm dicker Schläfer = true
 Пруд свирепых пираний = true
 Banc de demoiselles aileron-de-dragon = true
 Agua pura = true
 Banc mixte en eaux saumâtres = true
 Banc de crevettes-mantes
__________________
Author of JWExpBar and JWRepBar.
Report comment to moderator  
Reply With Quote
Unread 09-16-15, 05:05 PM  
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5617
File comments: 2321
Uploads: 54
Re: On first login after updating

What language are you guys playing in?

Originally Posted by Barleduq
I do have Fishing Buddy installed, which claims to enable double-click fishing ... sometimes when I click on the bobber to loot the fish, it immediately casts the line again and does NOT give me the fish.
Without any other information, I'd be inclined to assume this is happening because you have two addons trying to manage double-clicking to fish, or because your mouse has a sticky button, though you'd probably notice that in other apps as well.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
Report comment to moderator  
Reply With Quote
Unread 09-16-15, 11:09 AM  
def9
A Cobalt Mageweaver
 
def9's Avatar
AddOn Author - Click to view AddOns

Forum posts: 219
File comments: 108
Uploads: 1
I also get the error after updating to version: 6.2.2.14 using no other mods other than swatter and gofish and a clean wtf folder.

Lua Code:
  1. Error occured in: Global
  2. Count: 1
  3. Message: ..\AddOns\GoFish\Addon.lua line 15:
  4.    attempt to index field 'Quick fishing {OFF}' (a nil value)
  5. Debug:
  6.    GoFish\Addon.lua:15: in main chunk
__________________
Epiria, level 100 Ret/Holy Paladin
Simkin level 100 Combat Rogue
Feldeemus, level 100 Arcane Mage
Report comment to moderator  
Reply With Quote
Unread 09-16-15, 03:41 AM  
Barleduq
Premium Member
 
Barleduq's Avatar
Premium Member

Forum posts: 135
File comments: 742
Uploads: 0
On first login after updating

My apologies, I don't use Bugger, I use Swatter, as that comes with the Auctioneer suite. Also, the last time I turned all my addons off, I had to re-create all my settings. If you're still willing to take this report...

I updated GoFish. Started game via CLI (linux system). Game stopped, told me to patch. Launched Battle.net app via doubleclick on desktop shortcut. After patch download/install finished, exited battle.net app and launched from CLI. The very first toon I logged in, this message popped up on Swatter:

Code:
Date: 2015-09-16 05:04:21
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\GoFish\Addon.lua line 15:
   attempt to index field 'Quick fishing {OFF}' (a nil value)
Debug:
   GoFish\Addon.lua:15: in main chunk
Locals:
ADDON = "GoFish"
ns = <table> {
 F = <table> {
 }
 L = <table> {
 }
}
FISHING = "Fishing"
FISHING_POLE = nil
F = <table> {
 蕁麻魚群 = true
 Ein Schwarm Hochlandguppys = true
 大型鼠尾魚群 = true
 Grosso Banco di Dipnoi di Giada Luminosi = true
 Banco di Pesci di Vetro = true
 微光珍宝斑马鱼 = true
 Musselback Sculpin School = true
 Grande Cardume de Polvos do Recife Migrados = true
 Cardume de Pançudos do Mar Profundo = true
 Banco di Gamberi Mantide Aggrovigliati = true
 Débris de la Voile sanglante = true
 Banco di Pescifango = true
 Banco de peces alveolares de jade = true
 Banco di Vildenti Frenetici = true
 Poza brillante = true
 Débris flottants = true
 Large Swarm of Migrated Reef Octopus = true
 Banc de poissons-spores = true
 Sporefish School = true
 포자물고기 떼 = true
 용지느러미 천사돔 떼 = true
 Piscinia extraño = true
 Banco di Pescisalvia = true
 Banc de tassergals = true
 刺皮鱼群 = true
 Banco de pulpos de arrecife emigrados = true
 Banco de sabiolas = true
 Cardume de Bagres-cegos Albinos = true
 Schiffswracktrümmer = true
 미꾸라지 떼 = true
 Grande réserve de boue de gouramis tigres = true
 Pozza di Tuorlo di Gru = true
 Banco di Pesci Scorpione Toccati dallo Sha = true
 Косяк борейского медузника = true
 Ein Schwarm Sporenfische = true
 Cardume de Acarás-bandeira Pinadragos = true
 Floating Wreckage = true
 Destroços Encharcados = true
 유리지느러미 송사리 떼 = true
 闪光翠绿肺鱼 = true
 Banc de lutjans de nagefeu = true
 虎皮丝足鱼群 = true
 Banc de saumons glaciaires = true
 Cardume de Piranha Selvagem = true
 Косяк ледоспинки = true
 Cardume de Boca-grandes Abissais Oleosos = true
 Косяк испуганноого веслоноса = true
 Стайка каменного угря = true
 Cardume de Boca-grandes Abissais = true
 高地孔雀魚群 = true
 Redbelly Mandarin School = true
 Ein Schwarm Blauflossen = true
 Banco de mandarines panzarroja = true
 Fat Sleeper School = true
 Grosso Banco Affollato di Panciarossa Orientali = true
 Большой косяк сверкающего бриллиантового данио = true
 Verhedderter Schwarm riesiger Mantisgarnelen = true
 Banco de esturiones ciegos de lago = true
 Cardume da Lagoa = true
 Cardume de Platis = true
 Oily Abyssal Gulper School = true
 Giant Mantis Shrimp Swarm = true
 Fire Ammonite School = true
 Cardume de Peixes-espátula de Krasarang = true
 Bassin du lagon = true
 Restos de los Velasangre = true
 크라사랑 주걱철갑상어 떼 = true
 Mandarines panzarroja atiborrados = true
 Grosso Banco di Pesci Scorpione Toccati dallo Sha = true
 Banco di Pesci Oceanici = true
 Ein Schwarm Riffkraken = true
 비취 폐어 떼 = true
 Косяк глубоководного шалфокуня = true
 Pozza di Fuoco = true
 황금 화살고기 떼 = true
 Стайка саженного угря = true
 Cardume de Escorpiões do Mar Oleosos = true
 Cardume Misto Salobre = true
 Banco de pargos de fuego = true
 Стая запутавшихся раков-богомолов = true
 Banc de sagerelles abyssales = true
 Glimmering Jewel Danio Pool = true
 Enjambre de poliodóntidos aterrados = true
 Cardume de Gouramis-tigre = true
 帝王鲑鱼群 = true
 Pozza di Piranha Selvaggi = true
 Banco de salmones glaciales = true
 Banco di Pesci Spatola nel Panico = true
 Flaque de sang = true
 Peixe-espinho Tocado pelo Sha = true
 Schiffswrackteile = true
 一大群迁徙的八爪鱼 = true
 Détritus de la pompe à vapeur = true
 Ein Schwarm Rotbauchmandarine = true
 Косяк луфаря = true
 Banco di Storioni di Lago Ciechi = true
 Cardume de Azorragues Aguanegra = true
 Grande Poça de Piramboias de Jade Brilhantes = true
 Banco di Eleotridi Grassi = true
 Banco de pulpos de arrecife = true
 Ein Schwarm dicker Schläfer = true
 Пруд свирепых пираний = true
 Banc de demoiselles aileron-de-dragon = true
 Agua pura = true
 Banc mixte en eaux saumâtres = true
 Banc de crevettes-mantes géantes = 
AddOns:
     [ Elided for brevity. Let me know if you want the list. ]
  BlizRuntimeLib_enUS v6.2.2.60200 <none>
  (ck=cfc)
I do have Fishing Buddy installed, which claims to enable double-click fishing but this has never worked for me. Which is why I've installed GoFish.

ALSO:
I've not mentioned it before because I can't reliably reproduce it, but sometimes when I click on the bobber to loot the fish, it immediately casts the line again and does NOT give me the fish. The loot window flashes, there's something in it, but it never goes into my bags. Due to this, I've disabled GoFish on some of my alts.

ALSO:

When I was checking to make sure that I had it enabled on this toon, the options page under the Menu > Interface looked odd - I took a screenshot, you can see it here on imgur.
Report comment to moderator  
Reply With Quote
Unread 10-20-14, 02:32 AM  
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5617
File comments: 2321
Uploads: 54
Version 6.0.2.46
  • Fixed disabling auto-loot after fishing if it was off beforehand (why!?)

I couldn't actually reproduce the problem, but it was storing and setting the value as a boolean (true/false) instead of a flag (1/0) so I fixed that just in case. If you're still seeing auto-loot turning off after fishing, and you're sure it was on before fishing, please try disabling all your other addons and reproducing the problem. You can quickly check the state of the auto-loot setting at any time using this command:

/dump GetCVar("autoLootDefault")

It'll write "1" in your chat frame if it's on, or "0" if it's off. Run it before activating fishing mode, while fishing mode is active, and after deactivating fishing mode. It should say the same thing before and after depending on your setting, and "1" during fishing.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
Report comment to moderator  
Reply With Quote
Unread 10-19-14, 09:12 PM  
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view AddOns

Forum posts: 5617
File comments: 2321
Uploads: 54
Oh is that what's doing that... interesting. I'll have to see why the game isn't accurately indicating whether auto-loot is enabled. It should check the state when you start fishing, and only turn it off afterwards if it was off to begin with.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
Report comment to moderator  
Reply With Quote
Unread 10-18-14, 11:33 AM  
uncomplimentary
A Kobold Labourer

Forum posts: 0
File comments: 2
Uploads: 0
auto loot

auto loot is being toggled off on deactivation, it appears
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: