WoWInterface - Notable API changes in Legion

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Legion Beta archived threads (https://www.wowinterface.com/forums/forumdisplay.php?f=177)

- - Notable API changes in Legion (https://www.wowinterface.com/forums/showthread.php?t=53248)

Notable API changes in Legion

Hi everyone, I'd like to share some notable API changes in Legion. All of them have been tested in current alpha realm and I'm pretty sure you guys may in need of them. :-)

animationGroup:SetChange() has been removed
This one occurs in such circustance:

Lua Code:

local flash = item:CreateAnimationGroup()
for i = 1, 3 do
    local fade = flash:CreateAnimation('Alpha')
    fade:SetDuration(.2)
    fade:SetChange(-.8)
    fade:SetOrder(i * 2)
 
 
    local fade = flash:CreateAnimation('Alpha')
    fade:SetDuration(.3)
    fade:SetChange(.8)
    fade:SetOrder(i * 2 + 1)
end

GetAuctionItemClasses() has been removed
This one occurs in such circustance:
Lua Code:
```
local QUEST = select(10, GetAuctionItemClasses())
```
In fact, QUEST == "Quest" in enUS, just a string indicating quest items.
SetTradeSkillItem() has been removed
This one occurs in such circustance:
Lua Code:
```
hooksecurefunc(tooltip, 'SetTradeSkillItem', OnTradeSkill)
```

UnitIsTapped()/UnitIsTappedByPlayer() has been removed
This one occurs in such circustance:

Lua Code:

if not isName and (dead or (UnitIsTapped(unit) and not UnitIsTappedByPlayer(unit))) then
    return 0.5, 0.5, 0.5

UnitPowerMax()/UnitPower() should specify power type now, not an optional one
We use this code now:
Lua Code:
```
local value = UnitPowerMax(unit)
```
In Legion we should do something like this:
Lua Code:
```
local value = UnitPowerMax(unit, UnitPowerType(unit))
```
texture:SetTexture(r, g, b, a) changes into texture:SetColorTexture(r, g, b, a)
texture:SetTexture(texture_path) is working as well, but Blizzard creates as new SetColorTexture to cover texture:SetTexture(r, g, b, a) function.
In Legion if you want to specify texture by a texture path, use SetTexure. For RGBA value, use SetColorTexture instead.
item:125794:::::::::: is allowed now
For item link, we use something like "item:125794:0:0:0:0:0:0" before.
But in Legion, we can dismiss these zeros.
For user who wants to regex an item link, this is useful.
We can use texture:SetTexture(file_id) now, so GetSpellInfo will not return a texture path as the 3rd return value
We use this code to set an icon now:
Lua Code:
```
local _, _, icon = GetSpellInfo(spell_id)
texture:SetTexture(icon)
```
In Legion, that's easier:
Lua Code:
```
file_id = GetSpellTexture(spell_id)
texture:SetTexture(file_id)
```

Here is what I'm using in alpha realm:
https://github.com/icyblade/wow_addons
I did some changes to these addons so they will work in alpha environment.

Quote:

Originally Posted by icyblade (Post 313723)

UnitPowerMax()/UnitPower() should specify power type now
We use this code now:

Lua Code:

local value = UnitPowerMax(unit)

In Legion we should do something like this:

Lua Code:

local value = UnitPowerMax(unit, UnitPowerType(unit))

Not new, this has been in for a few expansions now. Maybe you meant it's not optional any more?

Quote:

All of them have been tested in current alpha realm

Are scripts in some capacity working on alpha realms? Or are these just observed in the alpha UI?

Quote:

Originally Posted by p3lim (Post 313730)

Not new, this has been in for a few expansions now. Maybe you meant it's not optional any more?

Yes, it's not optional now

Quote:

Originally Posted by Gello (Post 313731)

Are scripts in some capacity working on alpha realms? Or are these just observed in the alpha UI?

Here is what I'm using in alpha
https://github.com/icyblade/wow_addons

Quote:

Originally Posted by icyblade (Post 313723)

We can use texture:SetTexture(spellId) now, so GetSpellInfo will not return a texture path as the 3rd return value
We use this code to set an icon now:

Lua Code:

local _, _, icon = GetSpellInfo(spell_id)
texture:SetTexuture(icon)

In Legion, that's easier:

Lua Code:

texture:SetTexuture(spell_id)

This seems weird...

Quote:

Originally Posted by Gello (Post 313731)

Are scripts in some capacity working on alpha realms? Or are these just observed in the alpha UI?

Not officially, there are ways to hack the exe and enable addons.

Quote:

Originally Posted by Gethe (Post 313735)

Not officially, there are ways to hack the exe and enable addons.

I've been playing the Alpha (not as a developer) and the Addon button is active and does go to the addon list (I have two libraries for some reason).

Yeah the game recognizes that you have addons installed, but it won't run them.

I currently have RealUI installed on my alpha client (mostly because addons were legit active for that first public build), so if addons were being run it would be very obvious for me.

animationGroup:SetCharge()

I think you mean SetChange?
What do we use now, the SetChange is what creates the fade over time. Is there a setting some place else for this.

Was looking thru the code and found SetToAlpha() and SetFromAlpha(). Think these are new animationgroup functions.

I wonder if this fixes a bug from live. If you fade out a parent frame, and its children are also fading out at the same time. You can cause the child frames to be stuck in faded state. Only way is to reloadUI. I had to do some complicated coding in my addon to work around this bug. Be awesome if it was fixed.

Quote:

Originally Posted by galvin (Post 313759)

Yes that's SetChange, thanks for pointing out that

After looking at WorldMapFrame.lua. My best guess until someone tests.
SetFromAlpha() is where you start from.
SetToAlpha() is where you end at.

Quote:

Originally Posted by icyblade (Post 313723)

We can use texture:SetTexture(spellId) now, so GetSpellInfo will not return a texture path as the 3rd return value
We use this code to set an icon now:

Lua Code:

local _, _, icon = GetSpellInfo(spell_id)
texture:SetTexuture(icon)

In Legion, that's easier:

Lua Code:

texture:SetTexuture(spell_id)

Quote:

Originally Posted by Lombra (Post 313734)

This seems weird...

If it does accept spellID, then it isn't limited to spellID only. I think they may have introduced textureIDs too or something like that. The first return of GetLootSlotInfo is now a number and no longer a string path to the texture. This number does not match the itemID of the item in that loot slot, and you can use this number in :SetTexture() as well.

I'm guessing they have made :SetTexture really dynamic.

Yeah, they're using a "texture atlas" now, but I don't know if that's what is being discussed here. You can find out a very little bit about that HERE.

Quote:

Originally Posted by icyblade (Post 313723)

local value = UnitPowerMax(unit)
In Legion we should do something like this:

Lua Code:

local value = UnitPowerMax(unit, UnitPowerType(unit))

Power type isn't mandatory, you can use UnitPowerMax(unit) as before

Quote:

Originally Posted by icyblade (Post 313723)

[*] We can use texture:SetTexture(spellId) now, so GetSpellInfo will not return a texture path as the 3rd return value
We use this code to set an icon now:

Lua Code:

local _, _, icon = GetSpellInfo(spell_id)
texture:SetTexuture(icon)

In Legion, that's easier:

Lua Code:

texture:SetTexuture(spell_id)

That is not spellID, it's FileID. So it's only easer if you know exact fileID for texture, otherwise you still need call GetSpellTexture. You can use string path as before.

Quote:

Originally Posted by icyblade (Post 313723)

UnitIsTapped()/UnitIsTappedByPlayer() has been removed
This one occurs in such circustance:

Lua Code:

if not isName and (dead or (UnitIsTapped(unit) and not UnitIsTappedByPlayer(unit))) then
    return 0.5, 0.5, 0.5

does this mean tapped mobs no longer exist in legion?

Correct, tagging is no longer a thing, I'm unsure of members of the opposite faction tagging tho.

Tagging is still a thing, but it has changed and the api was consolidated to a single function: UnitIsTapDenied()

that is such a weird call name to choose over just consolidating it all into UnitIsTapped

Not really because most mobs will be tapable by more than one player ie. UnitIsTapped would return true but you can still kill the mob and get reward. What you will be checking for is the odd occaision you are denied the tap and reward.