WoWInterface

WoWInterface (https://www.wowinterface.com/forums/index.php)
-   Carbonite: Dev Talk (https://www.wowinterface.com/forums/forumdisplay.php?f=167)
-   -   L["...."] addings in Files (https://www.wowinterface.com/forums/showthread.php?t=51345)

gOOvER 12-31-14 04:24 AM

L["...."] addings in Files
 
I'm a bit Angry. When you add NEW L["..."] PLEASE add it also to the Lang files. I work atm at NxWeekly.lua and the enUS differs a lot from the others.

So Please;

1. Add new L["..."] to ALL other language Files (enUS, itIT, etc ......)
2. Add NEW L["..."] AT THE END OF THE TRANSLATIONFILE !!!!!!!! So it's esier to take a look, what missing


With my next Commit:

If you want to Translate a Boss of WoW use

B["BOSS"]

gOOvER 12-31-14 04:33 AM

See
https://github.com/Rythal/Carbonite/pull/202

nelegalno2 12-31-14 05:41 AM

Quote:

Originally Posted by gOOvER (Post 304081)
I'm a bit Angry. When you add NEW L["..."] PLEASE add it also to the Lang files. I work atm at NxWeekly.lua and the enUS differs a lot from the others.

So Please;

1. Add new L["..."] to ALL other language Files
2. Add NEW L["..."] AT THE END OF THE TRANSLATIONFILE !!!!!!!! So it's esier to take a look, what missing


With my next Commit:

If you want to Translate a Boss of WoW use

B["BOSS"]

Take a look at http://www.wowinterface.com/forums/s...ad.php?t=51261
ATM I don't have access to github so I can't make a pull for it.

gOOvER 12-31-14 09:46 AM

@atl77: Please take a look into existing PR's before you breaking the Languages. ;) Because you are only adding L[...] to deDE.lua and not to others. ;)

samyonair 12-31-14 10:39 AM

Sorry had to do some things. I think atl77 hasn't pulled your Request out of same Idea I don't pull it for the moment I Know the Github Version is thrwoing Errors at the Moment, but your change with lib should be decided by Rythal and thats why I don't pull nelegalnos pull for the Moment wants to wait until rythal decides if we pull gOOvERs request first than I will manually merge nelegalnos pull and go further with my Ideas for bindings

Greetings Samyonair

Rythal 12-31-14 10:47 AM

I am the main culprit in not adding them to every language besides enUS, and that's because the people working on translating have not needed them moved. When I do the push, someone is right there to duplicate the new strings across to the rest of the language files and i've gotten use to that.

When i'm working, localization is the last thing on my mind, and usually the last thing I do. I ignore the errors that it's not in the locale files, then I add them all to enUS and push it then move onto the next bug.

Rythal 12-31-14 10:49 AM

and what error is the github throwing? the only one I knew of was the Seals and I fixed that 5 minutes after it was reported.

samyonair 12-31-14 10:52 AM

Because you have done your merge without translated Lterms all languages apart from enUS, and German (because of atl77) are throwing arrors because of missing L terms

Greetings Samyonair

Rythal 12-31-14 10:55 AM

I must completely misunderstand how the acelocale works, it was my understanding if it's declared in enUS it uses that as the default, if your using another locale language and it wasn't replaced, then go back to the default one and use that, which was why enUS was declared the default language during table initializations.

Rythal 12-31-14 11:02 AM

I thought so... reading the page again on acelocale, and it is suppose to work the way I thought it was with enUS declared the default.

Rythal 12-31-14 11:18 AM

Silent flag was just added, acelocale should never again return an error.

samyonair 12-31-14 11:41 AM

I think then it is a good Idea if the Translators put their changes byself by compaering locales files with enUS because this removes many merge conflicts

greatings Samyonair

DeaTHCorEKiD 12-31-14 11:42 AM

i think silent flag in dev version are counterproductive, this helps not to find errors or missing translations.

samyonair 12-31-14 11:57 AM

the silent flag is only for locales files, our Problem is we have Translators for almost all supported Languages and they transmit their files, and a change in time between working on translations and a codechange leaves more problems then a missing term,

greetings Samyonair

Rythal 12-31-14 11:58 AM

Quote:

Originally Posted by DeaTHCorEKiD (Post 304106)
i think silent flag in dev version are counterproductive, this helps not to find errors or missing translations.

Not if I start making sure all new translations are always at the bottom. Just as my version of carbonite has debug settings enabled so I see stuff no one else does, I'll have my locales non-silenced to make sure they are added to enUS.

I really don't understand what changed, as besides the initial push I never updated the other languages besides enUS, and this is the first i've heard of errors coming from it, warnings yes but not errors.

Rythal 12-31-14 12:02 PM

Wait... maybe I'm getting cross-confused, when you said errors I thought you meant ingame LUA errors and that's what I was trying to fix up, are you meaning the github is throwing errors because it can't merge.

samyonair 12-31-14 12:09 PM

No I thought on lua errors I mixed it sorry

for declaretion

Lua errors missing L Terms

and merge conflicts by changeing translation files by

1. Translator works on translations

2. fix / enhancement : pushed to all languagefiles

3. Translator pulls his Version from 1

merge confict because files defer

greetings Samyonair

easy way for development

Guide for Translators Howto remove silent flag to develop

My thought was you do only enUS to don't create merge conflicts

atl77 12-31-14 12:56 PM

Proposal: silent for release only
 
Even though I believe the translator will spot missing translations sooner or later, I also think the silent option should only be set for releases. How about setting a flag to tell if a version is a release version and putting that into the locale definition instead of "true"?

nelegalno2 12-31-14 01:09 PM

Quote:

Originally Posted by samyonair (Post 304097)
Sorry had to do some things. I think atl77 hasn't pulled your Request out of same Idea I don't pull it for the moment I Know the Github Version is thrwoing Errors at the Moment, but your change with lib should be decided by Rythal and thats why I don't pull nelegalnos pull for the Moment wants to wait until rythal decides if we pull gOOvERs request first than I will manually merge nelegalnos pull and go further with my Ideas for bindings

Greetings Samyonair

I'm updating the file to the current version. And I don't mind updating the locale files when i have the time.


All times are GMT -6. The time now is 09:17 AM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI