Bug on changing talents and glyphs nUI v5.07.36(Release)
 

Wenever i try to change a talent or a glyph it shows a message and the glyphs and the talents dont change

Here is the message:

Date: 2013-09-11 19:51:35
ID: 1
Error occured in: AddOn: nUI
Count: 1
Message: Error: AddOn nUI attempted to call a forbidden function (RemoveTalent()) from a tainted execution path.
Debug:
[C]: RemoveTalent()
...rface\AddOns\Blizzard_TalentUI\Blizzard_TalentUI.lua:39: OnAccept()
..\FrameXML\StaticPopup.lua:3823: StaticPopup_OnClick()
[string "*:OnClick"]:1:
[string "*:OnClick"]:1
Locals:
None
AddOns:
Swatter, v4.4.0 (<%codename%>)
Babylonian, v5.1.DEV.332(/embedded)
Configator, v5.1.DEV.344(/embedded)
Gatherer, v4.4.0
GladiusEx, v
nUI, v5.07.36 (Lite)
SlideBar, v4.4.0 (<%codename%>)
BlizRuntimeLib_enUS v5.4.0.50400 <us>
(ck=f0)

Yeah... this is a known issue in nUI5. It's a taint error and related to how the Blizzard pulldown menus work. There's no easy fix for it. That said, it's been my experience that if you hold your nose just right, squint ever so slightly and only let your tongue stick out about a quarter inch from the corner of your mouth, it will work after a few tries. ~smile~ When all else fails, you might have to temporarily disable... which sucks, I know. I don't *think* this problem exists in nUI6... though, come to think of it, I'm not sure I've tested that fully.

what is very strange is that on teh previous version for wow 5.3 it didint have this bug!
I really dont know what cause the addon to have this bug but what i know its that it didin't had it before!

I've been using nUI for some time now, and I haven't had this problem for this current patch, either. What could have happened?

Also, it does have that bug in nUI6 as well. Just tried.

This just started happening for me after 5.4 too.

I vaguely remember having this problem with another addon in the past. If memory serves, the only real fix is to remove all drop-down menus/items created by the addon - which may not be a showstopper for me (I don't *think* I regularly use any nUI-created dropdowns).

An update, but not a very happy one, I'm afraid.

I've spent hours trying to get to the bottom of this.

It does not appear to be related to pulldown menus. I've disabled them, and the variables that can be corrupted by pull down menus are not tainted.

I have gone through and removed dozens of instances in nUI where variables weren't declared local when they should have. No change.

Another issue which has caused mysterious taint errors in the past is corruption of the lua global variable "_" (underscore). Not tainted.

I have disabled nUI's management of tooltips, the minimap, and the battlefield minimap InfoPanel plugin (all of which were causing taint to non-nUI globals). Didn't fix the problem either.

The StaticPopup dialog boxes have caused a number of taint problems in the past. They too do not seem to be tainted.

After removing every logged source of taint I could find, my Taint.log file shows only two variables that are tainted that don't have "nUI" somewhere in the name. Those are

MOVING_CHAT_FRAME, and

BINDING_KEYS_CLICK

The first is used to move the chat windows and combat log around to where nUI wants them, and the second is used to handle key bindings. Disabling these would screw the addon up badly enough that it didn't really seem worth trying.

I could not find any changes in the Blizzard interface code that would account for the changed behavior, either. The error happens on a call to a C-routine.

Since there are cases where things get tainted without being logged, I also wrote a script to scan through the entire global namespace (_G) and report any non-tabular variables that were tainted and did not have "nui" (case-insensitive) in the name.

Apart from the two above, there were a few taints here:

Most of the tainted stuff seems to be related to diagnostic tools like eventtrace, framestack, etc. Nothing that would obviously interact with any part of the GlyphUI, certainly.

I didn't do a *recursive* scan through _G, which might turn up something. Or it might just crash the client if there are any circular references... Once I recover from my depression, I'll probably try.

I also attach my taint log, in case somebody smarter can find something I missed.