WoWInterface - Clear Button Texture and Text LUA Help

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Clear Button Texture and Text LUA Help (https://www.wowinterface.com/forums/showthread.php?t=55351)

Dejablue

04-24-17 11:10 AM

Clear Button Texture and Text LUA Help

I am making an addon that creates buttons for the Sentinax beacons in your bags. I have it complete, except I cannot figure out how to iteratively clear and then refresh the button texture and text (for item count).

Maybe I am using the wrong template and or am missing something obvious. I always have trouble with refreshing text.

Here is code that works in game, you can copy/paste into a test addon, and it puts the buttons on your screen in the middle. Head to a vendor and sell a beacon, or go in the field and loot some. It will make new frames fine. But if the count changes it wont clear the previous text so there is, for example, a 2 on top of a 3 when you use it. The same is true for the textures.

Any help is appreciated.

Cheers!

Code:

--Beam Me Up Deja Initialization Frame

        

local Ecount

local Rcount

local Ucount



local BeamMeUpDejaInitFrame = CreateFrame("Frame", "BeamMeUpDejaInitFrame", BeamMeUpDejaDragFrame)

        BeamMeUpDejaInitFrame:RegisterEvent("PLAYER_LOGIN")

        BeamMeUpDejaInitFrame:RegisterEvent("PLAYER_REGEN_ENABLED")

        BeamMeUpDejaInitFrame:RegisterEvent("LOOT_OPENED")

        BeamMeUpDejaInitFrame:RegisterEvent("BAG_UPDATE")

        

        BeamMeUpDejaInitFrame:SetScript("OnEvent", function(self, event, ...)

                Ecount = 0

                Rcount = 0

                Ucount = 0        

                for bag = 0, 4, 1 do 

                        for slot=1, GetContainerNumSlots(bag), 1 do 

                                local name = GetContainerItemLink(bag,slot)

                                if name and string.find(name,"Sentinax Beacon") then

                                --if name and string.find(name,"Hearthstone") then

                                        --ddebug()

                                        local _, itemCount = GetContainerItemInfo(bag, slot)

                                        local itemName, itemLink, itemRarity,_,_,_,_,itemStackCount,_,itemTexture,_ = GetItemInfo(name)

                                                --print(name, itemName,itemStackCount)--Debugging

                                        local texture = select(10,GetItemInfo(name))

                                        local w = 36

                                        local h = 36

                                        local x

                                        local y = 0

                                        if itemRarity == 4 then

                                                --print("Ecount is "..Ecount)--Debugging

                                                x = (Ecount*w)*1.1

                                                y = h*2.1

                                                Ecount = Ecount+1

                                        end

                                        if itemRarity == 3 then

                                                --print("Rcount is "..Rcount)--Debugging

                                                x = (Rcount*w)*1.1

                                                y = h*1.1

                                                Rcount = Rcount+1

                                        end

                                        if itemRarity == 2 then

                                                --print("Ucount is "..Ucount)--Debugging

                                                x = (Ucount*w)*1.1

                                                Ucount = Ucount+1

                                        end

                                        

                                        BMUDButton = CreateFrame("Button", "BMUDButton"..name, UIParent, "SecureActionButtonTemplate");

                                        _G["BMUDButton"..name] = BMUDButton



                                        BMUDButtonFS = BMUDButton:CreateFontString("FontString","OVERLAY","GameTooltipText")

                                        _G["BMUDButtonFS"..name] = BMUDButtonFS                                        



                                        if ((_G["BMUDButtonFS"..name])~=nil) then

                                                BMUDButton:SetNormalTexture(nil,"ARTWORK")

                                                BMUDButton:SetPushedTexture(nil,"ARTWORK")

                                                BMUDButton:SetHighlightTexture(nil,"ARTWORK")

                                                BMUDButtonFS:SetFormattedText("")

                                        end



                                                BMUDButton:RegisterForClicks("AnyUp", "AnyDown")

                                                BMUDButton:ClearAllPoints()

                                                BMUDButton:SetPoint("CENTER",x,y+32)

                                                BMUDButton:SetSize(w,h)

                                        

                                                BMUDButtonFS:SetPoint("BOTTOMRIGHT", BMUDButton)

                                                BMUDButtonFS:SetFont("Fonts\\FRIZQT__.TTF", 14, "THINOUTLINE")

                                                --BMUDButtonFS:SetShadowOffset(1, -1)--Optional

                                                BMUDButtonFS:SetTextColor(1, 1, 1);

                                                --print(name, itemCount)--Debugging

                                                BMUDButton:SetAttribute("type","item")

                                                BMUDButton:SetAttribute("item",itemName)



                                                if event == "BAG_UPDATE" then

                                                        BMUDButtonFS:SetFormattedText("%.0f", itemCount)

                                                        BMUDButton:SetNormalTexture(itemTexture)

                                                        BMUDButton:SetPushedTexture(itemTexture)

                                                        BMUDButton:SetHighlightTexture(itemTexture)

                                                        print("Bag updated")

                                                end

                                        BMUDButton:HookScript("OnEnter", function(self)

                                                GameTooltip:SetOwner(self, "ANCHOR_CURSOR")

                                                GameTooltip:SetHyperlink(name)

                                                GameTooltip:Show()

                                        end)

                                        BMUDButton:HookScript("OnLeave", function(self) GameTooltip:Hide() end)

                                end

                        end 

                end

        end)

Fizzlemizz

04-24-17 12:31 PM

I don't see where you check if a button already exists. Every OnEvent seems to trigger the creation of a new set of buttons for each specified item found.

syncrow

04-24-17 02:02 PM

You're code re-creates your buttons constantly, which would cause massive error junk when you loot beacons right in combat....

It would be much better to pre-create all necessary buttons and only handle the count text upon bag updates.

Here is a little example on how it would look like:

Lua Code:

local buttonSize = 36
local padding = 0;
local beacons = {
    -- rares
    [146923] = "",  -- petrification
    [147355] = "",  -- bloodstrike
    [146922] = "",  -- fel growth
    [146915] = "",  -- greater Torment
    [146912] = "",  -- greater carnage
    [146914] = "",  -- greater engineering
    [146910] = "",  -- greater dominance
    [146913] = "",  -- greater warbeasts
    [146911] = "",  -- greater firestorm
    
    -- uncommons
    [146906] = "",  -- carnage
    [146907] = "",  -- warbeasts
    [146909] = "",  -- torment
    [146908] = "",  -- engineering
    [146903] = "",  -- dominance
    [146905] = "",  -- firestorm
}
 
local function CreateButtons()
    local index = 1;
    
    for itemID in pairs(beacons) do
        local itemName, itemLink = GetItemInfo(itemID)
        
        if itemName then
            local texture = select(10, GetItemInfo(itemID));
            local button = CreateFrame("Button", "BMUDButton"..index, UIParent, "SecureActionButtonTemplate")
            local xPos = -300 + ( (buttonSize + padding) * (index-1))
            
            button:SetSize(buttonSize, buttonSize)
            button:SetPoint("CENTER", xPos, 0)
            button:RegisterForClicks("AnyUp", "AnyDown")
            button:SetAttribute("type", "item")
            button:SetAttribute("item", itemName)
 
            button.fs = button:CreateFontString(nil, "OVERLAY", "GameTooltipText")
            button.fs:SetPoint("BOTTOMRIGHT")
            button.fs:SetFont("Fonts\\FRIZQT__.TTF", 14, "THINOUTLINE")
            button.fs:SetTextColor(1, 1, 1)
 
            button:SetNormalTexture(texture)
            button:SetPushedTexture(nil,"ARTWORK")
            button:SetHighlightTexture(nil,"ARTWORK")
            
            button:HookScript("OnEnter", function(self)
                GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
                GameTooltip:SetHyperlink(itemLink)
                GameTooltip:Show()
            end)
            button:HookScript("OnLeave", GameTooltip_Hide)
            
            -- overwrite empty string with the button as a reference here
            beacons[itemID] = button;
        end
        
        index = index + 1;
    end     
end
 
local function UpdateCount()
    for itemID, button in pairs(beacons) do
        local itemName = GetItemInfo(itemID);
        local count = 0;
        
        for bag = 0, 4 do
            for slot = 1, GetContainerNumSlots(bag) do
                local item = GetContainerItemID(bag, slot);
                
                -- found a beacon in your bag
                if itemID == item then
                    count = count + 1
                end
            end 
        end
        
        -- handle display
        if count > 0 then
            button.fs:SetText(count);
            button:GetNormalTexture():SetDesaturated(false);
        else
            button.fs:SetText("");
            button:GetNormalTexture():SetDesaturated(true);
        end
    end
end
 
local frame = CreateFrame("Frame", "BeamMeUpDejaInitFrame", BeamMeUpDejaDragFrame)
 
frame:RegisterEvent("PLAYER_LOGIN")
frame:SetScript("OnEvent", function(self, event, ...)
    if event == "PLAYER_LOGIN" then
        CreateButtons()
        UpdateCount()
        self:RegisterEvent("BAG_UPDATE")
    end
    
    if event == "BAG_UPDATE" then
        UpdateCount()
    end
end)

The buttons in this example are static and do not hide / show themselves properly, but this is further secure wrapping....

PS: beacons are not stackable, as far as i'm aware

Dejablue

04-24-17 07:31 PM

Quote:

Originally Posted by syncrow (Post 323038)

Lua Code:

local buttonSize = 36
local padding = 0;
local beacons = {
    -- rares
    [146923] = "",  -- petrification
    [147355] = "",  -- bloodstrike
    [146922] = "",  -- fel growth
    [146915] = "",  -- greater Torment
    [146912] = "",  -- greater carnage
    [146914] = "",  -- greater engineering
    [146910] = "",  -- greater dominance
    [146913] = "",  -- greater warbeasts
    [146911] = "",  -- greater firestorm
    
    -- uncommons
    [146906] = "",  -- carnage
    [146907] = "",  -- warbeasts
    [146909] = "",  -- torment
    [146908] = "",  -- engineering
    [146903] = "",  -- dominance
    [146905] = "",  -- firestorm
}
 
.....
            
        ....

The buttons in this example are static and do not hide / show themselves properly, but this is further secure wrapping....

PS: beacons are not stackable, as far as i'm aware

My first inclination was to create a table listing them all, but I chose to try this method as a sort of exercise as well as wanting to create them dynamically as found in the bags without knowing their specific names. This would future proof it if Blizzard decided to make a beacon of Murlocs, for example. There are also epic boss ones and epic ones that you take to each broken shore game

This isn't the entire code. I am not trying to show or hide them in combat, there is an inCombat check for a button that shows or hides them all that does nothing in combat.

They do indeed stack.:)

to 20 as per itemStackCount = GetItemInfo()

Thank you for taking the time. I appreciate it very much. Let me know if you have any ideas about creating them as a loop. Gah I really don;t want to make static tables for this ;/

Dejablue

04-24-17 07:44 PM

Quote:

Originally Posted by Fizzlemizz (Post 323035)

I don't see where you check if a button already exists. Every OnEvent seems to trigger the creation of a new set of buttons for each specified item found.

This is the latest attempt in the OP code:

Code:

    if ((_G["BMUDButtonFS"..name])~=nil) then

        BMUDButton:SetNormalTexture(nil,"ARTWORK")

        BMUDButton:SetPushedTexture(nil,"ARTWORK")

        BMUDButton:SetHighlightTexture(nil,"ARTWORK")

        BMUDButtonFS:SetFormattedText("")

    end

Yeah, BAG_UPDATE event fires a billion times and is more of a debugging event that i can use at a vendor to sell and rebuy my beacons to see if this works.

Thanks for taking the time. Let me know if you think of anything else :)

Fizzlemizz

04-24-17 08:42 PM

Quote:

Originally Posted by Dejablue (Post 323042)

This is the latest attempt in the OP code:

Code:

    if ((_G["BMUDButtonFS"..name])~=nil) then

        BMUDButton:SetNormalTexture(nil,"ARTWORK")

        BMUDButton:SetPushedTexture(nil,"ARTWORK")

        BMUDButton:SetHighlightTexture(nil,"ARTWORK")

        BMUDButtonFS:SetFormattedText("")

    end

That code doesn't actually do anything because you're checking if a Fontstring you've just created exists, and it always will because, you've just created a new one, along with a new parent button.

if BAG_UPDATE fires a billion times your code will have created a billion new buttons and fontstrings.

Rather than this, you need to check if a button of the same name exists before you create a new one:

Code:

local BMUDButton

if not _G["BMUDButton"..name] then

        BMUDButton = CreateFrame("Button", "BMUDButton"..name, UIParent, "SecureActionButtonTemplate");

        -- Create the extra bits here

else

        BMUDButton = _G["BMUDButton"..name]

        -- reset the extra bits here

end

Dejablue

04-24-17 10:12 PM

Quote:

Originally Posted by Fizzlemizz (Post 323043)

Code:

local BMUDButton

if not _G["BMUDButton"..name] then

        BMUDButton = CreateFrame("Button", "BMUDButton"..name, UIParent, "SecureActionButtonTemplate");

        -- Create the extra bits here

else

        BMUDButton = _G["BMUDButton"..name]

        -- reset the extra bits here

end

Wouldn't I want to check if a button exists and then clear it and if it doesn't then create it?

What do I do to reset the buttons? I have tried myriad solutions, none work.

Quote:

BMUDButton:SetNormalTexture(nil,"ARTWORK")
BMUDButton:SetPushedTexture(nil,"ARTWORK")
BMUDButton:SetHighlightTexture(nil,"ARTWORK")
BMUDButtonFS:SetFormattedText("")

Code:

_G["BMUDButton"..name]:SetNormalTexture(nil,"ARTWORK")

_G["BMUDButton"..name]:SetPushedTexture(nil,"ARTWORK")

_G["BMUDButton"..name]:SetHighlightTexture(nil,"ARTWORK")

_G["BMUDButton"..name]:SetFormattedText("")

Fizzlemizz

04-24-17 10:30 PM

Something like this:

Lua Code:

--Beam Me Up Deja Initialization Frame
    
local Ecount
local Rcount
local Ucount
 
local BeamMeUpDejaInitFrame = CreateFrame("Frame", "BeamMeUpDejaInitFrame", BeamMeUpDejaDragFrame)
    BeamMeUpDejaInitFrame:RegisterEvent("PLAYER_LOGIN")
    BeamMeUpDejaInitFrame:RegisterEvent("PLAYER_REGEN_ENABLED")
    BeamMeUpDejaInitFrame:RegisterEvent("LOOT_OPENED")
    BeamMeUpDejaInitFrame:RegisterEvent("BAG_UPDATE")
    
    BeamMeUpDejaInitFrame:SetScript("OnEvent", function(self, event, ...)
        Ecount = 0
        Rcount = 0
        Ucount = 0  
        for bag = 0, 4, 1 do 
            for slot=1, GetContainerNumSlots(bag), 1 do 
                local name = GetContainerItemLink(bag,slot)
                if name and string.find(name,"Sentinax Beacon") then
                --if name and string.find(name,"Hearthstone") then
                    --ddebug()
                    local _, itemCount = GetContainerItemInfo(bag, slot)
                    local itemName, itemLink, itemRarity,_,_,_,_,itemStackCount,_,itemTexture,_ = GetItemInfo(name)
                        --print(name, itemName,itemStackCount)--Debugging
                    local texture = select(10,GetItemInfo(name))
                    local w = 36
                    local h = 36
                    local x
                    local y = 0
                    if itemRarity == 4 then
                        --print("Ecount is "..Ecount)--Debugging
                        x = (Ecount*w)*1.1
                        y = h*2.1
                        Ecount = Ecount+1
                    end
                    if itemRarity == 3 then
                        --print("Rcount is "..Rcount)--Debugging
                        x = (Rcount*w)*1.1
                        y = h*1.1
                        Rcount = Rcount+1
                    end
                    if itemRarity == 2 then
                        --print("Ucount is "..Ucount)--Debugging
                        x = (Ucount*w)*1.1
                        Ucount = Ucount+1
                    end
                    local BMUDButton
                    if not _G["BMUDButton"..name] then -- Button does not exist so create it
                        BMUDButton = CreateFrame("Button", "BMUDButton"..name, UIParent, "SecureActionButtonTemplate");
                        BMUDButton.Label = BMUDButton:CreateFontString("$parent_FontString","OVERLAY")
                        BMUDButton:RegisterForClicks("AnyUp", "AnyDown")
                        BMUDButton:SetPoint("CENTER",x,y+32)
                        BMUDButton:SetSize(w,h)
                        BMUDButton.Label:SetPoint("BOTTOMRIGHT", BMUDButton)
                        BMUDButton.Label:SetFont("Fonts\\FRIZQT__.TTF", 14, "THINOUTLINE")
                        BMUDButton.Label:SetTextColor(1, 1, 1);
                        BMUDButton:SetAttribute("type","item")
                        BMUDButton:SetAttribute("item",itemName)
                        BMUDButton:HookScript("OnEnter", function(self)
                                GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
                                GameTooltip:SetHyperlink(name)
                                GameTooltip:Show()
                            end)
                        BMUDButton:HookScript("OnLeave", function(self) GameTooltip:Hide() end)
                    else -- Button exists so reset to default state
                        BMUDButton = _G["BMUDButton"..name]
                        BMUDButton:SetNormalTexture(nil)
                        BMUDButton:SetPushedTexture(nil)
                        BMUDButton:SetHighlightTexture(nil)
                        BMUDButton.Label:SetText("")
 
                    end
                    if event == "BAG_UPDATE" then -- only set textures and text for this event
                        BMUDButton.Label:SetFormattedText("%.0f", itemCount)
                        BMUDButton:SetNormalTexture(itemTexture)
                        BMUDButton:SetPushedTexture(itemTexture)
                        BMUDButton:SetHighlightTexture(itemTexture)
                        print("Bag updated:", name)
                    end
                end
            end 
        end
    end)

EDIT: If the textures aren't going to change for each button then you wouldn't need to set them to nil and then re-set them, just the text value.
This also doesn't cover buttons created for beacons you no longer have. This would require either keeping a table of buttons created or checking for buttons created for beacons you don't have.

Dejablue

04-24-17 10:57 PM

Quote:

Originally Posted by Fizzlemizz (Post 323045)

Something like this:

Lua Code:

--Beam Me Up Deja Initialization Frame
    
local Ecount
local Rcount
local Ucount
 
local BeamMeUpDejaInitFrame = CreateFrame("Frame", "BeamMeUpDejaInitFrame", BeamMeUpDejaDragFrame)
    BeamMeUpDejaInitFrame:RegisterEvent("PLAYER_LOGIN")
    BeamMeUpDejaInitFrame:RegisterEvent("PLAYER_REGEN_ENABLED")
    BeamMeUpDejaInitFrame:RegisterEvent("LOOT_OPENED")
    BeamMeUpDejaInitFrame:RegisterEvent("BAG_UPDATE")
    
    BeamMeUpDejaInitFrame:SetScript("OnEvent", function(self, event, ...)
        Ecount = 0
        Rcount = 0
        Ucount = 0  
        for bag = 0, 4, 1 do 
            for slot=1, GetContainerNumSlots(bag), 1 do 
                local name = GetContainerItemLink(bag,slot)
                if name and string.find(name,"Sentinax Beacon") then
                --if name and string.find(name,"Hearthstone") then
                    --ddebug()
                    local _, itemCount = GetContainerItemInfo(bag, slot)
                    local itemName, itemLink, itemRarity,_,_,_,_,itemStackCount,_,itemTexture,_ = GetItemInfo(name)
                        --print(name, itemName,itemStackCount)--Debugging
                    local texture = select(10,GetItemInfo(name))
                    local w = 36
                    local h = 36
                    local x
                    local y = 0
                    if itemRarity == 4 then
                        --print("Ecount is "..Ecount)--Debugging
                        x = (Ecount*w)*1.1
                        y = h*2.1
                        Ecount = Ecount+1
                    end
                    if itemRarity == 3 then
                        --print("Rcount is "..Rcount)--Debugging
                        x = (Rcount*w)*1.1
                        y = h*1.1
                        Rcount = Rcount+1
                    end
                    if itemRarity == 2 then
                        --print("Ucount is "..Ucount)--Debugging
                        x = (Ucount*w)*1.1
                        Ucount = Ucount+1
                    end
                    local BMUDButton
                    if not _G["BMUDButton"..name] then -- Button does not exist so create it
                        BMUDButton = CreateFrame("Button", "BMUDButton"..name, UIParent, "SecureActionButtonTemplate");
                        BMUDButton.Label = BMUDButton:CreateFontString("$parent_FontString","OVERLAY")
                        BMUDButton:RegisterForClicks("AnyUp", "AnyDown")
                        BMUDButton:SetPoint("CENTER",x,y+32)
                        BMUDButton:SetSize(w,h)
                        BMUDButton.Label:SetPoint("BOTTOMRIGHT", BMUDButton)
                        BMUDButton.Label:SetFont("Fonts\\FRIZQT__.TTF", 14, "THINOUTLINE")
                        BMUDButton.Label:SetTextColor(1, 1, 1);
                        BMUDButton:SetAttribute("type","item")
                        BMUDButton:SetAttribute("item",itemName)
                        BMUDButton:HookScript("OnEnter", function(self)
                                GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
                                GameTooltip:SetHyperlink(name)
                                GameTooltip:Show()
                            end)
                        BMUDButton:HookScript("OnLeave", function(self) GameTooltip:Hide() end)
                    else -- Button exists so reset to default state
                        BMUDButton = _G["BMUDButton"..name]
                        BMUDButton:SetNormalTexture(nil)
                        BMUDButton:SetPushedTexture(nil)
                        BMUDButton:SetHighlightTexture(nil)
                        BMUDButton.Label:SetText("")
 
                    end
                    if event == "BAG_UPDATE" then -- only set textures and text for this event
                        BMUDButton.Label:SetFormattedText("%.0f", itemCount)
                        BMUDButton:SetNormalTexture(itemTexture)
                        BMUDButton:SetPushedTexture(itemTexture)
                        BMUDButton:SetHighlightTexture(itemTexture)
                        print("Bag updated:", name)
                    end
                end
            end 
        end
    end)

EDIT: If the textures aren't going to change for each button then you wouldn't need to set them to nil and then re-set them, just the text value.

Have you tired this in game?

This does exactly what I have already tried. It does not reset the text or the textures after the first creation.

Fizzlemizz

04-24-17 11:13 PM

See the last edit in the last post.

Make sure you're seeing what event last happened so you know if the button should or should not be visible.
Change the bag code too:

Code:

if event == "BAG_UPDATE" then -- only set textures and text for this event

        BMUDButton.Label:SetFormattedText("%.0f", itemCount)

        BMUDButton:SetNormalTexture(itemTexture)

        BMUDButton:SetPushedTexture(itemTexture)

        BMUDButton:SetHighlightTexture(itemTexture)

        print("Bag Updated", name)

else

        print("Other Registered event", name)

end

With this, after a /reload will not show the button because a non BAG_UPDATE event is posted last when entering the world.

Fizzlemizz

04-24-17 11:30 PM

Just as a note, the code will only show the number of beacons of a type in the last bag slot with that type inspected. I haven't really played 7.2 so if you can only hold one beacon in a slot or you can have more than one slot with one type of beacon, then you will only ever see one or the quantity in the last slot checked holding the item.

Dejablue

04-24-17 11:48 PM

Quote:

Originally Posted by Fizzlemizz (Post 323045)

Something like this:

Lua Code:

--Beam Me Up Deja Initialization Frame
    
local Ecount
local Rcount
local Ucount
 
local BeamMeUpDejaInitFrame = CreateFrame("Frame", "BeamMeUpDejaInitFrame", BeamMeUpDejaDragFrame)
    BeamMeUpDejaInitFrame:RegisterEvent("PLAYER_LOGIN")
    BeamMeUpDejaInitFrame:RegisterEvent("PLAYER_REGEN_ENABLED")
    BeamMeUpDejaInitFrame:RegisterEvent("LOOT_OPENED")
    BeamMeUpDejaInitFrame:RegisterEvent("BAG_UPDATE")
    
    BeamMeUpDejaInitFrame:SetScript("OnEvent", function(self, event, ...)
        Ecount = 0
        Rcount = 0
        Ucount = 0  
        for bag = 0, 4, 1 do 
            for slot=1, GetContainerNumSlots(bag), 1 do 
                local name = GetContainerItemLink(bag,slot)
                if name and string.find(name,"Sentinax Beacon") then
                --if name and string.find(name,"Hearthstone") then
                    --ddebug()
                    local _, itemCount = GetContainerItemInfo(bag, slot)
                    local itemName, itemLink, itemRarity,_,_,_,_,itemStackCount,_,itemTexture,_ = GetItemInfo(name)
                        --print(name, itemName,itemStackCount)--Debugging
                    local texture = select(10,GetItemInfo(name))
                    local w = 36
                    local h = 36
                    local x
                    local y = 0
                    if itemRarity == 4 then
                        --print("Ecount is "..Ecount)--Debugging
                        x = (Ecount*w)*1.1
                        y = h*2.1
                        Ecount = Ecount+1
                    end
                    if itemRarity == 3 then
                        --print("Rcount is "..Rcount)--Debugging
                        x = (Rcount*w)*1.1
                        y = h*1.1
                        Rcount = Rcount+1
                    end
                    if itemRarity == 2 then
                        --print("Ucount is "..Ucount)--Debugging
                        x = (Ucount*w)*1.1
                        Ucount = Ucount+1
                    end
                    local BMUDButton
                    if not _G["BMUDButton"..name] then -- Button does not exist so create it
                        BMUDButton = CreateFrame("Button", "BMUDButton"..name, UIParent, "SecureActionButtonTemplate");
                        BMUDButton.Label = BMUDButton:CreateFontString("$parent_FontString","OVERLAY")
                        BMUDButton:RegisterForClicks("AnyUp", "AnyDown")
                        BMUDButton:SetPoint("CENTER",x,y+32)
                        BMUDButton:SetSize(w,h)
                        BMUDButton.Label:SetPoint("BOTTOMRIGHT", BMUDButton)
                        BMUDButton.Label:SetFont("Fonts\\FRIZQT__.TTF", 14, "THINOUTLINE")
                        BMUDButton.Label:SetTextColor(1, 1, 1);
                        BMUDButton:SetAttribute("type","item")
                        BMUDButton:SetAttribute("item",itemName)
                        BMUDButton:HookScript("OnEnter", function(self)
                                GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
                                GameTooltip:SetHyperlink(name)
                                GameTooltip:Show()
                            end)
                        BMUDButton:HookScript("OnLeave", function(self) GameTooltip:Hide() end)
                    else -- Button exists so reset to default state
                        BMUDButton = _G["BMUDButton"..name]
                        BMUDButton:SetNormalTexture(nil)
                        BMUDButton:SetPushedTexture(nil)
                        BMUDButton:SetHighlightTexture(nil)
                        BMUDButton.Label:SetText("")
 
                    end
                    if event == "BAG_UPDATE" then -- only set textures and text for this event
                        BMUDButton.Label:SetFormattedText("%.0f", itemCount)
                        BMUDButton:SetNormalTexture(itemTexture)
                        BMUDButton:SetPushedTexture(itemTexture)
                        BMUDButton:SetHighlightTexture(itemTexture)
                        print("Bag updated:", name)
                    end
                end
            end 
        end
    end)

Quote:

Originally Posted by Fizzlemizz (Post 323048)

Making headway. The text does update.

Now to work on getting the textures to update after BAG_UPDATE like they do with a UI reload.

Thanks for the help. Any ideas on textures? Is that not possible becasue frames persist until reload? Any way to recycle the frames? Hmmm.

syncrow

04-24-17 11:51 PM

As beacons do not stack and consume an inventory slot each, you don't have to care about stackCount at all.
So you can raise your beacon count by 1 every time that particular beacon is found.

Why do you want to update the textures at all?
The buttons are named by the beacons name, so they are not be recycled anyway.

And a beacon's icon is static and doesn't get changed by blizzard.

Fizzlemizz

04-24-17 11:54 PM

Quote:

Originally Posted by Dejablue (Post 323049)

Any way to recycle the frames? Hmmm.

That's what we're doing.

You may also be having trouble with positioning. If you /fstack over the buttons you'll probably find you have a bunch of "BMUDButton"..xxx buttons positioned over the top of each other.

Edit: Thanks syncrow. You will need to keep a tally rather than just using the last itemCount value for the text.

The recycle code

Lua Code:

local BMUDButton
if not _G["BMUDButton"..name] then -- Button does not exist so create it
    BMUDButton = CreateFrame("Button", "BMUDButton"..name, UIParent, "SecureActionButtonTemplate");
    -- BMUDButton points to a shiney new button
else
    BMUDButton = _G["BMUDButton"..name]
    -- BMUDButton points to the previously created button
end

Dejablue

04-25-17 12:56 AM

Quote:

Originally Posted by syncrow (Post 323050)

They do stack: http://i.imgur.com/46uZkI1.jpg

I want to completely hide the button and have them collapse so that you do not have spaces where you do not have beacons.

If I have two beacons I want to show them, If I then use one I want it to disappear. Then if I get a third one I want it to appear next to the one I still have, not leave a space and appear two or three icon spaces next to it, leaving empty space.

Dejablue

04-25-17 12:58 AM

Quote:

Originally Posted by Fizzlemizz (Post 323051)

Lua Code:

local BMUDButton
if not _G["BMUDButton"..name] then -- Button does not exist so create it
    BMUDButton = CreateFrame("Button", "BMUDButton"..name, UIParent, "SecureActionButtonTemplate");
    -- BMUDButton points to a shiney new button
else
    BMUDButton = _G["BMUDButton"..name]
    -- BMUDButton points to the previously created button
end

I understand this. however I do not understand what you put in place of :

-- BMUDButton points to a shiney new button

or

-- BMUDButton points to the previously created button

I get the concept.

What the hell is the syntax?

What you have so far works great. But once I have a button and use it and no longer have the beacons, the button persists. No event will remove it. Any ideas?

Fizzlemizz

04-25-17 01:16 AM

This is what I pointed out previously, in edit admittedly so you may have missed it.

One idea.
Keep a table of buttons as they are created (no pre-determined, fixed table needed), hide them all at the start of the event and only show the ones that actually have a count on any given pass.

One idea, there may be better and it probably need refining.

Dejablue

04-25-17 01:39 AM

Quote:

Originally Posted by Fizzlemizz (Post 323055)

Cool idea. I'll play with that and see what I come up with. Thanks :)

Fizzlemizz

04-25-17 01:41 AM

This should handle hiding/showing (admitedly untested), collapsing/expanding would still have to be handled:

Lua Code:

--Beam Me Up Deja Initialization Frame
    
local Ecount
local Rcount
local Ucount
local Tally
 
local BeamMeUpDejaInitFrame = CreateFrame("Frame", "BeamMeUpDejaInitFrame", BeamMeUpDejaDragFrame)
    BeamMeUpDejaInitFrame.Beacons = ()
    BeamMeUpDejaInitFrame:RegisterEvent("PLAYER_LOGIN")
    BeamMeUpDejaInitFrame:RegisterEvent("PLAYER_REGEN_ENABLED")
    BeamMeUpDejaInitFrame:RegisterEvent("LOOT_OPENED")
    BeamMeUpDejaInitFrame:RegisterEvent("BAG_UPDATE")
    
    BeamMeUpDejaInitFrame:SetScript("OnEvent", function(self, event, ...)
        for k,v in pairs(self.Beacons) do
            v:Hide()
        end
        Ecount = 0
        Rcount = 0
        Ucount = 0  
        Tally = 0
        for bag = 0, 4, 1 do 
            for slot=1, GetContainerNumSlots(bag), 1 do 
                local name = GetContainerItemLink(bag,slot)
                if name and string.find(name,"Sentinax Beacon") then
--              if name and string.find(name,"Hearthstone") then
                    --ddebug()
                    local _, itemCount = GetContainerItemInfo(bag, slot)
                    Tally = Tally + itemCount
                    local itemName, itemLink, itemRarity,_,_,_,_,itemStackCount,_,itemTexture,_ = GetItemInfo(name)
                        --print(name, itemName,itemStackCount)--Debugging
                    local texture = select(10,GetItemInfo(name))
                    local w = 36
                    local h = 36
                    local x
                    local y = 0
                    if itemRarity == 4 then
                        --print("Ecount is "..Ecount)--Debugging
                        x = (Ecount*w)*1.1
                        y = h*2.1
                        Ecount = Ecount+1
                    end
                    if itemRarity == 3 then
                        --print("Rcount is "..Rcount)--Debugging
                        x = (Rcount*w)*1.1
                        y = h*1.1
                        Rcount = Rcount+1
                    end
                    if itemRarity == 2 then
                        --print("Ucount is "..Ucount)--Debugging
                        x = (Ucount*w)*1.1
                        Ucount = Ucount+1
                    end
                    local BMUDButton
                    if not _G["BMUDButton"..name] then -- Button does not exist so create it
                        BMUDButton = CreateFrame("Button", "BMUDButton"..name, UIParent, "SecureActionButtonTemplate");
                        self.Beacons["BMUDButton"..name] = BMUDButton
                        BMUDButton.Label = BMUDButton:CreateFontString("$parent_FontString","OVERLAY")
                        BMUDButton:RegisterForClicks("AnyUp", "AnyDown")
                        BMUDButton:SetPoint("CENTER",x,y+32)
                        BMUDButton:SetSize(w,h)
                        BMUDButton.Label:SetPoint("BOTTOMRIGHT", BMUDButton)
                        BMUDButton.Label:SetFont("Fonts\\FRIZQT__.TTF", 14, "THINOUTLINE")
                        BMUDButton.Label:SetTextColor(1, 1, 1);
                        BMUDButton:SetAttribute("type","item")
                        BMUDButton:SetAttribute("item",itemName)
                        BMUDButton:HookScript("OnEnter", function(self)
                                GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
                                GameTooltip:SetHyperlink(name)
                                GameTooltip:Show()
                            end)
                        BMUDButton:HookScript("OnLeave", function(self) GameTooltip:Hide() end)
                    else -- Button exists so reset to default state
                        BMUDButton = _G["BMUDButton"..name]
                        BMUDButton:SetNormalTexture(nil,"ARTWORK")
                        BMUDButton:SetPushedTexture(nil,"ARTWORK")
                        BMUDButton:SetHighlightTexture(nil,"ARTWORK")
                        BMUDButton.Label:SetFormattedText("")
 
                    end
                    if event == "BAG_UPDATE" then -- only set textures and text for this event
                        BMUDButton.Label:SetFormattedText("%.0f", Tally)
                        BMUDButton:SetNormalTexture(itemTexture)
                        BMUDButton:SetPushedTexture(itemTexture)
                        BMUDButton:SetHighlightTexture(itemTexture)
                        BMUDButton:Show()
                        print("Bag Updated", name, BMUDButton.Label:GetText())
                    else
                        print("Other event", event, name)
                    end
                end
            end 
        end
    end)

There is now code that is surplus to requirements ;)

syncrow

04-25-17 01:48 AM

you could use "ContainerFrameItemButtonTemplate" instead of "SecureActionButtonTemplate".

pros:

clickability to use items
non secure (prevents taint)
can handle show / hide / positioning even while in combat

cons:

you have to create a header for each button (but thats fairly easy to achieve)

Edit: I'm going to prepare some code and explanation for you later... currently at work!^^

Dejablue

04-25-17 02:27 AM

Quote:

Originally Posted by syncrow (Post 323058)

you could use "ContainerFrameItemButtonTemplate" instead of "SecureActionButtonTemplate".

pros:

clickability to use items
non secure (prevents taint)
can handle show / hide / positioning even while in combat

cons:

you have to create a header for each button (but thats fairly easy to achieve)

Edit: I'm going to prepare some code and explanation for you later... currently at work!^^

Thank you so much ;) I look forward to it. Gonna play with ContainerFrameItemButtonTemplate for a while see what i can see. Maybe combine that with table.insert as buttons are created as per Fizzlemizz's suggestion, so we make tables like you suggested, and we may have something.

Cheers!

syncrow

04-25-17 01:35 PM

ok here is the code: (everything is tested, and should be properly debugged)

Lua Code:

local buttonSize = 36;
local padding = 2;
local perRow = 6;
 
local function CreateButton(parent)
    local button = CreateFrame("Frame", nil, parent)
    local index = #parent.beacons + 1 or 1
    
    button:SetSize(buttonSize, buttonSize);
    button.access = {}
    
    button.slot = CreateFrame("Button", nil, button, "ContainerFrameItemButtonTemplate")
    button.slot:SetSize(buttonSize, buttonSize)
    button.slot:SetPoint("CENTER")
    button.slot:SetScript("OnEnter", function()
        local bag = button:GetID()
        local slot = button.slot:GetID()
        
        GameTooltip:SetOwner(button, "ANCHOR_CURSOR")
        GameTooltip:SetBagItem(bag, slot);
        GameTooltip:Show()
    end)
    button.slot:SetScript("OnLeave", GameTooltip_Hide)
    button.slot:Show()
    
    button.slot.icon:SetTexCoord(0.075, 0.925, 0.075, 0.925);
    button.slot.BattlepayItemTexture:Hide()
    
    return button
end
 
local function UpdateButton(button)
 
    -- no access found: reset button
    if #button.access == 0 then
        button:Hide()
        button.slot.Count:SetText("")
        button.slot:SetNormalTexture("")
        return
    end
 
    local totalCount = 0;
    local texture, bagID, slotID;
    
    for info, values in pairs(button.access) do
        local bag, slot = unpack(values)
        local icon, count = GetContainerItemInfo(bag, slot)
        
        if count then
            totalCount = totalCount + count
        end
        
        -- get the first possible identification for access later
        if not bagID or not slotID or not tex then
            texture = icon
            bagID = bag
            slotID = slot
        end
    end
    
    -- we do not need to show a count there is only 1 item existing
    if totalCount == 1 then
        totalCount = ""
    end
 
    -- update count & texture
    button.slot.Count:SetText(totalCount)
    button.slot.icon:SetTexture(texture)
        
    -- update access
    button:SetID(bagID)
    button.slot:SetID(slotID)
    button:Show()
end
 
local function ResetButtons(self)
    local table = self.beacons
    
    for _, button in pairs(table) do
        button:Hide();
        button.access = {}
    end
end
 
local function CacheAccess(self)
    local table = self.beacons
    
    for bag = 0, 4 do
        for slot = 1, GetContainerNumSlots(bag) do
            local itemID = GetContainerItemID(bag, slot)
            
            if itemID then
                local name = GetItemInfo(itemID)
                
                -- beacon found!!!
                if name and name:find("Sentinax Beacon") then
                    local button = table[name]
                    
                    -- no button found: create it
                    if not button then
                        button = CreateButton(self)
                        table[name] = button
                    end
                    
                    -- store access
                    if button then
                        tinsert(button.access, {bag, slot})
                    end
                end
            end
        end
    end
end
 
local function UpdateAllButtons(self)
    local table = self.beacons
    local index = 1;
    
    for _, button in pairs(table) do
        if button then
            UpdateButton(button)
            
            if button:IsShown() then
                local row = math.ceil( index / perRow)
                local col = (index-1) % perRow + 1
                local x = (buttonSize * (col-1) ) + ( padding * (col-1) )
                local y = (buttonSize * (row-1) ) + ( padding * (row-1) )
                
                button:SetPoint("TOPLEFT", self, 0 + x, 0 - y)
                
                index = index + 1
            end
        end
    end
end
 
local function UpdateFrameSize(self)
    local table = self.beacons
    local width, height, numRows, numCols
    local shownBtns = 0
    
    for _, button in pairs(table) do
        if button:IsShown() then
            shownBtns = shownBtns + 1
        end
    end
    
    numRows = math.ceil( shownBtns / perRow )
    numCols = (shownBtns < perRow) and shownBtns or perRow
    width = (buttonSize * numCols) + (padding * (numCols - 1) )
    height = numRows * buttonSize + (padding * (numRows - 1) )
    
    self:SetSize(width, height)
end
 
local frame = CreateFrame("Frame", "BeamMeUpDejaInitFrame", UIParent)
 
frame.beacons = {}
frame:SetPoint("CENTER");
frame:RegisterEvent("PLAYER_LOGIN")
frame:SetScript("OnEvent", function(self, event, ...)
    if event == "PLAYER_LOGIN" then
        self:RegisterEvent("BAG_UPDATE")
        
        -- pre call the event for initialization
        ResetButtons(self)
        CacheAccess(self)
        UpdateAllButtons(self)
        UpdateFrameSize(self)
        
        return
    end
 
    ResetButtons(self)
    CacheAccess(self)
    UpdateAllButtons(self)
    UpdateFrameSize(self)
end)

Note:
- Buttons are ordered from left to right, and from top to bottom
(can be changed on line 129 - switch math operators for x / y)

Dejablue

04-26-17 09:04 AM

Quote:

Originally Posted by syncrow (Post 323071)

ok here is the code: (everything is tested, and should be properly debugged)

Lua Code:

local buttonSize = 36;
local padding = 2;
local perRow = 6;
 
local function CreateButton(parent)
    local button = CreateFrame("Frame", nil, parent)
    local index = #parent.beacons + 1 or 1
    
    button:SetSize(buttonSize, buttonSize);
    button.access = {}
    
    button.slot = CreateFrame("Button", nil, button, "ContainerFrameItemButtonTemplate")
    button.slot:SetSize(buttonSize, buttonSize)
    button.slot:SetPoint("CENTER")
    button.slot:SetScript("OnEnter", function()
        local bag = button:GetID()
        local slot = button.slot:GetID()
        
        GameTooltip:SetOwner(button, "ANCHOR_CURSOR")
        GameTooltip:SetBagItem(bag, slot);
        GameTooltip:Show()
    end)
    button.slot:SetScript("OnLeave", GameTooltip_Hide)
    button.slot:Show()
    
    button.slot.icon:SetTexCoord(0.075, 0.925, 0.075, 0.925);
    button.slot.BattlepayItemTexture:Hide()
    
    return button
end
 
local function UpdateButton(button)
 
    -- no access found: reset button
    if #button.access == 0 then
        button:Hide()
        button.slot.Count:SetText("")
        button.slot:SetNormalTexture("")
        return
    end
 
    local totalCount = 0;
    local texture, bagID, slotID;
    
    for info, values in pairs(button.access) do
        local bag, slot = unpack(values)
        local icon, count = GetContainerItemInfo(bag, slot)
        
        if count then
            totalCount = totalCount + count
        end
        
        -- get the first possible identification for access later
        if not bagID or not slotID or not tex then
            texture = icon
            bagID = bag
            slotID = slot
        end
    end
    
    -- we do not need to show a count there is only 1 item existing
    if totalCount == 1 then
        totalCount = ""
    end
 
    -- update count & texture
    button.slot.Count:SetText(totalCount)
    button.slot.icon:SetTexture(texture)
        
    -- update access
    button:SetID(bagID)
    button.slot:SetID(slotID)
    button:Show()
end
 
local function ResetButtons(self)
    local table = self.beacons
    
    for _, button in pairs(table) do
        button:Hide();
        button.access = {}
    end
end
 
local function CacheAccess(self)
    local table = self.beacons
    
    for bag = 0, 4 do
        for slot = 1, GetContainerNumSlots(bag) do
            local itemID = GetContainerItemID(bag, slot)
            
            if itemID then
                local name = GetItemInfo(itemID)
                
                -- beacon found!!!
                if name and name:find("Sentinax Beacon") then
                    local button = table[name]
                    
                    -- no button found: create it
                    if not button then
                        button = CreateButton(self)
                        table[name] = button
                    end
                    
                    -- store access
                    if button then
                        tinsert(button.access, {bag, slot})
                    end
                end
            end
        end
    end
end
 
local function UpdateAllButtons(self)
    local table = self.beacons
    local index = 1;
    
    for _, button in pairs(table) do
        if button then
            UpdateButton(button)
            
            if button:IsShown() then
                local row = math.ceil( index / perRow)
                local col = (index-1) % perRow + 1
                local x = (buttonSize * (col-1) ) + ( padding * (col-1) )
                local y = (buttonSize * (row-1) ) + ( padding * (row-1) )
                
                button:SetPoint("TOPLEFT", self, 0 + x, 0 - y)
                
                index = index + 1
            end
        end
    end
end
 
local function UpdateFrameSize(self)
    local table = self.beacons
    local width, height, numRows, numCols
    local shownBtns = 0
    
    for _, button in pairs(table) do
        if button:IsShown() then
            shownBtns = shownBtns + 1
        end
    end
    
    numRows = math.ceil( shownBtns / perRow )
    numCols = (shownBtns < perRow) and shownBtns or perRow
    width = (buttonSize * numCols) + (padding * (numCols - 1) )
    height = numRows * buttonSize + (padding * (numRows - 1) )
    
    self:SetSize(width, height)
end
 
local frame = CreateFrame("Frame", "BeamMeUpDejaInitFrame", UIParent)
 
frame.beacons = {}
frame:SetPoint("CENTER");
frame:RegisterEvent("PLAYER_LOGIN")
frame:SetScript("OnEvent", function(self, event, ...)
    if event == "PLAYER_LOGIN" then
        self:RegisterEvent("BAG_UPDATE")
        
        -- pre call the event for initialization
        ResetButtons(self)
        CacheAccess(self)
        UpdateAllButtons(self)
        UpdateFrameSize(self)
        
        return
    end
 
    ResetButtons(self)
    CacheAccess(self)
    UpdateAllButtons(self)
    UpdateFrameSize(self)
end)

Note:
- Buttons are ordered from left to right, and from top to bottom
(can be changed on line 129 - switch math operators for x / y)

Thanks Syn. I added you and Fizz as contributors and pushed it out to release. Found a couple bugs since. Text still doesn't update, but much headway has been made. Thank you for all of your help. Feel free to reply here or on Curse or PM me here or on Curse if you have suggestions, fixes, questions, etc. This is far from over, only just beginning.

https://mods.curse.com/addons/wow/265345-beammeupdeja

Cheers!

jeruku

04-26-17 03:39 PM

For this particular use, since you are scanning the bag anyway, I would recommend using the event BAG_UPDATE_DELAYED instead of BAG_UPDATE.

Dejablue

04-27-17 12:12 AM

Quote:

Originally Posted by jeruku (Post 323097)

For this particular use, since you are scanning the bag anyway, I would recommend using the event BAG_UPDATE_DELAYED instead of BAG_UPDATE.

Yeah, good call. I'll have to play with the events when I get a chance. Thanks :)

Kakjens

04-27-17 02:21 AM

Quote:

Originally Posted by syncrow (Post 323071)

ok here is the code: (everything is tested, and should be properly debugged)

Lua Code:

local buttonSize = 36;
local padding = 2;
local perRow = 6;
 
local function CreateButton(parent)
    local button = CreateFrame("Frame", nil, parent)
    local index = #parent.beacons + 1 or 1
    
    button:SetSize(buttonSize, buttonSize);
    button.access = {}
    
    button.slot = CreateFrame("Button", nil, button, "ContainerFrameItemButtonTemplate")
    button.slot:SetSize(buttonSize, buttonSize)
    button.slot:SetPoint("CENTER")
    button.slot:SetScript("OnEnter", function()
        local bag = button:GetID()
        local slot = button.slot:GetID()
        
        GameTooltip:SetOwner(button, "ANCHOR_CURSOR")
        GameTooltip:SetBagItem(bag, slot);
        GameTooltip:Show()
    end)
    button.slot:SetScript("OnLeave", GameTooltip_Hide)
    button.slot:Show()
    
    button.slot.icon:SetTexCoord(0.075, 0.925, 0.075, 0.925);
    button.slot.BattlepayItemTexture:Hide()
    
    return button
end
 
local function UpdateButton(button)
 
    -- no access found: reset button
    if #button.access == 0 then
        button:Hide()
        button.slot.Count:SetText("")
        button.slot:SetNormalTexture("")
        return
    end
 
    local totalCount = 0;
    local texture, bagID, slotID;
    
    for info, values in pairs(button.access) do
        local bag, slot = unpack(values)
        local icon, count = GetContainerItemInfo(bag, slot)
        
        if count then
            totalCount = totalCount + count
        end
        
        -- get the first possible identification for access later
        if not bagID or not slotID or not tex then
            texture = icon
            bagID = bag
            slotID = slot
        end
    end
    
    -- we do not need to show a count there is only 1 item existing
    if totalCount == 1 then
        totalCount = ""
    end
 
    -- update count & texture
    button.slot.Count:SetText(totalCount)
    button.slot.icon:SetTexture(texture)
        
    -- update access
    button:SetID(bagID)
    button.slot:SetID(slotID)
    button:Show()
end
 
local function ResetButtons(self)
    local table = self.beacons
    
    for _, button in pairs(table) do
        button:Hide();
        button.access = {}
    end
end
 
local function CacheAccess(self)
    local table = self.beacons
    
    for bag = 0, 4 do
        for slot = 1, GetContainerNumSlots(bag) do
            local itemID = GetContainerItemID(bag, slot)
            
            if itemID then
                local name = GetItemInfo(itemID)
                
                -- beacon found!!!
                if name and name:find("Sentinax Beacon") then
                    local button = table[name]
                    
                    -- no button found: create it
                    if not button then
                        button = CreateButton(self)
                        table[name] = button
                    end
                    
                    -- store access
                    if button then
                        tinsert(button.access, {bag, slot})
                    end
                end
            end
        end
    end
end
 
local function UpdateAllButtons(self)
    local table = self.beacons
    local index = 1;
    
    for _, button in pairs(table) do
        if button then
            UpdateButton(button)
            
            if button:IsShown() then
                local row = math.ceil( index / perRow)
                local col = (index-1) % perRow + 1
                local x = (buttonSize * (col-1) ) + ( padding * (col-1) )
                local y = (buttonSize * (row-1) ) + ( padding * (row-1) )
                
                button:SetPoint("TOPLEFT", self, 0 + x, 0 - y)
                
                index = index + 1
            end
        end
    end
end
 
local function UpdateFrameSize(self)
    local table = self.beacons
    local width, height, numRows, numCols
    local shownBtns = 0
    
    for _, button in pairs(table) do
        if button:IsShown() then
            shownBtns = shownBtns + 1
        end
    end
    
    numRows = math.ceil( shownBtns / perRow )
    numCols = (shownBtns < perRow) and shownBtns or perRow
    width = (buttonSize * numCols) + (padding * (numCols - 1) )
    height = numRows * buttonSize + (padding * (numRows - 1) )
    
    self:SetSize(width, height)
end
 
local frame = CreateFrame("Frame", "BeamMeUpDejaInitFrame", UIParent)
 
frame.beacons = {}
frame:SetPoint("CENTER");
frame:RegisterEvent("PLAYER_LOGIN")
frame:SetScript("OnEvent", function(self, event, ...)
    if event == "PLAYER_LOGIN" then
        self:RegisterEvent("BAG_UPDATE")
        
        -- pre call the event for initialization
        ResetButtons(self)
        CacheAccess(self)
        UpdateAllButtons(self)
        UpdateFrameSize(self)
        
        return
    end
 
    ResetButtons(self)
    CacheAccess(self)
    UpdateAllButtons(self)
    UpdateFrameSize(self)
end)

Note:
- Buttons are ordered from left to right, and from top to bottom
(can be changed on line 129 - switch math operators for x / y)

Didn't test in-game but seems like creation of button.slot.Count after line 27 is missing.

syncrow

04-27-17 02:27 AM

Quote:

Originally Posted by Kakjens (Post 323105)

Didn't test in-game but seems like creation of button.slot.Count after line 27 is missing.

button.slot inherits from "ContainerFrameItemButtonTemplate" which inherits from "ItemButtonTemplate" that has the childkey .Count as a font string

Edit:
@Deja, i would also recomment, using my code seperately instead of calling it inside a OnEvent function, the created frame was simply renamed by me but should be used as your initFrame...

Kakjens

04-27-17 02:34 AM

Thanks, after posting thought something similar, and found in ItemButtonTemplate.xml that it's indeed defined.

syncrow

04-27-17 02:50 AM

I'm going to hard test the complete addon on Friday.

Should I upload a new beta version on curse once debugged and changes made?

Dejablue

04-27-17 03:10 AM

Quote:

Originally Posted by syncrow (Post 323108)

I'm going to hard test the complete addon on Friday.

Should I upload a new beta version on curse once debugged and changes made?

Sure I will give you access.

Kakjens

04-27-17 11:24 AM

In line 54 probably a typo: instead of variable "texture" non-existant "tex" was used.
Removed external BeamMeUpDejaInitFrame. Don't know why but for item count updates to work, had to use CreateFontString in CreateButton.
Modified version sent to Deja.
Probably there's still much to fix/improve.

syncrow

04-27-17 01:12 PM

Begun fixing the beacon bar part:

Count display (fixed)
Disabled "LeftClick" to prevent some annoying ContainerFrameItemButtonTemplate stuff working (we only want the click to use part here)
Beacons are now sorted based on Quality > Count > Name
Merged some functions together to make the code cleaner

By the way, searching for names rather than using predefined itemIDs like mentions in my first solution, will be an issue for non english clients
Except we want to handle each localization manually...

Dejablue

04-27-17 11:01 PM

Quote:

Originally Posted by syncrow (Post 323116)

Begun fixing the beacon bar part:

Count display (fixed)
Disabled "LeftClick" to prevent some annoying ContainerFrameItemButtonTemplate stuff working (we only want the click to use part here)
Beacons are now sorted based on Quality > Count > Name
Merged some functions together to make the code cleaner

For localization we will ahve to do something like:

Code:

if name and name:find("Sentinax Beacon" or "Netherchunck") then

We also need to query other items, like nether shards and boss summon stones. This is going to require tables... bleh.

As for localization, we could simply search for local names, making our list, ostensibly, smaller, adding them to the table for Chinese, Russian, Portuguese, etc.

But you are correct that we wont have to worry about localization if we use item IDs.

syncrow

04-27-17 11:47 PM

Quote:

Originally Posted by Dejablue (Post 323122)

For localization we will ahve to do something like:

Code:

if name and name:find("Sentinax Beacon" or "Netherchunck") then

tracking nethershards and legion fall resources is quite easy:
simply loop through the currency list and get your information

I don't know what really speaks against a table that we want to use for tracking
- localization friendly
- can be maintained updated super easily by just adding / removing itemIDs
- we can throw updates without touching anything besides the itemID table for new items to track...

Dejablue

04-28-17 01:15 AM

Quote:

Originally Posted by syncrow (Post 323123)

Correct. I had not considered localizations. We should change to a table with the items we wish to track as you originally suggested. As for what speaks against a table; reduced/no maintenance in the future should Blizzard change things (like create Sentinax Beacon of the Murloc) we won't have to add it specifically, name search will add it which is particularly beneficial if none of us are playing the game and keeping up with it. My original goal was to execute this with string search functions, for the sake of it. It is doable, but with localization concerns I don't think it is worth it, especially if we simply make a list of localized strings to look for.

So the project went from looking for three names to looking for 33 names across 11 locales.

May as well just look for IDs instead.

syncrow

04-28-17 03:22 AM

Deja,

how do you want the beacon bar to be displayed exactly?

each quality in a seperate row?
dynamic with a specific sorting?
something else maybe

[Rare Beacons]
[Uncommen Beacons]
[Other Items]

Static layout:
[X][X][X][X][X][X][X][X][X]
[X][X][X][X][X][X]
[X][X][X]

dynamic: (#15 - live)
[X][X][X][X][X][X]
[X][X][X][X][X][X]
[X][X][X][X][X][X]

mixed 1:
[X][X][X][X][X][X]
[X][X][X][X][X][X]
[X][X][X][X][X][X]

mixed 2:
[X][X][X][X][X]
[X][X][X][X][X]
[X][X][X][X][X]
[X][X][X]

Kakjens

04-28-17 09:33 AM

I think ability to detect new Sentinax Beacons is interesting. Requirement to localize the search string - not so much. Therefore maybe some fuzzy detector whether or not this item is Sentinax Beacon can be written. Using currently known Sentinax Beacons a common string with maximal length could be calculated and used for searching.
Previously thought of more exotic ways of creation of the search string but currently think this is more or less plausible compared to others.

syncrow

04-28-17 09:45 AM

broken shore stuff would be a thing till 7.3 then everything will to argus, so could bet that no new beacon or any new broken shore grind related item will be added after 7.2.5 launch

and even when...add 2 spellIDs throw update, fix and everything is happy.
You simply cant prevent addons to be updated from time to time, but that is just my standpoint

Kakjens

04-28-17 11:16 AM

Indeed, in this specific example creation of search string through combinatorics is overkill. I was just surprised by possibility of automation of creation of feature extractor, as an input using few items.
But really, adding of few itemIDs after discovery of the new elusive Sentinax Beacons would be much easier.

Dejablue

04-28-17 12:31 PM

I want the layout to be static rarity rows that are dynamically created, i.e. collapse as created for each rarity per row.

[X][X][X] -- Netherchunk and Zone portals(see below)
[X][X] -- Epic
[X][X] -- Crafting Rare
[X][X][X][X] -- Rare
[X][X][X][X][X][X] -- Uncommon

__________________________________________

Netherchunk and Zone portals(see below)

Epic:
[146921] = "", -- Illisthyndria
[146920] = "", -- Fel Obliterator
[146919] = "", -- An'thyna:An'thyna
[146918] = "", -- Force-Commander Xillious
[146917] = "", -- Skulguloth
[146916] = "", -- Than'otalion

Crafting Rare:
[147355] = "", -- bloodstrike
[146923] = "", -- petrification
[146922] = "", -- fel growth

Rare:
[146915] = "", -- greater torment
[146914] = "", -- greater engineering
[146913] = "", -- greater warbeasts
[146912] = "", -- greater carnage
[146911] = "", -- greater firestorm
[146910] = "", -- greater dominance

Uncommon:
[146909] = "", -- torment
[146908] = "", -- engineering
[146907] = "", -- warbeasts
[146906] = "", -- carnage
[146905] = "", -- firestorm
[146903] = "", -- dominance
_____________________

Zone portals are rare(IIRC they are Epic). They open a portal in a zone, like Skyhorn in Highmountain. You go there, click it and a portal opens with aq miniboss. You kill it and loot exactly 300 Nethershards. I have had 2 drop, went and did them, but have not seen any since. Others can help you kill the boss but they do not get loot AFAIK. That being said, I forget what their name is and my google/WoWHead - fu has failed me to bring up their names.

At any rate, the very top row should be consumable you want to use right away, like Netherchunk and these zone portals.

Dejablue

05-01-17 08:06 AM

Hey Syncrow, any progress? If you are crunched for time, I can work on rewriting for tables, I just need help figuring out resetting the text.

Cheers!

syncrow

05-05-17 07:27 AM

Pretty much no time these days, sry

Dejablue

05-05-17 12:13 PM

Quote:

Originally Posted by syncrow (Post 323235)

Pretty much no time these days, sry

We worked it out man, np. I would have liked to have seen your solutions. Feel free to pop in with any suggestions or PM me.

Here is the project on WoWInterface and on Curse in case you missed it.

Cheers!

All times are GMT -6. The time now is 01:52 PM.