WoWInterface - Item Link Macros

Page 1 of 2

Show 60 post(s) from this thread on one page

WoWInterface (https://www.wowinterface.com/forums/index.php)

- AddOn Search/Requests (https://www.wowinterface.com/forums/forumdisplay.php?f=6)

- - Item Link Macros (https://www.wowinterface.com/forums/showthread.php?t=45297)

Tonyleila

11-29-12 07:33 AM

Item Link Macros

ItemLinkMacros

Quote:

ItemLinkMacros is an addon which allows you to add item links into your macros simply by Shift-LClicking an item link while the macro window is open.

The macro link part of this addon is still working fine BUT since 5.1 it blocks Shift klicking items to search them inside profession windows. Can anyone tell me how to fix this please?

Lua Code:

local _G = getfenv(0)
--stack references for globals
local GetItemInfo = _G.GetItemInfo
local GetItemSpell = _G.GetItemSpell
 
local strfind = _G.strfind
------- Replacing the ChatEdit_InsertLink function
local oldFunction = ChatEdit_InsertLink
 
ChatEdit_InsertLink = function(text)
   if ( not text ) then
      return false;
   end
   local activeWindow = ChatEdit_GetActiveWindow();
   if ( activeWindow ) then
      activeWindow:Insert(text);
      return true;
   end
   if ( BrowseName and BrowseName:IsVisible() ) then
      local item;
      if ( strfind(text, "item:", 1, true) ) then
         item = GetItemInfo(text);
      end
      if ( item ) then
         BrowseName:SetText(item);
         return true;
      end
   end
   if ( MacroFrameText and MacroFrameText:IsVisible() ) then
      local macroText = MacroFrameText:GetText();
      
      local item;
      if ( strfind(text, "item:", 1, true) ) then
         item = GetItemInfo(text);
      end
      -- my check for whether this is a spell or "other" link is kinda bad.  I could improve it with a Regex, but I doubt there will be many problems
      local spellLink = strfind(text, "|Hspell:", 1, true)
      
      local enchantLink = strfind(text, "|Henchant:", 1, true)
      local achievementLink = strfind(text, "|Hachievement:", 1, true)
      local talentLink = strfind(text, "|Htalent:", 1, true)
      local otherLink = enchantLink or achievementLink or talentLink
      
      if ( not otherLink and macroText == "" and not item ) then
         MacroFrameText:Insert(SLASH_CAST1.." "..text);
      elseif ( not otherLink and not spellLink and ( strfind(macroText, SLASH_USE1, 1, true) or strfind(macroText, SLASH_EQUIP1, 1, true) or strfind(macroText, SLASH_CAST1, 1, true) ) ) then
         MacroFrameText:Insert(item or text);
      else
         MacroFrameText:Insert(text);
      end
      return true;
   end
   return false;
end
SLASH_ADDTEXT1="/addtext"
SlashCmdList["ADDTEXT"] = function(text)
   if ( MacroFrameText and MacroFrameText:IsVisible() ) then
      MacroFrameText:Insert(text)
   end
end

Vlad	11-29-12 09:02 AM

Just beware that changing the global function ChatEdit_InsertLink will taint and break any secure code used by the chat and such, so if chat related stuff start to stop working, keep this in mind. :D

SDPhantom

11-29-12 10:59 AM

You're missing this block of code that should be after the MacroFrameText check.

Lua Code:

if ( TradeSkillFrame and TradeSkillFrame:IsShown() )  then
    local item;
    if ( strfind(text, "item:", 1, true) ) then
        item = GetItemInfo(text);
    end
    if ( item ) then
        TradeSkillFrameSearchBox:SetFontObject("ChatFontSmall");
        TradeSkillFrameSearchBoxSearchIcon:SetVertexColor(1.0, 1.0, 1.0);
        TradeSkillFrameSearchBox:SetText(item);
        return true;
    end
end

Tonyleila

11-29-12 06:01 PM

Quote:

Originally Posted by SDPhantom (Post 269796)

You're missing this block of code that should be after the...

Thanks for the code works fine now! :)
I'll send the code to author so he can update it ;)

SDPhantom

11-30-12 06:12 PM

That came out of the last half of the function the author copied from and modified the macro handling of. He just missed including it in his code.

natassja72

12-01-12 01:07 PM

Untill it gets updated, if at all, would it be possible to put here all code, including the fix? I don't want to mess things up myself...

Tonyleila

12-01-12 05:23 PM

Quote:

Originally Posted by natassja72 (Post 269988)

Untill it gets updated, if at all, would it be possible to put here all code, including the fix? I don't want to mess things up myself...

http://www.wowinterface.com/download...FanUpdate.html

natassja72

12-02-12 02:31 PM

Thanks! Advertising now is made easy:))

Tonyleila

06-05-13 01:43 PM

I just found out that my ItemLinkMacrosFanUpdate needs a fix. Can someone please help me with it?

For some reason it blocks to copy pet cages names into the auction house window. I can't copy the name from a petcage in my bag into the AH and not from the chat into AH.

Lua Code:

local _G = getfenv(0)
    --stack references for globals
    local GetItemInfo = _G.GetItemInfo
    local GetItemSpell = _G.GetItemSpell
     
    local strfind = _G.strfind
    ------- Replacing the ChatEdit_InsertLink function
    local oldFunction = ChatEdit_InsertLink
     
    ChatEdit_InsertLink = function(text)
       if ( not text ) then
          return false;
       end
       local activeWindow = ChatEdit_GetActiveWindow();
       if ( activeWindow ) then
          activeWindow:Insert(text);
          return true;
       end
       if ( BrowseName and BrowseName:IsVisible() ) then
          local item;
          if ( strfind(text, "item:", 1, true) ) then
             item = GetItemInfo(text);
          end
          if ( item ) then
             BrowseName:SetText(item);
             return true;
          end
       end
           if ( TradeSkillFrame and TradeSkillFrame:IsShown() )  then
        local item;
        if ( strfind(text, "item:", 1, true) ) then
            item = GetItemInfo(text);
        end
        if ( item ) then
            TradeSkillFrameSearchBox:SetFontObject("ChatFontSmall");
            TradeSkillFrameSearchBoxSearchIcon:SetVertexColor(1.0, 1.0, 1.0);
            TradeSkillFrameSearchBox:SetText(item);
            return true;
        end
    end
       if ( MacroFrameText and MacroFrameText:IsVisible() ) then
          local macroText = MacroFrameText:GetText();
         
          local item;
          if ( strfind(text, "item:", 1, true) ) then
             item = GetItemInfo(text);
          end
          -- my check for whether this is a spell or "other" link is kinda bad.  I could improve it with a Regex, but I doubt there will be many problems
          local spellLink = strfind(text, "|Hspell:", 1, true)
         
          local enchantLink = strfind(text, "|Henchant:", 1, true)
          local achievementLink = strfind(text, "|Hachievement:", 1, true)
          local talentLink = strfind(text, "|Htalent:", 1, true)
          local otherLink = enchantLink or achievementLink or talentLink
         
          if ( not otherLink and macroText == "" and not item ) then
             MacroFrameText:Insert(SLASH_CAST1.." "..text);
          elseif ( not otherLink and not spellLink and ( strfind(macroText, SLASH_USE1, 1, true) or strfind(macroText, SLASH_EQUIP1, 1, true) or strfind(macroText, SLASH_CAST1, 1, true) ) ) then
             MacroFrameText:Insert(item or text);
          else
             MacroFrameText:Insert(text);
          end
          return true;
       end
       return false;
    end
    SLASH_ADDTEXT1="/addtext"
    SlashCmdList["ADDTEXT"] = function(text)
       if ( MacroFrameText and MacroFrameText:IsVisible() ) then
          MacroFrameText:Insert(text)
       end
    end

Phanx

06-05-13 03:15 PM

Pre-hooking ChatEdit_InsertLink is a bad idea, as it will cause taint, and your particular hook is especially bad since you completely replicate the original function instead of just calling it -- so any time Blizzard changes the function, you either have to update your addon immediately, or you're breaking default UI functionality for your users.

You should use a secure post-hook instead:

Code:

hooksecurefunc("ChatEdit_InsertLink", function(link)

    if MyEditBox:IsVisible() and MyEditBox:HasFocus() then

        MyEditBox:Insert(link)

    end

end)

On a side note, upvaluing _G and then upvaluing _G.GetSpellInfo confers no benefit over just upvaluing GetSpellInfo directly -- and for code that only runs when the user shift-clicks a link in chat, there's no benefit in upvaluing anything at all. Just get rid of that clutter and make your code more readable.

p3lim

06-05-13 03:43 PM

It's not his code though Phanx, he just wanted to apply a patch to it.

Phanx

06-05-13 03:53 PM

Doesn't matter who wrote it. The problems are still the same. :p

Tonyleila

06-05-13 05:11 PM

Yep its not my code and thats why I don't know now what to do with the fix you posted my lua knowledge is more like "copy-past" or edit only :D
However I understand that the addon maybe needs a rewrite but I don't know how...

Phanx

06-05-13 07:15 PM

Based on the addon's description and code, it looks like the only thing it does is put the raw item link into the macro instead of just the item's name. Accordingly, the following code should work (for all link types, even). After the original ChatEdit_InsertLink function has run, it will check if the macro edit box has focus. If so, it will check if the macro already contains the link name. If not, it will insert the raw link.

This should work, because if the original function would handle the link (eg. shift-clicking a spell for a /cast command) then once your function runs, the edit box will already contain the link name (eg. the name of the spell).

Code:

hooksecurefunc("ChatEdit_InsertLink", function(link)

        if MacroFrameText and MacroFrameText:HasFocus() then

                local text = MacroFrameText:GetText()

                local name = strmatch(link, "%[(.-)%]")

                if not strfind(text, name, 1, true) then

                        MacroFrameText:Insert(link)

                end

        end

end)

If you really only want it to work for links, change it accordingly:

Code:

if MacroFrameText and MacroFrameText:HasFocus() and strfind(link, "|Hitem:", 1, true) then

p3lim

06-05-13 07:22 PM

The whole point of the addon is to have item links instead of item names, thus you'd have to match and replace.

Edit: You'd also have to make sure it only works when not combined with /equip or the like, and aswell when replacing that you don't exceed the character cap of macros.

p3lim

06-05-13 07:35 PM

This should do the job

Lua Code:

local commands = {
    [string.gsub(SLASH_CAST1, '/', '')] = true,
    [string.gsub(SLASH_EQUIP1, '/', '')] = true,
    [string.gsub(SLASH_USE1, '/', '')] = true,
    ['cast'] = true,
    ['equip'] = true,
    ['use'] = true,
}
 
hooksecurefunc('ChatEdit_InsertLink', function(link)
    if(MacroFrameText and MacroFrameText:HasFocus() and string.find(link, 'item:', 1, true)) then
        local macroText = MacroFrameText:GetText()
        local _, _, commandName = string.find(macroText, '/(%l+)')
        if(not commands[commandName]) then
            local item = string.match(link, '%[(.-)%]')
            if(string.find(macroText, item, 1, true)) then
                item = string.gsub(item, '%-', '%%-')
 
                local newline = string.find(macroText, '\n$') and '\n' or ''
                local newMacroText = string.gsub(string.gsub(macroText, item .. '$', ''), item .. '\n$', '') .. link .. newline
                if(string.len(newMacroText) <= 255) then
                    MacroFrameText:SetText(newMacroText)
                end
            end
        end
    end
end)

Tonyleila

06-05-13 09:23 PM

Thank you for your work!
Well my description is not all that was on the original addon page. Will your code also make this possible?

Quote:

Because there are cases where you don't want an item link, and you want plain text, ItemLinkMacros automatically adds plain text if your macro contains any of these strings:
/use
/cast
/equip

New slash command: /addtext
To make adding links to macros easier, I've added the slash command /addtext. As you would expect, it simply inserts the text following it into the macro edit box, including any link contained therein.
This also makes it easy to add in item links to a macro where you also have the string /use, /cast, or /equip.

p3lim

06-05-13 09:33 PM

The only thing missing is the slashcommand, which you could just copy/paste.

Tonyleila

06-05-13 10:32 PM

Quote:

Originally Posted by p3lim (Post 279264)

The only thing missing is the slashcommand, which you could just copy/paste.

I just copy and replaced your code with the old one of ILM and its not working. Had no errors but when trying to shift klick items into the macro window it shows item name with a slash in front of it: like /equip itemname.

May I also need a part of the old code?

p3lim

06-05-13 10:40 PM

Quote:

Originally Posted by Tonyleila (Post 279270)

That's the default behavior, if you want to use it for anything else you'd want to prefix the macro like you would in any case, with /say or /2 or whatever.
Write /say then shift-click, which is what I thought was the idea of it.

All times are GMT -6. The time now is 07:14 AM.

Page 1 of 2

Show 60 post(s) from this thread on one page