WoWInterface - Testing slash-command before execution?

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Testing slash-command before execution? (https://www.wowinterface.com/forums/showthread.php?t=58847)

Testing slash-command before execution?

Hello,

I use the following function to execute slash-commands, or commands:

Code:

-- .executeCmd("/sit", true)

-- .executeCmd("print(GetServerTime()), false)



function .executeCmd(cmdStr, isMacroBoolean)

        local cmdStr = cmdStr or ""

        local isMacroBoolean = isMacroBoolean or true

        local tbl = {strsplit("\n", cmdStr)}

        for i, strLine in ipairs(tbl) do

                strLine = strtrim(strLine)

                if (strLine ~= "") then

                        if (isMacroBoolean)) then

                                --------------------------- macro ("/" needed)

                                if (string.sub(strLine, 1, 1) ~= "/") then strLine = "/"..strLine end

                                DEFAULT_CHAT_FRAME.editBox:SetText(strLine)

                                ChatEdit_SendText(DEFAULT_CHAT_FRAME.editBox, 0)

                        else

                                --------------------------- command ("/" not valid)

                                if (string.sub(strLine, 1, 1) == "/") then strLine = string.sub(strLine, 2) end -- delete char 1

                                RunScript(strLine)

                        end

                end

        end

end

And I would like to test the passed command because if the command is not valid, it will display a lua error, and it can be confusing. I tried to play with pcall() without success.

Thank you for your help.

What function did you add to SlashCmdList to be called by your /xxx command? You could just use that.

Lua Code:

SLASH_MYSLASH1 = "/abc"
SlashCmdList.MYSLASH = function(msg)
    ...
end
-- Testing with
SlashCmdList.MYSLASH("PassedText")

Quote:

Originally Posted by Fizzlemizz (Post 339586)

What function did you add to SlashCmdList to be called by your /xxx command?

Well, .executeCmd() function is made for general purpose and could receive different kind of commands or macros, something like:

Lua Code:

.executeCmd("/sit", true) -- built-in macro
.executeCmd("/anAddonSlashCmd arg1", true) -- an addon /cmd
.executeCmd("print(GetServerTime()", false) -- script

So I'm not sure to understand what are you proposing.

The function for a slash command receives a single string parameter. If you want to interpret that into say commmands and parameters, you need to break down the string that is passed eg:

Lua Code:

SlashCmdList.SLASHFUNC = function(msg)
    local command, p1, p2, p3, p4 = strsplit(" ", strupper(msg))
    if command == "RESET" then
        FCF_ResetChatWindows()
    elseif command == "LEAVE" then
        if p1 == "TRADE" then
            LeaveChannelByName("Trade")
        else
            print(command, p1, "Not Implemented!")
        end
    end
end
 
-- test
SlashCmdList.SLASHFUNC = function("leave trade")

or are you saying you want to test if RunScript(strLine) is going to run without error before running RunScript(strLine)?

Quote:

Originally Posted by Fizzlemizz (Post 339589)

or are you saying you want to test if RunScript(strLine) is going to run without error before running RunScript(strLine)?

Yes :)

If I write RunScript("mmmkkhgrttt") I will have a lua error, and I would like to trap this error.
In fact, I'm now able to do this with something like:

Lua Code:

local func, errorMessage = loadstring(strLine)
            if (not func) then
                isError = true
            else
                local success, errorMessage = pcall(func)
                if (not success) then
                    isError = true
                end
            end

The tricky part is to catch errors when a macro is passed to the function .executeCmd() and processed with:

Lua Code:

if (isMacroBoolean)) then
                --------------------------- macro ("/" needed)
                if (string.sub(strLine, 1, 1) ~= "/") then strLine = "/"..strLine end
                DEFAULT_CHAT_FRAME.editBox:SetText(strLine)
                ChatEdit_SendText(DEFAULT_CHAT_FRAME.editBox, 0)
            else
                ...
            end

In case of macro passed as strLine, I don't know how to test/try strLine.

OK, I finally solve my problem, with the following code (maybe it could be optimized):

Lua Code:

function .executeCmd(cmdStr, isMacroBoolean, noPrintErrorBoolean) -- return "", or error string
    local cmdStr = cmdStr or ""
    local tbl = {strsplit("\n", cmdStr)}
    
    local function executeString(str) -- return "", or error string
        local str = str or ""
        local func, errorMessage = loadstring(str)
        if (not func) then
            return "slash command LUA error #59000."
        else
            local success, errorMessage = pcall(func)
            if (not success) then
                return "slash command error #59001."
            else
                return ""
            end
        end
    end
    
    local resultStr = ""
    for i, strLine in ipairs(tbl) do
        if (resultStr ~= "") then break end
        if (isMacroBoolean) then
            --------------------------- macro ("/" needed)
            if (string.sub(strLine, 1, 1) ~= "/") then strLine = "/"..strLine end
            if (string.sub(strLine, 1, 5) == "/run ") then
                strLine = string.sub(strLine, 6)
                resultStr = executeString(strLine)
            elseif (string.sub(strLine, 1, 8) == "/script ") then
                strLine = string.sub(strLine, 9)
                resultStr = executeString(strLine)
            else
                DEFAULT_CHAT_FRAME.editBox:SetText(strLine) -- sent to Chat Box
                ChatEdit_SendText(DEFAULT_CHAT_FRAME.editBox,0)
            end
        else
            --------------------------- command ("/" not valid)
            if (string.sub(strLine, 1, 1) == "/") then strLine = string.sub(strLine, 2) end -- delete char 1
            resultStr = executeString(strLine)
        end
    end
    
    if ((resultStr ~= "") and (not noPrintErrorBoolean)) then print(resultStr) end
    return resultStr
end