WoWInterface - Hooking Mixins and unnamed frames

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Hooking Mixins and unnamed frames (https://www.wowinterface.com/forums/showthread.php?t=56707)

MuffinManKen

09-25-18 10:34 AM

Hooking Mixins and unnamed frames

I'm trying to hook WorldMapBountyBoardMixin:ShowBountyTooltip. There was a thread a little while back (http://www.wowinterface.com/forums/s...ad.php?t=56578) that I used for reference and what I took from it is that if I hook the mixin AFTER the mixin is created but BEFORE it's used on a frame, the hook will work. Looking at the WorldMap code I didn't believe this was the case, but I tested it anyway with this:

Lua Code:

hooksecurefunc(WorldMapBountyBoardMixin, "ShowBountyTooltip", function(self,bountyIndex)
    print("WorldMapBountyBoardMixin:ShowBountyTooltip " .. tostring(bountyIndex))
end)

The print did not fire. The other method mentioned in that thread is to hook the frame itself, but in this case the frames are unnamed (just a hex string) so I don't believe I can do that directly.

So in a case like this, what is a reliable way to hook the method?

sticklord

09-25-18 02:43 PM

Im pretty sure it's impossible to hook the mixin, so you need to hook the frame. Maybe this will work (untested)

Lua Code:

local function ShowBountyTooltip(self, bountyIndex)
    print(bountyIndex)
end
 
for _,frame in pairs({WorldMapFrame:GetChildren()}) do
    if frame.BountyName then
        hooksecurefunc(frame, "ShowBountyTooltip", ShowBountyTooltip)
    end
end

MuffinManKen

09-25-18 09:48 PM

Thanks for the idea, I'll play with this a bit and see how it goes.

Those frames are allocated from a pool on every refresh so that may take some extra fiddling. I'm not entirely sure what happens to the innards of a frame when it's released/acquired. Would the hook stay in place? I guess I'll find out!

Edit: Actually it's the child tabs that are part of the pool, so I think that one issue may be moot.

MunkDev

09-26-18 10:50 AM

WorldMapFrame loads before any of your addons, so you'll need to address its overlay frames directly:

Lua Code:

local function ShowBountyTooltip(self, bountyIndex)
    print("WorldMapBountyBoardMixin:ShowBountyTooltip " .. tostring(bountyIndex))
end
 
for i, frame in ipairs(WorldMapFrame.overlayFrames) do
    if frame.ShowBountyTooltip then
        hooksecurefunc(frame, "ShowBountyTooltip", ShowBountyTooltip)
    end
end
 
hooksecurefunc(WorldMapBountyBoardMixin, "ShowBountyTooltip", ShowBountyTooltip)

MuffinManKen

09-26-18 02:44 PM

Quote:

Originally Posted by MunkDev (Post 330253)

WorldMapFrame loads before any of your addons, so you'll need to address its overlay frames directly:

That should be bit more efficient than iterating through all of the children. Not that performance should be an issue in this case, but for trivial effort the change seems worthwhile.

MuffinManKen

09-26-18 08:28 PM

In case anyone else is using this API, I'll note here that the factionID returned by GetQuestBountyInfoForMapID is bogus. Sometimes it's an unrelated faction, other times it's 0.

The questID is valid. I use that in a lookup to find the real faction id.

MuffinManKen

09-26-18 09:09 PM

Everything is now working well...almost. Since my hook runs after ShowBountyTooltip is done, I expected that it would be the last line and sometimes it is. But the last thing Blizzard function does is add the Reward and I guess it's a deferred call, so sometimes my line get added in the middle of the rewards like:
Rewards
You are now Friendly with the Champions of Azeroth (my text)
Radiant Azerite Fragment

I tried preloading the rewards (C_TaskQuest.RequestPreloadRewardData(questID)) but that didn't help. My hook is just:

Lua Code:

local msg = "stuff"
WorldMapTooltip:AddLine(msg);
WorldMapTooltip:Show();

The only thing I can think of is to Clear the tooltip and completely duplicate all of Blizzard's code, but that would be kind of awful, wouldn't it?

MuffinManKen

09-28-18 03:43 PM

I ended up clearing and duplicating WoW's code. I feel a little dirty, but it's not like this code is performance critical so I suppose it's good enough.

All times are GMT -6. The time now is 03:16 AM.