|
Missing Frames, Events and Functions in Battle For Azeroth
Granted this is from a quick nUI test, but I had got it working for Legion Beta, so assume these were changed in Battle For Azeroth. nUI on Login resulted in 33 unique error messages, some were these events, others what appeared to be Blizzard functions and the rest nUI functions.
Events: >Attempt to register unknown event "PLAYER_AURAS_CHANGED" >Attempt to register unknown event "UNIT_AURA_STATE" >Attempt to register unknown event "UNIT_SPELLCAST_SPELLMISS" >Attempt to register unknown event "PARTY_MEMBERS_CHANGED" >Attempt to register unknown event "UNIT_COMBO_POINTS" >Attempt to register unknown event "UNIT_PVP_UPDATE" >Attempt to register unknown event "RUNE_TYPE_UPDATE" >Attempt to register unknown event "UPDATE_WORLD_STATES" Functions (assumed Blizzard Functions not nUI) : >attempt to index global 'BattlefieldMinimap' (a nil value) >attempt to call upvalue 'GetPlayerMapPosition' (a nil value) Frames (assumed Blizzard Frames not nUI) : >Couldn't find inherited node: SecureFrame This is an event that flagged up as missing when testing my mage portals addon >Attempt to register unknown event "PARTY_CONVERTED_TO_RAID" These came up while logging in with Titan Panel ( and its built in modules activated ) so I could test my Alt ILevel Addon >Attempt to register unknown event "MINIMAP_ZONE_CHANGED" >Attempt to register unknown event "PARTY_MEMBERS_CHANGED" ---- Same as above >attempt to index global 'WorldStateAlwaysUpFrame' (a nil value) And my Alt ILevel addon came up with this one >Attempt to register unknown event "PLAYER_AVG_ITEM_LEVEL_READY" |
Add events that can't be registered for:
|
It looks like they've taken the rank returns out of functions like UnitBuff, UnitDebuff, UnitCastingInfo, UnitChannelInfo.
|
|
COMBAT_LOG_EVENT_UNFILTERED seems to be returning nothing back.
Looks like you have to use CombatLogGetCurrentEventInfo() instead. |
|
Does anyone know what's the BfA replacement for "QuestLogQuests_GetTitleButton" function?
|
Are the documentation .lua files up to date? I ask because they document several functions that, when called, don't seem to exist.
And anyone know of an up-to-date Removed/Name_Changed/Similar API comparison? The map/location related ones are killing me atm. |
Quote:
https://github.com/Ellypse/wow-ui-source/branches And the link Fizzlemizz posted has some additional notes on what they have found to be changed. Comparing the same files between versions will hopefully highlight event and function name changes. |
Quote:
Code:
function QuestLogQuests_AddQuestButton(prevButton, questLogIndex, poiTable, title, level, suggestedGroup, isHeader, isCollapsed, isComplete, frequency, questID, startEvent, displayQuestID, isOnMap, hasLocalPOI, isTask, isBounty, isStory, isHidden, isScaling, layoutIndex)Here is a portion of the Legion QuestMapFrame.lua file that has the function you are talking about. Code:
if (not headerCollapsed) thenCode:
if (not headerCollapsed or C_CampaignInfo.IsCampaignQuest(questID)) then |
oUF will have a PR dedicated to the expansion, containing unitframe-related changes:
https://github.com/oUF-wow/oUF/pull/434 |
Thank you, Xrystal!
|
Thank you Fizzlemizz and Xrystal for linking to my observations and my GitHub :D
Please note that I have also started updating the API changes article on Wowpedia with the things I am able to test and confirm in-game. If you can, please consider participating in this article to gather all the changes. |
Blue post with changes went up today.
|
Quote:
|
The changes are really not that bad. Most come down to removing the spell rank from all sorts of places and in some cases also going away from spell name in favor of spellID. All of those are relatively easy to fix.
The Map is the area which really breaks a lot, though. |
Quote:
Also, could anyone tell me if IsHarmfulSpell and IsHelpfulSpell take spellID again or still just spellName? |
Quote:
What is interesting is that the following code block Code:
GameTooltip:AddLine(IsHarmfulSpell(spellName) or "Helpful",1.0,1.0,1.0) |
RegisterUnitEvent seems bugged, simple test code:
Lua Code:
IsEventRegistered return values on Live: true player IsEventRegistered return values on Beta (26491): true I don't know if it has been like this in the previous builds aswell, just stumbled upon it when updating some addons. |
Is an invite required? I just installed beta and logged in.
|
In the latest export, Blizzard is still using:
Code:
elseif ( event == "UNIT_POWER_BAR_HIDE" ) then |
Quote:
|
Got my invite yesterday too. Eager to test my addons against the beta. Hopefully not all of them are bricked?! >_<
|
My Vignette addon stopped working. The event VIGNETTE_ADDED is nowhere to be found. Is there a new system for rare mob icons on the minimap? If so how can it be accessed?
Lua Code:
|
Quote:
C_VignetteInfo.GetVignetteInfo(vignetteGUID) returns a table containing name and other stuff |
Thanks that worked. I cannot find a replacement for the icon though. I had to disable the icon for now. The name is working fine but I seem to not find any information on the texture.
|
Quote:
Code:
Name = "VignetteInfo", |
Thanks. The missing link was GetAtlasInfo() which is not described anywhere.
It is working now. Lua Code:
Btw here is sth I found in the Blizzard_TutorialLogic.lua. It is a atlas to string texture converter if I see that right. It might be able to upgrade my current solution. Lua Code:
Nice that actually was helpful. Instead of the texture path hard coded you can use the texture file id instead. Got it working now. |
C_Map api in BfA
Updated 2nd May
Code:
api C_Map list |
RegisterUnitEvent is still bugged.
Frame:RegisterUnitEvent(event, unit) behaves as if Frame:RegisterEvent(event) was called - it register the event for all units. Submitted this, but since it was reported a month ago, maybe this needs a push |
UNIT_SPELLCAST_SUCCEEDED changes
The UNIT_SPELLCAST_SUCCEEDED event now returns 3 values:
1. unit 2. code string - see below for an example 3. spell id Teleport Dalaran (Northrend) resulted in the following 1. player 2. Cast-3-2084-571-11759-53140-000503097C 3. 53140 Portal Dalaran (Northrend) resulted in the following 1. player 2. Cast-3-2084-571-11759-53142-0000830AEF 3. 53142 After doing a few tests only the last two values changed, the spell ID depending on the spell cast and the last value intermittently and may be the same on different spells cast close together so could be a timestamp of sorts. Edit: Correction, it appears that last value changes per cast, with multiples sometimes appearing on a single button click. Looks like validating argument 2 against the previous to confirm if it is a repeat or not may be required Edit2: Correction again ... forgot that my code was doing the event test on several buttons with each checking its relevance rofl. Only 1 event per spell cast |
Quote:
Try this instead: Code:
GameTooltip:AddLine(IsHarmfulSpell(spellName) and "Harmful",1.0,1.0,1.0) |
You are right of course .. can't think what I was doing there... but seeing as it was more the case of testing the results of the function and avoiding a nil it might explain the results I mentioned rofl. Thanks for pointing it out, in case someone decided to use it :)
|
Yeah, I didn't think of it as a mere test for whether the function is present or not - though the thread title does imply that... lol
Still, getting "Helpful" as the result for a spell known as harmful being tested against IsHarmfulSpell might mean either that the function were present but bugged or that the function weren't there at all. Then again, the later case would also raise a Lua error, thus alerting you to the function being amiss, so... Well, at least, like you said, it might prevent false results "in case someone decided to use" the code. :D |
RegisterUnitEvent is fixed :banana:
GetFramesRegisteredForEvent is completely broken and always returns nil :( Edit: GetFramesRegisteredForEvent fixed aswell. |
Does anyone know how to get the Map IDs in BfA? The "/dump GetCurrentMapAreaID()" doesn't seem to work anymore.
|
Take a look a little up ...
Quote:
|
I found that I'm just noob enough to convert it into a working script. :p Would you elaborate please?
Code:
/run print(C_Map.GetCurrentMapID())I heard somewhere the map ID for Tiragarde Sound is supposed to be 895. And when doing Code:
/run for k, v in pairs(C_Map.GetMapInfo(895)) do print(k, v) endCode:
mapType 3Is there a way to get information about those map IDs? |
The various sites do not use the new mapIds that the new Blizzard API returns. If you need to be able to use a value from in game and refer to values various sites use, you will have to come up with a mapping for them, and have your addon use that mapping.
Using the new Blizzard map API you can get access to every map in the system very easily. However, mapping those to external sites is not easy. I would advise everyone to use the new Blizzard mapIDs for all maps. |
That number might be a reference to the map image they display on their website.
It may not have an in game api equivalent if it was retrieved via data mining. Maybe contact wowhead to see where they get their numbers from ( they may have generated their own set of numbers for their site after all). Using the various available map functions I haven't seen any number remotely similar. However, I can't remember what zone related functions are available pre BFA. Maybe the old zone IDs match the ones on the website but the new ones are just followed on to make the site consistent due to the big map api change. Edit ... Or as Nimh says :) |
I found an old thread of mine asking the same question:
http://www.wowinterface.com/forums/s...ad.php?t=54172 ... answered by many nice people. Semlar gave a working solution (4th post) to print out the map IDs used by wowdb/wowhead/others so the numbers I'm looking for were in the game once: Code:
/script print(GetAreaMapInfo(GetCurrentMapAreaID())) |
There is a mapping from the old map/dungeon levels to the new mapIds, which can be found in a BfA system if you dump the Blizzard code at AddOns/Blizzard_Deprecated/UIMapIDToWorldMapAreaID.lua
If you determine the mapping from the map/dungeon levels to the values used on the sites in a live system, and then use this BfA information, you can then make your mapping from the new BfA mapIDs to the values used on the sites. Not fun, but I bet when you are done if you make it available others may appreciate the work you put into it. |
Since 67.66% of your post seems chinese to me, it won't be me who reaps vast rewards here. :D
|
Quote:
Anyhow .. I'll try and break that post down to a chinglish level :P This link explains how to export the blizzard art and code to your hard drive, in case you hadn't done this in a long while, it helped me. https://wow.gamepedia.com/Viewing_Bl...interface_code Once you have done that you should find the following file in your respective Wow folder, here's mine. G:\Blizzard\World of Warcraft Beta\BlizzardInterfaceCode\Interface\AddOns\Blizzard_Deprecated The file is very long which is why it wasn't posted in it's entirety but here are the first few lines to show you what was meant. However, a quick search does not reveal the number 8567 or any 4 digit number starting with 856x. Code:
-- This is for the 8.x map transition. I hope that makes Nimh's posting a bit more clearer. |
There's some confusion between UI maps and maps. UI maps are what you view when you press M.
Maps (or sometimes seen in Blizzard's code as continentID) are the physical areas that we run around in. A UI map is a view onto one or more physical maps. It doesn't make sense to say that a creature spawns in a UI map. The deprecated table is a mapping between the old UI map system and the new UI map system. It won't help much if you're looking for physical map data. There's the function C_Map.GetWorldPosFromMapPos(uiMapID, mapPosition) -> continentID, worldPosition which can help you convert between the two. |
Here is an example that hopefully helps.
On a live server if you are in Stormwind and you do: /dump GetCurrentMapAreaID() you get: [1]=301, [2]=false Blizzard indicates that the mapId is 301 for Stormwind City. If you do: /dump GetAreaMapInfo(301) you get a bunch of stuff which includes: [2]=1519 This 1519 is the zone value that is used on a site like wowhead for Stormwind City. If you look in the UIMapIDToWorldMapAreaID.lua file dumped from a BfA beta system you will see a line: 84,301,,0 This means that BfA beta considers the mapID 84 to be the same that live called 301. Now you have the three pieces of information you wanted: Live mapID: 301 Live zoneID: 1519 BfA mapID: 84 You can create any mapping you want, e.g., you can say that BfA map 84 really is the same as zone 1519 on wowhead. Now the BfA map transition is a bit of a pain since we tend to store map data using its old mapID or possibly a combination of mapID and dungeon level. So if we are to transition old map data to new we need to use that UIMapIDToWorldMapAreaID.lua to change values. However, the new BfA map stuff is really useful for at least two reasons: (1) There is no longer a dungeon level concept. Each map has its own ID. Therefore, if you have a dungeon with three levels, you have three unique map IDs. (2) A character is in more than one map at the same time. For example, all at the same time a character can be in a dungeon, in a city, in a zone, in a continent, on a world. On each map the coordinates will be different. When one looks at a map at any level one can easily see where the character is (assuming the map shows the character). |
The following event is also no longer valid:
|
Quote:
|
Code:
HasSoulstone() |
From the 7.3.5 Deprecated.lua
Code:
-- Use C_DeathInfo.GetSelfResurrectOptions instead |
Where is that deprecated.lua?
|
After you export the UI code files
[WoW]\BlizzardInterfaceCode\Interface\AddOns\Blizzard_Deprecated See the notes in the .toc file. |
Is there a replacement for PARTY_CONVERTED_TO_RAID ?
My google-foo seems to be inadequate. |
Only thing I could find is..
https://www.townlong-yak.com/framexm...umentation.lua Name = "GroupRosterUpdate", Type = "Event", LiteralName = "GROUP_ROSTER_UPDATE" Name = "InstanceGroupSizeChanged", Type = "Event", LiteralName = "INSTANCE_GROUP_SIZE_CHANGED", Just to list 2... |
Thank you.
Seems like I'm in for a lot of wrapping. |
| All times are GMT -6. The time now is 12:12 AM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI