WoWInterface - How could this be written neater?

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - How could this be written neater? (https://www.wowinterface.com/forums/showthread.php?t=55376)

To prevent such annoyance, I wrote a complete a new debug module which only checks for annoyance of my own API:

Pretty much like c# try / catch <3

Everything else is third-party-addon stuff
(you are dismissed, foolish addon)

Sorry for interrupting ;)

I got a further question to MunkDev.

So, I was trying to apply same method to target's debuff and here I got some issue.

Lua Code:

local auraIDList = {
    233490,
    233496,
    233497,
    233498,
    233499,
};
 
local function UpdateDebuff(self)
    self:ReleaseAll();
 
    local prevButton;
    for i, auraID in pairs(auraIDList) do
        local spellName = GetSpellInfo(auraID);
        local _, _, icon, count, _, duration, expires = UnitDebuff("target", spellName, nil, "PLAYER");
 
        if duration and duration >= 0 then
            local button = self:Acquire();
 
            button.spellID = buffID;
            button.cd:SetCooldown(expires - duration, duration);
            button.icon:SetTexture(icon);
            button.count:SetText((count and count > 1) and count or "");
 
            button:Show();
 
            if prevButton then
                button:SetPoint("LEFT", prevButton, "RIGHT", gap, 0);
            else
                button:SetPoint("LEFT");
            end
 
            prevButton = button;
        end
    end
 
    self:SetSize(self.numActiveObjects > 0 and ((size + gap) * self.numActiveObjects) - gap or 0, size);
end

Those auraIDs are all "Unstable Affliction (UA)" of Affliction Warlock.

233490 / 233496 / 233497 / 233498 / 233499

The problem is since I am passing a spellName as an argument of UnitDebuff() function, casting UA once will generate five buttons at the same time as they all have same names, but different id :confused:

To track a specific UA debuff, I guess I should pass an index of an aura as an argument rather than a name, but looping through all debuffs sounds inefficient to me.

Do it the other way around, cycle through all target debuffs that are applied by you and match their IDs against UAs' IDs o_O

IIRC, unit can have up to 40(?) debuffs, might be wrong here...

-- edit #1

I should get some coffee...

Quote:

To track a specific UA debuff, I guess I should pass an index of an aura as an argument rather than a name, but looping through all debuffs sounds inefficient to me.

Do exactly that :D Just use `break`s to stop the for-loop if you need...

Quote:

Originally Posted by lightspark (Post 323339)

-- edit #1

I should get some coffee...

Do exactly that :D Just use `break`s to stop the for-loop if you need...

Hi lightspark :),

I was considering something like...

Lua Code:

function UpdateDebuff(self)
    self:ReleaseAll();
 
    local prevButton;
    for i, auraID in pairs(auraIDList) do
        for j = 1, 40 do
            local _, _, icon, count, _, duration, expires, _, _, _, spellID = UnitDebuff("target", j, "PLAYER");
            
            if auraID == spellID then
                -- blah blah blah
 
                break;
            end
        end
    end
end

But...

(1) What if my spell doesn't get included within those 40 debuffs?

(2) Would there be a variable that stores number of unit's (not only target's, but for others' as well) buff/debuff?

I mean something like BUFF_ACTUAL_DISPLAY/DEBUFF_ACTUAL_DISPLAY for player.

(3) I tried to refer aura element of oUF, but.............. meh... guess it's too complex for me :(

Drycoded, haven't tested anything...

Lua Code:

local IDs = {
    [233490] = true,
    [233496] = true,
    [233497] = true,
    [233498] = true,
    [233499] = true,
}
 
local UAs = {}
 
local function UpdateDebuff(self)
    self:ReleaseAll()
 
    for i = 1, 40 do
        local _, _, icon, count, _, duration, expires, _, _, _, spellID = UnitDebuff("target", i, "PLAYER")
 
        -- if there's no spellID it means there's less than 40 auras
        if not spellID then
            break
        end
 
        -- search for UAs
        if IDs[spellID] and duration and duration >= 0 then
            UAs[#UAs + 1] = {
                id = spellID,
                icon = icon,
                count = count or 1,
                start = expires - duration,
                duration = duration,
            }
        end
    end
 
    -- do something w/ present auras
    local prevButton
 
    for i = 1, #UAs do
        local info = UAs[i]
        local button = self:Acquire()
 
        button.spellID = info.id
        button.cd:SetCooldown(info.start, info.duration)
        button.icon:SetTexture(info.icon)
        button.count:SetText(info.count > 1 and info.count or "")
 
        if prevButton then
            button:SetPoint("LEFT", prevButton, "RIGHT", gap, 0)
        else
            button:SetPoint("LEFT")
        end
 
        button:Show()
 
        prevButton = button
 
        UAs[i] = nil
    end
 
    self:SetSize(self.numActiveObjects > 0 and ((size + gap) * self.numActiveObjects) - gap or 0, size)
end

Quote:

Originally Posted by Layback_ (Post 323341)

(1) What if my spell doesn't get included within those 40 debuffs?

Highly unlikely O_o

Quote:

Originally Posted by Layback_ (Post 323341)

(2) Would there be a variable that stores number of unit's (not only target's, but for others' as well) buff/debuff?

I mean something like BUFF_ACTUAL_DISPLAY/DEBUFF_ACTUAL_DISPLAY for player.

IIRC, nope...

Hi again,

(1) I guess the example slightly is limited (focused I mean) to Unstable Affliction (UA). Of course, I know that example is just an example and I should modify bits to make it generic, but, hm...... I don't know :confused:

(2) What if the a nth debuff on "target" is not "player's" while (n+1)th debuff is?

Quote:

Originally Posted by Layback_ (Post 323360)

(1) I guess the example is limited to Unstable Affliction (UA). Of course, I know that example is just an example and I should modify bits to make it generic, but, hm...... I don't know :confused:

Just add other spellIDs to IDs table then o_O I don't see what's the problem...

Quote:

Originally Posted by Layback_ (Post 323360)

(2) What if the a nth debuff on "target" is not "player's" while (n+1)th debuff is?

Eh? You don't understand how UnitAura's (that includes UnitBuff/UnitDebuff) filter works...

Lua Code:

UnitDebuff("target", i, "PLAYER")

W/ "PLAYER" as a filter you'll be getting ONLY debuffs that were applied by the player. It's a separate pre-filtered list of auras, there's no gaps, its indices aren't related to anything.

For example, this code:

Lua Code:

/run for i = 1, 40 do print(i, UnitBuff("player", i, "PLAYER|RAID")) end

will return this on my paladin:

Lua Code:

1 Greater Blessing of Kings  135993 0 nil 3600 16015.356 player false false 203538 true false true false 1 89847 89848 0
2 Greater Blessing of Wisdom  135912 0 nil 3600 16016.726 player false false 203539 true false true false 1

whereas actual buff list look like this:

Lua Code:

/run for i = 1, 40 do print(i, UnitBuff("player", i)) end

Lua Code:

1 Sign of the Warrior  1450455 0 nil 0 0 player false false 225787 false false true false 1
2 Fel Focus  134924 0 nil 4500.005 14209.837 player false false 242551 false false true false 1
3 Mana Divining Stone  134423 0 nil 0 0 player false false 227723 false false true false 1
4 Greater Blessing of Kings  135993 0 nil 3600 16015.414 player false false 203538 true false true false 1 89847 89848 0
5 Greater Blessing of Wisdom  135912 0 nil 3600 16016.726 player false false 203539 true false true false 1
6 Blessing of the Ashbringer  1109508 0 nil 0 0 player false false 242981 false false true false 1
7 March of the Highlord  589117 0 Magic 300 13282.648 nil false false 225455 false false false false 1

Quote:

Originally Posted by lightspark (Post 323361)

Eh? You don't understand how UnitAura's (that includes UnitBuff/UnitDebuff) filter works...

Lua Code:

UnitDebuff("target", i, "PLAYER")

W/ "PLAYER" as a filter you'll be getting ONLY debuffs that were applied by the player. It's a separate pre-filtered list of auras, there's no gaps, its indices aren't related to anything.

Holy.......................................

I thought giving a filter "PLAYER" lets the UnitAura to internally check if the caster was "player" or not.

Didn't realize that it would ignore all others from the scratch.

This makes more sense now +_+!!

It also cleared up the first point, so please ignore that :banana:

Quote:

Originally Posted by Seerah (Post 323368)

http://wowprogramming.com/docs/api/UnitAura ;)

Haha :)!!

Definitely didn't pay attention to word "Query" :p