WoWInterface - Am I understanding the 5.4.8 changes to CVars correctly?

WoWInterface (https://www.wowinterface.com/forums/index.php)

- General WoW Chat (https://www.wowinterface.com/forums/forumdisplay.php?f=143)

- - Am I understanding the 5.4.8 changes to CVars correctly? (https://www.wowinterface.com/forums/showthread.php?t=49307)

karmamuscle

05-21-14 03:14 AM

Am I understanding the 5.4.8 changes to CVars correctly?

The listed changes are here http://eu.battle.net/wow/en/forum/topic/10494573844#1

Will this make auto toggling nameplates based on combat impossible?
Cause doing it manually is just a bloody waste of a keybind imo. :)

10leej

05-21-14 03:28 AM

http://us.battle.net/wow/en/forum/to...9697?page=3#46

Looks like no, you can still show nameplates on combat entry with SetUIVisibility(true)

Dridzt

05-21-14 04:34 AM

I'm assuming (EU so haven't tested) that the change means you can't change nameplate visibility in combat.
You could still do it on combat status changes.
Events for entering combat (used to?) fire right before combat lockdown goes in effect.
So in theory you should be able to respond to changes in combat status, just not make any changes after combat has started.

ravagernl

05-21-14 11:28 AM

According to posters on the US forums, the client thinks you are in combat after all the event handlers registered to PLAYER_REGEN_DISABLED are handled.

http://us.battle.net/wow/en/forum/to...9697?page=1#10

Quote:

This is still doable. Right now on the PTR (build 18224):

Code:

local f=CreateFrame("Frame")

f:SetScript("OnEvent",function(self,event)

 SetCVar("nameplateShowEnemies",event=="PLAYER_REGEN_DISABLED" and 1 or 0)

end)

f:RegisterEvent("PLAYER_REGEN_ENABLED")

f:RegisterEvent("PLAYER_REGEN_DISABLED")

will hide nameplates out of combat and show nameplates in combat.

OFFTOPIC: Am I right if this gnome is actually a very famous AddOn author here :P?

semlar

05-21-14 12:38 PM

Quote:

Originally Posted by ravagernl (Post 292889)

OFFTOPIC: Am I right if this gnome is actually a very famous AddOn author here :P?

I think (but I'm not positive) that Ro has an account on here named Gello.

Phanx

05-21-14 07:24 PM

Quote:

Originally Posted by Dridzt (Post 292883)

Yep, this is how it's always worked. You can freely make changes when PLAYER_REGEN_DISABLED fires, including changes that are not allowed in combat like hiding secure frames, equipping items, and now modifying these particular cvars.

This change should not affect "auto toggle nameplates for combat" addons at all.

ravagernl

05-22-14 09:56 AM

Quote:

Originally Posted by semlar (Post 292891)

I think (but I'm not positive) that Ro has an account on here named Gello.

I was thinking the same thing but I didn't want to make the link because of possible privacy issues some authors have :)

10leej

05-22-14 02:12 PM

Quote:

Originally Posted by ravagernl (Post 292913)

I was thinking the same thing but I didn't want to make the link because of possible privacy issues some authors have :)

Gello is Ro, he confirmed that with me back when I used Adapt with BobUI plus it's not that hard to figure out who he ius cause just about every other addon he makes he posts on the official forums.

Well except PlusNothing which I maintain for him.

All times are GMT -6. The time now is 05:35 AM.