WoWInterface - [Retail] nPower not updated need help with error code.

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - [Retail] nPower not updated need help with error code. (https://www.wowinterface.com/forums/showthread.php?t=57749)

[Retail] nPower not updated need help with error code.

Hello,
NeavUI has not been updated sence 08/27/18 some people have tried to do quick fixes but not everything is updated. One of the addons I use from it is called nPower and it works but keeps thowing me a error everytime a load screen comes up.

Here is the link to the GitHub for the addon to see the whole addon. nPower

the error code I am getting from BugGrabber is:

Code:

411x nPower\core.lua:209: attempt to perform arithmetic on local 'start' (a nil value)

nPower\core.lua:209: in function <nPower\core.lua:207>

nPower\core.lua:388: in function <nPower\core.lua:373>



Locals:

self = 1

start = nil

duration = nil

runeReady = nil

(*temporary) = <function> defined =[C]:-1

(*temporary) = 342594.828000

(*temporary) = 342594.828000

(*temporary) = nil

(*temporary) = "attempt to perform arithmetic on local 'start' (a nil value)"

It seems to only happen on my Deathknight. the chunk of code that is being referenced is:

Lua Code:

local function CalcRuneCooldown(self)
    local start, duration, runeReady = GetRuneCooldown(self)
    local time = floor(GetTime() - start)
    local cooldown = ceil(duration - time)
 
    if (runeReady or UnitIsDeadOrGhost("player")) then
        return "#"
    elseif (not UnitIsDeadOrGhost("player") and cooldown) then
        return cooldown
    end
end

and this function only seems to show up in this bit of code at the end of the .lua:

Lua Code:

if (f.Rune) then
    local updateTimer = 0
    f:SetScript("OnUpdate", function(self, elapsed)
        updateTimer = updateTimer + elapsed
 
        if (updateTimer > 0.1) then
            for i = 1, 6 do
                if (UnitHasVehicleUI("player")) then
                    if (f.Rune[i]:IsShown()) then
                        f.Rune[i]:Hide()
                    end
                else
                    if (not f.Rune[i]:IsShown()) then
                        f.Rune[i]:Show()
                    end
                end
 
                f.Rune[i]:SetText(CalcRuneCooldown(i))
                f.Rune[i]:SetTextColor(0.0, 0.6, 0.8)
            end
 
            updateTimer = 0
        end
    end)
end

Hopefully one of you awesome programmers have an idea why this keep throwing an error.

Thanks in advance for any help solving this issue.

Coke

In my rune code I check that start has been given a value (Blizzard does also in their UpdateRunes function which probably means GetRuneCooldown can return nil for start no matter what the online docs say) so a change to something like:

Lua Code:

local function CalcRuneCooldown(self)
    local cooldown
    local start, duration, runeReady = GetRuneCooldown(self)
    if start then
        local time = floor(GetTime() - start)
        cooldown = ceil(duration - time)
    end     
    if (runeReady or UnitIsDeadOrGhost("player")) then
        return "#"
    elseif (not UnitIsDeadOrGhost("player") and cooldown) then
        return cooldown
    end

Here's what i'm using and built around nPower code.

Lua Code:

local A, C, L = select(2, ...):unpack()
local RuneBar = CreateFrame("Frame")
local DataBars = A["DataBars"]
local Panels = A["Panels"]
 
-- Lib Globals
local select = select
local unpack = unpack
 
-- WoW Globals
local GetRuneCooldown = GetRuneCooldown
local GetTime = GetTime
local UnitClass = UnitClass
local GetSpecialization = GetSpecialization
 
-- Locals
local Class = select(2, UnitClass("player"))
 
-- Color Tabels
local Mult = 2.5
local BloodColor = { 1 * Mult, 0, 0 }
local FrostColor = { 0, 0.35 * Mult, 1 * Mult }
local UnholyColor = { 0.25 * Mult, 0.55 * Mult, 0.10 * Mult }
 
function RuneBar:OnUpdate(Elapsed)
    local Duration = self.Duration + Elapsed
    self.Duration = Duration
    self:SetValue(Duration)
end
 
function RuneBar:Update()
    for i = 1, 6 do 
        local Start, Duration, RuneIsReady = GetRuneCooldown(i)
        if (Start) then         
            self.RunesBars[i].Duration = GetTime() - Start
            self.RunesBars[i]:SetMinMaxValues(0, Duration)
            self.RunesBars[i]:SetScript("OnUpdate", self.OnUpdate)
        else
            self.RunesBars[i]:SetMinMaxValues(0, 1)
            self.RunesBars[i]:SetValue(1)
            self.RunesBars[i]:SetScript("OnUpdate", nil)
        end
    end 
end
 
function RuneBar:UpdateSpec()   
    for i = 1, 6 do
        local GetSpecialization = GetSpecialization()
        if (GetSpecialization == 1) then
            self.RunesBars[i]:SetStatusBarColor(unpack(BloodColor))
        elseif (GetSpecialization == 2) then
            self.RunesBars[i]:SetStatusBarColor(unpack(FrostColor))
        elseif (GetSpecialization == 3) then
            self.RunesBars[i]:SetStatusBarColor(unpack(UnholyColor))
        end
    end
end
 
function RuneBar:OnEvent(event)
    if (event == "RUNE_POWER_UPDATE") then
        self:Update()
    elseif (event == "PLAYER_ENTERING_WORLD" or event == "PLAYER_SPECIALIZATION_CHANGED" or event == "PLAYER_TALENT_UPDATE") then
        self:UpdateSpec()
    end
end
 
function RuneBar:CreateBar()
    local Bar = CreateFrame("StatusBar", nil, UIParent)
    Bar:Size(220, 12)
    Bar:Point("TOP", Panels.ActionBarPanelMiddle, 0, 32)
    
    local RunesBars = {}
 
    for i = 1, 6 do
        local Bars = CreateFrame("StatusBar", nil, Bar)
        Bars:Size(210/6, 12)
        Bars:SetStatusBarTexture(C.Media.Texture)
        Bars:CreateBackdrop()
        Bars:CreateShadow()
        
        if (i == 1) then
            Bars:Point("LEFT", Bar, 2, 0)
        else
            Bars:Point("LEFT", RunesBars[i-1], "RIGHT", 2, 0)
        end
        
        RunesBars[i] = Bars
    end
    
    RegisterStateDriver(Bar, "visibility", "[vehicleui][petbattle] hide; show")
 
    self:RegisterEvent("RUNE_POWER_UPDATE")
    self:RegisterEvent("PLAYER_SPECIALIZATION_CHANGED")
    self:RegisterEvent("PLAYER_TALENT_UPDATE")
    self:RegisterEvent("PLAYER_REGEN_ENABLED")
    self:RegisterEvent("PLAYER_REGEN_DISABLED")
    self:RegisterEvent("PLAYER_ENTERING_WORLD")
    self:SetScript("OnEvent", self.OnEvent)
    
    self.Bar = Bar
    self.RunesBars = RunesBars
end
 
function RuneBar:Enable()
    if not (C.DataBars.RuneBar) or (Class ~= "DEATHKNIGHT") then
        return
    end
 
    self:CreateBar()
end
 
DataBars.RuneBar = RuneBar

Quote:

Originally Posted by Fizzlemizz (Post 334835)

Lua Code:

local function CalcRuneCooldown(self)
    local cooldown
    local start, duration, runeReady = GetRuneCooldown(self)
    if start then
        local time = floor(GetTime() - start)
        cooldown = ceil(duration - time)
    end     
    if (runeReady or UnitIsDeadOrGhost("player")) then
        return "#"
    elseif (not UnitIsDeadOrGhost("player") and cooldown) then
        return cooldown
    end

Thank You @Fizzlemizz it works perfectly, it so nice not hearing the "fatality" every time the screen loads.

Quote:

Originally Posted by cokedrivers (Post 334837)

Thank You @Fizzlemizz it works perfectly, it so nice not hearing the "fatality" every time the screen loads.

"fatality" is what that Gnome voice says? I've wondered for years what that was, but was too lazy to figure it out. :)