WoWInterface

WoWInterface (https://www.wowinterface.com/forums/index.php)
-   Carbonite: Maps (Main AddOn) (https://www.wowinterface.com/forums/forumdisplay.php?f=119)
-   -   Map Scale Keybinding Isn't Working (https://www.wowinterface.com/forums/showthread.php?t=55659)

KrysEmlyn 08-20-17 01:04 PM

Map Scale Keybinding Isn't Working
 
I've updated to the latest version of Carbonite today and I set a keybinding of "Control+T" for the restoring the map scale to the saved map scale. Carbonite spits an error if I try to use the keybinding:

Code:

Carbonite\NxMap.lua:2668: attempt to index local 'self' (a nil value)
Carbonite\NxMap.lua:2668: in function `NXMapKeyScaleRestore'
[string "NxMAPSCALERESTORE"]:1: in function <[string "NxMAPSCALERESTORE"]:1>

Locals:
self = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'self' (a nil value)"

Can this be fixed, please?

jeffy162 08-20-17 04:41 PM

It MAY not have to be "fixed". Did you try another modifier (shift or alt) key combination? I know control is used for something to do with the map (or at least it used to be when I played yet). Besides, testing that out first would help, maybe, a little bit.

By-the-way, what happens when you right click the map and try restoring your map scale in the right click menu?

KrysEmlyn 08-20-17 07:13 PM

Jeffy,

Using the Alt or Shift modifier keys results in the same error:
Code:

Carbonite\NxMap.lua:2668: attempt to index local 'self' (a nil value)
Carbonite\NxMap.lua:2668: in function `NXMapKeyScaleRestore'
[string "NxMAPSCALERESTORE"]:1: in function <[string "NxMAPSCALERESTORE"]:1>

Locals:
self = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'self' (a nil value)"

Further testing of just using letter keys without modifiers also results in this same error.

Right-clicking the mini map and selecting Restore Map Scale works just fine, though.

jeffy162 08-21-17 07:47 AM

Hmmm..... Have you eliminated other addon interference? With Carbonite I mean.

KrysEmlyn 08-29-17 06:56 PM

I have not eliminated other addon interference, but I discovered a code change in the Carbonite Maps Github repository. Applying that code change does allow the keybind for restoring the map scale to function like it used to.

ircdirk 08-30-17 08:29 AM

Quote:

Originally Posted by KrysEmlyn (Post 324852)
I have not eliminated other addon interference, but I discovered a code change in the Carbonite Maps Github repository. Applying that code change does allow the keybind for restoring the map scale to function like it used to.

Propose Pull Request on GitHub Carbonite repo to fix this problem.

KrysEmlyn 08-30-17 08:24 PM

The fix I mentioned has already been rolled into Carbonite:
Code:

function Nx:NXMapKeyScaleRestore()
-        local map = self.Map:GetMap (1)
+        local map = Nx.Map:GetMap (1)
        map:Menu_OnScaleRestore()
 end

(Copied from the GitHub repository)

I copied this change into my local copy yesterday to test that it works as I think I saw a comment about having the change tested. I'll be downloading the alpha version that was put out today, which contains this fix. :)


All times are GMT -6. The time now is 07:45 PM.

vBulletin © 2020, Jelsoft Enterprises Ltd
© 2004 - 2020 MMOUI