WoWInterface

WoWInterface (https://www.wowinterface.com/forums/index.php)
-   nUI: Bug Reports (https://www.wowinterface.com/forums/forumdisplay.php?f=90)
-   -   Unable to add a glyph (https://www.wowinterface.com/forums/showthread.php?t=48154)

Brillynt 09-15-13 12:25 AM

Unable to add a glyph
 
When I click the glyph to activate it. I get the Disable or Ignore dialog prompt.

Seer 09-15-13 02:07 AM

Not sure but you can try to richt click the glyph to remove it and then add the new one. At least saves the trouble of disabling and reloading.

I know that doesnt work for talents tho.

spiel2001 09-15-13 08:52 AM

Yup. There's a slew of new taint issues. I'm working through them yesterday and today and hope to get a new update out tonight. Not a promise, but trying.

Thorgald 09-15-13 03:58 PM

Having the same issues with glyphs, and also when it comes to respeccing talents...


Date: 2013-09-15 23:53:46
ID: 1
Error occured in: AddOn: nUI
Count: 1
Message: Error: AddOn nUI attempted to call a forbidden function (RemoveTalent()) from a tainted execution path.
Debug:
[C]: RemoveTalent()
...rface\AddOns\Blizzard_TalentUI\Blizzard_TalentUI.lua:10: OnAccept()
..\FrameXML\StaticPopup.lua:3823: StaticPopup_OnClick()
[string "*:OnClick"]:1:
[string "*:OnClick"]:1
Locals:
None
AddOns:
Swatter, v5.18.5433 (PassionatePhascogale)
Ace3, v
Altoholic, v5.4.001
AtlasLootLoader, vv7.07.00
AucAdvanced, v5.18.5433 (PassionatePhascogale)
AucFilterBasic, v5.18.5433 (PassionatePhascogale)
AucFilterOutlier, v5.18.5433.5347(5.18/embedded)
AucMatchUndercut, v5.18.5433.5364(5.18/embedded)
AucScanData, v5.18.5433 (PassionatePhascogale)
AucStatHistogram, v5.18.5433 (PassionatePhascogale)
AucStatiLevel, v5.18.5433 (PassionatePhascogale)
AucStatPurchased, v5.18.5433 (PassionatePhascogale)
AucStatSales, v5.18.5433.5376(5.18/embedded)
AucStatSimple, v5.18.5433 (PassionatePhascogale)
AucStatStdDev, v5.18.5433 (PassionatePhascogale)
AucStatWOWEcon, v5.18.5433.5323(5.18/embedded)
AucUtilAHWindowControl, v5.18.5433.5347(5.18/embedded)
AucUtilAppraiser, v5.18.5433.5427(5.18/embedded)
AucUtilAskPrice, v5.18.5433.5347(5.18/embedded)
AucUtilAutoMagic, v5.18.5433.5415(5.18/embedded)
AucUtilCompactUI, v5.18.5433.5427(5.18/embedded)
AucUtilEasyBuyout, v5.18.5433.5427(5.18/embedded)
AucUtilFixAH, v5.18.5433 (PassionatePhascogale)
AucUtilItemSuggest, v5.18.5433.5417(5.18/embedded)
AucUtilPriceLevel, v5.18.5433.5427(5.18/embedded)
AucUtilScanButton, v5.18.5433.5403(5.18/embedded)
AucUtilScanFinish, v5.18.5433.5347(5.18/embedded)
AucUtilScanProgress, v5.18.5433.4979(5.18/embedded)
AucUtilScanStart, v5.18.5433.5347(5.18/embedded)
AucUtilSearchUI, v5.18.5433.5373(5.18/embedded)
AucUtilSimpleAuction, v5.18.5433.5415(5.18/embedded)
AucUtilVendMarkup, v5.18.5433.4828(5.18/embedded)
Babylonian, v5.1.DEV.332(/embedded)
BagBrother, v
Baggins, v460
BattlePetQualityNotifier, v1.3.0
BeanCounter, v5.18.5433 (PassionatePhascogale)
Collectinator, v2.0.3
Configator, v5.1.DEV.344(/embedded)
DataStore, v5.4.001
DataStoreAchievements, v5.4.001
DataStoreAgenda, v5.4.001
DataStoreAuctions, v5.4.001
DataStoreCharacters, v5.4.001
DataStoreContainers, v5.4.001
DataStoreCrafts, v5.4.001
DataStoreCurrencies, v5.4.001
DataStoreInventory, v5.4.001
DataStoreMails, v5.4.001
DataStorePets, v5.4.001
DataStoreQuests, v5.4.001
DataStoreReputations, v5.4.001
DataStoreSpells, v5.4.001
DataStoreStats, v5.4.001
DataStoreTalents, v5.4.001
DebugLib, v5.1.DEV.337(/embedded)
Enchantrix, v5.18.5433 (PassionatePhascogale)
EnchantrixBarker, v5.18.5433 (PassionatePhascogale)
ExtraCD, v1.2
Factionizer, v5.04.00.27 13.9.1
GatherMate2, v1.27
Informant, v5.18.5433 (PassionatePhascogale)
LibBabbleInventory30, v
LibBagUtils10, v1.0.27
LibDBIcon10, v
LibExtraTip, v5.12.DEV.355(/embedded)
LibGratuity30, vr$Revision: 41183 $
LibPeriodicTable31, vv3.3.0.423
LibQTip10, vr165-release
LibStub, v
MozzFullWorldMap, v5.04.00.00
nUI, v5.07.37 (Plus)
PetBattleMaster, v1.8.0
PetJournalEnhanced, v2.9.8
PetTracker, v
PetTrackerAlerts, v
PetTrackerJournal, v
PetTrackerSwitcher, v
Prat30, v3.5.7
Prat30HighCPUUsageModules, v
Prat30Libraries, v
Scrap, v12.9
ScrapMerchant, v
ScrapSpotlight, v
SlideBar, v5.18.5433 (PassionatePhascogale)
Stubby, v5.18.5433 (PassionatePhascogale)
TipHelper, v5.12.DEV.351(/embedded)
TomTom, vv50400-1.0.0
BlizRuntimeLib_enUS v5.4.0.50400 <eu>
(ck=c98)

spiel2001 09-15-13 09:09 PM

Roger that. I'm still trying to work may way through the taint issues. Not looking like I'm going to get an update out today.

shakytremors 09-17-13 03:25 PM

I tried adding doing glyphs as well and I even removed all my addons and redownloaded them to make sure i was up to date and started with just nui installed. when i tested with trying to change out a glyph i received this lua error message:

Message:
...rface\AddOns\Blizzard_TalentUI\Blizzard_TalentUI.lua:710: attempt
to perform arithmetic on local 'id' (a nil value)
Time: 09/17/13 14:10:03
Count: 1
Stack: ...rface\AddOns\Blizzard_TalentUI\Blizzard_TalentUI.lua:710: in
function 'PlayerTalentFrame_SelectTalent'
...rface\AddOns\Blizzard_TalentUI\Blizzard_TalentUI.lua:40: in function
'OnAccept'
Interface\FrameXML\StaticPopup.lua:3823: in function
'StaticPopup_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>

Locals: id = nil
(*temporary) = <function> defined =[C]:-1
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on local 'id' (a nil value)"

I know Im not the only one and that Scott is working hard on fixes but I wanted to share this with you.

spiel2001 09-17-13 06:18 PM

Thanks for the added info. I'm going to get an update out as soon as I can. I just haven't been able to resolve it yet. I'm working it as we speak.

spiel2001 09-17-13 08:16 PM

For the record, I'm still working this. I've been systematically through the '/console taintlog 11' output for nUI and cleaned up every taint that was not an nUI specific variable and I still cannot unlearn a talent. I don't *think* it's a Blizz bug, but I'll be damned if I can figure out what the trigger is. I can find nothing I'm tainting which would account for it.

I've reached out for some help and will update when I know more.

shakytremors 09-18-13 02:28 PM

Thanks for your updates, I havent done any addon programing before but if your needing any help I would like to try and give you a hand if you need it.

Belechannas 09-20-13 11:57 AM

Quote:

Originally Posted by spiel2001 (Post 284770)
For the record, I'm still working this. I've been systematically through the '/console taintlog 11' output for nUI and cleaned up every taint that was not an nUI specific variable and I still cannot unlearn a talent. I don't *think* it's a Blizz bug, but I'll be damned if I can figure out what the trigger is. I can find nothing I'm tainting which would account for it.

I've reached out for some help and will update when I know more.

Heh, misery loves company; glad I'm not alone in finding this completely baffling:

http://www.wowinterface.com/forums/s...38&postcount=7

Is the taintlog 11 option available on the Live server now? I read your post about it in the other forum, but at the time you said it was PTR-only.

spiel2001 09-20-13 02:42 PM

Yeah.... they went ahead and made it available on the live server, too.

shayotan 09-23-13 05:13 AM

Just wondering still working on this?
 
i cannot right click remove a Glyph either; as well as even add one.
-------------------
Date: 2013-09-24 06:13:47
ID: 1
Error occured in: AddOn: nUI
Count: 1
Message: Error: AddOn nUI attempted to call a forbidden function (RemoveGlyphFromSocket()) from a tainted execution path.
Debug:
[C]: RemoveGlyphFromSocket()
..\FrameXML\StaticPopup.lua:82: OnAccept()
..\FrameXML\StaticPopup.lua:3823: StaticPopup_OnClick()
[string "*:OnClick"]:1:
[string "*:OnClick"]:1
Locals:
None

spiel2001 09-23-13 07:59 AM

I have found, at least in nUI6, that if I go to add a glyph, it will block. If I say "Ignore" I can then add the glyph. I have not had the same success with removing talents.

In the meantime, I can continuing to work with Blizz to try and sort this out and am going over my own code with a fine tooth comb looking for the trigger. There is *no* indication that a taint has occurred until you go to do the action, then it taints without an explanation of why. It's very frustrating.

Foxlit 09-24-13 08:33 AM

The following fixed this issue for me: in nUI/Bars/nUI_MicroMenu.lua, comment out line 149, for instance like so:
Code:

--        button.SetPoint      = function() end;

spiel2001 09-24-13 10:27 AM

Really? 0.o

You are my hero if that's the fix... I'll look at it when I get home from work tonight. Probably doing the same thing in both nUI5 and nUI6, too.

Thanks much!

Belechannas 09-25-13 06:06 AM

Wow.

Does seem plausible, though. Setting a member of a Blizz UI element (the talent panel button) would taint it, and anything that tries to call it, and then I guess all bets are off.

Odd that it wasn't logged though.

So I have to ask, Foxlit - how did you determine that line to be the problem?

BO5ivojLupen 09-25-13 04:13 PM

I can confirm, that this fix actually works! Thanks so much!

Foxlit 09-26-13 04:46 PM

Quote:

Originally Posted by Belechannas (Post 285093)
So I have to ask, Foxlit - how did you determine that line to be the problem?

What actually worked was this: prevent large chunks of nUI's code from running, check if issue still persists, repeat with a different or smaller chunk. Upon narrowing to nUI/Bars/nUI_MicroMenu.lua, read the code to find that it replaces SetPoint on all microbuttons, while UpdateMicroButtons(), which eventually calls MainMenuMicroButton:SetPoint (because of the in-game store in 5.4.0), is called from the execution path that eventually taints TalentUI. Comment out the SetPoint assignment, verify that TalentUI is no longer tainted and that glyphs/talents can be removed.

I actually started by looking at the error message, then the relevant static popup's OnAccept handler, verified that PlayerTalentFrame.talentGroup was tainted (issecurevariable is your friend), then backtracked through TalentUI code to figure out approximately where nUI taints TalentUI -- issecurevariable suggested it was somewhere after PlayerTalentFrameTalents.summariesShownWhenNoPrimary = true in PlayerTalentFrame_OnShow, and before the PlayerTalentFrame.selectedPlayerSpec = self.specIndex in PlayerSpecTab_OnClick. Upon closer examination, this made no sense (there's nothing you could taint by accident between those two points), so off I went to do what was described in the first paragraph.

Bonus observation: taint tracking doesn't work properly. In this case, TalentUI was tainted through the UpdateMicroButtons call in PlayerTalentFrame_OnShow, so PlayerTalentFrameTalents.summariesShownWhenNoPrimary, which is set immediately after the UpdateMicroButtons call, should've also been tainted, and yet issecurevariable claims that it wasn't. You can also test this by doing /run UpdateMicroButtons = function() print("Hi!") end, opening the talent frame, and observing that /dump issecurevariable(PlayerTalentFrameTalents, "summariesShownWhenNoPrimary") prints 1. This one is in our favour (something that should be tainted isn't), but broke my debug-by-reading approach.

spiel2001 09-27-13 12:14 PM

I have an update going out shortly (for nUI5) with this fix in it.

Interestingly enough, it appears the fix it more complicated in nUI6. I haven't sorted out where the difference is there yet but it would seem that just making the change to the caching and nil of the Blizz functions is not enough in this case. Will have to poke into it more.

Belechannas 09-28-13 11:24 PM

Quote:

Originally Posted by Foxlit (Post 285143)
What actually worked was this:...[epic debugging skillz]

Well, I tip my hat to you sir. I've been writing and debugging computer code for 35+ years, and I couldn't find it after spending the better part of a day.

Ah, senility...


All times are GMT -6. The time now is 09:57 PM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI