WoWInterface - Objective Tracker

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Objective Tracker (https://www.wowinterface.com/forums/showthread.php?t=52366)

Objective Tracker

So Zork wrote a cool addon "rObjectiveTrackerMover"

The problem is me and another guy are having a bug where the ObjectiveTracker jumps in combat around. Weirdly, its not in every combat, I feel like its random, I couldn't figure how I recreate the problem.

Zork said he had problems before, he said it was fixed but the Issue is still sometimes occurring so I wanted to ask this smart forum.

This is basicly the important part of the code, I think

Lua Code:

local function AdjustSetPoint(self,...)
    local a1,af,a2,x,y = ...
    if a1 and af == "MinimapCluster" and y ~= cfg.y then
      if InCombatLockdown() then
        self:SetPoint(a1,af,a2,x,cfg.y)
      else
        frame.point = {a1,af,a2,x,cfg.y}
        frame:RegisterEvent("PLAYER_REGEN_ENABLED")
      end
    end
  end
 
  frame:SetScript("OnEvent", function(self,event)
    self:UnregisterEvent(event)
    if event == "PLAYER_LOGIN" then
      self.point = {ObjectiveTrackerFrame:GetPoint()}
      hooksecurefunc(ObjectiveTrackerFrame, "SetPoint", AdjustSetPoint)
    end
    if InCombatLockdown() then
      ObjectiveTrackerFrame:SetPoint(unpack(self.point))
    end
  end)

I think the problem is something with "If InCombatLockdown()" so my question is, how do I fix this bug of the ObjectiveTracker moving back to its position in Combat.

Lua Code:

local function noop() end
 
ObjectiveTrackerFrame:ClearAllPoints()
ObjectiveTrackerFrame:SetPoint("TOPRIGHT", UIParent, "TOPRIGHT", 0, -300)
ObjectiveTrackerFrame.ClearAllPoints = noop
ObjectiveTrackerFrame.SetPoint       = noop
ObjectiveTrackerFrame:SetHeight(500)

This is the code I have been using to relocate my objective tracker. No need for any events or anything; ObjectiveTrackerFrame exists at file scope; furthermore I haven't had ANY issues with taint via setting ClearAllPoints and SetPoint to a dummy function.

Obviously you are interested in the SetPoint line that has position arguments.

I would not suggest to use either of the code. The first one simply doesn't handle the SetPoint hooks, which happens when boss or arena frames appera, or when you enable/disable the Blizzard side bars. The second one is a taint hazzard.

Try this code:

Lua Code:

local moving
hooksecurefunc(ObjectiveTrackerFrame, "SetPoint", function(self)
    if moving then
        return
    end
    moving = true
    self:SetMovable(true)
    self:SetUserPlaced(true)
    self:ClearAllPoints()
    self:SetPoint("CENTER", UIParent, "CENTER", 0, 0)
    self:SetScale(1.1) -- optional
    self:SetWidth(300) -- optional
    self:SetHeight(400) -- optional
    self:SetMovable(false)
    moving = nil
end)

Also keep that in mind if the original parent of the frame aka the "MinimapCluster" is not in it's original position, then the client won't be able to bypass secure code for it's children frame aka the "ObjectiveTrackerFrame" and you won't be able to click on the quest items on the frame.

The only solution is that to reset the "MinimapCluster", or to use another 3rd party Minimap addon, which you can reposition securely/properly.

How far is the 2nd code from Clamsoda a taint hazzard?

The Quests are clickable and the quest tracker has the correct position

You're calling :SetPoint() in your :SetPoint() hook, Resike. That'll make an infinite loop.

In WFWW, I create a container frame, parent the objective tracker to that, and move/size the container. Then I do this, to avoid the recursive :SetPoint call...

Lua Code:

local cap = ObjectiveTrackerFrame.ClearAllPoints
    local sp = ObjectiveTrackerFrame.SetPoint
    hooksecurefunc(ObjectiveTrackerFrame, "SetPoint", function(self)
        cap(self)
        sp(self, "TOPLEFT", 30, -10)
    end)

Quote:

Originally Posted by Seerah (Post 309124)

Lua Code:

local cap = ObjectiveTrackerFrame.ClearAllPoints
    local sp = ObjectiveTrackerFrame.SetPoint
    hooksecurefunc(ObjectiveTrackerFrame, "SetPoint", function(self)
        cap(self)
        sp(self, "TOPLEFT", 30, -10)
    end)

It's not infinite because of the moving variable.

Quote:

Originally Posted by gempir (Post 309123)

How far is the 2nd code from Clamsoda a taint hazzard?

The Quests are clickable and the quest tracker has the correct position

There is nothing wrong with it, but it could potentionally spread taint for other addons. Also it's not the best method to permanently kill a function, since you can't really restore it only by deleting the code itself.

Quote:

Originally Posted by Resike (Post 309125)

It's not infinite because of the moving variable.

Bah, I guess my eyes glazed over for that bit. ><