WoWInterface - Druid power value not changing color on shapeshift

WoWInterface (https://www.wowinterface.com/forums/index.php)

- oUF (Otravi Unit Frames) (https://www.wowinterface.com/forums/forumdisplay.php?f=87)

- - Druid power value not changing color on shapeshift (https://www.wowinterface.com/forums/showthread.php?t=51908)

Druid power value not changing color on shapeshift

I've noticed a rather irritating issue with my unit frames. When I switch from caster to cat the color of the power text does not update with the bar. To clarify this is only when shifting. Upon using any ability in cat form the text changes to the proper color. (See attached image)

Here is the code used to color the text

Lua Code:

local text = lib.gen_fontstring(f.Health, cfg.font, 18, "OUTLINE")
            text:SetPoint("RIGHT", s.arrow, "LEFT", 6, -8)
            s:HookScript("OnValueChanged", function(self, value)
            
            if (value >= 1e3) then
            text:SetFormattedText("%.1fk", value / 1e3, 0)
            else
            text:SetFormattedText("%d", value, 0)
            end
            
            local r, g, b = s:GetStatusBarColor()
            text:SetTextColor(r, g, b)
            text:SetJustifyH("RIGHT")

S is the power bar in this case. Does anyone have any suggestions as to how I can force it to change on shape shift?

Using an actual hook to set the power text is pretty hack-y... you should really just use a PostUpdate function:

Code:

local text = lib.gen_fontstring(f.Health, cfg.font, 18, "OUTLINE")

text:SetPoint("RIGHT", s.arrow, "LEFT", 6, -8)



s.text = text

s.PostUpdate = function(self, unit, value, maxvalue, minvalue)

      local r, g, b = self:GetStatusBarColor()

      if (value >= 1e3) then

            self.text:SetFormattedText("|cff%02x%02x%02x%.1fk", r * 255, g * 255, b * 255, value / 1e3)

      else

            self.text:SetFormattedText("|cff%02x%02x%02x%d", r * 255, g * 255, b * 255, value)

      end

end

On a side note, I don't know what that 0 you were passing to SetFormattedText was supposed to do... SetFormattedText takes the same arguments as string.format, so if your pattern (arg1) is "%d" then only one further argument will have any effect.

You also don't need to explicitly set the justification; if your font string only has one anchor point (eg. RIGHT), it will always grow away from that point (eg. towards the left) no matter what justification (if any) is set on it.

Another option would be to use a tag, but the "do it yourself" approach is more efficient in this case since the current power value is already available in the PostUpdate function without needing to call UnitPower again.

Quote:

Originally Posted by Phanx (Post 306484)

Using an actual hook to set the power text is pretty hack-y... you should really just use a PostUpdate function:

The HookScript function is used to get a smooth power value transition. The original discussion is available here: http://www.wowinterface.com/forums/s...ad.php?t=45676

Quote:

Originally Posted by Phanx (Post 306484)

Code:

local text = lib.gen_fontstring(f.Health, cfg.font, 18, "OUTLINE")

text:SetPoint("RIGHT", s.arrow, "LEFT", 6, -8)



s.text = text

s.PostUpdate = function(self, unit, value, maxvalue, minvalue)

      local r, g, b = self:GetStatusBarColor()

      if (value >= 1e3) then

            self.text:SetFormattedText("|cff%02x%02x%02x%.1fk", r * 255, g * 255, b * 255, value / 1e3)

      else

            self.text:SetFormattedText("|cff%02x%02x%02x%d", r * 255, g * 255, b * 255, value)

      end

end

Thank you I will fix that.

Quote:

Originally Posted by Phanx (Post 306484)

You also don't need to explicitly set the justification; if your font string only has one anchor point (eg. RIGHT), it will always grow away from that point (eg. towards the left) no matter what justification (if any) is set on it.

Thank you I was unaware of this.

Quote:

Originally Posted by Phanx (Post 306484)

Another option would be to use a tag, but the "do it yourself" approach is more efficient in this case since the current power value is already available in the PostUpdate function without needing to call UnitPower again.

I think trying to work the smooth power value transitions out in a tag may be more work than what I am doing now. This particular text is only used on the player frame. All other frames are handled by tags.

I have tried the code you posted, thank you for that. It didn't however seem to work. I didn't get any errors, but there was no output. I will fiddle with it some more see if I can figure out what I am doing wrong.

Here is a short video I made to show the problem. Not sure if it will help any.

http://youtu.be/Fy4h8hXgdYA

Show your whole code, everything. We have no idea what the variables are.

Here is the whole power bar code section

Lua Code:

--gen powerbar func
  lib.gen_ppbar = function(f)
    --statusbar
    local s = CreateFrame("StatusBar", nil, f)
    s:SetStatusBarTexture(cfg.powerbar_texture)
    fixStatusbar(s)
    if f.mystyle == "player" or f.mystyle == "pet" then
        s:SetHeight(16)
        s:SetWidth(f:GetWidth())
        s:SetPoint("TOP",f,"TOP",8,0)
    else
        s:SetHeight(retVal(f,16,14,10))
        s:SetWidth(f:GetWidth())
        s:SetPoint("TOP",f,"TOP",6,0)
    end
    s:SetFrameLevel(1)
 
    --helper
    local h = CreateFrame("Frame", nil, s)
    h:SetFrameLevel(0)
    h:SetPoint("TOPLEFT",-5,5)
    h:SetPoint("BOTTOMRIGHT",5,-5)
    lib.gen_backdrop(h)
    --bg
    local b = s:CreateTexture(nil, "BACKGROUND")
    b:SetTexture(cfg.powerbar_texture)
    b:SetAllPoints(s)
    --arrow
    if f.mystyle ~= "tot" and f.mystyle ~= "failRaid" and f.mystyle ~= "pet" then
        s.arrow = s:CreateTexture(nil, "OVERLAY")
        s.arrow:SetTexture([[Interface\Addons\oUF_Fail\media\textureArrow]])
        s.arrow:SetSize(16,16)
        s.arrow:SetPoint("BOTTOM", s:GetStatusBarTexture(), "RIGHT", 0, retVal(f,9,9,6))
        fixTex(s.arrow)
 
        if f.mystyle == "player" then
        --== smooth power text for player==--  
            local text = lib.gen_fontstring(f.Health, cfg.font, 18, "OUTLINE")
            text:SetPoint("RIGHT", s.arrow, "LEFT", 6, -8)
 
            s:HookScript("OnValueChanged", function(self, value)
                local r, g, b = s:GetStatusBarColor()
                if (value >= 1e3) then
                    text:SetFormattedText("|cff%02x%02x%02x%.1fk", r * 255, g * 255, b * 255, value / 1e3)
                else
                    text:SetFormattedText("|cff%02x%02x%02x%d", r * 255, g * 255, b * 255, value)
                end
            end) 
 
        else
        --==regular power text for everyone else==--
            local powertext = lib.gen_fontstring(f.Health, cfg.font, 18, "OUTLINE")
            powertext:SetPoint("RIGHT", s.arrow, "LEFT", 6, -8)
            --powertext:SetJustifyH("RIGHT")
            f:Tag(powertext, "[fail:pp]")
        end 
        --==No arrows for raid and boss==--
        if f.mystyle ~="raid" and f.mystyle ~="failBoss" then
            f:Tag(powa, "[fail:pp]")
        end
        
    if cfg.ShowExtraUnitArrows == "true" then
        s.arrow:Show()
    else
        s.arrow:Hide()
    end
    end
 
    f.Power = s
    f.Power.bg = b
end

Thank you and please let me know if you need any more or anything else. Excuse my noobness I'm in no way a programmer.

I was looking for where and when you actually set the colors for the power bar.
I'm guessing it's set after the OnValueChanged/PostUpdate fires, which is why you don't see it update.

Quote:

Originally Posted by p3lim (Post 306503)

I was looking for where and when you actually set the colors for the power bar.
I'm guessing it's set after the OnValueChanged/PostUpdate fires, which is why you don't see it update.

I follow. You are correct I believe that it is set after. Is there a better way to set the text color aside from grabbing the color of the bar?

Quote:

Originally Posted by Sauerkraut (Post 306504)

I follow. You are correct I believe that it is set after. Is there a better way to set the text color aside from grabbing the color of the bar?

You can set them at the same time in the same function using the same values.
Basically, move the coloring of your text to where you color your bar.

Quote:

Originally Posted by p3lim (Post 306511)

You can set them at the same time in the same function using the same values.
Basically, move the coloring of your text to where you color your bar.

Thank you p3lim I will try that.