WoWInterface - Unable to click quest button

WoWInterface (https://www.wowinterface.com/forums/index.php)

- AddOn Help/Support (https://www.wowinterface.com/forums/forumdisplay.php?f=3)

- - Unable to click quest button (https://www.wowinterface.com/forums/showthread.php?t=50666)

Unable to click quest button

I found it unable to use the quest button on objectivetrackframe,
And I have no idea about how this happened.
Could be due to the bag addons?
Anyone here would show me a clue?

Do you have an addon that does anything to the objective frame even as simple as moving it ?

I've noticed that the moment the main frame is re-parented in an addon the quest button becomes unsecure and kicks off a fuss with an error or just refuse to work. Could be coincidental.

There are also tons of other ways you can taint the objective tracker that don't even require touching the objective tracker itself. Personally I just gave up trying to get working quest item buttons on the objective tracker, and am using p3lim's ExtraQuestButton addon to (basically) put quest items on the extra action button; it doesn't let you pick which item to use, but automatically selects the item based on your current location, and so far I've never needed to use a different item. Another option would be to use the quest item ring in OPie, or another addon that creates a separate menu/bar for quest items.

Quote:

Originally Posted by Xrystal (Post 301763)

Code:

local wf = ObjectiveTrackerFrame

wf:SetClampedToScreen(true)

wf:SetMovable(true)

wf:SetUserPlaced(true)

wf:ClearAllPoints()

wf.ClearAllPoints = function() end

wf:SetPoint("TOPRIGHT", UIParent, "TOPRIGHT", -100, -250)

wf.SetPoint = function() end

wf:SetHeight(450)

local function Moveit(f)

        f:EnableMouse(true)

        f:RegisterForDrag("LeftButton")

        f:SetHitRectInsets(-15, -15, -5, -5)

        f:SetScript("OnDragStart", function(s)

                wf:StartMoving()

        end)

        f:SetScript("OnDragStop", function(s)

                wf:StopMovingOrSizing()

        end)

end

Moveit(ObjectiveTrackerBlocksFrame.QuestHeader)

Moveit(ObjectiveTrackerBlocksFrame.ScenarioHeader)

Moveit(ObjectiveTrackerBlocksFrame.AchievementHeader)

These are the codes I use for move the frame.

Quote:

Originally Posted by Phanx (Post 301779)

I used the ExtraQuestButton as well, which helps a lot.

Quote:

Originally Posted by siweia (Post 301785)

Code:

wf.ClearAllPoints = function() end

wf.SetPoint = function() end

Both of those lines will break any secure frame if applied to the frame itself or any of its ancestors.

Quote:

Originally Posted by Phanx (Post 301788)

Both of those lines will break any secure frame if applied to the frame itself or any of its ancestors.

Thanks! I will delete those lines.

Quote:

Originally Posted by Phanx (Post 301788)

Both of those lines will break any secure frame if applied to the frame itself or any of its ancestors.

Unfortunately, the problem is still there. Would you mind to look at my other codes that relate to objectiveframe? Sorry for bothering.

Code:



-- Autocollapse the watchframe when in Dungeons

local wfclps = CreateFrame("Frame")

wfclps:RegisterEvent("ZONE_CHANGED_NEW_AREA")

wfclps:RegisterEvent("PLAYER_ENTERING_WORLD")

wfclps:SetScript("OnEvent", function()

        if IsInInstance() and not ScenarioBlocksFrame:IsVisible() then

                ObjectiveTrackerFrame.collapsed = true

                ObjectiveTracker_Collapse()

        else

                ObjectiveTrackerFrame.collapsed = nil

                ObjectiveTracker_Expand()

        end

end)



-- Questblock click enhant

hooksecurefunc(QUEST_TRACKER_MODULE, "OnBlockHeaderClick", function(self)

        if(IsControlKeyDown()) then

                AbandonQuest()

        elseif(IsAltKeyDown() and GetQuestLogPushable()) then

                QuestLogPushQuest()

        end

end)



-- Show quest color and level

local function Showlevel()

        if ENABLE_COLORBLIND_MODE == "1" then return end

        local numEntries = GetNumQuestLogEntries()

        local titleIndex = 1

        for i = 1, numEntries do

                local title, level, _, isHeader, _, isComplete, frequency, questID = GetQuestLogTitle(i)

                local titleButton = QuestLogQuests_GetTitleButton(titleIndex)

                if title and (not isHeader) and titleButton.questID == questID then

                        titleButton.Check:SetPoint("LEFT", titleButton.Text, titleButton.Text:GetWrappedWidth() + 2, 0)

                        titleIndex = titleIndex + 1

                        local text = "["..level.."] "..title

                        if isComplete then

                                text = "|cffff78ff"..text

                        elseif frequency == 2 then

                                text = "|cff3399ff"..text

                        end

                        titleButton.Text:SetText(text)

                end

        end

end

hooksecurefunc("QuestLogQuests_Update", Showlevel)

Any time you replace a key/value on a secure frame, you're liable to break it, so these lines are potentially problems:

Code:

                ObjectiveTrackerFrame.collapsed = true

                ObjectiveTrackerFrame.collapsed = nil

They may seem innocuous, but since reading/writing them may happen in a code path that can't handle taint, they may in fact break the buttons.

There are also other ways to taint the objective frame, apparently involving the world map (probably because the world map shows quest stuff now) but I haven't looked into it in great detail. For example, right now I'm not using any addons which touch the objective frame at all, and the buttons still don't work, with a random "action blocked" error if I try to click on them. I'm still using ExtraQuestButton, which I linked before, and have enabled the quest item ring in OPie for the occasional case where ExtraQuestButton picked the "wrong" item (eg. when the relevant areas for two items overlap).

At some point I plan to write a full replacement for the objectives tracker, since as far as I'm concerned the current objectives tracker is an unsalvagable disaster, but I have no ETA, and it likely won't support item buttons at all.

It's also worth pointing out that Blizzard could solve the problem very easily, by making the UseQuestLogSpecialItem only require a hardware event (eg. a click). I understand they don't want addons automatically using the items for you to complete quests, but I really don't see any serious potential for abuse if it just requires a click/keypress. It's a quest, not raid progression or tournament PvP. :rolleyes:

I was contemplating the same thing Phanx for my scrolling watch frame update but looks to be a bit of a task despite them making it more modular and template based. I am hoping that creating a secure action button will help things a bit.

However, this is assuming
local link, item, charges, showItemWhenComplete = GetQuestLogSpecialItemInfo(questLogIndex);
has the link include the itemID of the button so it can be used in a secure way.

For now I did a simpler update and suggest users use another addon for the quest item button.

Quote:

Originally Posted by Xrystal (Post 302488)

I am hoping that creating a secure action button will help things a bit.

And hiding the questframe in combat would break it I'd guess ;)

Quote:

Originally Posted by Rilgamon (Post 302498)

And hiding the questframe in combat would break it I'd guess ;)

Well, seeing as some of the quest items are supposed to be used while in combat, theoretically it shouldn't be hidden.

Don't get the hassle about this, i can freely move/scale/parent/show/hide/setwidth/setheight the frame even in combat, without getting any taints. The key object here is the SetUserPlaced(true)

Lua Code:

local moving
hooksecurefunc(ObjectiveTrackerFrame, "SetPoint", function(self)
    if moving then
        return
    end
    moving = true
    self:SetMovable(true)
    self:SetUserPlaced(true)
    self:ClearAllPoints()
    self:SetPoint("CENTER", UIParent, "CENTER", 0, 0)
    self:SetScale(1.1)
    self:SetWidth(300)
    self:SetHeight(400)
    self:SetParent(TargetFrame) -- Only for default Blizzard unitframes.
    self:SetMovable(false)
    moving = nil
end)

Of course i did'nt tested with all of the quest items, but i guess if one is working properly then all should.

Two things could cause this taint issues, if you have an addon which abuses this frame badly, or if you have ANY ADDON which calls ObjectiveTracker_Update() at any point. If you call ObjectiveTracker_Update() at any point by an addon then you are fucked.

Hmm thanks Resike. That may very well be what has caused things to go wrong on my rewrite. On the old version I am sure I used the setuserplaced function but don't seem to have done that this time.

Will see if that little change resolves the problem at my end.

Although I haven't done the securehooking this time either so maybe the two combined is the problem.

The real issue if this taint is 90% of the authors just renamed the old WatchFrame_Update() to ObjectiveTracker_Update() so there is a pretty damn good chance you have at least one addon which calls this and taints it.

Well, rigged up a mini addon, to create a scrolling frame to hold the tracker frame in and all seems fine except ...

Lua Code:

local addonName,addonData = ...
 
local myScrollFrame
 
addonData.Options = {
    FrameWidth = 500, 
    FrameHeight = 150,
    IsMovable = true,
    HasBorder = true,
}
 
addonData.SetMovable = function(self,frame)
    if not frame then return end
    frame:EnableMouse(true)
    frame:SetMovable(true)
    frame:RegisterForDrag("LeftButton")
    frame:SetScript("OnDragStart",function(self)
        self:StartMoving()
    end)
 
    frame:SetScript("OnDragStop",function(self)
        self:StopMovingOrSizing()
        self:SetUserPlaced(true)
        self:SetClampedToScreen(true)
    end)
 
    frame:SetScript("OnHide",function(self)
        self:StopMovingOrSizing()
        self:SetUserPlaced(true)
        self:SetClampedToScreen(true)
    end)
end
 
addonData.AddBorder = function(self,frame)
    local border = CreateFrame("Frame",_G[frame:GetName().."Border"],frame)
    border:SetFrameLevel(frame:GetFrameLevel()-1)
    border:SetFrameStrata(frame:GetFrameStrata())
    border:ClearAllPoints()
    border:SetPoint("TOPLEFT",-10,10)
    border:SetPoint("BOTTOMRIGHT",35,-10)
 
    local backDrop = {       
        bgFile = "Interface/Tooltips/UI-Tooltip-Background", 
        edgeFile = "Interface/Tooltips/UI-Tooltip-Border", 
        tile = true, 
        tileSize = 16, 
        edgeSize = 16, 
        insets = 
        {
            left = 4, 
            right = 4, 
            top = 4, 
            bottom = 4 
        },
    }                       
    border:SetBackdrop(backDrop)
    border:SetBackdropBorderColor( 1, 1, 0, 1 )
    border:SetBackdropColor( 0, 0, 0, 1 )
 
    frame.border = border
end
 
addonData.BuildScrollFrame = function(self,name,parent,options)
    parent = parent or UIParent
    local frame = CreateFrame("ScrollFrame",name,parent,"UIPanelScrollFrameTemplate")
    frame.ScrollBar = _G[frame:GetName() .. "ScrollBar"];
    frame.ScrollBar:SetPoint("LEFT",frame,"RIGHT",5,0)
    frame:SetWidth(options.FrameWidth - 55)
    frame:SetHeight(options.FrameHeight - 20)
    if options.HasBorder then
        self:AddBorder(frame)
    end
    if options.IsMovable then
        self:SetMovable(frame)
        if not frame:SetUserPlaced() then
            frame:SetPoint("CENTER",parent,"CENTER",10,-10)
        end
    else
        frame:SetPoint("CENTER",parent,"CENTER",10,-10)
    end
    ScrollFrame_OnLoad(frame)
    frame:UpdateScrollChildRect()
 
    frame:SetScript("OnScrollRangeChanged",function(self,xrange,yrange)
        ScrollFrame_OnScrollRangeChanged(self, xrange, yrange)
        self:UpdateScrollChildRect()
    end)
 
    frame:SetScript("OnVerticalScroll",function(self,offset)
        addonData:OnVerticalScroll(frame,offset)
        self:UpdateScrollChildRect()
    end)
 
    frame:SetScript("OnMouseWheel",function(self,delta)
        ScrollFrameTemplate_OnMouseWheel(self, delta)
        self:UpdateScrollChildRect()
    end)
 
    return frame
end
 
addonData.OnVerticalScroll = function(self,frame,offset)
    if offset == 0 then return end
    local scrollbar = _G[frame:GetName().."ScrollBar"];
    scrollbar:SetValue(offset);
    local min;
    local max;
    min, max = scrollbar:GetMinMaxValues();
    if ( offset == 0 ) then
        _G[scrollbar:GetName().."ScrollUpButton"]:Disable();
    else
        _G[scrollbar:GetName().."ScrollUpButton"]:Enable();
    end
    if ((scrollbar:GetValue() - max) == 0) then
        _G[scrollbar:GetName().."ScrollDownButton"]:Disable();
    else
        _G[scrollbar:GetName().."ScrollDownButton"]:Enable();
    end
end
 
local function CreateScrollFrame()
    myScrollFrame = addonData:BuildScrollFrame("XrystalScrollFrame_ObjectivesTracker",UIParent,addonData.Options)
end
 
local OTFMoving
hooksecurefunc(ObjectiveTrackerFrame, "SetPoint", function(self)
    if not myScrollFrame then return end
    if OTFMoving then return end
    OTFMoving = true
    self:SetMovable(true)
    self:SetUserPlaced(true)
    self:ClearAllPoints()
    self:SetPoint("TOPLEFT", myScrollFrame, "TOPLEFT", 30, 0)
    self:SetScale(1.1)
    self:SetWidth(addonData.Options.FrameWidth - 30)
    self:SetHeight(1000)
    myScrollFrame:SetScrollChild(self)
    self:SetMovable(false)
    OTFMoving = nil
end)
 
--DEFAULT_OBJECTIVE_TRACKER_MODULE.blockOffsetX = 30
CreateScrollFrame()

I need that line that is commented out to keep the offset correct for my frame as otherwise the POI Icons and half of the check marks are too far left and are invisible. However, the moment I use that line it causes the taint message. This is a very basic version to my addon but visually it is useless without that offset being able to be used.

I tried a bit work on this, and it breaks exactly as same as what Resike said.
You can just type "/script ObjectiveTracker_Update()" to have a go.

And I also found a thing that, I use HandyNotes and its plugin "DraenorTreasures" in game, if I untracked a quest from the objectivetracker frame by holding SHIFT key and click, it would taint the button as well.
Even I disable all the addons but these two.

Update: Seems like moving the "MinimapCluster" aka the (Minimap), will also cause this taint.

I can get ObjectiveTrackerFrame to do what I want for the most part except for one problem. No matter what I've tried I cannot get UseQuestLogSpecialItem to work if you untrack an objective from the quest log.

Quote:

Originally Posted by Vrul (Post 302871)

I have no issues with that, so it's probably caused by another addon, mostly map addons could cause this.