IsFlyableArea() + [flyable] conditional bugged in 7.3.5?
 

Both return false on a character in Pandaria (Kun-Lai Summit) who has Artisan Riding and wasn't able to fly in Pandaria before 7.3.5, but correctly return true on those characters who had Wisdom of the Four Winds before the patch hit (which is now gone, because it's not required anymore).

Did anyone else notice this/is there a alternative for IsFlyableArea?

Same bug on Highmountain Tauren and Nightbornes - IsFlyableArea() returns false in Orgrimmar.

Seems like someone posted it on the US forums, so I guess there's a chance this might be fixed in BfA.

https://us.battle.net/forums/en/wow/topic/20761606777

There is now:
https://github.com/phanx-wow/LibFlyable

I've had a number of people email me about the IsFlyableArea replacement function in my mount addon, and this weekend have had the inexplicable urge to address some the mountain of bug reports that have been piling up on my addons since I quit playing, so I just split said function out into a proper library so everyone can just use it instead of copy-pasting.

Note that I'm still not actually playing the game, and have no urge or plans to start, so until/unless someone volunteers as a maintainer, bugs will only get fixed if you tell me about them in sufficient detail. :p

Yes. All of Legion Dalaran is flyable.

Phanx, awesome stuff. Here's a couple of updates, from your GitHub:

• Warlords garrisons and Legion class halls are never flyable.

Garrisons are flyable, with the exceptions of the mine, inside buildings, and if the player is swimming. Legion class halls are not flyable, possibly except right beside a flightmaster NPC. At least when I zone into my class hall on a flying mount I remain flying until I move into the building proper.

• Ashran and the Tanaan Jungle Intro are never flyable.

Both of these zones are 100% completely flyable, except for obvious things like inside buildings or while swimming.
**EDIT** oops, yes, you are correct that the Tanaan Jungle intro is not flyable, but Tanaan Jungle itself is flyable. I missed that, sorry!

The Argus zone and its three sections are not flyable, nor will they ever be flyable. Argus is the new Timeless Isle.

Hopefully this helps. Nice to see you, even if all you are doing is fixing bugs. We miss you!

Some class halls are flyable. Dreamgrove (druid) and Lodge (hunter) are flyable since they're simply zones of Broken Isles. I want to say Maelstrom is flyable (shaman) but I don't have a shaman to test.

Interesting. I play a Demon Hunter and it is flyable by the flightmaster but not inside the building itself. That is cool that some classes can fly, perhaps because their class halls are larger?

Most buildings aren't flyable inside. But also Fel Hammer is inside Mardum which isn't flyable.

Don't remember about Acherus but that might be flyable everywhere, too.

Thanks, great idea. I totally forgot about Flight Master's License, that's the reason why IsFlyableArea() returned false in Orgrimmar on new alts.

Only DKs, Hunters and Druids can fly in their class hall. The DK class hall is on the broken shore (not instanced).

Can you check if IsFlyableArea() now returns correct info in all those scenarios? (e.g. false in the mine, buildings, and when swimming; true otherwise). If it does then I can just remove the special check for garrisons.

Does that also apply to the garrison shipyard?

It's for the PvP Ashran, not the normal world Ashran. I should update the description to clarify.

Does IsFlyableArea() return false there even with Broken Isles Pathfinder?

If it does, then it normally won't need a special check, and I'll just add the mapID to the 7.3.5 override list.

Otherwise, please run /dump GetInstanceInfo() while you're there, and give me the 8th value. It's not listed on Wowpedia as a separate instance map, but I can't tell if that means it's not separate, or if the wiki just hasn't been updated.

Can you check if IsFlyableArea() is returning correct info in class halls? Last I heard, it wasn't, but it wasn't working in garrisons either. If both have been fixed then I can just remove the special check; otherwise I'll have to add more checks for those specific class halls that are actually flyable.

It doesn't, not for all classes:

IsFlyableArea() correctly returns false on the Argus maps (mapID 1669).

So it looks like all of the garrison areas are true, even if your character automatically dismounts inside buildings. I can tell you that if you are mounted, either a ground or flying mount, and you swim, it does not dismount you regardless of where in the world you are swimming.

I will dump GetInstanceInfo() tomorrow when I am in Argus. It should give me 3 or 4 different values, possibly 5, if you are asking for the mapIDs.

1. Vindicaar
2. Mac'Aree
3. Argus
4. Antoran Wastes
5. Kokuun

Thanks for the info. Can you get me the instanceMapIDs from GetInstanceInfo for the bugged ones (demon hunter, monk, shaman, warlock, warrior)? Wowpedia is missing the instanceMapIDs for class halls.

Good, no special handling required! (I'm assuming 1669 is the instanceMapID from GetInstanceInfo, not the mapID from GetCurrentMapAreaID.)

More questions:

1. Does IsFlyableArea() return true inside buildings in the garrison?
2. Can you actually not manually summon a flying mount while swimming in the garrison?

No need; according to the info Sezz posted above, Argus doesn't need special handling.

FYI GetInstanceInfo gives you an instanceMapID, not a mapID. The two aren't interchangable; even for an instance (continent) that only contains one map (zone) the instanceMapID and mapID are different.

Sure:

1519 Demon Hunter
1514 Monk
1469 Shaman
1107 Warlock
1479 Warrior

Yes, that's correct.

1: Don't know, but can easily check in a bit once I get to my PC.
2: You can mount while in the water, as long as you're not inside the underwater cave (which disallows mounting by virtue of being a cave, regardless of the water.) Flying mounts are also pretty interchangeable with ground mounts nowadays in virtually every scenario.

Changes for the class order halls are on GitHub.

Inside the cave should be covered by "indoors". Normally IsFlyableArea() returns false while indoors, so I'm waiting to hear whether it's actually returning true while indoors in the garrison; that will determine what I actually need to check for.

Right, but the purpose of LibFlyable is to determine whether you can actually fly in your current location, not just whether you can summon a flight-capable mount. ;)

Come to think of it, I'm pretty sure IsFlyableArea() checks your general zone/continent, irrespective of your more specific location. As such it returns true indoors in the garrison, in the same way it returns true while indoors in buildings outside of the garrison (personally tested just now, btw. Or at least it also returned true in a building at Embaari Village, couldn't be bothered to check every place in the game.)

I imagine that flyable doesn't always necessarily imply mountable. You could fly in that area, if it were mountable.

Maybe I should check IsIndoors() for those locations instead? if that can be reliably used to determine whether the player could mount or not. If you can't mount then it goes without saying that you can't fly either :p

But of course, flying mounts used to be completely unmountable in non-flying areas (while they now can and are treated as the same as hybrid mounts), and as I had no idea whether you were aware or not, I wanted to clarify.

IsFlyableArea() returns true even inside the building within the Garrison. I'll check the cave later, but all the buildings I tested return true, yet you cannot manually cast a mount spell. If such a spell is on your action bar, it is greyed out.

It returns false in buildings in Orgrimmar, so I assumed it did that everywhere. However, if that's not the case, then I won't bother checking it in garrisons. You also have a good point here:

...so I'm just going to declare garrisons flyable with Draenor Pathfinder and call it good.

There's a significant difference between:

1. IsFlyableArea() or replacement; and
2. Can I summon a flying mount right now?

I started out thinking the intention was (1) but a lot of the comments lead me to think it is actually (2), which I think would be a mistake.

At least two bugged areas on Argus have IsFlyableArea() == true even though you can't fly there. I forget the second one, but the first is a graveyard on Mac'Aree near the City Center teleporter.

Both of the Draenor garrisons are correctly flagged.

With the exception of the Deaths of Chromie scenario (MapID 1177, InstanceMapID 1756) you can't fly on continent -1, even though most of it is flagged flyable. This handles many many cases, including the Draenor intro area.

All of the Legion order halls are correctly flagged once continent -1 is excluded.

The intention is (1); addons should be able to do something like:

This is why in my last post I stated I'm not going to bother checking for other conditions in garrisons -- the library should only be answering the question "if you summoned a flight-capable mount here (whether or not that's blocked for some other reason) and pressed the spacebar, would it fly into the air or fall back to the ground?"

That's what the real IsFlyableArea() is supposed to do, but fails in certain areas. The original problem I wanted to solve was that all continents but Outland required buying a spell to fly in, but IsFlyableArea() didn't consider whether your character actually knew that spell.

As soon as Blizzard fixes the 7.3.5 problem, then the library logic will go back to what it originally was -- if IsFlyableArea() returns false, assume it's correct; otherwise "trust but verify" by checking a few other things. The 7.3.5 problem is that now the opposite problem is happening in some places, so we can't trust a return of false from IsFlyableArea() either.

Finally, keep in mind that prior to 5 days ago this wasn't a library at all, but a file I was copy-pasting into my various addons (and others were copy-pasting into their various addons) so it's good that we're clarifying the scope here to avoid bloat going forward. I definitely intend for it to be (1) and not (2) so please feel free to point out anything you think is out of scope for (1).

OK, I'm just blacklisting the entire Argus continent/instance, then.

Are you sure? I understand they are now flyable, but unless they're flyable without Draenor Pathfinder, then if IsFlyableArea() still returns false for characters without Draenor Pathfinder, they're not flagged correctly.

If GetCurrentMapAreaID() == 1177 and select(8, GetInstanceInfo()) == 1756, then where is the -1 coming from?

-1 would be coming from GetCurrentMapContinent()

I'm (very) familiar with the issues with 7.3.5, having worked around them myself. Based on previous experience Blizzard will be aware of the bug but won't hotfix it, so it'll be broken until there's a minor patch.

Garrisons are not flagged "correctly" with respect to the achievement unlocks. Blizzard appear to not consider this a bug - I don't expect it to change and I expect it to continue to work this way in the future with BfA. Given that it is reliably continent-wide it is a minor inconvenience at most.

-1 is the continent, from GetCurrentMapContinent()

Also if you are going to be doing map querying and don't want to handle it nicely yourself you may as well use https://www.wowace.com/projects/herebedragons

I've tagged version 2 of LibFlyable.

Right; this means garrisons will now be treated just like Draenor itself.

I'm not doing any map querying, and don't need to know anything about maps, so nothing HereBeDragons offers is applicable. The only global API functions I'm actually using are:

• GetInstanceInfo
• GetSubZoneText
• IsFlyableArea
• IsSpellKnown

Just encountered a bug: The library returns true for Timeless Isle, while IsFlyableArea() correctly returns false.

Odd; I was actually playing in Pandaria, and was using the same code in my mount addon back then.

What is the output from /run print(string.format("%8$d %1$s", GetInstanceInfo())) while on the Timeless Isle?

I actually checked GetInstanceInfo when I was there and it returned 870, so I'm currently using GetCurrentMapAreaID() to check for Timeless Isle (951).

FYI, the bug with IsFlyableArea() and [flyable] was fixed a week or two back.

However the behaviour of (at least) IsFlyableArea() and probably [flyable] has changed so that it no longer tests if the character knows any flying skills.

This is an understandable change if their server-side fix was just removing the character-based condition checks.

If you mean it no longer tests if the character knows flying skills required for the current area (e.g. you need Broken Isles Pathfinder to fly in Legion zones) that's not really a change; it's always worked that way, and working around that is the primary purpose of this library. Up until 7.3.5 it was the only purpose of the library, which a private function being used in several of my addons for years to avoid summoning huge dragons to waddle around on the ground.

The temporary workaround for the 7.3.5 bug was just the impetus for actually making an official public release of it. If that specific bug has been fixed then I can remove the check for it in the library.

Thanks, tested it in Pandaria and it correctly returned true.

I think in the past it always returned false if your character didn't have any flying skill, this is now not the case anymore.

I mean the regular flying skills, not the area-specific unlocks.