Roll Your Own Fixes for 5.041
 

To Fix Quest Log breaking after doing a daily:

Change Line 7496 to:
----
To fix dungeon eye missing:

Change Line 25269 to:
----

To fix the world map fading out of existance when you mouse out:

Change Line 11248 to:
----

To fix the LUA errors on world map hovering over some zones from achievements being removed (wetlands, duskwood etc)

After Line 6795 (should be "if alw or not don then") Add
After Line 6799(should be "return format("%s%s %d/%d",col2,nam,cnt,nee)") Add
----

To fix the green blob wintergrasp currently is on the map

Change Line 24396 to

Thanks!

I might add since line numbers are referenced and notepad doesn't have them, that people probably should download a program like notepad++ that supports line numbers. ;)

Rythal,

You are a god among men.

These a-holes basically screwed you and you are still fixing their glitches lol.

I say bail and let them suffer.

It's just not in me to do that... at least I only posted how to fix the bugs instead of fixing them and releasing it :P

this post along with the fixes just proves that your heart was in the right place with the fan update.

You are the best. We respect you.

If i was an official developer of carbonite,i would accept help of Rythal to place his fixes in official update ...
and maybe another help with him too...
Rythal seems to be very skilled fixing bugs so why refusehis help
just my opinion ...

JK

My guess is that they don't give a crap about the bugs, infact they probably glitched it themselves

I no longer use Carbonite but you are a star Rythal. When you create your map addon will you post the details here so we can get it and donate to you, for your great work here and the one part of Carbonsh..e that is irreplaceable?

thanks for the heads up on how to fix the quest log error. it works good again

So what your saying (without really saying) is that in the last 3 days, since they last released the crud version, they couldn't be bothered updating it with 6 lines of code????

Ok I get the fact that they don't play WoW anymore. That's OK.

What I don't get is their unwillingness to make an effort, yes I know they came at the 13th hour and brought it out (broken) but they weren't around before hand, they haven't been reading their own forums, they were apparently unaware of MoP's patch release, which meant they haven't been paying attention to anything WoW related, let alone their own add on/forum.

I don't like the fact that Rythal was shunned for being the only person to step up and do what the original authors should have done in the first place and what he continually tries to do ( Like roll your own fixes lol). And before anyone starts, I do appreciate all the work the OA's have done with Carbonite, I have used it for many years, and donated in the past. I also agree that they own their code, it is theirs! I just don't agree with the way they have handled things since. I mean here's the quick version of what I understand went on.

Bliz released MOP Patch,
Everyone's addons went psycho,
Most addons were nearly fixed from day 1,
Carbonite OA's were nowhere to be seen, not even a "Sorry we're late, but we're on it!"
Rythal (After numerous attempts to contact OA's by others.) decided to fix Carbonite for the masses. And lets face it, we are quite a User Base.
After a few bug fix versions everyone is happy (mostly) :)
Along came the OA's, very late, who then throws out an unfinished (official) version, and cracks Rythal on the back of the head with the naughty stick for his troubles.
Now people who wrongly assumed the (Official) version would work properly, have replaced Rythals (working) version with it, and are now boned.
Rythal continues to try to help at risk of another crack with the naughty stick.

If you feel I have missed anything in this brief overview then I'm sure you'll let me know. Edits will be in bold after you have corrected me. :)

@Rythal

I assume by your posting that you make these roll your own fixes, free to use, without copyright?? If you could please clarify this? That way the OA's have no excuse for waiting another day before removing finger from bum and getting the hell on with it? Or does that sound unfair? Again, I'm sure you'll all let me know.

:)

PS Spelling mistakes are due to a keyboard with no lettering left on it Lol.

That's how I have been reading the situation.. Except one small thing. (in bold)
I remember reading a post by Rythal, saying it was not him that has contacted the OA's. But someone who knew them.

Apart from that I will not comment on the drama that is taking place here...

First point I have quoted above - Rythal has said himself that he personally never contacted the OA's because others said they had tried. Not that it specifically diminishes him at all, but a clarification point (and I understand why he wouldn't).

Second, lots of people make suggestions on code replacement, I know Jeffrey is one I've seen in the forums for a while as well. Also, you assume that the OA's have access and time every day to get on these forums, file through lots of posts and then fix the codes - all very quickly, not something I assume. I think we could see more timely responses if the posts that happened, now that the OA's are back, are problems and fixes posted by others. Granted, I'm guilty of adding to the issue seeing how I respond to these messages - but I like to help give timely feedback, though it isn't official by any means.

This does give one good point however, I love this thread for what it was intended (or I believe it was intended) a place to report bugs and people to post quick fixes. Hopefully they can be found and incorporated quickly. Thank you again Rythal for your work!

This might help faatal out with finding bug's and fixing carbonite.
Have to say I'm a little upset how I respond to the quick post he did but with the little time he has to update I understand.
maybe the people on the forums can give faatal help with finding the bug's and posting the fix also if they know the coding for it.
I'm hoping this will help carbonite out and faatal.
But I would like to see Rythal part of team if faatal will allow it.
that would also help faatal out alot.. due to his RL stuff.

Please help faatal out.
Plus hear the plea's of the member's of the forums faatal.
If you need the help just Ask... As I think many will help you keep Carbonite alive.

Thank you so much for the info on the fixes. Everything worked great. Only problem I am still having is a large black circle in the middle of Dalaran and Shattrath. Not sure if I did something wrong or if that is a separate issue.

That's an unrepairable bug introduced with the new patch. Any area that is "indoors" but still mountable (dalaran, undercity, cleft of shadows, caverns of time) causes the map to do that if it's transparent at all... there is no sure fire way to detect when it will happen. In mine it was fixed by docking / solid if it was a known bugged area, we will have to wait and see how they handle it and just live with it for now :(

Hey Rythal thx for fixing the Update by providing "Do it yourself" help. So i'm asking if you could help with the language solution? the are French, Spanish and even german players like me out there who love to use Carbonite with my prefered language but it doesn't work.

carbonite
 

.....

OMG i luv how you can simplify things ... i wrote a post and well wasnt as simple as you ... i hate how my brains works sometimes but you summed everything up and i have been reading the posts since the patch of 5.04 came out my roomie wont play without a working carbonite... people rely on it alot cause blizzards version of a smaller map for while out and a bout well really doesnt stack up or compare to carbonites map, among their also attempt for a quest tracker, wonder what else blizz will put in without letting the UI be scaled the way the user wants ...
but back to the things here ... i updated and did the official and noticed i was running 15-20 fps before i updated carbonite and when i updated it my fps dropped to 5fps to 1fps at times ... so theres an issue ...

If you can get your hands or still have my fan update, replacing localization.lua in the official 5.041 will make it work again. Sadly I know some have asked about russian but that's not one I got done before I had to stop.

I don't have line numbers in my LUA file. I'm having a hard time finding where to make these changes. Is it possible for someone to post what the original lines were, so I can search for them and then make the replacements?

Somewhere along the line I remember seeing something about how you can have page numbers in Notepad, but I don't remember how to get them, or where I saw it.

If you don't mind installing a small program to edit Lua files (and a lot of other types of code) you can get either Notepad++ or Sublime Text 2. They're free and not the only editors you can get, they're just the two that I like and use. (And they use page numbers.)

Thanks for that, I'll give one of them a try :)

What can I say ???? I'm a simple guy :) lol

I just wanted to get a, clear cut, quick overview out there, so peeps that didn't have the whole story, now have some sort of idea.

I know a lot of people have said that the OA's should take Rythal onto the team, in my view if I was Rythal, after the way he was treated when OA's came back (and hit him with the naughty stick n all) and they then turned round and asked him to join, my response would politely be along the lines of "Hell No, ya whining baby!" And I'm sure some will agree. Now I know some peeps will take this as a message of disrespect, this is not the case, I have great respect for what the OA's have done in the past. Just not for the way they have behaved in recent days.

I know this is kinda Hijacking the original topic so I'll try n shut up now :)

I still have Rythal's update installed. If I install 5.041 and do the fixes in this thread, will the result be better or worse then Rythal's version?

The fix doesnt work in mop beta

Pandaria map out of sync not working at all

World map islands are located differently in updated VS. Rythal
Rythal old one works in beta though

open it with notepad++

in notepad, open the edit menu, choose the 'go to' option (ctrl + G) and that will allow you to go to a spacific line number, if you want you can go to view - > status bar and the line number and column number will be shown in the bottom right part of the window, that is it shows the line number of the cursor.

Thanks, both, for the suggestions. Someone earlier mentioned notepad++ and it worked perfectly :)

DUDE!!! You have changed my life. It is finaly working with the german client. I don't know how to thank you.:banana::banana:


Worktrough i did:
Installed Carbonite 5.041
Fixed Carbonite.lua with Rythals posted Changes with Notepad C++
Replaced Cabonite 5.041 localization.lua with Rythals localization.lua

That's it! Maybe it will work with French and Spanish versions.

Thx again Rythal

Hi Rythal,
I was able to figure out where most of the fixes go in the current carbonite.lua from the updated version from Carbonites authors using normal Notepad from Windows 7. Notepat allows you to view status bar, then under tools go to a specific line.

Unfortunately the lines didn't exactly match from Notepad on my PC with the updated Carbonite.lua which was recently released.

I was able to search for terms, and find most of the code which supposedly needed to be modified.

Unfortunately I get a "Carbonite File Error" "Download Carbonite again".

I assume the changes affected the size of the file.

Is there any way to persuade Carbonite to accept the changes?

I'd like to have this stuff fixed, and am not able to figure out how to persuade Carbonite to run after making some changes to it's .LUA file. :(

That message is because one or more of the changes were not made right, you would need to turn on displaying lua errors to see which one. It's a default message when the addon has a problem not just because of the file size.

Version 5.041 do not work at me on RUru. no quest tracker, i don't can open tha map (same as the original map) and the questlog is the original blizzard questlog.There is too no welcome logo of carbonite and the only i can see, that carbonite is acitivated is, that the little carbonite symbol is shown at the minimap. it seems, that carbonite is not activated, but it is!

Please help me.... :(:(:(

I also cannot find the lines - I downloaded and installed notepad++ but the line numbers sure dont look like they match the suggested changes - any ideas?

5.041 working on Spanish client with these modifications and localization.lua from Rythal's fan update.

Thank you Rythal!!

I have placed a text file on my website if you want it with those fixes in it.

http://www.botclan.net/wow/Carbonite.txt

You will have to right click save target as and rename the file to .lua and replace the file in the Carbonite folder...

Hi all. I was typing and not using cut-n-paste, so I typed "self,BaA" when it is actually "self.BaA". I had a "duh" moment with that too because it's obviously a single attribute and not two parameters.

This did lead to that odd error about the file needing to be downloaded again. :)

Hope that helps some of you that are struggling, I'm back in business.

Easy fix/workaround for me in Dalaran was just right click map, Minimap, change Transparency to 0.00. It still leaves icons from what I can tell, and easier to get to since I like having my minimap overlay.

hi, im new to this sort of stuff, but ive done some of the patching and it works however i have noticed when i went into undercity i got a big black circle, is there a way to fix this please, love the addon :banana:

As already said, the only fix for that is to set minimap transparency to either 0 or 100 ... anything in between causes that to happen in broken zones :( You can turn it back to whatever you want after you leave the zone.

Thank you for continuing to support this addon.

As for my take on the situation, I think it takes balls of brass to continue to take donations and then sit on your arses giving your user base zero feedback.
I appreciate that this is your baby, but the very least you owe those who have donated is a quick sticked message on the forums or main page letting us know what is or isn't going to happen.

Thanks
 

Thanks for replying to my post in other forum. It worked!

Seriously? Apparently you are not aware that Rythal is not the original developer of Carbonite, he's a fan who has helped the community by providing fixes that the original developer has not provided. You owe Rythal a most abject apology.

I think Entropy was holding 2 conversations there. I initially read it as you did then realised that the paragraph separation could also imply that the second one is for the carbonite authors and the first one for Rythal.

if that was his intention he certainly could have made it more clear.:cool:

Rythal,

Just ran all the dungeons in Outland with a guild-mate to lvl them and noticed none of the maps are working there. Did your fix have the same issue or is this another "Official" bug?

I've also noticed you can't see party member's quests in the "Official" version either. I started blocking the code yesterday so I could locate that section and see what the problem is and couldn't help but end up with a better appreciation for the work you put into your update lol.

party member quests works, and doesn't work... for some reason the client is quitting the chat channel used to talk with group members, I haven't really looked into it beyond that.. I just know I created a new chat tab so I could watch the channel, and saw that I left it after a few minutes (when I was in it, my journal did show my parties quests right).

Not sure on outland maps, and with the servers going offline every couple minutes can't really check right now.

thanks for that must have missed it when reading :rolleyes:

So group questing is a chat channel? This is driving me nuts without it. Do you know of a fix or another addon that has group questing?

I really really want to thank you for showing the code in the lines to be replaced.

My notepad did not line up with the line numbers provided in the initial post.

Thank you, and thanks to Rythal.

I now have an updated Carbonite that actually works. :)

to get the numbers to line up download Notepad++, its free and works wonders!

Well so far it has tracked the quest updates of party members but the quest list itself is the issue I'm having. It has a white button that once turned on should show your party member's quests in your own quest list. Currently that button does absolutely nothing. Being able to see their quests in the list helps a ton when they can't share those quests.

Hey Rythal, thanks for the great fixes, I am still using yours rather than the "official" update.

Why not download some free patch software, fix and update everything, then post a link to the patch software and release a patch?

That way you aren't releasing anyone else's code, but at the same time making a "good" version of Carbonite available.

Just a thought....

original 2007-2012

i think we have to hold it.

i also have this problem.
if i start wow, i get the following error

Message: ..\AddOns\Carbonite\Carbonite.lua line 19737:
attempt to index local 'map' (a nil value)

Debug:
(tail call): ?
[C]: ?

Carbonite\Carbonite.lua:19737: ToS1()

Carbonite\Carbonite.lua:1597: ToggleFrame()
[string "*:OnClick"]:1:
[string "*:OnClick"]:1

no carbonite map, no quest tracker
i have replaced the carbonite.lua with the file from jovenyoung after i try to replace the lines by myself
i only see the wow-questlog and the wow-map... :-(

Can Somebody tell me pls easy and short what i have to do to use Carbonite the newest version with the German WoW Client that would be super Nice


MFG

I could do that, but
a) most people would get lost if I tried explaining how to use patch / diff, or would not like having to install new software.
b) every version of carbonite is different, so a patch for 5.041 would fail in every chunk for 5.042. Every time they did an update i'd have to find where the functions moved to then redo every change.

Hmmm, for a), a something like GNU Patch for Windows (or other similar software) should be portable, so if the patch.exe, the patch file, and a batch file were extracted into the addon directory, the user could just run the batch file and it would do the rest.

For b), doesn't the software to generate the patch look at both files and generate the patch? If you developed your own version starting with what you did before, and maintained it yourself adding features and fixing bugs without going back to their version at all, whenever an "official" release were made all you should have to do is run the patch/diff software against your .lua and their current one, and you should get a valid patch for that version, regardless of how different they were.

Which file needs to be edited?
I see various folders and i'm not sure if i'm editing the correct file..
:eek:

The file you will edit is Carbonite.lua in the Carbonite folder...

Someone posted the complete addon with fixes on thepiratebay website as well I believe...

(a) That's a whole lot of hoops to jump through to support someone else's addon.
(b) It is my understanding that they are still running a code obfuscator on their addon and not publishing the lua source they themselves are working with.
They've just adjusted it so it doesn't run afoul of Blizzard's addon policy in a very blatant and obvious way.

For that reason their lua code changes disproportionately between revisions and someone trying to fix the new one would have to start over duplicating all the work they did on the last one tracing functions and such.
(I'm assuming that's one of the reasons they still run an obfuscator on their code to discourage fan updates)