WoWInterface - Problems with Big Tables

Page 1 of 2

Show 60 post(s) from this thread on one page

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Problems with Big Tables (https://www.wowinterface.com/forums/showthread.php?t=52608)

Endzeit

08-13-15 07:51 AM

Problems with Big Tables

Edit#2:
It works now.. but i got stutter when hover over items.. is there a way with a ~1800 table to improve performance?
-----
EDIT:
i found the problem.. this is working:

Code:

local setName =  {

[1] = {  name = "Mystic's Regalia (Recolor)", items = {14090, 26008, 14094}, },

-- [2......1778]

[1779] = {  name = "Imperial Plate", items = {31436, 30002, 12424, 12425, 12422, 12427, 12429}, },

}

function addline_gametip()

local itemName,itemLink = GameTooltip:GetItem()

        if itemLink ~= nil then          

                local itemString = string.match(itemLink, "item[%-?%d:]+");

                local _, itemId, enchantId, jewelId1, jewelId2, jewelId3, jewelId4, suffixId, uniqueId, linkLevel, reforgeId = strsplit(":", itemString);



 for i = 1, #setName do

j = 1 

while j <= 8 do



if (setName[i]['items'][j] ~= nil) and (format("%u",itemId) == format("%u", setName[i]['items'][j])) then

                GameTooltip:AddLine("Transmog Set: " .. setName[i]['name'])

                GameTooltip:Show();

                end

j = j + 1

                end

 end

 end

 end



 



GameTooltip:HookScript("OnTooltipSetItem", addline_gametip);

-------

I'm working on my first wow addon and i'm a big newbie with lua and coding. I think im finished, but it dont work.

problems are the do while i think. here is my code:

Code:

local setName =  {

[1] = {  name = "Mystic's Regalia (Recolor)", items = {14090, 26008, 14094}, },

-- [2......1778]

[1779] = {  name = "Imperial Plate", items = {31436, 30002, 12424, 12425, 12422, 12427, 12429}, },

}



function addline_gametip()

local itemName,itemLink = GameTooltip:GetItem()

        if itemLink ~= nil then          

                local itemString = string.match(itemLink, "item[%-?%d:]+");

                local _, itemId, enchantId, jewelId1, jewelId2, jewelId3, jewelId4, suffixId, uniqueId, linkLevel, reforgeId = strsplit(":", itemString);



 for i = 1, #setName do

j = 1 

while j <= 8 do

 if (itemId == setName[i]['items'][j]) then

                GameTooltip:AddLine("Transmog Set: " .. setName[i]['name'])

                GameTooltip:Show();

                end

j = j + 1

                end

 end

 end

 end





GameTooltip:HookScript("OnTooltipSetItem", addline_gametip);

hope someone can help me :)

Mazzop

08-13-15 04:26 PM

cannot help on technical side and i am not sure if i get, what you trying to do :)
but what if you do table other way around and index by itemID with aray of sets name that item is in
adding tooltip then would be trivial

elcius

08-13-15 05:08 PM

lua has no problem with very large tables, just make an itemid to setid lookup table.

Lua Code:

local setName =  {
[1] = {  name = "Mystic's Regalia (Recolor)", items = {14090, 26008, 14094}, },
-- [2......1778]
[1779] = {  name = "Imperial Plate", items = {31436, 30002, 12424, 12425, 12422, 12427, 12429}, },
}
 
-- make lookup table, ideally this would be pre-made
local itemSet = {};
for i,set in pairs(setName) do
    for j, id in pairs(set['items']) do
        itemSet[id] = i;
    end
end
 
function addline_gametip()
    local itemName,itemLink = GameTooltip:GetItem();
    if not itemLink then return end
    
    local itemId = itemLink:match('item:(%d+)');
    local setIndex = itemSet[tonumber(itemId)];
    
    if setIndex and setName[setIndex] then
        GameTooltip:AddLine("Transmog Set: " .. setName[setIndex]['name']);
    end
 end
 
 
GameTooltip:HookScript("OnTooltipSetItem", addline_gametip);

Endzeit

08-14-15 07:19 AM

wow this works great. thanks :)

Next Step i want to add Message, when one of this Items received Loot.

Lua Code:

function AddLootMsg(self, event, message, ...)
    local itemName,itemLink = GetItemInfo(itemID);
    if not itemLink then return end
    local itemId = itemLink:match('item:(%d+)');
    local setIndex = itemSet[tonumber(itemId)];
 
        if setIndex and setName[setIndex] then
        DEFAULT_CHAT_FRAME:AddMessage("Hello, World!");
    end
end
 
ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT", AddLootMsg);

this is not working..
whats the different between GetItemInfo(itemID); and GameTooltip:GetItem(); ?
Can i use the same lookup table or i need a new one?
Can i use the same locals agains?

suicidalkatt

08-14-15 07:45 AM

Quote:

Originally Posted by elcius (Post 310319)

lua has no problem with very large tables, just make an itemid to setid lookup table.

~ Snip

While your method would be ideal, it doesn't really do what the author intended.

I believe they want to have the tooltip show every set that contains a particular itemID not just the first one that returns true.

Lua Code:

local setName =  {
[1] = {  name = "Mystic's Regalia (Recolor)", items = {14090, 26008, 14094}, },
-- [2......1778]
[1779] = {  name = "Imperial Plate", items = {31436, 30002, 12424, 12425, 12422, 12427, 12429}, },
}
 
-- make lookup table, this will create a list that looks something like this
--[[
local table = {
    [14090] = {201,560,888} -- Item id = Table of setName[index] values
}
]]
local itemSet = {}
do 
    for i,set in pairs(setName) do -- Looks through all the set
        for j, id in pairs(set['items']) do -- looks though just the items table within
            if not itemSet[id] then itemSet[id] = {} end -- creates a table within itemSet for each id (only once)
            tinsert(itemSet[id], i) -- inserts each set index into the table
        end
    end
end
 
function addline_gametip()
    local itemName,itemLink = GameTooltip:GetItem();
    if not itemLink then return end
    
    local itemId = tonumber(itemLink:match('item:(%d+)'));
    if itemSet[itemId] then -- if a set is found
        for i, setIndex in pairs(itemSet[itemId]) do -- for each index the id has
            GameTooltip:AddLine("Transmog Set: " .. setName[setIndex]['name']); -- add a line to the game tooltip
        end
    end
 end
 
 
GameTooltip:HookScript("OnTooltipSetItem", addline_gametip);

Endzeit

08-14-15 07:55 PM

thanks suicidalkatt & elcius.

Quote:

1 set = 1 itemid. Both variants are correct for me. ItemId 123456 can not be in 2 Sets in my table.

Lua Code:

function AddLootMsg(self, event, message, ...)
     if not string.match(message,'Hbattlepet') then
    local lootid = select(3, string.find(message, "item:(%d+):"))
    
    local itemName,itemLink = GetItemInfo(lootid);
    if not itemLink then return end
    
    
    local itemId = tonumber(itemLink:match('item:(%d+)'));
    
    if itemSet[itemId] then -- if a set is found
        for i, setIndex in pairs(itemSet[itemId]) do -- for each index the id has
        message = message:gsub("\124r.", "\124r (|cff9400D3Transmog Set: " .. setName[setIndex]['name'] .. "|cff00aa00).")
        return false, message, ...
 
    end
end
end
end
 
ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT", AddLootMsg);

thats my code for chat_msg_loot so far.. in my first tests it works.. have someone also an improvement for this code?

SDPhantom

08-15-15 12:45 AM

Since all the code is doing is matching items to set names, the lookup table doesn't need to be so complicated to use. Here's my example. There can be more optimizations depending on how you want the tooltip to look.

Lua Code:

local TransmogSets={
    {
        name="Mystic's Regalia (Recolor)",
        items={14090, 26008, 14094},
    },
    {
        name="Imperial Plate",
        items={31436, 30002, 12424, 12425, 12422, 12427, 12429},
    },
--  And so on ...
};
 
--  Lookup Table
local ItemSetNames={}; do
    for _,set in ipairs(TransmogSets) do--  Scan through all sets
        for _,itemid in ipairs(set.items) do--  Scan through items
--          Add set name to list in lookup table
            if not ItemSetNames[itemid] then ItemSetNames[itemid]={}; end
            table.insert(ItemSetNames[itemid],set.name);
        end
    end
 
--  Sorts set names
    for _,list in pairs(ItemSetNames) do table.sort(list); end
end
 
--  Tooltip Hook
GameTooltip:HookScript("OnTooltipSetItem",function(self)
    local _,link=self:GetItem();
    if not link then return; end--  Exit if we have no item
 
    local id=tonumber(link:match("|Hitem:(%d+)")) or 0;--   Force nil to zero if we have an invalid link (no items exist at index zero)
    if ItemSetNames[id] then
        for i,name in ipairs(ItemSetNames[id]) do
--          Only show our label on the first line
            self:AddDoubleLine(i<=1 and "Transmog Set:" or " ",name);
        end
    end
end);
 
--  Chat Hook
ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT",function(self,event,msg,...)
    local id=tonumber(msg:match("|Hitem:(%d+)")) or 0;--    Force nil to zero if we have an invalid link (no items exist at index zero)
    if ItemSetNames[id] then return false,msg.." (|cff9400d3Transmog Sets: "..table.concat(ItemSetNames[id],", ").."|r).",...; end
end);

Edit: Replaced string.join() section with more efficient table.concat() call.

Endzeit

08-15-15 01:06 PM

Lua Code:

--  Chat Hook
ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT",function(self,event,msg,...)
    local id=tonumber(msg:match("|Hitem:(%d+)")) or 0;--    Force nil to zero if we have an invalid link (no items exist at index zero)
    if ItemSetNames[id] then return false,msg.." (|cff9400d3Transmog Sets: "..string.join(", ",unpack(ItemSetNames[id])).."|r).",...; end
end);

works.. but it also show loot from other player.. this should not happen. i tried this:

Lua Code:

--  Chat Hook
ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT",function(self,event,msg,...)
    local id=tonumber(msg:match("|Hitem:(%d+)")) or 0;--    Force nil to zero if we have an invalid link (no items exist at index zero)
    if ItemSetNames[id] and LOOT_ITEM_PUSHED_SELF or LOOT_ITEM_SELF ~= nil then return false,msg.." (|cff9400d3Transmog Sets: "..string.join(", ",unpack(ItemSetNames[id])).."|r).",...; end
end);

this works for myself.. but get lua errors if other player loot items.

Mazzop

08-15-15 02:50 PM

try

Lua Code:

ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT",function(self,event,msg,who...)
  if who==UnitName("player")
    local id=tonumber(msg:match("|Hitem:(%d+)")) or 0;--    Force nil to zero if we have an invalid link (no items exist at index zero)
    if ItemSetNames[id]  then return false,msg,who.." (|cff9400d3Transmog Sets: "..string.join(", ",unpack(ItemSetNames[id])).."|r).",...; end 
  end
end);

Endzeit

08-15-15 03:13 PM

Quote:

Originally Posted by Mazzop (Post 310361)

try

Lua Code:

ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT",function(self,event,msg,who...)
  if who==UnitName("player")
    local id=tonumber(msg:match("|Hitem:(%d+)")) or 0;--    Force nil to zero if we have an invalid link (no items exist at index zero)
    if ItemSetNames[id]  then return false,msg,who.." (|cff9400d3Transmog Sets: "..string.join(", ",unpack(ItemSetNames[id])).."|r).",...; end 
  end
end);

this is not working.. lua errors.
also trying change from 'function(self,event,msg,who...)' to 'function(self,event,msg,who,...)'
and
' if who==UnitName("player")' to ' if who==UnitName("player") then'
no lua errors now, but is not working anymore

print(who); returns nothing like print();

Mazzop

08-15-15 03:23 PM

obviously i cannot drycode :)
its 5th argument, from fast /etrace

Lua Code:

ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT",function(self,event,msg,who,language,channelString,target,  ...)
      if target==UnitName("player") then
        local id=tonumber(msg:match("|Hitem:(%d+)")) or 0;--    Force nil to zero if we have an invalid link (no items exist at index zero)
        if ItemSetNames[id] then return false,msg,who,language,channelString,target,." (|cff9400d3Transmog Sets: "..string.join(", ",unpack(ItemSetNames[id])).."|r).",...; end 
      end
    end);

Endzeit

08-15-15 03:43 PM

this cannot be working like this
for example playername: "Killer"
target returns "Killer"
UnitName("player") returns "Killer nil"

Lua Code:

ChatFrame_AddMessageEventFilter("CHAT_MSG_LOOT",function(self,event,msg,_,_,_,target,  ...)
      local name, realm = UnitName("player")
      if target==name then
        local id=tonumber(msg:match("|Hitem:(%d+)")) or 0;--    Force nil to zero if we have an invalid link (no items exist at index zero)
        if ItemSetNames[id] then return false,msg.." (|cff9400d3Transmog Sets: "..string.join(", ",unpack(ItemSetNames[id])).."|r).",...; end 
      end
    end);

this works for UnitName("player"), cant check now if it works for other players

Mazzop

08-15-15 03:48 PM

instead of UnitName("player") use select(1, UnitName("player"))
or make a variable local playername=UnitName("player")

Seerah

08-15-15 07:27 PM

Quote:

Originally Posted by Mazzop (Post 310366)

instead of UnitName("player") use select(1, UnitName("player"))
or make a variable local playername=UnitName("player")

The second option here ^^ is WAY better than the first. 1) it eliminates a needless function call. 2) select(1, ...) will still return everything after that 1st return.

Torhal

08-15-15 08:45 PM

There's also the option of

Code:

(UnitName("player"))

That will only evaluate the first return value, but it's a bit non-obvious if you're looking at the code months later.

Phanx

08-16-15 01:55 AM

Quote:

Originally Posted by Mazzop (Post 310366)

select(1, UnitName("player"))

There is no reason to ever use select with 1 as the first argument. There's almost no reason to ever use select at all -- it's way slower than assigning variables, eg. local _, class = UnitClass("player") -- but there's really no reason to ever use it like this. >_<

Mazzop

08-16-15 02:38 AM

ok ok, select is big nono, i get it :)
dont wanna hijack topic, but not even here

instead of sexy and nice

Lua Code:

for j = 1, numbonuses do
  bonus[j] = select(14 + j, strsplit(":", itemstring))
end

would be better hideous abomination with numerous if depends of numbonuses and 14+ _ ?

Lombra

08-16-15 04:25 AM

Quote:

Originally Posted by Mazzop (Post 310376)

ok ok, select is big nono, i get it :)
dont wanna hijack topic, but not even here

instead of sexy and nice

Lua Code:

for j = 1, numbonuses do
  bonus[j] = select(14 + j, strsplit(":", itemstring))
end

would be better hideous abomination with numerous if depends of numbonuses and 14+ _ ?

A few calls here and there is not gonna make a difference. It's fine, and I'd say this is a perfectly reasonable situation in which to use it. That logic might be improved slightly in other ways, though!

Rilgamon

08-16-15 06:04 AM

Quote:

Originally Posted by Lombra (Post 310379)

A few calls here and there is not gonna make a difference.

Turn your logic around a little. The request was to improve the performance. And removing select will always be an improvement.

Lombra

08-16-15 10:36 AM

Quote:

Originally Posted by Rilgamon (Post 310381)

Turn your logic around a little. The request was to improve the performance. And removing select will always be an improvement.

Sure, but I didn't read the word "performance" anywhere, only "better". If the performance gain is negligible I would definitely go for readability.

Edit: Without wanting to make a point of it, just did some quick benchmarks so people can get an idea of the difference.
This takes 43 ms to run:

Code:

for i = 1, 1e6 do

        local a, b, c = 1, 2, 3, 4, 5, 6, 7, 8, 9

end

This takes 94 ms to run, with the first select argument not affecting the result. No local reference.

Code:

for i = 1, 1e6 do

        local a, b, c = select(1, 1, 2, 3, 4, 5, 6, 7, 8, 9)

end

That's one million iterations, with each value adding a few ms in both tests.

All times are GMT -6. The time now is 04:37 AM.

Page 1 of 2

Show 60 post(s) from this thread on one page