Rogue combo points 6 and 9, confused how we get to 9
Not sure where to ask this. In comboframe.lua there is a comment that says this.
-- If we have 6 or 9 max combo points, we use the first combo point and we show 6 circles -- in a row. Otherwise we skip the first combo point and show 5 circles. The last 3 combo -- point circle (if you have the talent to allow this) are shown only if filled. I looked thru rogue stuff and the most they can have is 8 combo points. I even selected the talent. And looked at the max combo points which came out to 8. I looked thru all the legendary items and artifact powers and found nothing that adds an additional combo point to get to 9. It looks like blizzard is making the code behind combo points more complicated. Any ideas? |
Typo?
ComboFrame.xml should identify the max. number of points available if exporting the interface is allowed yet. |
theres code that checks for it.
Code:
function ComboFrame_UpdateMax(self) The XML goes up to 9. Surprised these forums are not getting busy yet. Addons been enabled. |
Addons may be enabled but authors haven't been invited... well, not many of them yet.
|
Rogues in Legion have two talents that increase their max combo points, both on the same tier.
One is Deeper Stratagem, which increases the max to 6. The other is Anticipation, which was modified from it's live form of using charges, to in Legion, increasing your max CP to 8 not 9. I have confirmed this on alpha that if I do Code:
/dump UnitPowerMax("player", SPELL_POWER_COMBO_POINTS) It's possible that there is another way of getting that one additional CP, but honestly I think this is just a miscommunication between the class team and the UI team. edit: In Blizzard_NamePlates/Blizzard_ClassNameplateBar_RogueDruid.lua they have this: Lua Code:
|
Ok 9 points in the xml is real. I see what they're doing now. They left it flexible in the code.
1 to 6 is normal points also includes the talent Deeper Stratagem 7 to 9 is always anticipation points They have an offset start from 1 for 6 or 9. Then start from 2 for everything else. This way 7 to 9 in the code is always anticipation points. The UI will show the following based on UnitPowerMax() 6: The UI can show up to 6 circles 9: The UI can show up to 6 circles, then 3 small circles Less than 6: The UI can show up to 5 circles 7 or 8: The UI can show up to 6 circles. Then 1 or 2 small circles. This flexibility covers future changes, if they decide rogues will get an extra combo point from something. On top of what they get now. Just found out about ComboFramePlayer.lua which has combo points as well. Not sure how that works with ComboFrame.lua Is one of these for the heads up display below your character, and the other is for the portrait? EDIT: ComboFrame.lua doing similar, using 1 to 6, then 1 to 3 for bonus. Then if its 5 its 1 to 5, no bonus. If 8 then its same with bonus. If 6 then then just 6 with no bonus. This also does some fancy animation stuff when bonus points gets moved to normal. So what do we have 3 separate lua files? one for nameplates, portrait, and heads up |
All times are GMT -6. The time now is 08:12 AM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI