L["...."] addings in Files
I'm a bit Angry. When you add NEW L["..."] PLEASE add it also to the Lang files. I work atm at NxWeekly.lua and the enUS differs a lot from the others.
So Please; 1. Add new L["..."] to ALL other language Files (enUS, itIT, etc ......) 2. Add NEW L["..."] AT THE END OF THE TRANSLATIONFILE !!!!!!!! So it's esier to take a look, what missing With my next Commit: If you want to Translate a Boss of WoW use B["BOSS"] |
|
Quote:
ATM I don't have access to github so I can't make a pull for it. |
@atl77: Please take a look into existing PR's before you breaking the Languages. ;) Because you are only adding L[...] to deDE.lua and not to others. ;)
|
Sorry had to do some things. I think atl77 hasn't pulled your Request out of same Idea I don't pull it for the moment I Know the Github Version is thrwoing Errors at the Moment, but your change with lib should be decided by Rythal and thats why I don't pull nelegalnos pull for the Moment wants to wait until rythal decides if we pull gOOvERs request first than I will manually merge nelegalnos pull and go further with my Ideas for bindings
Greetings Samyonair |
I am the main culprit in not adding them to every language besides enUS, and that's because the people working on translating have not needed them moved. When I do the push, someone is right there to duplicate the new strings across to the rest of the language files and i've gotten use to that.
When i'm working, localization is the last thing on my mind, and usually the last thing I do. I ignore the errors that it's not in the locale files, then I add them all to enUS and push it then move onto the next bug. |
and what error is the github throwing? the only one I knew of was the Seals and I fixed that 5 minutes after it was reported.
|
Because you have done your merge without translated Lterms all languages apart from enUS, and German (because of atl77) are throwing arrors because of missing L terms
Greetings Samyonair |
I must completely misunderstand how the acelocale works, it was my understanding if it's declared in enUS it uses that as the default, if your using another locale language and it wasn't replaced, then go back to the default one and use that, which was why enUS was declared the default language during table initializations.
|
I thought so... reading the page again on acelocale, and it is suppose to work the way I thought it was with enUS declared the default.
|
Silent flag was just added, acelocale should never again return an error.
|
I think then it is a good Idea if the Translators put their changes byself by compaering locales files with enUS because this removes many merge conflicts
greatings Samyonair |
i think silent flag in dev version are counterproductive, this helps not to find errors or missing translations.
|
the silent flag is only for locales files, our Problem is we have Translators for almost all supported Languages and they transmit their files, and a change in time between working on translations and a codechange leaves more problems then a missing term,
greetings Samyonair |
Quote:
I really don't understand what changed, as besides the initial push I never updated the other languages besides enUS, and this is the first i've heard of errors coming from it, warnings yes but not errors. |
Wait... maybe I'm getting cross-confused, when you said errors I thought you meant ingame LUA errors and that's what I was trying to fix up, are you meaning the github is throwing errors because it can't merge.
|
No I thought on lua errors I mixed it sorry
for declaretion Lua errors missing L Terms and merge conflicts by changeing translation files by 1. Translator works on translations 2. fix / enhancement : pushed to all languagefiles 3. Translator pulls his Version from 1 merge confict because files defer greetings Samyonair easy way for development Guide for Translators Howto remove silent flag to develop My thought was you do only enUS to don't create merge conflicts |
Proposal: silent for release only
Even though I believe the translator will spot missing translations sooner or later, I also think the silent option should only be set for releases. How about setting a flag to tell if a version is a release version and putting that into the locale definition instead of "true"?
|
Quote:
|
All times are GMT -6. The time now is 05:31 AM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI