WoWInterface - action bar wont show on last boss in dtk

WoWInterface (https://www.wowinterface.com/forums/index.php)

- nUI: Bug Reports (https://www.wowinterface.com/forums/forumdisplay.php?f=90)

- - action bar wont show on last boss in dtk (https://www.wowinterface.com/forums/showthread.php?t=46266)

action bar wont show on last boss in dtk

on last boss in drak tharon keep when boss changes u into skeleton the action bar for the skeleton buttons doesnt show any idea how to fix that?

using nui5 incase u wondering which

Looking at the some web searches on that boss it looks like there may be problems getting the right bar to appear.

2 Sep 2012 - http://us.battle.net/wow/en/forum/topic/6490009164 - When Tharon'ja transforms the group to undead, the special action bar does not appear.

14 Feb 2013 - http://us.battle.net/wow/en/forum/topic/7922982721 - Tharonja removed all my abilities

30 Dec 2012 - http://www.curse.com/forums/games/wo...itching-during - On the last boss of Drak'Tharon Keep, where you get transformed into a skeleton, your first action bar should switch to a new set of abilities. Mine doesn't.

Reply on the last one .. 'With both BT4 and Dominos, there is an option per action bar to switch with vehicle, but I believe it is off by default. In any case, I'm fairly certain that's what you want. '

So sounds like there is another macro action bar setting that needs to be set for this type of thing that might be hidden somewhere in Bartender and Dominos.

dont have bt4 and dominos installed in addons only have nui installed for addon so is there a way to turn that action bar on in nui

nUI should automatically change action bars so I suspect there is another setting that bartender addon knows about that nUI doesn't. hopefully it is easy to find.

Edit 1: I was posting those example links to help explain that it is a blizz fault that is likely causing it as it was happening without any addons for someone.

Edit 2: Unfortunately I can't see what setting nUI needs to make as I cannot locate the settings in bartender that even remotely looks like how nUI sets its bars up with. And without an easier way of testing I can't even play with it to track down the setting like I did with all the other possible settings.

Edit 3: Looking at the blizz coding it is possible that it is linked to the following which may or may not be in nUI .

Lua Code:

elseif (HasTempShapeshiftActionBar()) then
      MainMenuBarArtFrame:SetAttribute("actionpage", GetTempShapeshiftBarIndex());

I will try and take a look before I start playing tomorrow.

does same thing with quest in vash

vision of the past: invasion of vashj'ir
reoccupation

if u want to know which class playing it on its a monk thought i let u know if that helps

thanks.

Looks like I can solo dtk with my paladin so just ran through it without addons and can see it working but none of my debug code is showing which is worrying:

Lua Code:

local eventFrame = CreateFrame("Frame","XUI_ActionBar_Events")
 
local function CheckEvents(self,event,...)
    local args = { ... }
    print(event,args[1],args[2],args[3],args[4],args[5])
 
    print("HasVehicleActionBar() = ", HasVehicleActionBar())
    print("HasOverrideActionBar() = ", HasOverrideActionBar())
    print("HasTempShapeshiftActionBar() = ", HasTempShapeshiftActionBar())
    print("HasBonusActionBar() = ", HasBonusActionBar())
    print("HasTempShapeshiftActionBar() = ", HasTempShapeshiftActionBar())
    
end
 
 
eventFrame:RegisterEvent("ACTIONBAR_PAGE_CHANGED")
eventFrame:RegisterEvent("UPDATE_BONUS_ACTIONBAR")
eventFrame:RegisterEvent("UPDATE_VEHICLE_ACTIONBAR")
eventFrame:RegisterEvent("UPDATE_OVERRIDE_ACTIONBAR")
eventFrame:RegisterEvent("UPDATE_SHAPESHIFT_FORM")
eventFrame:RegisterEvent("UPDATE_POSSESS_BAR")
eventFrame:RegisterEvent("UPDATE_EXTRA_ACTIONBAR")

So now testing the tournament ground area to see if my debug tests are working there.

edit: oops, forgot to set the script to run rofl .. oh well need to empty the bags after the first run , so will reset and try again.

edit2: second screenshot shows what my mini addon does. As you can see it correctly recognises that it has loaded the vehicle action bar.

Okay, looks like I was right. Draktharon Keep uses the TempShapeshift Bar for those abilities.

Now to see how nUI can be fixed to work with it.

Scott, need your help :D

Added the following to the event checks in nUI5's nUI_ButtonBar.lua file and it is triggering but I can't remember how to tell the actionbar to change this way.

Lua Code:

elseif ( event == "UPDATE_SHAPESHIFT_FORM" ) then
        if ( HasTempShapeshiftActionBar() ) then
            print("HasTempShapeshiftActionBar: ", HasTempShapeshiftActionBar(), " Action Page = ", GetTempShapeshiftBarIndex() )
            nUI_ActionBar:SetAttribute( "actionpage", GetTempShapeshiftBarIndex() );
        end

For your reference the TempShapeshiftBar is the same bar number as the ExtraActionBar which is 13.

yeah since the quests in vash uses the same script as boss in dtk. anyway for temp fix for it or need to wait for scott

I'm trying to fix it but Scott understands how nUI and the secure action bars work better than myself. I don't think I have anyone that can quickly get to the vash quest stage so just redoing the dungeon over and over on my pally ... would have been better if it was the first boss but of course its not that easy rofl.

Edit: Okay, tried various ways the other addons have got this working but none of them seem to work with nUI so there must be something else I have to do for nUI to register the change.

Current code I have adjusted Scott is :

Lua Code:

nUI_ActionBar:SetAttribute('updatePage', [[
        local newPage = 0
    
        if HasTempShapeshiftActionBar() then
            newPage = GetTempShapeshiftBarIndex() or 0
        else
            newPage = 0
        end
        
        local oldPage = self:GetAttribute('actionpage') or 0
        if newPage == 0 then
            newstate = newPage
        else
            newstate = oldPage
        end
    ]])
        
 
        nUI_ActionBar:SetAttribute( 
            "_onstate-page", 
            [[
            
                self:RunAttribute( "updatePage" )
 
                self:SetAttribute( "actionpage", tonumber( newstate ) );
                
                for i, button in ipairs( ChildList ) do
                    if not button:GetAttribute( "nUI_ActionButtonOverlay" ) then
                        button:SetAttribute( "touch", nil )                 
                    end
                end                         
            ]]
        );

and

Lua Code:

elseif ( event == "UPDATE_SHAPESHIFT_FORM" or event == "UPDATE_BONUS_ACTIONBAR" ) then
        if ( HasTempShapeshiftActionBar() ) then
            print("Event is : ", event, ", Has Temp Shapeshift bar so trying to switch page to the new bar, and actionpage is : ",nUI_ActionBar:GetAttribute("state-page"))
            
            if ( HasBonusActionBar() or HasOverrideActionBar() or HasVehicleActionBar() or HasTempShapeshiftActionBar() ) then
                if (HasVehicleActionBar()) then
                    print("VehicleBarIndex =", GetVehicleBarIndex())
                elseif (HasOverrideActionBar()) then
                    print("OverrideBarIndex = ", GetOverrideBarIndex())
                elseif (HasTempShapeshiftActionBar()) then
                    print("TempShapeShiftBarIndex = ", GetTempShapeshiftBarIndex())
                elseif (HasBonusActionBar() and GetActionBarPage() == 1) then
                    print("BonusBarIndex = ", GetBonusBarIndex())
                else
                    print("ActionBarIndex = ", GetActionBarPage())
                end
            else
                print("No special bar so using Action Bar Page: ", GetActionBarPage())
            end
 
            
            if not InCombatLockdown() then
            else
                print("In Combat so unable to switch")
            end         
        end
            
    end

it consistently displays TempShapeshiftBar as 13 everytime it switches me but the bar doesn't ever change because the TempShapeShiftBar isn't set when you first load the addon so the page setup doesn't seem to change as it always shows the actionpage as 1

Xrystal -- I'm not sure if I can get to this or not until this coming weekend... I've got to travel on business this week and won't be back until Friday around 5:30 -- unless I end up locked up in a hotel room with time to spare, I'm not going to get to look at it. If I do... I'll holler. Otherwise, it will likely be Saturday before I see it.

Thanks Scott,

If I get a brainwave and fix it I'll let you know

was wondering did u ever find a fix for this? was lvling a few more chars through vash and still encountered same problems as couple months back

I suspect the culprit may be this line in nUI_ButtonBar.lua:

Code:

RegisterStateDriver(nUI_ActionBar, "page", "[vehicleui] 12; [overridebar] 14; [bar:2] 2; [bar:3] 3; [bar:4] 4; [bar:5] 5; [bar:6] 6; [bonusbar:1] 7; [bonusbar:2] 8; [bonusbar:3] 9; [bonusbar:4] 10; [bonusbar:5] 11;1" );

It is a sort of lookup table that controls what bar is displayed based on what bar the Blizzard UI says to display.

I have hacked my version so that it doesn't use different bar for Moonkin form, as described here:

http://www.wowinterface.com/forums/s...ad.php?t=46554

Anyway, the statement above is a sort of conditional, which takes the first matching value, and if nothing matches, it uses bar 1 (the default). I notice there is no entry for the tempshapeshift bar (bar 13), so when Blizzard says to load that one, nUI will load bar #1 (I think...).

Edit: Ah, the wonders of Google. It looks like the match for bar 13 was removed to fix some other problem...by Xrystal:

http://www.wowinterface.com/forums/s...8&postcount=16

I have been testing this again and again with my pally and I have not as yet been able to identify a way to get it to work. At least not with the way nUI5 is currently coded to work. My knowledge of secure coding is not as extensive as Scotts so I'm currently at an impasse.

Just tested the dungeon in the latest nUI6 version and the bar doesn't show there but so far I have been unable to get some debug code in place to identify where to start testing code changes.

Well, save me messing up my copy of nUI6 beyond recognition I thought I would see if I could create a simple actionbar and get it to do the switches and test things that way ... not working quite like I planned though so Scott, a little help if possible.

The below is the whole of my code and it works in the sense that the main action bar appears and is useable and even has some basic functionality because of the templates I used.

However, despite it shifting when I use it on my warlock and shift into meta mode it doesn't work on my druid in ANY of her forms nor when doing the farming ( OVERRIDEBAR ) and definitely no closer to figuring out DTK last boss problems with it.

Any idea as to why it isn't working Scott ? Or anyone else looking in that understands Secure Handling.

Oh, and I take it that the secure snippet blocks don't allow print output commands for debugging ?

Lua Code:

local addonName,addonData = ...
 
local actionBarFrame = CreateFrame("Frame","XUI_ActionBar_Frame",UIParent,"SecureHandlerStateTemplate,SecureHandlerAttributeTemplate,SecureHandlerShowHideTemplate")
local eventFrame = CreateFrame("Frame","XUI_ActionBar_Events")
 
local function CheckEvents(self,event,...)
    local args = { ... }
    print(event,args[1],args[2],args[3],args[4],args[5])
    print("HasVehicleActionBar() = ", HasVehicleActionBar())
    print("HasOverrideActionBar() = ", HasOverrideActionBar())
    print("HasTempShapeshiftActionBar() = ", HasTempShapeshiftActionBar())
    print("HasBonusActionBar() = ", HasBonusActionBar())
    print("HasPossessBar() = ", IsPossessBarVisible())
    print("HasExtraBar() = ",HasExtraActionBar())
 
    
    if ( event == "ADDON_LOADED" and args[1] == addonName ) then
        actionBarFrame:SetPoint("CENTER",UIParent,"CENTER",0,0)
        actionBarFrame:SetAttribute( "XUI_ActionType","ACTIONBUTTON" )
        actionBarFrame:SetAttribute( "actionpage", 1 );
        actionBarFrame.Buttons = { }
        local lastButton = nil
        for i = 1,12 do
            actionBarFrame.Buttons[i] = CreateFrame("CheckButton","$parent_Button_"..i,actionBarFrame,"SecureActionButtonTemplate,ActionBarButtonTemplate")
            actionBarFrame.Buttons[i]:SetID(i)
            actionBarFrame.Buttons[i]:SetAttribute("action", i );
            actionBarFrame.Buttons[i]:Show()
            if ( lastButton ) then
                actionBarFrame.Buttons[i]:SetPoint("TOPLEFT",actionBarFrame.Buttons[i-1],"TOPRIGHT",1,0)
            else
                actionBarFrame.Buttons[i]:SetPoint("TOPLEFT",actionBarFrame,"TOPLEFT",1,0)
            end
            lastButton = actionBarFrame.Buttons[i]
            ActionButton_UpdateAction(lastButton);
        end
        RegisterStateDriver( actionBarFrame, "visibility", "[petbattle] hide; show" );
 
        actionBarFrame:Execute(
            [[
                ChildList     = newtable( self:GetChildren() );
                ActionButtons = newtable();
                actionType    = self:GetAttribute( "XUI_ActionType" );
                
                local j = 1;
                
                for i, child in ipairs( ChildList ) do
                    if child:GetAttribute( "XUI_ActionType" ) then
                        ActionButtons[j] = child;
                        j = j+1;
                    end
                end
            ]]
        );
 
        actionBarFrame:SetAttribute(
            "updatePage",
            [[
 
                if ( newstate ~= "custombar" ) then return end
 
                local newIndex = 0
                local oldIndex = self:GetAttribute( "newstate" )
 
                if ( ( HasVehicleActionBar() and UnitVehicleSkin("player") and UnitVehicleSkin("player") ~= "") 
                or ( HasOverrideActionBar() and GetOverrideBarSkin() and GetOverrideBarSkin() ~= "") ) then
                    if ( HasVehicleActionBar() ) then
                        newIndex = GetVehicleBarIndex()
                    else
                        newIndex = GetOverrideBarIndex()    
                    end
                else
                    if HasVehicleActionBar() then
                        newIndex = GetVehicleBarIndex()
                    elseif HasOverrideActionBar() then
                        newIndex = GetOverrideBarIndex()
                    elseif HasTempShapeshiftActionBar() then
                        newIndex = GetTempShapeshiftBarIndex()
                    elseif HasBonusActionBar() and GetActionBarPage() ~= 1 then
                        newIndex = GetBonusBarIndex() 
                    else
                        newIndex = GetActionBarPage()
                    end
                else
                    newIndex = GetActionBarPage()
                end
                if ( newIndex == 0 ) then
                    newstate = oldIndex
                else
                    newstate = newIndex
                end
                print("newState=",newstate)
            ]]
            )
 
        actionBarFrame:SetAttribute( 
            "_onstate-page", 
            [[
 
                print(newstate)
                self:RunAttribute("updatePage")
                print(newstate)
                self:SetAttribute( "actionpage", tonumber( newstate ) );                
                print(newstate)
                for i, button in ipairs( ActionButtons ) do
                    button:SetAttribute( "touch", nil )
                end         
 
            ]]
        );        
 
        actionBarFrame:SetAttribute( 
            "_onshow", 
            [[
                for i, button in ipairs( ActionButtons ) do
                    button:SetAttribute( "touch", nil )
                end         
            ]]
        );              
 
        RegisterStateDriver( actionBarFrame, "page", "custombar; 1" );
        actionBarFrame:Show()
 
    end
    
end
 
eventFrame:RegisterEvent("ACTIONBAR_UPDATE_STATE")
eventFrame:RegisterEvent("ADDON_LOADED")
eventFrame:RegisterEvent("ACTIONBAR_PAGE_CHANGED")
eventFrame:RegisterEvent("UPDATE_BONUS_ACTIONBAR")
eventFrame:RegisterEvent("UPDATE_VEHICLE_ACTIONBAR")
eventFrame:RegisterEvent("UPDATE_OVERRIDE_ACTIONBAR")
eventFrame:RegisterEvent("UPDATE_SHAPESHIFT_FORM")
eventFrame:RegisterEvent("UPDATE_POSSESS_BAR")
eventFrame:RegisterEvent("UPDATE_EXTRA_ACTIONBAR")
 
eventFrame:SetScript("OnEvent",CheckEvents)

I should (hopefully) have a little time when I get home this evening... assuming I can drag myself through the door. I'll try and have a look at it then.

Well, after some research on State Handling - something minimal on what is happening to pets - I managed to use the same approach on the action bar paging ... it correctly reports the right page based on the blizzard special coding I filched that tests for the things a macro conditional can't test for.

However, not all the action bar buttons themselves aren't changing. Using them executes the right function but visually they are the wrong ones. But only a couple of them are having this problem.

Once I get that part figured out for my druid stance changes I can work on the next stage. I'm sure it will end up being some little thing I messed up on.

This issue here is taint. There's a lot the Blizz code does with the action buttons that addons cannot because of secure execution. When we start trying to code the stuff that Blizz is doing ourselves to work around the missing macro, then we start throwing taint.

I've asked Blizz for a macro and I think it's in the latest PTR drop. I'm testing on the PTR today, so I'll report back what I find.