WoWInterface - EquipSetManager and icon replacements

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Legion Beta archived threads (https://www.wowinterface.com/forums/forumdisplay.php?f=177)

- - EquipSetManager and icon replacements (https://www.wowinterface.com/forums/showthread.php?t=54305)

EquipSetManager and icon replacements

If you are using custom icon replacements, as in putting your own tga files into Interface\ICONS, the EquipmentManager icon selector will fail to set a correct icon path for every spell whose icon you are trying to use and fall back to the question mark icon.

Video: https://dl.dropboxusercontent.com/s/..._09-18-35.webm
(I am using an addon in the video that expands the icon selection screen, but the problem happens without any addons, too)

Example of such a icon pack: http://www.wowinterface.com/download...nPackBlue.html

I've seen a number of people having this problem

http://us.battle.net/forums/en/wow/topic/20747745286
https://www.wowace.com/addons/larger...ger-selection/

GetEquipmentSetIconInfo() would start returning texture paths with a dot appended (?) after the inventory gear items and in alphabetical order
Same for GetSpellorMacroIconInfo() after the class specific spell icons

With Equipment Manager window open:

Lua Code:

/run for i = 15, 20 do print(i, GetEquipmentSetIconInfo(i)) end

Lua Code:

15, 133452
16, 1034142
17, 1085039
18, "6BF_Blackrock_Nova."
19, "6BF_Explosive_Shard."
20, "6BF_Retched_Blackrock."

That looks like it's from GetLooseMacroItemIcons() and GetLooseMacroIcons()
https://github.com/Gethe/wow-ui-sour...ua#L2040-L2041

(Edit) I was wrong about that part, I'm guessing it's SaveEquipmentSet() only accepting FileDataIDs, while CreateMacro() accepts both FileDataIDs and texture paths (with or without dot)

Lua Code:

CreateMacro("test1", 135953) -- works
CreateMacro("test2", "Spell_Holy_Renew") -- works
CreateMacro("test3", "Spell_Holy_Renew.") -- works
 
SaveEquipmentSet("test1", 135953) -- works
SaveEquipmentSet("test2", "Spell_Holy_Renew") -- does not work (question mark)
SaveEquipmentSet("test3", "Spell_Holy_Renew.") -- does not work (question mark)
 
SetGuildBankTabInfo(1, "test1", 135953) -- works
SetGuildBankTabInfo(1, "test2", "Spell_Holy_Renew") -- works
SetGuildBankTabInfo(1, "test3", "Spell_Holy_Renew.") -- works

Certain (?) custom/skinned iconsthat are not normally macro icons would only work as FileDataIDs

Lua Code:

CreateMacro("test1", 1392922) -- works
CreateMacro("test2", "70_inscription_deck_Hellfire_3") -- does not work (green)
CreateMacro("test3", "70_inscription_deck_Hellfire_3.") -- does not work (green)
 
CreateMacro("test1", 236834) -- works
CreateMacro("test2", "Achievement_Zone_StormPeaks_03") -- works
CreateMacro("test3", "Achievement_Zone_StormPeaks_03.") -- works

Preventing them from filling the *_ICON_FILENAMES tables is a workaround at least

Lua Code:

GetLooseMacroItemIcons = function() end
GetLooseMacroIcons = function() end

This won't fix custom icons (as in custom icon paths from addons) though, the duplicates(?) just won't show up in the icon selector

Those custom icons don't seem to get accepted for CreateMacro / SaveEquipmentSet either way
http://us.battle.net/forums/en/wow/topic/20748014713 (I didn't know Gello was aware of it much earlier)

(I'd like to post this on the US forums but I'm on EU)