WoWInterface - Errors in small coordinates addon. Would appreciate help.

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Errors in small coordinates addon. Would appreciate help. (https://www.wowinterface.com/forums/showthread.php?t=55751)

Errors in small coordinates addon. Would appreciate help.

Lua Code:

local CoordText = WorldMapFrame.BorderFrame.TitleText
 
local totalElapsed = 0
WorldMapDetailFrame:HookScript('OnUpdate', function(self, elapsed)
    if(totalElapsed > 0.1) then
        if(WorldMapScrollFrame:IsMouseOver()) then
            local scale = self:GetEffectiveScale()
            local centerX, centerY = self:GetCenter()
            local width, height = self:GetSize()
            local x, y = GetCursorPosition()
 
            x = ((x / scale) - (centerX - (width / 2))) / width
            y = (centerY + (height / 2) - (y / scale)) / height
 
            CoordText:SetFormattedText('%.0f , %.0f', x * 100, y * 100)
            CoordText:SetTextColor(0, 1, 0)
        else
            local x, y = GetPlayerMapPosition('player')
            CoordText:SetFormattedText('%.0f , %.0f', x * 100, y * 100)
            CoordText:SetTextColor(1, 1, 0)
        end
 
        totalElapsed = 0
    else
        totalElapsed = totalElapsed + elapsed
    end
end)

Is throwing this error, repeatedly.

Code:

25x Tweaks\Coordinates.lua:19: attempt to perform arithmetic on local 'x' (a nil value)

Tweaks\Coordinates.lua:19: in function <Tweaks\Coordinates.lua:4>



Locals:

self = WorldMapDetailFrame {

 0 = <userdata>

}

elapsed = 0.015000000596046

x = nil

y = nil

(*temporary) = <function> defined =[C]:-1

(*temporary) = WorldMapFrameTitleText {

 0 = <userdata>

}

(*temporary) = "%.0f , %.0f"

(*temporary) = nil

(*temporary) = nil

(*temporary) = nil

(*temporary) = nil

(*temporary) = nil

(*temporary) = nil

(*temporary) = nil

(*temporary) = "attempt to perform arithmetic on local 'x' (a nil value)"

totalElapsed = 0.11200000345707

CoordText = WorldMapFrameTitleText {

 0 = <userdata>

Any ideas as to why? It seems to happen inside instances.

Thanks.

Quote:

Originally Posted by Lesteryoung (Post 325208)

Any ideas as to why? It seems to happen inside instances.

Patch 7.1 disabled the player location API in instances. Blizzard stated beforehand that it should fail silently, but they lied, like they usually do when PR and code mix, since no one involved with PR actually knows or understands code changes. Same thing happened in 7.2 when they protected friendly nameplates, which spat many errors as well.

If this is your code, you're going to have to account for any location-based API, such as coordinates or facing, returning nil values. If this is an addon you are using, update it.

It's not my code, but from someone on here that I got a year or so ago.

I wouldn't really feel comfortable updating, I'd probably just break it more.

You could probably just replace line 19 with

lua Code:

if x and y then CoordText:SetFormattedText('%.0f , %.0f', x * 100, y * 100) end

Could just check for it as well.

Lua Code:

if x ~= 0 and y ~= 0 then
    CoordText:SetFormattedText('%.0f , %.0f', x * 100, y * 100)
else
    CoordText:SetText('')
end

Quote:

Originally Posted by Kanegasi (Post 325209)

Blizzard stated beforehand that it should fail silently, but they lied,

It does fail silently. It doesn't give an error when the function is called within instances, it just returns a nil value. The error happens when someone tries to do something they can't with a nil value.

Thanks all. Appreciate the help.

Quote:

Originally Posted by Kkthnx (Post 325212)

Could just check for it as well.

Lua Code:

if x ~= 0 and y ~= 0 then
    CoordText:SetFormattedText('%.0f , %.0f', x * 100, y * 100)
else
    CoordText:SetText('')
end

This will throw an error if x and y are both nil.

Quote:

Originally Posted by semlar (Post 325215)

This will throw an error if x and y are both nil.

Weird, never had an issue with it since I had to change to it.

In an instance, nil is returned for the x and y coordinates.

Since nil ~= 0 ...

Lua Code:

if x ~= 0 and y ~= 0 then   --> true
    CoordText:SetFormattedText('%.0f , %.0f', x * 100, y * 100)   --> attempt to perform arithmetic on a nil value
else
    CoordText:SetText('')
end