WoWInterface - Using LUA but having problems with making a button...

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Using LUA but having problems with making a button... (https://www.wowinterface.com/forums/showthread.php?t=47740)

Using LUA but having problems with making a button...

that does not use UIPanelButtonTemplate for a background. Would love to have a button that is just the text itself or an icon or "|TInterface\\TargetingFrame\\UI-RaidTargetingIcon_6:14:14|t" as an example.
I just like clean interfaces and believe that having just the raid icon itself against the background of the frame would be great. I could probably do it in XML but Phanx pointed out everything should be done in Lua, so I shifted my whole project to that Lei ShenCoordinator 2.
The buttons that I currently have use the following code:

Lua Code:

local function CreateBasicButton(parent, name, text, tooltipText)
    local button = CF("Button", name, parent, "SecureActionButtonTemplate, UIPanelButtonTemplate")
    button.text = _G[button:GetName().."Text"]
    button.text:SetText(text)
    button:SetWidth(30)
    button:SetHeight(30)
    button:SetScript("OnEnter", function(self)
      GameTooltip:SetOwner(self, "ANCHOR_TOP")
      GameTooltip:AddLine(tooltipText, 0, 1, 0.5, 1, 1, 1)
      GameTooltip:Show()
    end)
    button:SetScript("OnLeave", function(self) GameTooltip:Hide() end)
    return button
  end
 
  --create world marker buttons
local button = CreateBasicButton(LeiShenCoordinator, "Button", "|TInterface\\TargetingFrame\\UI-RaidTargetingIcon_6:14:14|t", "Raid Marker 1\nRight-click to clear")
    button:RegisterForClicks("LeftButtonUp", "RightButtonUp")
    button:SetAttribute("type", "macro")
    button:SetAttribute("macrotext", format("/wm 1"))
    --if not previousButton then
      button:SetPoint("TOPRIGHT", LeiShenCoordinator, -120, -80)
      button:SetAttribute("type2", "macro")
    button:SetAttribute("macrotext2", format("/cwm 1"))

Thanks in advance!

So just create the button without that template, and create icons and/or font strings as desired:

Code:

-- Create the button:

local button = CreateFrame("Button", name, parent, "SecureActionButtonTemplate")

button:SetSize(30, 30)



-- Add the icon:

local icon = button:CreateTexture(nil, "ARTWORK")

icon:SetAllPoints(true)

icon:SetTexture("Interface\\TargetingFrame\\UI-RaidTargetingIcon_6")

button.icon = icon



-- Set scripts etc.

Code:

-- Create the button:

local button = CreateFrame("Button", name, parent, "SecureActionButtonTemplate")

button:SetSize(15, 45)



-- Add a font string:

local text = button:CreateFontString(nil, "OVERLAY")

text:SetPoint("CENTER")

text:SetText("Blue Square")

button.text = text



-- Set scripts etc.

On a side note, there is no benefit to upvaluing CreateFrame, since if you are calling it enough to matter, you're doing something horribly wrong; and when you're upvaluing global functions, for the sake of readability you should keep the full name, eg:

Code:

-- Do this:

local CreateFrame = CreateFrame



-- NOT this:

local CF = CreateFrame

Addons aren't macros or text messages with limited character space. You don't need to condense everything to the fewest possible characters. Imagine that you take 6 months off from coding, and then come back and read your code -- if you'd be confused by your variable name, you shouldn't use that variable name in the first place. This is especially true for API functions, which already have names; giving them different names doesn't provide any benefit, but does create confusion.

Here's my take on creating better code. I kept the idea of using a function to generate the buttons dynamically, yet improved on its operation. First of all, the buttons share the same OnEnter and OnLeave scripts to minimize on excessive memory usage. The function arguments changed to incorporate native support for displaying a texture instead of using a FontString to display them. You can still put text on the button if you choose to.

Lua Code:

local CreateButton; do-- Prototype for function
--  Tooltip Handlers
    local function OnEnter(self)
        if self.Tooltip then
            GameTooltip:SetOwner(self,"ANCHOR_TOP");
            GameTooltip:AddLine(self.Tooltip,0,1,0.5,1,1,1);
            GameTooltip:Show();
        end
    end
    local function OnLeave(self) if GameTooltip:IsOwned(self) then GameTooltip:Hide(); end end
 
--  Button Generator (this will be assigned to the upvalue noted as a function prototype)
    function CreateButton(parent,name,texture,text,tooltip)
        tooltip=tooltip or text;--  If no tooltip, use button text
 
--      Create our button
        local btn=CreateFrame("Button",name,parent,"SecureActionButtonTemplate");
        btn:RegisterForClicks("AnyUp");--   Register all buttons
        btn:SetSize(30,30);
 
--      Setup button text
        btn:SetNormalFontObject("GameFontNormalSmall");
        btn:SetHighlightFontObject("GameFontHighlightSmall");
        btn:SetDisabledFontObject("GameFontDisableSmall");
        btn:SetText(text);
 
--      Setup button's backgorund, you can use :SetNormalTexture() and other functions to set state-based textures
        local tex=btn:CreateTexture(nil,"BACKGROUND");
        tex:SetAllPoints(btn);
        tex:SetTexture(texture);
        btn.Texture=tex;
 
--      Register handlers
        btn:SetScript("OnEnter",OnEnter);
        btn:SetScript("OnLeave",OnLeave);
        btn.Tooltip=tooltip;
 
--      Return our button
        return btn;
    end
end
 
local button=CreateButton(LeiShenCoordinator,"LeiShenCoordinatorWorldMarkerButton1","Interface\\TargetingFrame\\UI-RaidTargetingIcon_6",nil,"Raid Marker 1\nRight-click to clear");
button:SetPoint("TOPRIGHT",-120,-80);-- Anchors always default to an object's parent
button:SetAttribute("type","macro");--  "type" without a number will handle all clicks unless a more specific attribute is found
button:SetAttribute("macrotext1",SLASH_WORLD_MARKER1.." 1");--      Adds world marker 1 on left-click
button:SetAttribute("macrotext2",SLASH_CLEAR_WORLD_MARKER1.." 1");--    Clears world marker 1 on right-click

Something Phanx didn't mention that should be covered. You should NEVER use a generic name such as "Button" for any UI object. This is the same rule that these names should not be used for any sort of global variable. Global collisions is one of the many reasons an addon can unexpectedly break. This is one reason why most addons use their name as part of any global object it creates. For example, I had your button named "LeiShenCoordinatorWorldMarkerButton1" to guarantee its uniqueness.

Thank you both for your help and comments. Will tryout your suggestions.

Just to save you the potential headache, line 3 in SDPhantom's code should read:

Lua Code:

local function OnEnter(self)

instead of

Lua Code:

local function OnEnter(delf)

I did catch that, thanks!

Quote:

Originally Posted by Clamsoda (Post 283707)

Just to save you the potential headache, line 3 in SDPhantom's code should read:

Lua Code:

local function OnEnter(self)

instead of

Lua Code:

local function OnEnter(delf)

D'oh! Fixed now. :rolleyes: