WoWInterface - Changing actionbars attribute in secure env

WoWInterface (https://www.wowinterface.com/forums/index.php)

- Lua/XML Help (https://www.wowinterface.com/forums/forumdisplay.php?f=16)

- - Changing actionbars attribute in secure env (https://www.wowinterface.com/forums/showthread.php?t=57065)

Changing actionbars attribute in secure env

Hi all,

I had and still have a problem that I post some day ago about trying to scale a ActionBar:
https://www.wowinterface.com/forums/...ad.php?t=57047

The problem is still there even if Fizzlemizz and Terenna suggest some changes at the code.

I have tried to use someting like:

Lua Code:

MultiBarRight:HookScript('OnSizeChanged', function()
    if not UnitAffectingCombat("player") then 
        if MultiBarRight:GetScale() > 0.81 then
            MultiBarRight:SetScale(0.8)
        end
    end
end)

and I have seen that this bar changes a lot of time during gameplay from scale 0.8 to 1 (probably when the function is called in combat or on some state that make UnitAffectingCombat("player") true.

For example I had always an error when exit from "BeachHead" quest of Tortollan Seekers but using the :

Lua Code:

if not UnitAffectingCombat("player") then 
...
end

there isn't error anymore, even if I have the ActionBar scale = 1 instead of 0.8 it was started the quest with.

Now I am here to ask if it is possible to have some clues on how generate a secure enviroment to make changes to UI element during combat or other state that can generate a taint.

Thanks so much.

You'll have to make a secure frame:

Lua Code:

local secureFrame = CreateFrame('frame', nil, UIParent, 'SecureActionButtonTemplate')

then you'll need to hook your script as above. I think you'll need to set a reference frame for the MultiBarRight inside of the secure frame. So something like:

Lua Code:

secureFrame:SetFrameRef('MultiBarRight', MultiBarRight)

Then you'll need to securely insert the reference frame into a secure table.

Lua Code:

secureFrame:Execute([[
     multiBarRightSecureTable = table.new()
     mutliBarRightSecureTable[1] = secureFrame:GetFrameRef('MultiBarRight')
]])

Then you'll execute secure code in your MultiBarRight Hookscript:

Lua Code:

MultiBarRight:HookScript('OnSizeChanged', function()
     secureFrame:Execute([[
          if multiBarRightSecureTable[1]:GetScale() > 0.81 then
               multiBarRightSecureTable[1]:SetScale(0.8)
          end
     ]])
end)

I think that will work. IDK, I just learned about secure coding yesterday and I'm probably not great at it. You might be able to skip the multiBarRightSecureTable thing altogether and just use self:GetFrameRef('MultiBarRight'):GetScale() and self:GetFrameRef('MultiBarRight'):SetScale(). I'm not sure, like I said I'm fairly new to this, too.

Hi Terenna,

thanks for your help again ...

I have tried your code but I got an error ... do you have some clues :) ?

The code:

Lua Code:

local secureFrame = CreateFrame('frame', nil, UIParent, 'SecureActionButtonTemplate')
secureFrame:SetFrameRef('MultiBarRight', MultiBarRight)
secureFrame:Execute([[
     multiBarRightSecureTable = table.new()
     multiBarRightSecureTable[1] = secureFrame:GetFrameRef('MultiBarRight')
]])
 
MultiBarRight:HookScript('OnSizeChanged', function()
     secureFrame:Execute([[
          if multiBarRightSecureTable[1]:GetScale() > 0.81 then
               multiBarRightSecureTable[1]:SetScale(0.8)
          end
     ]])
end)

The error:

Lua Code:

1x gmActionBars\core.lua:5: attempt to call method 'SetFrameRef' (a nil value)
gmActionBars\core.lua:5: in main chunk
 
Locals:
ADDON = "gmActionBars"
secureFrame = <unnamed> {
 0 = <userdata>
}
(*temporary) = nil
(*temporary) = <unnamed> {
 0 = <userdata>
}
(*temporary) = "MultiBarRight"
(*temporary) = MultiBarRight {
 0 = <userdata>
 slideOut = <unnamed> {
 }
}
(*temporary) = "attempt to call method 'SetFrameRef' (a nil value)"

Thanks everyone for attention.

try replacing your CreateFrame with this: CreateFrame('frame', nil, UIParent, 'SecureHandlerAttributeTemplate')

perhaps it needs a handler rather than an actionbutton

Hi Terenna,

thanks so much for your reply but I couldn't test it before.

It doesn't work either.

The code:

Lua Code:

local secureFrame = CreateFrame('frame', nil, UIParent, 'SecureHandlerAttributeTemplate')
secureFrame:SetFrameRef('MultiBarRight', MultiBarRight)
secureFrame:Execute([[
         multiBarRightSecureTable = table.new()
         multiBarRightSecureTable[1] = secureFrame:GetFrameRef('MultiBarRight')
]])
     
MultiBarRight:HookScript('OnSizeChanged', function()
         secureFrame:Execute([[
            multiBarRightSecureTable[1]:SetScale(0.8)
         ]])
end)

The error:

Lua Code:

1x FrameXML\RestrictedExecution.lua:431: Call failed: [string "         multiBarRightSecureTable[1]:SetScale(0.8..."]:1: attempt to index field '?' (a nil value)
[C]: ?
FrameXML\RestrictedExecution.lua:431: in function <FrameXML\RestrictedExecution.lua:420>
(tail call): ?
(tail call): ?
FrameXML\SecureHandlers.lua:499: in function <FrameXML\SecureHandlers.lua:473>
[C]: in function `SetAttribute'
FrameXML\SecureHandlers.lua:743: in function <FrameXML\SecureHandlers.lua:725>
(tail call): ?
gmChat\core.lua:33: in function <gmChat\core.lua:32>
[C]: in function `LoadAddOn'
FrameXML\UIParent.lua:446: in function `UIParentLoadAddOn'
FrameXML\UIParent.lua:561: in function `AchievementFrame_LoadUI'
gmActionBars\core.lua:156: in function <gmActionBars\core.lua:107>
gmActionBars\core.lua:170: in function <gmActionBars\core.lua:165>
 
Locals:
(*temporary) = "Call failed: [string "          multiBarRightSecureTable[1]:SetScale(0.8..."]:1: attempt to index field '?' (a nil value)"

Any ideas ?

Thank so much

You can't use the secureFrame in the snippet, since the snippets are processed in a secure environment, you an use self instead the secureFrame since it's the one called the Execute.

And to run the snippet codes during a script event, you also can't Hook or set the script, you can only do it like

Lua Code:

secureFrame = secureFrame or CreateFrame('frame', nil, UIParent, 'SecureHandlerAttributeTemplate')
 
SecureHandlerWrapScript(MultiBarRight, "OnShow", secureFrame, [[  -- do the job  ]])

Unfortunately, the OnSizeChanged isn't a script type supported by the wrap script, so you can't do the job through the secure snippets.

The MultiBarRight's scale will be reset in MultiActionBar_Update, it's called under several conditions. I can't say it's a good choice to disable it, so you may keep scale it out of combat, or just change the uiparent's scale, or just replace it with an action bar mod.

create a frame with a SecureFrameTemplate, change the scale of this frame, and MultiBarRight:SetParent(this frame), maybe ?

Lua Code:

hooksecurefunc(MultiBarRight, "SetScale", function(self, scale)
    if scale < 1 then self:SetScale(1) end
end)

I have been using this since 8.0, never meet a taint issue.

Hi,

thanks so much for your answer.

I have tried your code and it doesn't give any errors when the player enters world ...and the bars are at 0.8 ...

Lua Code:

5:  hooksecurefunc(MultiBarRight, "SetScale", function(self, scale)
6:     if scale ~= 0.8 then self:SetScale(0.8) end
7:  end)
 
9:  hooksecurefunc(MultiBarLeft, "SetScale", function(self, scale)
10: if scale ~= 0.8 then self:SetScale(0.8) end
11:end)

But when I finish the quest BeachHead (which is vehicle exit) I got:

Lua Code:

1x [ADDON_ACTION_BLOCKED] AddOn 'gmActionBars' tried to call the protected function 'UNKNOWN()'.
!BugGrabber\BugGrabber.lua:519: in function <!BugGrabber\BugGrabber.lua:519>
[C]: ?
[C]: in function `SetScale'
gmActionBars\core.lua:6: in function <gmActionBars\core.lua:5>
[C]: in function `SetScale'
FrameXML\MultiActionBars.lua:85: in function `MultiActionBar_Update'
FrameXML\ActionBarController.lua:169: in function `ValidateActionBarTransition'
FrameXML\ActionBarController.lua:137: in function `ActionBarController_UpdateAll'
FrameXML\ActionBarController.lua:62: in function <FrameXML\ActionBarController.lua:51>
 
Locals:
InCombatSkipped

And the MultiBarRight is to 1.0 scale again (I don't use the MultiBarLeft)

The FrameXML\MultiActionBars.lua:85

Lua Code:

local scale = 1;
if ( contentHeight > availableSpace ) then
    scale = availableSpace / contentHeight;
end
        MultiBarRight:SetScale(scale);    --> line 85
if ( showLeft ) then
        MultiBarLeft:SetScale(scale);
end

I really don't understand why is not possible in an easy way to set scale to a value different from 1 :)

P.s.
The other thing I don't understand is why if I call this code instead:

Lua Code:

hooksecurefunc(MultiBarRight, "SetScale", function(self, scale)
     self:SetScale(0.8)
end)

which basically do the same thing of the code above it fired a lot of errors like:

Lua Code:

7x C stack overflow
[C]: in function `SetScale'
gmActionBars\core.lua:6: in function <gmActionBars\core.lua:5>
[C]: in function `SetScale'
gmActionBars\core.lua:6: in function <gmActionBars\core.lua:5>
[C]: in function `SetScale'
gmActionBars\core.lua:6: in function <gmActionBars\core.lua:5>
[C]: in function `SetScale'
gmActionBars\core.lua:6: in function <gmActionBars\core.lua:5>
[C]: in function `SetScale'
gmActionBars\core.lua:6: in function <gmActionBars\core.lua:5>
[C]: in function `SetScale'
gmActionBars\core.lua:6: in function <gmActionBars\core.lua:5>
...
gmActionBars\core.lua:6: in function <gmActionBars\core.lua:5>
[C]: in function `SetScale'
gmActionBars\core.lua:6: in function <gmActionBars\core.lua:5>
[C]: in function `SetScale'
gmActionBars\core.lua:6: in function <gmActionBars\core.lua:5>
[C]: in function `SetScale'
FrameXML\MultiActionBars.lua:85: in function `MultiActionBar_Update'
FrameXML\InterfaceOptionsPanels.lua:1184: in function `InterfaceOptions_UpdateMultiActionBars'
[string "*:OnLoad"]:4: in function `setFunc'
FrameXML\InterfaceOptionsPanels.lua:1154: in function <FrameXML\InterfaceOptionsPanels.lua:1147>
 
Locals:
(*temporary) = MultiBarRight {
 0 = <userdata>
 SetScale = <function> defined =[C]:-1
 slideOut = <unnamed> {
 }
}
(*temporary) = 0.800000
(*temporary) = <function> defined =[C]:-1
(*temporary) = MultiBarRight {
 0 = <userdata>
 SetScale = <function> defined =[C]:-1
 slideOut = <unnamed> {
 }
}
(*temporary) = 0.800000
 = <function> defined =[C]:-1
 = <function> defined @gmActionBars\core.lua:5

I'm not sure what's going on, but the reason you're last code causes a stack overflow is because you essentially enter an infinite loop.

You hook into the setscale function, and then SetScale within it. So it just constantly hooks into itself and runs and runs and runs. Thus, you need to have an if self:GetScale() > 0.8 then self:SetScale(0.8) end so it doesn't infinitely run; it only runs until the scale is 0.8.

Quote:

Originally Posted by gmarco (Post 331792)

I really don't understand why is not possible in an easy way to set scale to a value different from 1 :)

because SetScale is protected

i see 3 solutions :

1 : you inherit the scale from a secure parent

2 : you can maybe wrap an handler of the blizz code (see SecureHeadersGuide-4.0-r1.pdf)

3 : look into SecureStateDriver.lua if an event is triggered in your case