WoWInterface

WoWInterface (https://www.wowinterface.com/forums/index.php)
-   General Authoring Discussion (https://www.wowinterface.com/forums/forumdisplay.php?f=20)
-   -   [WoW Classic] Alkitron HonorTab - Attempt to resurrect (https://www.wowinterface.com/forums/showthread.php?t=57682)

UberAce 11-16-19 10:27 PM

[WoW Classic] Alkitron HonorTab - Attempt to resurrect
 
I am a prior author of old Vanilla Honor tracker addons. Given the state of how Honor is tracked in WoW Classic, I wanted to revisit a honor tracker UI.

For WoW Classic
My criteria this time was to stay away from plugins like my original Honor addon which was a plugin to Infobar and Titan Panel. So I looked around and stumbled upon this simple addon.

All this uses for itís UI is the existing Character Frameís Honor Tab. If I could get this addon to work and understand how it replaces values on the WoW Honor tab, I could then start to incorporate my original addonís honor equations.


Given that the toc interface version number is older than Classic version number...i was hoping just updating the toc interface number would work.
But, each time I try to get this addon to run, it just removes the existing Honor Tabs contents....blanks out the numbers.

Anyone able to take a quick look at the xml and see if there is something I can focus on to make this work? It is only 4 files. Very small addon.

Alkitron_HonorTab
https://github.com/ericraio/vanilla-...itron_HonorTab

myrroddin 11-16-19 11:47 PM

Honor doesn't exist yet in Classic. I think it's coming in phase 2.

Edit:
  • Your Interface number in the ToC is wrong. 11302 is the current version.
  • Both your XML and Lua files have badly named variables and in the Lua file most those are named globally. That's asking for disaster.
  • The reference this has long been replaced with self.
  • Every one of your functions isn't local.
  • The variable factiongroup will never be nil in Classic and since it already returns strings, it would be easier to use strings "Alliance" or "Horde" rather than 0 or 1 because the strings are easier to read and debug.
  • I suggest creating or verifying your saved variables in PLAYER_LOGIN instead of VARIABLES_LOADED.
Those were the quick things I spotted. Check for stray global variables and functions with this tool, and have a read through porting addons to Classic along with the 1.13.2 changes.

UberAce 11-17-19 12:36 AM

Thanks.

1) Honor pvp released this past Tuesday as Phase 2 is now live.

2) As I mentioned I updated the toc version number and that alone isnt enough. You are looking at the Github repo of the original authors code. I am just trying to make it work.

Again, this sint my code. Im trying to make it work. I guess based on your response I am guessing the LUA wow engine is not the one from Vanilla in Classic and I need to be looking at the BFA LUA engine?

myrroddin 11-17-19 04:46 AM

Quote:

Originally Posted by UberAce (Post 334580)
I guess based on your response I am guessing the LUA wow engine is not the one from Vanilla in Classic and I need to be looking at the BFA LUA engine?

Correct. Classic's Lua is from the 8.x version of the game, with some 8.x APIs getting renamed to their old vanilla versions, but not all. Plus there are new and different APIs that didn't exist in vanilla.

Not about the honor system, but an example would be RepByZone for Classic. When I was writing it, I discovered that quite a few of the map APIs were exactly the same for retail as for classic, with the numeric returns for zones being different. Most likely you will see something similar with the honor system.

UberAce 11-17-19 07:53 PM

Quote:

Originally Posted by myrroddin (Post 334583)
Correct. Classic's Lua is from the 8.x version of the game, with some 8.x APIs getting renamed to their old vanilla versions, but not all. Plus there are new and different APIs that didn't exist in vanilla..

Hmm...tried multi fixes based on your links provided. I canít get past the events not firing, initial onload not triggering. Seems when I stopped coding addons in LK, I didnít bother to think they would change this much in the core engine.

Classic is not Vanilla in so many ways. :confused

Seerah 11-19-19 12:32 PM

Events, load, etc. works the same way. You're missing something else.


All times are GMT -6. The time now is 02:12 PM.

vBulletin © 2020, Jelsoft Enterprises Ltd
© 2004 - 2020 MMOUI