Just like I said there was a total small thing that prevented that buttons displaying.
In the update function I tried to update the
scrollFrame which was not actually a frame in my code, I replaced it with the correct
DeathKnightFrameScrollChild frame and now the buttons display.
However, I still have not been able to get the scroll frame to scroll.
I have been checking out other addons to see how they scroll without any success, so any further help would be great.
@Zax your suggestion of adding in a debug print does help, it is far too often that I could probably identify problems much earlier if I simply added debug prints