View Single Post
10-13-16, 07:43 AM   #1
rowaasr13
A Fallenroot Satyr
AddOn Author - Click to view addons
Join Date: Jun 2007
Posts: 27
Remind me, is table itself tainted when you insecurely add/replace key/value pair?

I just noticed this familiar UI panel "click" every time I used AP item and since I was also working with Artifact API at the time, I immideately thought that someone is obviously scanning artifact on each update without disabling panel as they should. Search for SocketInventoryItem found that ExRT (Exorsus Raid Tools) was the culprit, but I also found following piece of code there:

Lua Code:
  1. do
  2.     --Fix Blizzard Errors
  3.     local def = C_ArtifactUI.GetTotalPurchasedRanks
  4.     C_ArtifactUI.GetTotalPurchasedRanks = function(...)
  5.         local arg1,arg2,arg3 = def(...)
  6.         if not arg1 then
  7.             return 0
  8.         end
  9.         return arg1,arg2,arg3
  10.     end
  11. end

So, as subject says, would that make any access to C_ArtifactUI itself tainted and bring all kind of funky errors in combat?
__________________
Garrison Mission Manager