Originally Posted by semlar
If the person who wrote it thought it was worth the extra effort to implement, it probably wouldn't be a good idea to take it out just to simplify the code, at least not unless you're quite certain it's redundant.
|
I have spent many years working on legacy code and I have seen no shortage of cases which convince me of the opposite of your argument.
I'm pretty sure that regardless of whether this would be a good place to do it, this implementation simply doesn't work. Here is the "Recycle" function:
Code:
function Recycle.prototype:Recycle()
table.insert(self.recycleList, trash)
end
That is the only mention of the "trash" variable in the entire code base. So I guess most of the time it's just pushing nil into the table, which I *think* basically does nothing other than waste time. Of course since it isn't scoped, if another addon happened to assign something to the global "trash" then all sorts of fun would happen!