Quantcast WoWInterface - View Single Post - [WoW Classic] Alkitron HonorTab - Attempt to resurrect
View Single Post
11-16-19, 11:47 PM   #2
myrroddin
A Pyroguard Emberseer
 
myrroddin's Avatar
AddOn Author - Click to view addons
Join Date: Oct 2008
Posts: 1,101
Honor doesn't exist yet in Classic. I think it's coming in phase 2.

Edit:
  • Your Interface number in the ToC is wrong. 11302 is the current version.
  • Both your XML and Lua files have badly named variables and in the Lua file most those are named globally. That's asking for disaster.
  • The reference this has long been replaced with self.
  • Every one of your functions isn't local.
  • The variable factiongroup will never be nil in Classic and since it already returns strings, it would be easier to use strings "Alliance" or "Horde" rather than 0 or 1 because the strings are easier to read and debug.
  • I suggest creating or verifying your saved variables in PLAYER_LOGIN instead of VARIABLES_LOADED.
Those were the quick things I spotted. Check for stray global variables and functions with this tool, and have a read through porting addons to Classic along with the 1.13.2 changes.

Last edited by myrroddin : 11-17-19 at 12:03 AM. Reason: Tips and suggestions
  Reply With Quote