View Single Post
10-12-14, 06:57 AM   #7
Falleneu
A Deviate Faerie Dragon
Join Date: Aug 2010
Posts: 12
Originally Posted by semlar View Post
Never compare something like IsShown() to an explicit value like 1 or true, you should pretty much always just do "if not f:IsShown() then" to check that it's not being shown.

I don't think OnSizeChanged can even fire for a hidden frame, anyway.

Just remove the line, it doesn't do anything. It's breaking the function because IsShown() can never return 1 (it returns true on the beta).

This is not the only place you're comparing IsShown() to 1, so you'll have to clean up a few other areas.
I wish I was better at this, surprising that it even works on Live without issues the way I read this.