[WoW Classic] Alkitron HonorTab - Attempt to resurrect
View Single Post
11-16-19, 11:47 PM
A Pyroguard Emberseer
Join Date: Oct 2008
Honor doesn't exist yet in Classic. I think it's coming in phase 2.
Your Interface number in the ToC is wrong. 11302 is the current version.
Both your XML and Lua files have badly named variables and in the Lua file most those are named globally. That's asking for disaster.
has long been replaced with
Every one of your functions isn't local.
will never be nil in Classic and since it already returns strings, it would be easier to use strings "Alliance" or "Horde" rather than 0 or 1 because the strings are easier to read and debug.
I suggest creating or verifying your saved variables in PLAYER_LOGIN instead of VARIABLES_LOADED.
Those were the quick things I spotted. Check for stray global variables and functions with
, and have a read through
porting addons to Classic
along with the
Last edited by myrroddin : 11-17-19 at
. Reason: Tips and suggestions
View Public Profile
Send a private message to myrroddin
Visit myrroddin's homepage!
Find More Posts by myrroddin