View Single Post
04-29-16, 01:24 PM   #6
galvin
A Frostmaul Preserver
AddOn Author - Click to view addons
Join Date: Nov 2006
Posts: 265
Ok 9 points in the xml is real. I see what they're doing now. They left it flexible in the code.

1 to 6 is normal points also includes the talent Deeper Stratagem
7 to 9 is always anticipation points

They have an offset start from 1 for 6 or 9. Then start from 2 for everything else.
This way 7 to 9 in the code is always anticipation points.

The UI will show the following based on UnitPowerMax()
6: The UI can show up to 6 circles
9: The UI can show up to 6 circles, then 3 small circles
Less than 6: The UI can show up to 5 circles
7 or 8: The UI can show up to 6 circles. Then 1 or 2 small circles.

This flexibility covers future changes, if they decide rogues will get an extra combo point from something. On top of what they get now.

Just found out about ComboFramePlayer.lua which has combo points as well. Not sure how that works with ComboFrame.lua
Is one of these for the heads up display below your character, and the other is for the portrait?

EDIT: ComboFrame.lua doing similar, using 1 to 6, then 1 to 3 for bonus. Then if its 5 its 1 to 5, no bonus. If 8 then its same with bonus. If 6 then then just 6 with no bonus. This also does some fancy animation stuff when bonus points gets moved to normal.

So what do we have 3 separate lua files? one for nameplates, portrait, and heads up

Last edited by galvin : 04-29-16 at 02:15 PM.