Quantcast
WoWInterface - View Single Post - How could this be written neater?
View Single Post
05-08-17, 06:32 AM   #8
Kkthnx
A Cobalt Mageweaver
 
Kkthnx's Avatar
AddOn Author - Click to view addons
Join Date: Aug 2011
Posts: 244
Originally Posted by MunkDev View Post
(3) You don't need to upvalue the global environment just to grab a few functions. This process is quick and painless and only happens once on login anyway.
Originally Posted by Lombra View Post
Pretty sure it's a net loss, even.
I'd love to see more info on this. I have learned that is it is faster.

For example

Lua Code:
  1. local _G = _G

then follow suit

Lua Code:
  1. local GetCVar = _G.GetCVar

Is this bad practice? If so I'd love more info on this. Everyone has their ways.

So telling him he doesn't need to do this is right or wrong here or are you teaching him what you have learned.

Lua Code:
  1. -- WoW Lua
  2. local _G = _G
  3.  
  4. -- Wow API
  5. local GetSpecialization = _G.GetSpecialization
  6. local GetSpellInfo = _G.GetSpellInfo
__________________
Success isn't what you've done compared to others. Success is what you've done compared to what you were made to do.

Last edited by Kkthnx : 05-08-17 at 06:40 AM.
  Reply With Quote