Auras.gap bugging out?

grimgaw · 08-22-12, 04:12 PM

When gap is enabled I get overlay/background still displaying on that invisible icon.
Here's relevant part of code i'm working with:

Code:

local function PostCreateIcon(f, button)
	f.disableCooldown = true
	
	button.icon:SetTexCoord(.1, .9, .1, .9)
	
	button.time = createFS(button, 14, 'OUTLINE')
	button.time:SetPoint("BOTTOM", button, 2, -6)
	button.time:SetJustifyH('CENTER')
	
	button.count = createFS(button, 15, 'OUTLINE')
	button.count:ClearAllPoints()
	button.count:SetPoint("TOPRIGHT", button, 4, 4)
	button.count:SetJustifyH('RIGHT')
	
	button.overlay:SetTexture(NORMAL)
	button.overlay:SetTexCoord(0,1,0,1)
	button.overlay:SetPoint("TOPLEFT", -2, 2)
	button.overlay:SetPoint("BOTTOMRIGHT", 2, -2)
	button.overlay:SetVertexColor(0.37, 0.3, 0.3)
	button.overlay:Show()
	button.overlay.Hide = function() end
	
	createShadow(button, 7)
end
local function PostUpdateIcon(f, unit, icon, index, offset)
	local _, _, _, _, _, duration, expirationTime, caster = UnitAura(unit, index, icon.filter)
	
	if duration and duration > 0 then
		icon.time:Show()
		icon.timeLeft = expirationTime
		icon:SetScript("OnUpdate", createBuffTimer)	
	else
		icon.time:Hide()
		icon.timeLeft = math.huge
		icon:SetScript("OnUpdate", nil)
	end

	if icon.isDebuff and unit == 'target' then
		if playerUnits[caster] then
			icon.icon:SetDesaturated(false)
		else
			icon.icon:SetDesaturated(true)
		end
	end
	icon:SetScript('OnMouseUp', function(self, mouseButton)
		if mouseButton == 'RightButton' then
			CancelUnitBuff('player', index)
		end
	end)
	
	icon.first = true
end

And a screenie of the problem:

I'm still an lua newbie, so please explain accordingly.

Rainrider · 08-22-12, 05:03 PM

This looks pretty much like oUF_Caellian code with the exception of

Code:

	button.overlay.Hide = function() end
	
	createShadow(button, 7)

From oUF's aura element:

lua Code:

local hasGap
        if(visibleBuffs ~= 0 and auras.gap) then
            hasGap = true
            visibleBuffs = visibleBuffs + 1
 
            local icon = auras[visibleBuffs] or (auras.CreateIcon or createAuraIcon) (auras, visibleBuffs)
 
            -- Prevent the icon from displaying anything.
            if(icon.cd) then icon.cd:Hide() end
            icon:EnableMouse(false)
            icon.icon:SetTexture()
            icon.overlay:Hide()
            icon.stealable:Hide()
            icon.count:SetText()
            icon:Show()

So just remove "button.overlay.Hide = function() end" from your code. The "button.overlay:Show()" part is also not needed, oUF takes care of this.

Also:

lua Code:

icon:SetScript('OnMouseUp', function(self, mouseButton)
    if mouseButton == 'RightButton' then
        CancelUnitBuff('player', index)
    end
end)

won't function in combat, leading to an error message and the option to either disable oUF or ignore the error. This is because oUF does not implement the secure aura header.

grimgaw · 08-22-12, 05:34 PM

Removing

Code:

button.overlay.Hide = function() end

makes my borders disappear.

Code:

createShadow

is just a backdrop function, removing it and function above leaves me with just plain icons. I guess that solves the problem however I'd really like to have the icons with borders and shadow.

Phanx · 08-22-12, 05:45 PM

Post the contents of your createShadow function. I add custom borders to aura icons in my oUF layout and have never seen a problem like the one you're seeing. I'd guess you're not actually parenting the custom textures to the aura icon frame; otherwise they'd get hidden along with the icon.

grimgaw · 08-22-12, 06:20 PM

Code:

local function createBackrop(f, inset)
	f:SetBackdrop({
		bgFile = BG,
		edgeFile = OUTERSHADOW,
		tile = false,
		tileSize = 0,
		edgeSize = 7,
		insets = {
			left = inset,
			right = inset,
			top = inset,
			bottom = inset
		}
	})
	f:SetBackdropColor(0,0,0,.8)
	f:SetBackdropBorderColor(0,0,0,.8)
end

local function createShadow(f, offset)
	local s = CreateFrame("Frame", nil, f)
	s:SetFrameLevel(0)
	s:SetPoint("TOPLEFT", -(offset), offset)
	s:SetPoint("BOTTOMRIGHT", offset, -(offset))
	createBackrop(s, 7)
end

I can work around shadows and make them hide with PostUpdateGapIcon but the button.overlay keeps displaying on 'gap button'.

grimgaw · 08-22-12, 07:08 PM

After much tinkering, I 'think' I found the problem in oUF's aura element:

Code:

-- Prevent the icon from displaying anything.
if(icon.cd) then icon.cd:Hide() end
icon:EnableMouse(false)
icon.icon:SetTexture()
icon.overlay:Hide()
icon.stealable:Hide()
icon.count:SetText()
icon:Show() --This line should be icon:Hide()

Edit: That is the latest version from GitHub

haste · 08-22-12, 10:11 PM

That :Show() is very much intended. In 1.6.x, oUF creates a hidden icon for the gap.

You need to make your overlay.Hide handle showing and hiding of your custom border.

grimgaw · 08-23-12, 03:15 AM

Oh, I see. For now changing it to Hide fixes all my problems,
however as I understand it's used for custom filters,
and those would break with it on Hide. Could anyone more experienced,
give me a hint where to go from my code to implement what Haste said?

Rainrider · 08-24-12, 09:52 AM

oUF creates a button widget for every buff/debuff so that it can accept mouse clicks (which is currently broken because of lack of SecureAuraHeader support). This button is basically a lua table and oUF adds some fields to it as:
icon (which holds the aura texture)
overlay (which is the aura border that most of us use to color based on aura type)
cd (holding the cooldown spiral)
count (holding a font object to represent the number of applications)
stealable (a texture to inform whether the aura is stealable or purgeable)

In order to make a gap aura, oUF does not hide the button but rather sets the icon texture to nil and hides all the other fields (overlay, cd, count and stealable).

You create a shadow effect around the button by parenting another frame to the button and setting a backdrop to that frame. In WoW the visibility of something depends on the visibility of its parent, so that if a parent is hidden, so are its children. But oUF does not hide the button itself, so your childframe and its backdrop remain visible too.

To work around this, you could create your backdrop based on the return of button.icon:GetTexture(). If this returns nil, then it is the gap aura and you don't create the backdrop. With your current code, you have to do this from within your createShadow function.

lua Code:

if not f.icon:GetTexture() then return end

You don't have to create another frame just for the shadow effect. You could apply your backdrop to the aura button, because it is a frame itself.

Take a look at https://github.com/haste/oUF/blob/ma...s/aura.lua#L83

Phanx · 08-24-12, 06:57 PM

Originally Posted by Rainrider

oUF creates a button widget for every buff/debuff so that it can accept mouse clicks (which is currently broken because of lack of SecureAuraHeader support).

1) Mouse support is also required for tooltips on mouseover.

2) SecureAuraHeader is pathetically limited, with very limited sorting features and no useful filtering features. There is no way to support it in oUF (or any other addon) without losing all filtering features and most sorting features. Also, you can't show buffs and debuffs with a single SecureAuraHeader, so the entire Auras element would have to go, and you'd only be able to use the separate Buffs and Debuffs element.

Originally Posted by Rainrider

To work around this, you could create your backdrop based on the return of button.icon:GetTexture(). If this returns nil, then it is the gap aura and you don't create the backdrop. With your current code, you have to do this from within your createShadow function.

lua Code:

if not f.icon:GetTexture() then return end

The bolded, italicized portion of what you posted is wrong. If you do it that way, then any button which is first displayed without an icon will not get a shadow, ever. For example, if you get a debuff, Icon #1 will show the debuff icon and get a shadow. If you get another debuff, Icon #2 will show the second debuff and get a shadow. If you then get a buff, Icon #3 will be an invisible spacer, and will not get a shadow; Icon #4 will show the buff and get a shadow. Then the first debuff expires, so Icon #1 is now the second debuff with a shadow, #2 is now the spacer but still has a shadow, and #3 is now the buff but does not have a shadow.

Instead, you need to dynamically hide or show your shadow. A simple way to do that would be to hook the icon texture's SetTexture method:

Code:

hooksecurefunc(icon.icon, "SetTexture", function(self, texture)
    if texture and strlen(texture) > 0 then
        shadow:Show()
    else
        shadow:Hide()
    end
end)

Rainrider · 08-25-12, 04:48 AM

I just emphasized on the lack of SecureAuraHeader support because grimgaw had code calling CancelUnitBuff, which is now protected. You are right about the limitations of the SecureAuraHeader.

Thank you for the corrections, I didn't realize it works like that. So oUF reuses already created buttons for new auras, right?

Phanx · 08-25-12, 05:08 AM

CancelUnitBuff is only protected while in combat. Out of combat, you can cancel buffs as insecurely as you want. The only caveat is that shapeshift forms cannot be cancelled insecurely, and will silently fail (ie. no error message).

To your other question, yes; buttons get reused. If you have 2 buffs when your layout loads, oUF creates 2 buttons. If you gain 1 more buff, oUF creates a third button. If you lose 2 buffs, there are still 3 buttons, but 2 of them are hidden. If you then gain 1 buff, you still have created only 3 buttons; 2 of them are visible, and 1 of them is hidden. Creating a new button every time you gained an aura would be an incredibly huge waste of memory, as there is no way to unload or destroy frame objects.

Rainrider · 08-25-12, 04:35 PM

http://www.wowhead.com/item=19250 my apologies to grimgaw for the wrong tips. Thanks a lot Phanx for the clarification and for correcting me.

Paopao001 · 08-27-12, 03:58 AM

I met this problem, too. And I solved it this way.
In my layout, the aura icon got two more things on it, a shadow border and a timer. I prevent the gap icon from showing this two things by PostUpdateGapIcon. However, I need to force the border showing in PostUpdateIcon, or it might kill other real aura icons' borders.

Code related to create the two more things and hide them in gap.

Lua Code:

--=============================================--
--[[                   Auras                 ]]--
--=============================================--
local PostCreateIcon = function(auras, icon)
    icon.icon:SetTexCoord(.07, .93, .07, .93)
 
    icon.count:ClearAllPoints()
    icon.count:SetPoint('BOTTOMRIGHT', 3, -3)
    icon.count:SetFontObject(nil)
    icon.count:SetFont(cfg.font, 9, cfg.fontflag)
    icon.count:SetTextColor(.9, .9, .1)
 
icon.overlay:SetTexture(cfg.texture)
icon.overlay:SetDrawLayer('BACKGROUND')
    icon.overlay:SetPoint('TOPLEFT', icon, 'TOPLEFT', -1, 1)
    icon.overlay:SetPoint('BOTTOMRIGHT', icon, 'BOTTOMRIGHT', 1, -1)
 
icon.bd = createBackdrop(icon, icon, 0)
 
icon.remaining = createFont(icon, 'OVERLAY', cfg.font, 9, 'OUTLINE', 1, 1, 1)
    icon.remaining:SetPoint('TOPLEFT', -3, 2)
 
    if cfg.auraborders then
        auras.showDebuffType = true
end
end
 
local CreateAuraTimer = function(self, elapsed)
    self.elapsed = (self.elapsed or 0) + elapsed
 
    if self.elapsed < .2 then return end
    self.elapsed = 0
 
    local timeLeft = self.expires - GetTime()
    if timeLeft <= 0 then
        self.remaining:SetText(nil)
    else
        self.remaining:SetText(FormatTime(timeLeft))
    end
end
 
local PostUpdateIcon = function(icons, unit, icon, index, offset)
local name, _, _, _, _, duration, expirationTime = UnitAura(unit, index, icon.filter)
 
if icon.isPlayer or UnitIsFriend('player', unit) or not icon.isDebuff then
icon.icon:SetDesaturated(false)
if duration and duration > 0 then
icon.remaining:Show()
else
icon.remaining:Hide()
end
else
icon.icon:SetDesaturated(true) -- grey other's debuff casted on enemy.
icon.overlay:Hide()
icon.remaining:Hide()
icon.count:Hide()
end
 
if duration then
icon.bd:Show() -- if the aura is not a gap icon show it's bd
end
 
icon.expires = expirationTime
icon:SetScript('OnUpdate', CreateAuraTimer)
end
 
local PostUpdateGapIcon = function(auras, unit, icon, visibleBuffs)
icon.bd:Hide()
icon.remaining:Hide()
end