Help with first addon

[Inviticus]

wordCues = {"noob","nub","newb","retard","retards","loser","idiot","idiots","losers"}

function Frame1_OnLoad()
	this:RegisterEvent("CHAT_MSG_BATTLEGROUND");
end

function Frame1_OnEvent()
	local sender = arg2;
	local sentence = arg1;
	if ("CHAT_MSG_BATTLEGROUND" == event) then
	  for i=1,# db do
	    if (string.find(sentence, wordCues[i])) then
	      DEFAULT_CHAT_FRAME:AddMessage(sender .. ":" .. wordCues[i]);
	    end
	  end
	end
end

Any idea what's not working with this? Any help would be appreciated.

[Inviticus]

Also, what function is used to ignore a player? Thanks again for any help.

[Mera]

not "CHAT_MSG_BATTLEGROUND" == event but event == "CHAT_MSG_BATTLEGROUND"

not for i=1,# db do but for i=1,#wordCues do

else you're looking for AddIgnore

[Slakah]

not "CHAT_MSG_BATTLEGROUND" == event but event == "CHAT_MSG_BATTLEGROUND"

That would make no difference, although there's very little reason for doing so as from what I can see you haven't registered any other events.

instead of doing

for i = 1, #wordCues do

it would be better to use ipairs
e.g.

for i, v in ipairs(wordCues) do
	if string.find(sentence, v) then
		DEFAULT_CHAT_FRAME:AddMessage(sender .. ":" .. v)
	end
end

also a quick note it would be better to not use the globals this, event and argN's because they are going to be removed in Wrath of the Lich King . Instead of using an XML file you could create a frame using lua and then register an event this way.

local f = CreateFrame("Frame")
f:RegisterEvent("CHAT_MSG_BATTLEGROUND")
f:SetScript("OnEvent", function(f, event, sentence, sender)
	<Code Here>
end)

[Mera]

ha yes true I was thinking to = instead of == , but sure then its the same in both orders, I must really stop weed

[ravagernl]

local wordCues = {"noob","nub","newb","retard","retards","loser","idiot","idiots","losers"}

local f = CreateFrame("Frame")
f:RegisterEvent("CHAT_MSG_BATTLEGROUND")
f:SetScript("OnEvent", function(self, event, ...)
  	if self[event] then self[event](self, ...) end
end)

function f:PLAYER_ENTERING_WORLD(sentence, sender)
	for i, v in ipairs(wordCues) do
		if string.find(sentence, v) then
			DEFAULT_CHAT_FRAME:AddMessage(sender .. ":" .. v)
			AddIgnore(sender)
		end
	end
end

Drycoded, not tested so it may not work.

[Inviticus]

Wow, that was quick. Thanks, guys.

[Inviticus]

What's this line do, exactly? Just curious. I'm new to all of this.

if self[event] then self[event](self, ...) end

[Tristanian]

Originally Posted by Inviticus What's this line do, exactly? Just curious. I'm new to all of this. if self[event] then self[event](self, ...) end

It basically "maps" an event to a method that can be used by whichever 'self' registered the event (typically your frame).