Changes for MoP

in10s3gamer · 07-18-12, 11:46 PM

Hello,
I'm really bad at coding in LUA. I've been maintaing oUF_Nivea for myself and made my own changes on it for a while now, but now that I'm on the beta I'm not quite sure why any of my frames aren't loading. There is a very large heap of files I would have to go through to find what isn't working, and I would much rather make a brand new unit frame than try to sort through all of Dawn's coding.

So I guess my question is, are there a few common functions or API changes that I should be aware of that are layout breaking in MoP? I updated to the latest oUF from haste's github, but apart from that I am at a loss. I can get oUF_simple to work, so if all else fails I will begin modification on that.

Phanx · 07-19-12, 05:42 AM

5.0 API changes on Wowpedia:
http://www.wowpedia.org/Patch_5.0.1/API_changes

Initial changes found:
http://www.wowinterface.com/forums/s...ad.php?t=43091

5.0.1->5.0.3 changes:
http://www.wowinterface.com/forums/s...ad.php?t=43719

And a whole thread in this very forum about oUF changes:
http://www.wowinterface.com/forums/s...ad.php?t=43621

And an entire forum for threads about API changes:
http://www.wowinterface.com/forums/f...play.php?f=153

These resources are not even remotely difficult to find. If you need more specific help, you're going to have to post some code and any error messages, and ask more specific questions.

in10s3gamer · 07-19-12, 06:21 PM

Thank you Phanx. The main problem I am having is that I get no error messages at all -- I simply log in and I have the default unit frames, which is why I have no idea at all where to start. I don't expect anyone to troubleshoot the entire addon for me and find what exactly is breaking, so if you know of any general problems that might cause the addon from not loading or only loading partially I'm open to any suggestions. Otherwise I'll dive into the resources you've provided (of which I've found before, but was extremely daunting).

The addon is a barely modified version of ouf_nivea:
http://www.wowinterface.com/download...oUF_Nivea.html

in10s3gamer · 07-19-12, 07:19 PM

Here is the very long lua file...

https://gist.github.com/3148057

I updated the tags in another file, and searched to see if any of the "Changed API"s were in this file, but there weren't any of them. Any ideas? If I had an error message I'd be on a lot better footing right now.

Talyrius · 07-19-12, 07:47 PM

Enable Lua errors under Interface Options > Help and try again.

in10s3gamer · 07-19-12, 07:52 PM

They've been enabled (I got LUA errors for one other addon)

in10s3gamer · 07-19-12, 08:04 PM

I just downloaded an addon called "BugGrabber" that I'll use to see if there are lua errors that just aren't being displayed. Be back in about 5 min. due to the long loading screens on beta right now

in10s3gamer · 07-19-12, 08:53 PM

All right.

Looks like they changed the GetSpellInfo function? Or maybe they changed it a while back and it's only layout breaking now?

Here's what Dawn wrote to whitelist which auras to display:

Lua Code:

Whitelist = {
    auras = {
 
    ---------   
    -- PvE --
    ---------
        
    -- Baradin Hold
        --Argaloth
        [GetSpellInfo(88954) or "Consuming Darkness"] = true,
        
    -- The Bastion of Twilight
        -- Halfus Wyrmbreaker
        [GetSpellInfo(83908) or "Malevolent Strikes"] = true,
        
        -- Valiona and Theralion
        [GetSpellInfo(86844) or "Devouring Flames"] = true,
        [GetSpellInfo(86788) or "Blackout"] = true,
        [GetSpellInfo(95639) or "Engulfing Magic"] = true,
        [GetSpellInfo(86013) or "Twilight Meteorite"] = true,
 
-- Lots of spells in between
 
        [GetSpellInfo(49039)] = true,                   -- Lichborne
        [GetSpellInfo(73975)] = true,                   -- Necrotic Strike
    
    },
}

The error I get is the following, from BugGrabber:

Code:

oUF_Nivea\Nivea_AuraFilterList.lua:47: table index is nil
oUF_Nivea\Nivea_AuraFilterList.lua:47: in main chunk
oUF_Nivea\Nivea:155: attempt to index global "Whitelist" (a nil value)
oUF_Nivea\Nivea:155: in main chunk

edit:: Nevermind... I deleted most of the spells from the aurafiltering (except one that wasn't throwing an error) and I got it to partially work. Lol I guess some spells just got deleted on the beta. Now I have a bunch of other errors but I should be able to work through it. Thanks!

Phanx · 07-20-12, 12:15 AM

GetSpellInfo works the same as it always has; if the provided spell ID does not map to any existing spell, it returns a nil value.

An easy way to avoid the problem:

Code:

local function GetSpellName(id)
    local name = GetSpellInfo(id)
    if not name then
        print("Invalid spell ID:", id)
    end
    return name or ""
end

Then replace all calls to GetSpellInfo with calls to your custom GetSpellName function.

This way, you won't have to update immediately when Blizzard removes a spell, and you won't have to do any work to figure out which spell(s) were removed, since it will tell you right in the chat frame which IDs are no longer valid.

in10s3gamer · 07-20-12, 06:42 PM

Thank you so much!