LFDRole indicator problems.

sacrife · 08-13-10, 07:15 AM

Hi, I'm trying to use this piece of code on my partyframes.
Similar code works fine for pvp, resting, leader, masterlooter. However with LFD role which has 3 different textures based on role there's some problems.

How can I get around this and make this work?
The error is some failure of creating/using SetTexCoord (Because the original textures use that)

Code:

	local lfdrole = CreateFrame("StatusBar", nil, self)
	lfdrole:SetStatusBarTexture(sett1ngs.texture)
	lfdrole:SetFrameStrata("MEDIUM")
	lfdrole:SetFrameLevel(4)
	lfdrole:SetHeight(sett1ngs.cicon)
	lfdrole:SetWidth(sett1ngs.cicon)
	lfdrole:SetPoint("TOPRIGHT", 1, 1)
	lfdrole:SetStatusBarColor(1, 1, 1)
	lfdrole.bd = SetBD(lfdrole, backdrop, {0,0,0,1}, "MEDIUM")

	self.LFDRole = lfdrole
	
	local isTank, isHealer, isDamage = UnitGroupRolesAssigned(unit) 
	local _, uclass = UnitClass(unit) 
	if isTank then 
		lfdrole:SetStatusBarColor(0, .7, 1)
	elseif isHealer then 
		lfdrole:SetStatusBarColor(0, 1, 0) 
	elseif isDamage then 
		lfdrole:SetStatusBarColor(1, 0, 0)
	end

yj589794 · 08-13-10, 07:29 AM

The LFD element is expecting a Texture to be assigned to self.LFDRole, not a StatusBar.

sacrife · 08-13-10, 07:41 AM

Yes, but is there anyway to make my idea work?

yj589794 · 08-13-10, 07:58 AM

maybe this (totally untested)

Code:

	local lfdrole = CreateFrame("StatusBar", nil, self)
	lfdrole:SetStatusBarTexture(sett1ngs.texture)
	lfdrole:SetFrameStrata("MEDIUM")
	lfdrole:SetFrameLevel(4)
	lfdrole:SetHeight(sett1ngs.cicon)
	lfdrole:SetWidth(sett1ngs.cicon)
	lfdrole:SetPoint("TOPRIGHT", 1, 1)
	lfdrole:SetStatusBarColor(1, 1, 1)
	lfdrole.bd = SetBD(lfdrole, backdrop, {0,0,0,1}, "MEDIUM")

	lfdrole.Update = function(self, event)
		local role = self.LFDRole
		local isTank, isHealer, isDamage = UnitGroupRolesAssigned(unit) 

		if isTank then 
			role:SetStatusBarColor(0, .7, 1)
			role:Show()
		elseif isHealer then 
			role:SetStatusBarColor(0, 1, 0) 
			role:Show()
		elseif isDamage then 
			role:SetStatusBarColor(1, 0, 0)
			role:Show()
		else
			role:Hide()
		end
	end

	self.LFDRole = lfdrole

sacrife · 08-13-10, 08:46 AM

It did not error, but no square (statusbar) appeared and every frame got a healer lfd icon. Even outside of the instance and not grouped.

yj589794 · 08-13-10, 08:57 AM

Originally Posted by sacrife

It did not error, but no square (statusbar) appeared and every frame got a healer lfd icon. Even outside of the instance and not grouped.

sigh, copy&paste error.....

change this line:

Code:

		local isTank, isHealer, isDamage = UnitGroupRolesAssigned(self.unit)

sacrife · 08-13-10, 09:11 AM

Same result

*edit*
Wait, I think I screwed up. Let me check something. It's really a hassle to test this as I have to queue constantly for dungeons and complete them because I don't intend to be a jackass :P

yj589794 · 08-13-10, 09:23 AM

I'm just not sure why you are trying to use a statusbar for this anyway.

I can't really give any more suggestions until I get home and I am able to try this in-game.

haste · 08-13-10, 09:35 AM

Using a statusbar make no sense at all when you only change the color and nothing else.

Regardless! You could just redirect .SetTexCoord to .SetStatusBarColor, and ofc change the arguments into something you'd want.

sacrife · 08-13-10, 09:36 AM

I use statusbars as that is because the original layout I got the concept from used it and I copied it to use it more extensively.

I'm open for idea's on how to change it if that is necessary.

sacrife · 08-13-10, 09:36 AM

Originally Posted by haste

Using a statusbar make no sense at all when you only change the color and nothing else.

Regardless! You could just redirect .SetTexCoord to .SetStatusBarColor, and ofc change the arguments into something you'd want.

I don't know how to do that :P
I'll try.

Rostok · 08-13-10, 10:08 AM

Code:

local lfdrole = self.Health:CreateTexture(nil, 'OVERLAY')
lfdrole:SetPoint(POINT)
lfdrole:SetTexture(...)
lfdrole:SetSize(WIDTH,HEIGHT)
lfdrole.Update = updateLFD
self.LFDRole = lfdrole
	
local updateLFD = function(LFDRole, unit)
	local isTank, isHealer, isDamage = UnitGroupRolesAssigned(unit) 
	if isTank then 
		LFDRole:SetVertexColor(0, .7, 1)
	elseif isHealer then 
		LFDRole:SetVertexColor(0, 1, 0) 
	elseif isDamage then 
		LFDRole:SetVertexColor(1, 0, 0)
	end
end

we did this but the texture remains white, i read the code of the elements and the update function with .Update should work. What's wrong with this ?

sacrife · 08-13-10, 10:10 AM

Originally Posted by yj589794

maybe this (totally untested)

Code:

	local lfdrole = CreateFrame("StatusBar", nil, self)
	lfdrole:SetStatusBarTexture(sett1ngs.texture)
	lfdrole:SetFrameStrata("MEDIUM")
	lfdrole:SetFrameLevel(4)
	lfdrole:SetHeight(sett1ngs.cicon)
	lfdrole:SetWidth(sett1ngs.cicon)
	lfdrole:SetPoint("TOPRIGHT", 1, 1)
	lfdrole:SetStatusBarColor(1, 1, 1)
	lfdrole.bd = SetBD(lfdrole, backdrop, {0,0,0,1}, "MEDIUM")

	lfdrole.Update = function(self, event)
		local role = self.LFDRole
		local isTank, isHealer, isDamage = UnitGroupRolesAssigned(unit) 

		if isTank then 
			role:SetStatusBarColor(0, .7, 1)
			role:Show()
		elseif isHealer then 
			role:SetStatusBarColor(0, 1, 0) 
			role:Show()
		elseif isDamage then 
			role:SetStatusBarColor(1, 0, 0)
			role:Show()
		else
			role:Hide()
		end
	end

	self.LFDRole = lfdrole

This works now when I fixed something I didnt notice before.

However, is it really a problem using statusbars?

yj589794 · 08-13-10, 10:37 AM

Originally Posted by Rostok

Code:

local lfdrole = self.Health:CreateTexture(nil, 'OVERLAY')
lfdrole:SetPoint(POINT)
lfdrole:SetTexture(...)
lfdrole:SetSize(WIDTH,HEIGHT)
lfdrole.Update = updateLFD
self.LFDRole = lfdrole
	
local updateLFD = function(LFDRole, unit)
	local isTank, isHealer, isDamage = UnitGroupRolesAssigned(unit) 
	if isTank then 
		LFDRole:SetVertexColor(0, .7, 1)
	elseif isHealer then 
		LFDRole:SetVertexColor(0, 1, 0) 
	elseif isDamage then 
		LFDRole:SetVertexColor(1, 0, 0)
	end
end

we did this but the texture remains white, i read the code of the elements and the update function with .Update should work. What's wrong with this ?

You need to declare updateLFD before it is used:

Code:

local updateLFD = function(self, event)
   -- some functionality
end

lfdrole.Update = updateLFD

yj589794 · 08-13-10, 10:41 AM

Originally Posted by sacrife

This works now when I fixed something I didnt notice before.

However, is it really a problem using statusbars?

You are using a component that provides features that you are not using.

It's like using a jackhammer where a spoon would do.

sacrife · 08-13-10, 11:09 AM

Originally Posted by yj589794

You are using a component that provides features that you are not using.

It's like using a jackhammer where a spoon would do.

Is there a performance difference?

yj589794 · 08-13-10, 11:28 AM

Nothing that you would ever notice

Rostok · 08-13-10, 11:49 AM

Originally Posted by yj589794

You need to declare updateLFD before it is used:

Code:

local updateLFD = function(self, event)
   -- some functionality
end

lfdrole.Update = updateLFD

hum yes, indeed, but i did not test it, sacrife did (i myself would have done it in the right way i think) maybe we did not comprehend each other with sacrife