The way I address the lack of Burning Embers support in classicons.lua

Aerials · 05-27-13, 09:07 PM

I ended up using:

Code:

local lockHasGreen = IsPlayerSpell(137206)
[...]
if lockHasGreen then
[etc...]

This part of that would have saved me quite a while, lol... I didn't know you could check a spell like this:

Code:

if (IsSpellKnown(WARLOCK_GREEN_FIRE)) then

oh well. I may look over the way you have done it all later, but for now I like how I have it. I can't really test it, but it should work (lol...). They're the same power type I think (just a cosmetic difference), so it should be fine.

My colors currently:

Code:

local Colors = { 
	[1] = {148/255, 130/255, 201/255, 1}, -- Shards
	[2] = {150/255, 50/255,  150/255, 1}, -- Fury
	[3] = {222/255, 95/255,  95/255, 1}, -- Embers
	[4] = {225/255, 115/255,  225/255, 1}, -- Full Fury
	[5] = {95/255, 222/255,  95/255, 1}, -- Green Fire
}

Rainrider · 05-28-13, 07:26 AM

Normally it's a good idea to check the default implementation to see what events blizzard uses for setting up and updating. There are often some constants like WARLOCK_GREEN_FIRE, that you can use too and that are likely to remain usable if they change the spell id. It is also more descriptive when you read the code later. As for the green fire, yes, it is just a cosmetic change, not one regarding the power type or the way it works. It leads to a change though - you must keep SPELLS_CHANGED registered for the element for destro locks if you want to support it.