Detecting World PvP Zones

[Choonstertwo]

Someone has recently commented on my KillingBlow_Enhanced AddOn that it doesn't work in Ashran when PvP only mode (i.e. only report killing blows when in PvP zones) is enabled. To detect if the current zone is a PvP zone, I'm calling IsInInstance and checking if the instance type (second return value) is "pvp" or "arena".

Is there an easy way to detect whether the current zone is a World PvP zone? The World Battlefield API section didn't have any obvious solution to this.

[Choonstertwo]

Thanks, I'll use that approach.

[Banknorris]

I try to avoid to use SetMapToCurrentZone() as much as I can (so far I could totally avoid it) because it will interfere with the user watching another map. The alternative approach that works well is to use GetInstanceInfo()

local _,_,_,_,_,_,_,zone = GetInstanceInfo()
if zone==1191 then
	print("I am in Ashran")
elseif zone==732 then
	print("I am in Tol Barad")
end

This approach does NOT work in Wintergrasp though because when you are there you will get the 571 return which is the Northrend id both during Wintergrasp battle or between battles (when it is like any Northrend zone).

[Choonstertwo]

That's a good idea. Using GetInstanceInfo, I can at least avoid calling SetMapToCurrentZone on every continent except Northrend.

[Choonstertwo]

Just for future reference:


When you enter a new continent/instance (including when you first log in), PLAYER_ENTERING_WORLD and ZONE_CHANGED_NEW_AREA are fired in that order. When PLAYER_ENTERING_WORLD fires, GetInstanceInfo returns the correct instance map ID but GetCurrentMapAreaID returns the area ID of the continent. When ZONE_CHANGED_NEW_AREA fires, GetCurrentMapAreaID returns the correct area ID (after you call SetMapToCurrentZone).

[Resike]

Originally Posted by Banknorris I try to avoid to use SetMapToCurrentZone() as much as I can (so far I could totally avoid it) because it will interfere with the user watching another map. The alternative approach that works well is to use GetInstanceInfo() local _,_,_,_,_,_,_,zone = GetInstanceInfo() if zone==1191 then print("I am in Ashran") elseif zone==732 then print("I am in Tol Barad") end This approach does NOT work in Wintergrasp though because when you are there you will get the 571 return which is the Northrend id both during Wintergrasp battle or between battles (when it is like any Northrend zone).

You can use this to detect if the battle is active or not:

http://wowprogramming.com/docs/api/GetWorldPVPAreaInfo

[semlar]

Presumably you can just use IsInActiveWorldPVP()

There's also GetZonePVPInfo()

[gmarco]

I do something like this in "remgank" :

local _, instanceType = IsInInstance()
        if REMGANK_ENABLE == false or instanceType == "arena" or instanceType == "pvp" or (instanceType == "none" and GetZonePVPInfo() == "combat") then
            -- REMGANK_ENABLE == false Monitoring is disabled
            -- arena is, obviously, an arena.
            -- pvp is a battleground.
            -- none with GetZonePVPInfo() == "combat" is an outdoor PvP zone like Wintergrasp.
            self:UnregisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
        else
            -- If not in a pvp zone, register CLEU:
            self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
        end
        return
    end

It seems to work for me ...

[Choonstertwo]

Originally Posted by semlar Presumably you can just use IsInActiveWorldPVP()

Do you know whether that returns true only during an active battle or any time you're in a World PvP zone? Do you know which event to listen for to know when the return value changes? Unfortunately I don't think trial accounts have access to any world PvP zones, so I can't test it myself.

The default UI only seems to call it when you right click on a unit on the world map to determine whether or not you can report them as AFK.

WoW Programming doesn't have any documentation for it and Wowpedia doesn't have it listed at all.

[p3lim]

Originally Posted by Banknorris I try to avoid to use SetMapToCurrentZone() as much as I can (so far I could totally avoid it) because it will interfere with the user watching another map.

This method is safe:

local oldAreaID = GetCurrentMapAreaID()
SetMapToCurrentZone()
 
-- store the current area ID
local areaID = GetCurrentMapAreaID()
 
SetMapByID(oldAreaID)
 
-- do things

[semlar]

Originally Posted by p3lim This method is safe: local oldAreaID = GetCurrentMapAreaID() SetMapToCurrentZone()   -- store the current area ID local areaID = GetCurrentMapAreaID()   SetMapByID(oldAreaID)   -- do things

No it isn't, you don't take into account the previous map level. Also, changing the map resets its zoom (if you use the scroll wheel on the world map).

This would also set the map to the wrong zone if you're currently inside of a microdungeon.

There are other things to consider when changing the map, like how extremely cpu intensive addons like Routes and Gatherer would react.

The only safeish method for actively changing the current map is to unregister WORLD_MAP_UPDATE from every frame that's watching it, do your thing and swap the map back to what it previously was, then re-register the event to those frames.

I don't recommend anyone do that unless they fully comprehend how the map works.